Commit graph

2432 commits

Author SHA1 Message Date
Translation updater bot 6fea75bf7b Localisation updates from https://translatewiki.net.
Change-Id: I76eb90ec1ad222f5887a01a1a4abb38337b8a9ce
2014-11-07 22:15:17 +01:00
Ed Sanders 5238d06dc7 Support pre's in tables
Bug: 73100
Change-Id: I971420047026c91ed92a19a52d2fd3b6fbeac24a
2014-11-07 15:44:13 +00:00
jenkins-bot 27e70a6a21 Merge "Matching pages from suggestions in link dialog now actually work as links" 2014-11-06 21:49:07 +00:00
suchetag cb704dee84 Matching pages from suggestions in link dialog now actually work as links
* A subclass of MenuItemWidget from OOUI, MWLinkMenuItemWidget, is introduced that, when used in MWLinkTargetInputWidget for both
external and internal links, returns actual page links.

* MWInternalLinkMenuItemWidget is extended from MWLinkMenuItemWidget to support the internal links.

* LinkCache is being used in MWInternalLinkMenuItemWidet to stylize the links. Thus, getting rid of some old css classes.

Bug: 51205
Change-Id: I3ac18dabd514ca539fff1db3c67ae97931c3d4fc
2014-11-06 13:46:09 -08:00
Translation updater bot 47295b4441 Localisation updates from https://translatewiki.net.
Change-Id: I0d8f1d19fdae87a23f088dbad5e2dac413b5825a
2014-11-06 21:56:21 +01:00
jenkins-bot 613e69b2c8 Merge "Refactor out show/hide loading spinner" 2014-11-06 18:39:06 +00:00
Ed Sanders 841dfda98d Refactor out show/hide loading spinner
Change-Id: If505a46f54921ce4742ecfed598eb07a9ba5e3eb
2014-11-06 16:41:05 +00:00
jenkins-bot 1a6c46f7ee Merge "Use hasOwnProperty instead of 'key in obj'" 2014-11-06 12:37:04 +00:00
jenkins-bot 81d153b430 Merge "Disable review button while save dialog is pending" 2014-11-06 00:35:17 +00:00
jenkins-bot 209dbe2449 Merge "Allow headings in table cells" 2014-11-05 23:52:23 +00:00
Alex Monk 3628fc0ffc Disable review button while save dialog is pending
Bug: 65310
Change-Id: I7cfb5d84b91b4a20282e126b8c863c15519b5a9d
2014-11-05 23:36:33 +00:00
jenkins-bot cfed84e063 Merge "QA: sort remaining page elements that belong in the iframe" 2014-11-05 22:43:36 +00:00
Cmcmahon beebfff6f9 QA: sort remaining page elements that belong in the iframe
We need to figure out where the language screenshot elements reside

merged as an interim step to share the code more easily, no change
to function

Change-Id: Icae480aaa526a9de6e6926e027c0cac0c7de997e
2014-11-05 15:39:10 -07:00
Ed Sanders 26f567d84f Allow headings in table cells
We possibly want to discourage this somehow but our current
functionality achieves this by doing an isolateAndUnwrap
which for a table is catastrophic.

Bug: 72990
Change-Id: I79f1348da20385dfec014afcac0fb5464580cf2f
2014-11-05 22:34:13 +00:00
Roan Kattouw e144e55972 Followup 31bafa1: forgot to rename 'data' to 'args' for citation commands
Bug: 73001
Change-Id: I8cc436cbe16955130d25b2385e3f561fd2ffb4d5
2014-11-05 13:46:54 -08:00
jenkins-bot ca7ef3be1f Merge "Remove the loading spinner at the end, not halfway through loading" 2014-11-05 21:00:53 +00:00
Ed Sanders 0efbfa7e21 Use hasOwnProperty instead of 'key in obj'
Change-Id: I48f044c547b48a97cdfb31f7b887dca0ed7e341b
2014-11-05 20:54:50 +00:00
Roan Kattouw ccd9142262 Remove the loading spinner at the end, not halfway through loading
We were attaching its removal to the wrong promise in 2 of the 3
places where it was being called.

Also this file is horrible and should be refactored. A lot.

Change-Id: If74b1629266f22e2d110305b139bef4a8e69b13b
2014-11-05 12:50:40 -08:00
Translation updater bot 58ba085453 Localisation updates from https://translatewiki.net.
Change-Id: Icaf0b9a1ce7848d97c1466cdbc1cff4d4335e54a
2014-11-05 21:50:17 +01:00
Cmcmahon f8b34e4e89 QA: remove stuff now that iframes are gone
Change-Id: I6d520acd9d1e18d803f7e44f5ea45502658f14d9
2014-11-05 10:01:55 -07:00
jenkins-bot 06387f7f54 Merge "Revert "Clear selection after tearing down surface to work around Firefox bug"" 2014-11-05 01:39:16 +00:00
Catrope c8396eb65f Revert "Clear selection after tearing down surface to work around Firefox bug"
Superseded by I051ef92eeea9 in VE core.

This reverts commit d68eae6c8d.

Change-Id: Ie5e0a6169cfe3634e20a3b88e8aeb980b4094e10
2014-11-04 17:20:30 -08:00
jenkins-bot d6c3a4aa92 Merge "Kill MWCategoryWidget#onLookupEnter" 2014-11-05 01:18:15 +00:00
Roan Kattouw a5e9e1f456 Fix indicator alignment in MWCategoryItemWidget
We were setting the height to 2.25em which just happened
to be right, but it depended on the browser's default
line-height being a certain value. Now that that's changed
with unisolation, the alignment breaks.

Instead of using a magic value, use height: 100%; so it
takes the parent's height. We don't even have to make the
parent position: relative; because it already is.

Also change the width to 2em, which is a much more defensible
value than 2.25em. Previously 2.25em kind of made sense because
that was also the height (resulting in a square box), but
now we don't have that excuse any more.

Bug: 72962
Change-Id: Id617bfaafefd1fc1530fbee29be5d935ec486b92
2014-11-04 16:53:11 -08:00
jenkins-bot 309305b03e Merge "[BrowserTest] WIP adding cases to test other options under Page Settings to options.feature" 2014-11-04 23:04:40 +00:00
ryasmeen@wikimedia.org 4aa8be0e71 [BrowserTest] WIP adding cases to test other options under Page Settings to options.feature
Also:
* Fixed a typo in options_steps.rb
* Disabled Metrics/ClassLength Rubocop cop.

Change-Id: I7128ba8f7ebf9c63aef9399a9cdf24831e1a2d38
2014-11-04 15:01:45 -08:00
Translation updater bot f9517993de Localisation updates from https://translatewiki.net.
Change-Id: If507707479641bfd07e950f03136b46e53f3c62f
2014-11-04 23:33:19 +01:00
James D. Forrester 31bafa183d Update VE core submodule to master (a942301)
New changes:
2cc219a Update OOjs UI to v0.1.0-pre (571f26d0ab)
3543cb7 Protect against offset=-1 in insertContent()
7a3d456 [BREAKING CHANGE] Move selection restrictions from tools to commands
3d847bb Disable desktop context on table selections
41282dd Missed function rename from RangeFix change
dd6c8b8 Support toDomElements returning an empty array
9be6464 Placholder -> placeholder
9bdd0a8 Restore basic styling to toolbar in core target (only)

Local changes:
Move selection restrictions from tools to commands

Change-Id: I88f3d04946bd1d03ed001d747475a8b495a0f64c
2014-11-04 14:11:04 -08:00
Alex Monk b1e47365d0 Kill MWCategoryWidget#onLookupEnter
This code was somehow broken by Ia47bc897 (wtf, how?)
Actually removing it seems to do no harm (wtf?), as far as I've been able to tell...

Bug: 72906
Change-Id: If7eb34a20cc8060b594a567278241b02a8ee327a
2014-11-04 20:35:55 +00:00
Roan Kattouw c23208371a Followup 0165a53: don't store an mw.Title object instead of a string in TemplateModel
0165a53 overlooked the fact that 'name' is also passed to
the MWTemplateModel constructor, and there it really does
always need to be a string, not magically either a string
or an mw.Title object. Oops :(

Bug: 72961
Change-Id: I0b20f0768aae4d9cc9f7af268abd0a704b6adc3a
2014-11-04 10:58:53 -08:00
Roan Kattouw 362d0ebcdf Followup 0165a53: fix typo causing undefined to be passed to mw.Title
Bug: 72948
Change-Id: I1942f153f18c5a182de38a0e067ec5a92abeefd3
2014-11-04 10:53:58 -08:00
Cmcmahon 3b53b23fb1 [BrowserTest] no iframes for switch mode test
Change-Id: I99e4686144ded173f8d91be87f02a4c144284237
2014-11-04 08:06:33 -07:00
Cmcmahon 0f2310a49d [BrowserTest] no more iframes for "no review" message
Change-Id: I9f7429eff32043c26264faa48404e6f573330b7f
2014-11-04 07:46:24 -07:00
jenkins-bot bb96a9083f Merge "Replacing MWTitleInputWidget.getValue() with MWTitleInputWidget.getTitle()" 2014-11-04 01:18:38 +00:00
suchetag 0165a53044 Replacing MWTitleInputWidget.getValue() with MWTitleInputWidget.getTitle()
Now that we have .getTitle() as a method in MWTitleInputWidget, replacing the callers
of MWTitleInputWidget.getValue() with .getTitle(). This fixes a bug in the .getTitle()
method in MWTitleInputWidget which was not taking the namespaces into account before.

Also fixes: the error when entering "Talk:" as a template title. The button to add template
remains disabled when "Talk:" is given as an input to the title here.

Bug: 71998
Change-Id: I1e629a61ec8b035d93a4b7acfecab81934019166
2014-11-03 17:05:51 -08:00
Cmcmahon 666001ba1c [BrowserTest] no more iframes for transclusion
Change-Id: Ifc50a50e98de18612e6ab4b548b1cf6ec05bc825
2014-11-03 16:27:17 -07:00
Cmcmahon aab1680244 [BrowserTest] no more iframes for switch modes test
Change-Id: Ifebc458f9ff9583954226d86759753b0314db649
2014-11-03 15:51:55 -07:00
Cmcmahon 396d74053b [BrowserTest] no more iframes for References
Change-Id: I7f5cf7b991cfcfd3ebebe0f17bb594802fe7dea0
2014-11-03 15:41:38 -07:00
jenkins-bot b70f2176fa Merge "[BrowserTest] no more iframes for options" 2014-11-03 22:20:55 +00:00
Cmcmahon 9b6e21cf0b [BrowserTest] no more iframes for options
Change-Id: Iee2c88f693edb68017154a497aea05d16eb7453c
2014-11-03 15:18:44 -07:00
jenkins-bot aab271f6e7 Merge "MWReferenceGroupInputWidget: Remove dummy call to onInputChange()" 2014-11-03 22:09:44 +00:00
Cmcmahon 6907583418 [BrowserTest] no more iframes
Change-Id: I8090f95ccd1cf2744649084c863e6034db062d87
2014-11-03 14:45:52 -07:00
Cmcmahon fcfb847276 [BrowserTest] no more iframes for Media test
Change-Id: I724e071935f383185fdc44cf1a139931f8ded557
2014-11-03 14:37:59 -07:00
Cmcmahon a51783983f [BrowserTest] no more iframes for Links test
Change-Id: I72c01981b332a32711e929543a61a780de962a2e
2014-11-03 14:18:21 -07:00
Roan Kattouw fe2895b145 MWReferenceGroupInputWidget: Remove dummy call to onInputChange()
This was needed to make the ComboBoxWidget initialize
its selection, but Idcbf38c53 makes that happen automatically.

Depends on Idcbf38c53 in oojs-ui.

Bug: 72783
Change-Id: I8d3a014f862ece7f4f201af205a8a7ca6c365eaa
2014-11-03 21:12:17 +00:00
jenkins-bot 48cfd29886 Merge "[BrowserTest] click More button, no iframes" 2014-11-03 20:59:37 +00:00
Cmcmahon 61f8cf7ca5 [BrowserTest] click More button, no iframes
Change-Id: I1426f4dcfb65d6e38be5f7e495e9600f98894525
2014-11-03 13:57:29 -07:00
James D. Forrester d0e62e1ab3 MWGalleryInspectorTool: Provide the tool in the toolbar
Now that the toolbar hides extra features by default, we don't need to
use autoAddToGroup and autoAddToCatchall over-rides.

Change-Id: I493f7d46a3f77e7c62af05f8e05ae4dde7147e4b
2014-11-03 11:19:04 -08:00
jenkins-bot 35a7931f10 Merge "[BrowserTest] no more iframes for Cite test" 2014-11-03 19:11:48 +00:00
Cmcmahon 3b57451863 [BrowserTest] no more iframes for Cite test
Change-Id: Ic31521dc8124818df1451a57ae396ca2e9c6beef
2014-11-03 11:57:55 -07:00