wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-15 18:39:52 +00:00
Code Issues Packages Projects Releases Wiki Activity
2095 commits 161 branches 1 tag 190 MiB
Commit graph

405 commits

Author SHA1 Message Date
Trevor Parscal 5aa3bbedc7 Fixed output of translateOffset when collapsing a range 
Change-Id: Ifb40dd1f9de557d4237660f5fb7119d6aa940c65
 2012-06-21 10:45:58 -07:00
Inez Korczynski bbaa17a6c4 * Replace spaces at the beginning and at the end of text node with   
* Alternate double spaces with &nbsp, "  " -> "  "

Change-Id: Ib4351ed6263e69f0d98957c2d0d8411e040fece7
 2012-06-20 15:32:14 -07:00
Catrope 37600d020c Add ve.dm.Transaction.translateOffset() and translateRange() 
Change-Id: I21bde38056862a1de167646f6cf3030e38d3497b
 2012-06-20 14:52:44 -07:00
Catrope a22c1870ea Fix ve2 paths in RL modules and tests 
Change-Id: I435b9902209348beba83f399ae165d179e954ccb
 2012-06-20 10:57:23 -07:00
Catrope 748b34cc49 ve2 -> ve in the tests directory too 
Change-Id: I30b56b1c43202d8cb6af397d2813b19b1a71d30e
 2012-06-19 18:36:34 -07:00
Catrope fc4ba3019a Fix selectNodes() bug: empty range at the start of a node returned [] 
Because of the end>=left condition, the loop was exiting right before
hitting the startBefore case, so use end>=left-1 instead.

Fixing this exposed another bug that caused nodeRange and nodeOuterRange
to be off by one: we need to increment left after storing it in
startOffset, not before

Change-Id: I54e18fb2119c8caefb4f7a7f2be43c6129afc4c0
 2012-06-19 17:12:36 -07:00
Catrope 61f4a8af78 Update the code to account for the fact that sHref is now a string 
and update tests to reflect the recent changes in link handling

Change-Id: Ie1a3e409c22c09f104c244b1db4764fd202fc885
 2012-06-19 16:04:07 -07:00
Trevor Parscal 41b6ccf9d3 Fixed ve.dm.Surface tests that broke when setSelection was deprecated 
Change-Id: I7319067cff0e088f70726c826a0c01be47aec808
 2012-06-19 15:56:25 -07:00
Trevor Parscal ca4f19c726 Fixed remaining uses of transact to change 
Change-Id: I63c8fb183be8b37db85ed386d7bf33633e821f80
 2012-06-18 22:05:05 -07:00
Trevor Parscal 11a3d883f2 Using resource loader debug scripts to unstub ve.log 
Also added ve.dir and converted use of console.log to ve.log

Change-Id: Ibbfd78b6ece163f54f40e997c79a01de6609c2b4
 2012-06-18 13:30:39 -07:00
Catrope e6751e3f03 Set data.title based on sHref so LinkInspector can use it 
Change-Id: I7589740ec5661afd7c8dd0f54e955d170e3096e6
 2012-06-13 19:32:49 -07:00
Catrope 7dd65cda91 Add newFromWrap(), ported 98% verbatim from the old code 
Change-Id: I81fc74b1d23bc6b60e476bfefbae4d7d9a9bf5f6
 2012-06-13 16:17:23 -07:00
Trevor Parscal 169b7e754d Cleaned up toolbar annotation updates 
Change-Id: I8cefd6c871ed6d1ad71f64eb66236de1b8b719b5
 2012-06-13 14:31:46 -07:00
Catrope c9605066cd Merge remote-tracking branch 'origin/master' into dmrewrite 2012-06-12 11:57:32 -07:00
Rob Moen 2ea1030ab4 Rewrite document annotation getters to return collection objects 
vs arrays

Change-Id: Ib48a39fff501cdb769f5b9b9fc7717805b74236e
 2012-06-12 11:10:29 -07:00
Catrope ab0c37def9 Rip out the offset map 
The offset map was broken from the start because it wasn't updated when
adjusting the length of a text node, and if we fix that bug it's
doubtful whether the costs of updating the offset map outweigh the
benefits, especially considering that adjusting the length of a text
node is something we do for almost every keypress. If it turns out
having an offset map does make sense, we can always reintroduce it
later.

Change-Id: I59e8bc154f7d07aa1bab2f473c13ff466d0e463f
 2012-06-11 18:10:08 -07:00
Catrope 77e923e323 Update tests for Parsoid workarounds 
Change-Id: Ifc7e7dc53eafa62af5652a2dba6cdc1fad199b4c
 2012-06-11 18:10:07 -07:00
Trevor Parscal c8c4ed8f99 Added ve.dm.Transaction.newFromContentBranchConversion 
Change-Id: I0e272b24dddae028e44d4c693297b1875000ef57
 2012-06-11 15:58:44 -07:00
Trevor Parscal 20d1c290d4 Fixed multi-auto-wrapping issue and added tests to track regressions 
Roan mostly wrote this

Change-Id: Id292c84a4da97d6608aa7c17ab6a4cf5a2e3f409
 2012-06-08 15:16:55 -07:00
Trevor Parscal 773be35b16 Fixed element summaries to not rely on HTML serialization, which can render attributes in any order and tends to differ between browsers 
Change-Id: I9cb7c3d26efaf983f667c9490cc4be0ea2fe5ab5
 2012-06-08 15:15:22 -07:00
Trevor Parscal 5969f55550 Delete HTMLConverter and update demo&sandbox 
Also update the demo and sandbox for ve.{dm,ce}.TableSectionNode

Change-Id: I5a73a8250d283e8666b93561ce9e9374739936a5
 2012-06-08 12:40:43 -07:00
Trevor Parscal faa58d1e4a Merge branch 'refs/heads/master' into dmrewrite 2012-06-08 12:29:57 -07:00
Trevor Parscal 61ba00aaef Add a tableSection to the example data and update offsets and stuff in almost all tests 
This fixes the converter tests.

Change-Id: I72f6d6c103c3a8bbee201c070a2f7c1bfe401235
 2012-06-08 12:27:39 -07:00
Trevor Parscal 2e0d4ef094 Make tableCell represent both <td> and <th> 
Adding a 'style' attribute which is set to either 'data' or 'header'

This breaks even more tests because of missing style attributes

Change-Id: I0a75d8c1578b4414eeae8c484f6c4d6f8a59472a
 2012-06-08 12:27:22 -07:00
Trevor Parscal c614d3391b Add ve.dm.TableSectionNode and ve.ce.TableSectionNode 
Yes, this breaks a bunch of tests, because tableRows are now required to be inside tableSections

Change-Id: Idb52d988df69173647c85f7602344650456e078e
 2012-06-08 12:26:45 -07:00
Trevor Parscal 911ee3229a Test getDomFromData using getDataFromDom's tests 
Move the test cases for getDataFromDom out into ve.dm.example and use them to test getDomFromData as well

Change-Id: Ib33854a7a1e8cb6a8ebf2c5b88cd5c17e25644b2
 2012-06-07 22:10:53 -07:00
Trevor Parscal f2b3df8027 Cleaned up some useless/unused functions 
Change-Id: I6aa5d0ed3d21993ed653ee64b4928ef98874db2d
 2012-06-07 15:02:40 -07:00
Trevor Parscal 453bec4555 Fixed alienInline and alienBlock conversion (was missing closings) 
Change-Id: Ie8e51eb8d9a452c656aebf341071da5627dd80b5
 2012-06-07 14:30:06 -07:00
Trevor Parscal fa9fe8b08a Added support for alienInline nodes 
Change-Id: I15b9cbcdb66b966dca28edcb26bf5d54a4f17be6
 2012-06-07 14:16:19 -07:00
Catrope 3c1de3dc4f Add ve.dm.Document.getBalancedData() 
Change-Id: I2420ef5369b9eae053962898b64dd7324e714bbd
 2012-06-07 13:17:57 -07:00
Trevor Parscal c8ec9fc6f5 Added a test for removing all the content of a paragraph in the middle of a document 
Change-Id: Ibbbc401a6484616dca52133b605d643ba3f810eb
 2012-06-07 10:57:03 -07:00
Gabriel Wicke b49102281f Remove a few entries we now care about from the whitelist 
They are mostly about whitespace, but there is also a debatable quote test
that outputs an empty bold element at the end of the line. We should perhaps
strip this empty bold in the QuoteTransformer, as the preservation of an empty
bold tag in round-tripping does not seem to be too useful.

Change-Id: I1d8f3ebabcd9f6249e5170de420ba52e8aea22ca
 2012-06-07 10:04:20 +02:00
Trevor Parscal b62beed2e2 Added implementation for ve.dm.Converter.getDataFromDom 
Change-Id: I8561d4a00ba630b86fb7bcd3e347fe2c6c2f6aa3
 2012-06-06 17:47:27 -07:00
Catrope f34b41fe3f Add a test case for a complex removal 
Change-Id: I9e57bf2f1381b1da196308f1cd27c9be58bf8509
 2012-06-06 15:36:08 -07:00
Catrope 5e47bdc57f Maintain a transaction-wide offset adjustment 
This fixes a bug where the second replace operation in a transaction
would cause the rebuild of the wrong range, or the adjustment of the
wrong text node.

Change-Id: I9b1c68d84999d538fe10bb193f4dfdd694121d2a
 2012-06-06 15:34:55 -07:00
Catrope 02b19f337f Add zero-length text nodes to empty content nodes 
This is needed to make the results of certain transactions' tree sync
round-trip cleanly through the ve.dm.Document constructor

Change-Id: I2ab0758ec6bd7afba5b6645c7330f9fa2d45205d
 2012-06-06 15:33:42 -07:00
Catrope 1429a3da59 Rewrite newFromRemoval() using 'covered' mode 
Change-Id: If0736aff6d194ec09c2a109f046dd6362ddc64fb
 2012-06-06 11:47:35 -07:00
Catrope 1566306937 Add 'covered' mode in selectNodes 
Change-Id: I4d24c011ce7a94bc75508dea410fb0ed9ebce6a1
 2012-06-06 11:47:35 -07:00
Catrope 61229a5313 Make selectNodes tests actually compare nodeOuterRange 
Change-Id: I5c251eb6972e8064ab7e9b2cb9fe2e93060c830f
 2012-06-06 11:47:35 -07:00
Catrope 1498ac74eb Fix broken input data in selectNodes tests 
Change-Id: I8b81d23d8c501d8f0db5d2922ed3408a6c9033b0
 2012-06-06 11:47:35 -07:00
Rob Moen 2439c0149a Created secondary method for getMatchingAnnotations 
new static method looks for annotation in annotation object.
ve2 Cleanup on annotate method and surface model.
Partially revive UI tools by exchaning old method usage
for ve2 methods.

Change-Id: Id0ac58330292d76801bbcf1d71a919b493f8ab9e
 2012-06-06 11:27:23 -07:00
Trevor Parscal 5d20f45120 Added getHtmlElementFromDataElement and getDataElementFromHtmlElement 
Change-Id: Ie5f4fd86612b5a6c34b5843d1e9a521edc626a63
 2012-06-06 10:17:51 -07:00
Gabriel Wicke 0f9d939b00 Use word diff if --color is enabled 
Change-Id: Ib8d3de75ac306974abfdaca22bfc7b69bc62891d
 2012-06-05 16:10:13 +02:00
Catrope 528728558b Fix bug in selectNodes's logic for traversing back up the tree 
Change-Id: I0fc5a2ad2c9a8d162e8ddbf3cc6d31684d364928
 2012-06-05 06:50:09 -07:00
Trevor Parscal 9111e34a0b Added nodeOuterRange to selectNodes 
Change-Id: I9ef0c383fbb2515c752d2d3c52e8632aac73d811
 2012-06-04 16:21:29 -07:00
Trevor Parscal a0ea700090 Added tests for transactions that deal with removing alien nodes 
Change-Id: Id36413c62386dbe5ebc8c8b3a1d3c5e301a8175a
 2012-06-04 16:21:29 -07:00
Catrope f7445b37b8 Retain attributes when reopening closed nodes 
* Push entire elements onto openingStack rather than type strings
* When closing an element, build a clone of the opening and push it onto
  closedElements, then insert that clone when reopening the element

Change-Id: I8b0fb44394aed6c471dc6dacaab03e44c2333733
 2012-06-04 16:07:16 -07:00
Catrope e67b2fd793 Add some more tests for newFromInsertion 
Change-Id: I3c403928a8176d8685e48a63759fefec4657ca96
 2012-06-04 16:01:14 -07:00
Rob Moen f958297102 Create tests for surface model annotate method. 
Fix up surface model tests

Change-Id: I02b57edc5c3faeb39e0b3c1f473f03fbd49d85b4
 2012-06-04 15:02:56 -07:00
Trevor Parscal 386faa5569 Fixed ve.dm.Transaction.newFromRemoval so it supports trimming off extra openings and closings 
Change-Id: Icbcf4129a51aa92d47aa89738facd0d288337cbd
 2012-06-01 14:34:59 -07:00