Commit graph

976 commits

Author SHA1 Message Date
Alex Monk 07c6c17e5c Unbreak loading of VE in the read page
Change-Id: Ic3e4e65296fa63b3a7d5114366f2859f4ce3f21d
2015-11-03 18:16:47 +00:00
Alex Monk f71a5a5bca Dialog for switching between wikitext and visual editing
Change-Id: I7046ffbe318d046b4baee11f4148ab77fc2af7fd
2015-11-03 01:36:29 +00:00
jenkins-bot a0a0f0e2c0 Merge "Allow switching from wikitext to VE" 2015-11-02 23:18:33 +00:00
Alex Monk 85b745666f Allow switching from wikitext to VE
Just by pressing the VE tab for now

Requires a relatively new version of restbase

Bug: T49779
Change-Id: I2a5294345f5e0f469c1dd1bdd29dbce211571a4e
2015-11-02 20:55:19 +00:00
Krinkle 59f55fbb9b Revert "DesktopArticleTarget.init: Tolerate missing wgRelevantPageName"
Shouldn't be needed once T116693 is fixed.

This reverts commit 39bb635a60.

Change-Id: I545a9eba85f15dcae00c5f117939960acf4113d2
2015-10-27 01:07:47 +00:00
Roan Kattouw 39bb635a60 DesktopArticleTarget.init: Tolerate missing wgRelevantPageName
For some reason this happens on some zhwiki pages.

Bug: T116693
Change-Id: I2880b8e7f2ed933928b155dd8727012f79854e1d
2015-10-26 16:31:44 -07:00
Timo Tijhof 51369ab9ab mw.TargetLoader: Avoid private mw.loader#moduleRegistry property
Follows-up 28f3a02e56.

* Use mw.loader#getState() instead of private 'moduleRegistry'.
  This property is not a supported API and may change at any time.

* Use plain push() instead of splice(). The order of modules
  is insignificant as dependencies are enforced by module registry
  only. Besides, the order is additionally normalised both
  client-side and server-side by ResourceLoader.

Change-Id: Id9291c97c3bfc01c4cf203aa7b15629fb8412f5b
2015-10-24 22:26:14 +01:00
jenkins-bot 724aeb9b33 Merge "Add theme-specific drop shadows to target loading bar" 2015-10-22 23:06:58 +00:00
jenkins-bot a67c62a754 Merge "Create separate skinStyles for target loading bar" 2015-10-22 23:06:56 +00:00
Ed Sanders c9fc5fb171 Add theme-specific drop shadows to target loading bar
As a modal popup it should have a drop shadow

Change-Id: I5b4a07c268c30124ed7ba6cc5391005595abeb7b
2015-10-22 16:02:25 +01:00
Ed Sanders 9749ff5187 Create separate skinStyles for target loading bar
Change-Id: I74eff697711641a7c111564ddb9e493ad358b8d4
2015-10-22 16:01:44 +01:00
Ed Sanders 28f3a02e56 References: Don't load ext.visualEditor.mwreference if Cite is not installed
Ultimately we should move all the code for this module to the cite
extension.

Bug: T41621
Change-Id: Ia2fcc9513ae806aaa173770337f176d5dbf59709
2015-10-22 11:36:17 +01:00
jenkins-bot 81a89952ef Merge "Educational popups and highlights for links+citations" 2015-10-14 21:52:50 +00:00
jenkins-bot 45468b992a Merge "ve.init.mw.Target: Remove jqueryMsg hacks in #saveErrorNewUser" 2015-10-06 21:09:58 +00:00
Bartosz Dziewoński c684e2c682 ve.init.mw.Target: Remove jqueryMsg hacks in #saveErrorNewUser
The bug in jqueryMsg that required this is now fixed.

Bug: T87219
Change-Id: Ib7ef7e6a0451539099c12ae32d02b50c269c7529
2015-10-06 19:04:10 +02:00
Alex Monk 9d6fbc894e Educational popups and highlights for links+citations
Bug: T108620
Change-Id: I42b0e06f50aca5cb783d88f79a080461e745ceee
2015-10-06 14:33:57 +01:00
jenkins-bot aaaded172b Merge "Toolbar config: Prevent 'Table' from moving after menu expand" 2015-10-05 15:14:47 +00:00
Ed Sanders 1eb0ef2011 Consistently use spaces inside brackets in CSS
Change-Id: Ie63a50cb16cb89dac7060857220485d7d23f2fe3
2015-10-04 18:33:43 +01:00
Ed Sanders 7337eb1d7e Toolbar config: Prevent 'Table' from moving after menu expand
Change-Id: I9f472668e0cf8f3014c681f6f2430e685bf50534
2015-10-04 13:28:55 +01:00
Alex Monk a46b7a819e Hack to stop logging edit events for non-desktop targets
Mobile target, for example, has events logged in the MobileFrontend extension instead
(which covers both the wikitext editor there and the VE integration)

Bug: T110272
Bug: T109525
Change-Id: I521f1825dc9c0a135db54cd005cda723908f14bc
2015-10-01 23:48:10 +00:00
jenkins-bot e14c8e11cf Merge "Change a bunch of parsoid references to acknowledge that RESTBase is sometimes in the middle" 2015-10-01 16:14:29 +00:00
jenkins-bot ce8107ec0b Merge "Autodisable preference" 2015-09-28 23:46:59 +00:00
Alex Monk 97e70ba3cc Autodisable preference
We want to flip the default of visualeditor-enable to true, but don't
necessarily want to turn it on for users who already have contributions but who
haven't already enabled it. Therefore we're considering adding such users to
this autodisable preference which they can self-remove (by explicitly enabling
VE) or we can target later, separate from betatempdisable users.

Bug: T112352
Change-Id: I1ce5e6c92055e30fdc82bc912a767e913b190ef6
2015-09-29 00:30:27 +01:00
jenkins-bot 2e4a70e082 Merge "Add scroll padding equal to the document height for iOS" 2015-09-26 16:39:26 +00:00
Ed Sanders 6769860adb Add scroll padding equal to the document height for iOS
Allows users to edit the end of the document in iOS without
the keyboard obscuring the content.

Change-Id: I72f1de97e61a0c0d8acac2e58b36b3ece58fca89
2015-09-26 17:06:37 +01:00
Alex Monk 3386f66770 Save dialog: Make review/resolve actions work in mobile
Depends on Ic92378b7

Bug: T111894
Change-Id: I5ca5f803642dd12db4e9fb213dc6478701661528
2015-09-26 00:08:31 +01:00
Bartosz Dziewoński 89b118daaf ve.init.mw.LinkCache: Update comment about Disambiguator extension
Disambiguator extension adds the .mw-disambig CSS class to internal
disambiguation links since 8cc16d021410f49fa12a2f35c97cdac51adf4380.

Change-Id: If32bcb8867a874ee4127593f58619d059fe691b0
2015-09-24 19:20:12 +02:00
Ed Sanders 42d04b6f47 DesktopArticleTarget: Fix page title (first H1) font size in Vector
Change-Id: I87409ad5da3819732d13943a64b2ca22f65f9418
2015-09-22 17:12:23 +00:00
Ed Sanders ade9bfda4b Skin specific fixes for external link cartouches
Change-Id: I84edb509e7ecaae00befbfdeeee7a75373564536
2015-09-20 23:35:23 +01:00
Ed Sanders 8c66e5df75 Load mwgallery on mobile as well
It's just as usable as the alien extension inspector which
is currently shown, and has better messages.

Change-Id: Ifbce9df4aff77cf76a8445158987be716ba45302
2015-09-19 18:14:52 +01:00
eranroz 051066ead6 Server-side replace Edit=>Edit Source on talk NS
If VE is enabled for consistency edit section links become edit source in all NS.
This patch fixes it to be done on the backend for namespaces where VE is not enabled
(instead of user side) to avoid noticeable flickers on page load.

Bug: T112366
Change-Id: Iba090bfc1b2ff4886fb0cf2b37db7870b6be792d
2015-09-16 00:39:13 +03:00
James D. Forrester e5e1810f02 MWWelcomeDialog: Alter to be welcoming, use a nice image
Drop beta-ness as users don't care and it confuses them. Leaving the preference
alone for now.

Bug: T99963
Bug: T112354
Change-Id: I0e039dec54d528fce24226e76b931b593dd13a9e
2015-09-14 18:29:07 -07:00
Alex Monk 82b62896e1 Change a bunch of parsoid references to acknowledge that RESTBase is sometimes in the middle
Bug: T112339
Change-Id: I0eac521a89fc399de168408ef55c9143c0db742a
2015-09-14 21:18:01 +01:00
Alex Monk 23691dc861 If init fails once, don't completely break when the user retries
The loading progress would not be reset upon failure, causing issues
when you tried to start loading again.

Bug: T96437
Change-Id: I7ec4be82304c101fa1bd634f60bc6b0047e2d53d
2015-09-14 21:13:45 +01:00
jenkins-bot 3b82179c06 Merge "Initialize actions toolbars" 2015-09-07 19:35:17 +00:00
Roan Kattouw 36dc5147bb Initialize actions toolbars
Right now .initialize() doesn't do anything other than enable
the window resize handler for toggling the "narrow" styling,
but as a matter of principle we should call .initialize()
on toolbars after attaching them.

Change-Id: I419c943d1d20af2105b84b8f5fbccc7070af601b
2015-09-07 11:30:30 -07:00
James D. Forrester 486bc7e6e3 mw.trackSubscriber: Log platform as phone vs. desktop
Change-Id: I71c25f28098c72ed779117da9c243dc3a87e611d
2015-09-05 21:29:03 +00:00
Alex Monk 6d94d060ac Bump Schema:Edit to revision 13457736
* Remove page.length
* Add action.abort.type = switchnochange

Needs to be deployed at the same time as Ib99700ac

Bug: T111420
Change-Id: I7ee245157d4de6c220d7cdf54cd1dd69ff836f15
2015-09-04 00:51:05 +00:00
Ed Sanders e4c351e362 Implement getUserConfig and setUserConfig in MW
Depends on I5704a0e3e0 in core.

Change-Id: I0d6c9317a91dc02566d8877bd1aefae581213cbb
2015-09-01 01:03:38 +00:00
Timo Tijhof 4e3d3acf65 mw.DesktopArticleTarget.init: Don't make non-VE edit tab collapsible
Collapsible relates to the Vector menu behaviour where an item
is moved into the dropdown menu if the window is narrow.

This should only apply to the secondary tab when there are two tabs.

If there is only one tab (non-VE, e.g. in a non-VE namespace) then
this tab should not be collapsible.

Server-side code handled this correctly, but client-side was
adding the class unconditionally.

Change-Id: Iecd195e92f43fe9f11b3938a1a24caed7b331e5f
2015-08-25 05:50:24 +02:00
Alex Monk 01f7207947 Don't retry request in tryWithPreparedCacheKey unless the error was badcachekey
Bug: T109787
Change-Id: I66cd40fadcdfd59bbea05240d0c9917342c6f5a2
2015-08-21 02:01:56 +01:00
James D. Forrester 00d3226be1 build: Enable jscs jsDoc rule 'checkParamNames' and make pass
Change-Id: Ifcd3f67524c32148ff3591263d6374b31ee57d3b
2015-08-19 11:33:59 -07:00
James D. Forrester 85f91f394e build: Enable jscs jsDoc rule 'requireNewlineAfterDescription' and make pass
Change-Id: I7c0fabc93834d19198caea8f5dd1834e9e473d0a
2015-08-19 11:21:01 -07:00
James D. Forrester 945242a55a build: Enable jscs jsDoc rule 'checkAnnotations' and make pass
Change-Id: I76abb1eb1f3e1a2e8a4c03f577a080f4889b3a6d
2015-08-19 11:09:34 -07:00
James D. Forrester 19df1d4c8a build: Enable jscs rule 'requireVarDeclFirst' and make pass
Change-Id: Ia2f765d12bde001c329c2ff4c080a36b71de9803
2015-08-19 11:05:01 -07:00
James D. Forrester f5c6f61163 build: Enable jscs rule 'requireSpacesInsideBrackets' and make pass
Change-Id: I846d36c15e1b1f810d2ef7fd422f8412790bcb0f
2015-08-19 10:33:02 -07:00
Ed Sanders c0d2546617 Add down indicator to advanced menu in mobile
It is a dropdown list so give it the down indicator we use elsewhere.

Change-Id: I8976f2bc5edd1e221ca155da02660703318480ac
2015-08-19 13:05:14 +01:00
Ed Sanders 87daf4773d Fix typos in function names
Change-Id: Id8a9bcd1b4409bc8132ac6007b75274074f5f477
2015-08-18 13:54:51 +01:00
jenkins-bot 0ca9a5a21b Merge "ve.init.mw.Target#saveErrorCaptcha: Focus CAPTCHA input on display" 2015-08-17 19:32:16 +00:00
Ed Sanders 91b7ede4e3 ve.init.mw.Target#saveErrorCaptcha: Focus CAPTCHA input on display
Change-Id: I491d0585380a36e87412d2c36a1d9e5b6111ccac
2015-08-17 19:20:05 +00:00