Tapping the toolbar save button while the save dialog is open triggers a save
because of the accesskey. It shouldn't save on a double-tap, because that's
easy to accidentally do / trigger on a slow device.
Bug: T230816
Depends-On: I4c3afce9d57c9bca737272b40b9a4862b5794bac
Change-Id: I1925b1b97de6a811f73196b616ec09a2c30c336f
Depends on MediaWiki change I48d4bb3f, which adds the 'arrayParams'
option to handle explicitly indexed array parameters like
`&preloadparams[0]=a&preloadparams[1]=b`. Previously we only handled
implicit indexes like `&preloadparams[]=a&preloadparams[]=b`.
Bug: T231382
Depends-On: I48d4bb3fdf0ea7f5eb133c59bf63651ba356fc42
Change-Id: I8c899bce1b19fa286bd385f89e102a4b87db4db3
New changes:
78d5b216d More documentation for ve.dm.VisualDiff#diffTreeNodes
fe0ca590e Link context: Add small spacing between link and label
Change-Id: Ie96de32a9ae6a96fad92781d84a685225bdbc911
The double result creates more confusion that it clears up,
and now that the query input is always used for text insertion
it is less of an issue that we don't have a case-exact match
in the results list.
Bug: T230819
Change-Id: I58cbe740fa7d0327aadd5dd111161bb7087a4ddb
New changes:
aec8d85c5 build: Upgrade eslint-utils dependency from 1.3.1 to 1.4.2 for security issue
Change-Id: Ia2e5f94899fbb6d3ba036d820df95a3149df0a03
New changes:
13477446b Localisation updates from https://translatewiki.net.
9ef837943 GeneratedContentNode: Re-apply model selection if DOM node count changes
45c37f702 ve.ce.Surface: Don't request offsets that are out of bounds
Bug: T231085
Bug: T231094
Change-Id: Iad370402c5645a0ed4078977155815a95715dab5
New changes:
2e37aaea7 Localisation updates from https://translatewiki.net.
85011b54a Utils: Move ve.supportSelectionExtend to client-only utils
077dfaa59 ve.dm.Change: Remove no-longer used doc argument from #deserialize
586a91bc5 ve.dm.Change: Fix serialize to be recursive
Change-Id: Ia70f2a663899972e35ac0b077465f946ebc49ffc
New changes:
77076f828 LinkAnnotationInspector: add a "label" field on mobile
Local changes:
* Updates for mobile link label editing
Bug: T229431
Change-Id: Ib0489f6f59b228ebc4a20f7a0a515be938a8f6d3
When saving fails for a reason we don't handle explicitly, the error
message will have HTML formatting and will respect any on-wiki
overridden messages, rather than being plain text generic message.
Extensions providing custom SaveErrorHandlers may need to be updated.
The only one in Gerrit that requires a fix is TitleBlacklist:
Ibeae79c95557a7af699716c9d921f34c310bee6d.
* Remove handling for errors returned in .visualeditoredit.edit.info
rather than .errors (.error in old format). AFAIK this is only used
by some extensions, it is probably incorrect to do (T229539) and all
extensions I know of that do this (AbuseFilter, SpamBlacklist,
ConfirmEdit) have custom SaveErrorHandlers.
* Remove custom error messages for 'readonly' (identical to API
response) and for 'hookaborted' (very unhelpful and there is a
chance that the API response is better, if the extension causing
this error generates any error message).
* Add a silly shim for MobileFrontend integration, because we allow it
to handle error responses, and it expects them in the old format.
This is probably subtly wrong in many ways, but MobileFrontend code
only uses this for logging, so it shouldn't explode. In the future
we will hopefully change it to use errorformat=html (T228897#5366960).
Bug: T229532
Change-Id: I3b9c4fefc0869ef7999c21cef754434febd852ec
A @method annotation is only necessary when the docblock is not
directly followed by a function declaration (in which case JSDuck
assumes it documents a property), e.g. when defining an abstract
function or referencing a function from another library.
I verified that JSDuck generates exactly the same output before and
after this change (docs/data-<hash>.js files are identical).
Change-Id: I7edf51a8560ab9978b42800ab1026f0b5555c3bf
New changes:
92b32ff5e Localisation updates from https://translatewiki.net.
43950656f Rebaser: Listen to surface history event, not document transact event
3847440a4 Localisation updates from https://translatewiki.net.
5e3e913ea Consider focus, not anchor, in ve.ce.RangeState
56378e975 Prevent RangeState tests from hanging QUnit via a huge diff
Bug: T230814
Change-Id: Ib1f238c4800e3acb581122cbb999a8e59dd5b2c5
New changes:
62f06382c Localisation updates from https://translatewiki.net.
5fc25c0d9 LinkContextItem: Apply ellipsis directly to link
Local changes to fix link ellipsis styles.
Bug: T230267
Depends-On: I25bb4fa9b7288232b08bab9c88f281817a26d6bb
Change-Id: I8a4b04d45979a1f6c375a7c92a340e3e81d7753c