This was accidentally removed in d69d366469 during its refactor.
Because of the change to how checks are decided to be shown, I've made
AddReferenceEditCheck always be required -- later code in
hasAddedContentNeedingReference assumes that it's loaded anyway, so a
wiki deciding to configure it to not load at all for some account types
would have broken saving.
Bug: T373692
Change-Id: I007cd705451581ebacfa12e8ac5502bd1bc56a38
Listeners will already know which object emitted the event.
Currently this event is used once as a aggregate event,
(as 'editItem' in the ve.ui.MWGalleryGroupWidget constructor)
in which case the emitting object is already prepended as the
first argument (as documented in OO.EmitterList.prototype.aggregate).
Change-Id: I490f368af8e9cae60eacac918bf83702999f705b
This passes the option to ApiParse which will ensure that it uses
the ArticleParserOptions hook so that the parser options used after
reload match the ones originally used to render the article.
Bug: T373212
Depends-On: I906affc8d2335b7bb48dff3a4b061fcf86b71cee
Change-Id: I18147254f1ac5f08a57e85eb2f031df7701dccef
As described in T326169, when editing a (manually created) cross-wiki redirect,
VisualEditor will throw a null dereference exception causing it to fail to load
in the browser (looking like it is just taking forever to load).
This patch prevents the exception from occurring by not attempting to write to
the null object.
Bug: T326169
Change-Id: I50fa803c7b4ce65dac1fe345431d8b8f9d0b3d61
…but not when we were previously logged-in. Temporary accounts no
longer leak IP addresses, but it's still not nice to lose attribution
of edits by logged-in users.
Follow-up to 317d6dd724.
Bug: T345975
Change-Id: I24c786c0f060921f773e1d6d1c7463f1cc79aab2
A notice already appears and informs the user of the visual editor that
they're not logged in if their session has ended. Showing an additional
error dialog informing the editor of this when saving changes is not
needed.
Bug: T345975
Change-Id: I20a904dbc6d3c2f0d08e4ceea27e35ee1b65bb71
preSaveChecksShown + preSaveChecksNotShown = preSaveChecksAvailable
allowing us to use simple stat counters to detect errors in check
generation.
Follow-up to 57daf35bd6
Change-Id: I0586b766b5beec3bd059c90875ad0e2d1f092fab
New changes:
cf83d253d Use safe access (hasOwnProperty) for selection stores
c2ee0773b alphabetize scripts in package.json
3206d1e9e fix jsdoc warning
682a9bc0a Handle right-click-delete in Firefox programmatically
435d81879 ve.dm.TransactionProcessor: Use ve.compare
70cce6bb0 Update OOUI to v0.50.3
227cfd31a i18n: Use localized digits in VE's find and replace dialog
4daaf826f Localisation updates from https://translatewiki.net.
4e34a2b05 Localisation updates from https://translatewiki.net.
a4186823b Localisation updates from https://translatewiki.net.
4d129d953 Update OOUI to v0.50.4
44e1bfb1f Localisation updates from https://translatewiki.net.
79dfba95c Localisation updates from https://translatewiki.net.
4a2e52396 Localisation updates from https://translatewiki.net.
cca20d203 Follow-up 79dfba95ce4: build: Update languages to add 'sjd'
c2c5b7a56 ve.ui.AuthorItemWidget: Fix color picker
9b5f854b6 Localisation updates from https://translatewiki.net.
62cbcaf56 Localisation updates from https://translatewiki.net.
b03c13815 Localisation updates from https://translatewiki.net.
be8847993 Localisation updates from https://translatewiki.net.
Bug: T220629
Bug: T368198
Change-Id: Ib2b1a5db75598f7cf627e6fbaf0c19f53b49c925
MediaWiki needs this even without VisualEditor so let's move it there.
Bug: T371702
Depends-On: I4dcfa3916a07e92565b5667adb2ead0115fdb438
Change-Id: I0562ea1e5bd28eabd3ef0bcd8372155da67bcd0c