wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-15 18:39:52 +00:00
Code Issues Packages Projects Releases Wiki Activity
19296 commits 161 branches 1 tag 190 MiB
Commit graph

78 commits

Author SHA1 Message Date
Ed Sanders 1b5550f485 Move var declarations inline 
Mostly ve-mw/ui and a few left overs.

Change-Id: Idea0c94d974e661c49af8ad4545cd8fd98179ca8
 2022-03-01 17:50:24 +00:00
Ed Sanders 86c405a2e1 Prefere ve.extendObject over $.extend 
Change-Id: I37fef45701653cef08de9ec699865aa4fdf477bc
 2021-11-15 21:30:19 +00:00
Thiemo Kreuz a625669380 Add missing @fires documentation tags 
Change-Id: I0c9b2aa827a6806004480b642c23f320b190b6ab
 2021-09-30 15:50:33 +00:00
Thiemo Kreuz aa556e3ef8 Update and fix all @param config and @cfg documentation 
I tried to review all of them. Some of the changes I did:
* Make sure the `config` parameter is not marked as optional
  when it is not.
* Make sure default values are mentioned.
* List individual `@cfg` options when it makes sense.

Note I don't list all options a class could accept (e.g. via all
its parent classes and mixins). That's too much. Instead I checked
how a class is actually used and list only these options.

Even then I don't list everything, e.g. unspecific options
like "classes" that can be used pretty much everywhere.

Change-Id: Idf4fbe1dc3608ace277df9e385f2f140df3a2f50
 2021-09-12 12:35:27 +00:00
Thiemo Kreuz 8f045a7155 Remove/fix a few small pieces of unused code 
I found these thanks to PHPStorm.

Change-Id: Ieb30a95debb58d3a454ac3c6f0546e5dbbe77ed4
 2021-05-21 11:43:45 +00:00
Ed Sanders 4545f53245 build: Update eslint-config-wikimedia to 0.17.0 
Fix instances of variable shadowing.

Change-Id: I6e2befb020d7d4b506c7b46131eafacd951aa6d1
 2020-08-18 13:16:49 +01:00
Akinwale Alagbe 2f7765d1e8 Fix: provide proper focus order to Category popup 
Bug: T257173
Change-Id: I99e9332adb83bf1197da827583b9f22f68b2f395
 2020-07-13 21:30:38 +02:00
James D. Forrester 2c77e88d2c doc: Bump copyright year for 2020 
Change-Id: I30539877543dc2a57bd1428a00d10ac46d8fc294
 2020-01-08 09:13:24 -08:00
Ed Sanders 4c86c54e46 Replace $.when with ve.promiseAll 
Add linting guards, except in preinit

Change-Id: I999641eddb0e0f5b112ec2259dbafc1e816e3437
 2019-11-04 22:06:54 +08:00
David Chan 22098d6b16 Convert $.Deferred() to ve.createDeferred(), except in preinit 
Follow-up to a8e07e026dea4f54241d1dbb6b7bcdbd8c670db2 in core.

Change-Id: I09333adb4876c6e584a4a6b6a1628227c4cd2616
 2019-11-02 13:06:28 +08:00
Bartosz Dziewoński 84d548e7b1 Remove redundant @method annotations 
A @method annotation is only necessary when the docblock is not
directly followed by a function declaration (in which case JSDuck
assumes it documents a property), e.g. when defining an abstract
function or referencing a function from another library.

I verified that JSDuck generates exactly the same output before and
after this change (docs/data-<hash>.js files are identical).

Change-Id: I7edf51a8560ab9978b42800ab1026f0b5555c3bf
 2019-08-21 23:33:15 +02:00
James D. Forrester 05fb44ae56 build: Upgrade eslint-config-wikimedia from 0.12.0 to 0.13.1 
Change-Id: I43f407da92f59a8bf758cc2586e84aa5e18d9ab0
 2019-08-02 09:51:07 -07:00
Ed Sanders 33774758b7 MWCategoryWidget: Implement setDisabled 
Change-Id: I443f2b55e2f17fb3c182e6cb22e392434513ce6c
 2019-02-25 12:56:37 +00:00
Ed Sanders 332aa1f3d2 build: Update eslint-config-wikimedia to 0.11.0 
Change-Id: I5a294705eed1760e2d4dde33934d2ffb12e29525
 2019-02-20 20:23:43 +00:00
James D. Forrester 3c293ea00c doc: Bump copyright year for 2019 
Change-Id: I8991b97c980d4149f53eb5601036220ef3c0c440
 2019-01-01 13:24:23 +00:00
Ed Sanders 1a3e8a958c build: Use eslint-config-wikimedia v0.9.0 and make pass 
Change-Id: Idb57fc12e7822cf17e10dbb726480fc7de0ae199
 2018-11-21 16:51:20 +00:00
petarpetkovic 30f099382a Replace jQuery.grep with Array.prototype.filter 
Change-Id: I912fb68060d88b618cb2a2502417c1bccc5fecec
 2018-08-25 00:11:30 +02:00
Ed Sanders 478b0bcbb9 Create getters for localised APIs (getContentApi/getLocalApi) 
Pass through the current document when available, otherwise
assume the current surface's document.

Also add a getter for getPageName, so that can vary based
on the target document.

Bug: T193856
Change-Id: Ifdc951fdc6a43b924d102e3fcd7e59e52023757b
 2018-05-05 14:32:55 +01:00
James D. Forrester 0a7a845a42 doc: Bump copyright year 
Change-Id: I0b299c840ede1a1b8552cecfc70c5760ab036181
 2018-01-03 17:45:07 +00:00
David Lynch f7d0df2449 MWCategoryWidget: batch requests for category data 
API query cuts off after 50 results.

Bug: T163406
Change-Id: I6e83843dd1a22334d9ddec7103ddf318fb181112
 2017-04-20 16:47:16 -05:00
James D. Forrester 122f49b2dd build: Bump file copyright notices for 2017 
Change-Id: I3c20809e71cc0da58123e1b5f29c4f3aac945496
 2017-01-03 08:58:33 -08:00
Alex Monk c843824c97 Batch gallery imageinfo requests via ImageInfoCache subclass 
Also get rid of .join( '|' ) for API request parameters per Bartosz

Bug: T147067
Change-Id: If4444cca300d65e28d6fb9003fcac5e076a5129a
 2016-12-06 22:10:19 +00:00
Ed Sanders e655880d14 eslint: Remove unused exception and fix documentation errors 
Don't enable valid-jsdoc yet though, due to @chainable bug.

Change-Id: I4d2a6de19c72c6e4c20733446616d8046419d431
 2016-10-28 12:02:36 -07:00
Alex Monk 7888c688b7 Simplify and fix category popup widget checks 
Bug: T86357
Change-Id: I9a85267f6da0077e2167a92f25a8dc41074e6548
 2016-09-13 04:17:20 +01:00
Ed Sanders 62bdaac13b Use super property to call parent methods 
Change-Id: I76982b844cf2871d7583463def4393e5bdc33aa2
 2016-08-23 11:56:47 -07:00
Ed Sanders 115bf4b3d2 CategoryWidget: Remove reorder event fix after upstream fix 
Change-Id: I9088c931433b0824f72b4c77d0fd05cb062068f7
Depends-On: I67945db3652b0edb24b490089b8ea5a43f0b29d0
 2016-03-03 15:53:49 +00:00
Ed Sanders 8f028813e5 CategoryWidget: Update to work with new DraggableGroupElement 
Change-Id: Iefac99dba0e6b8ed3eaaa1d5f1d92e402e3cf2db
 2016-02-25 16:07:50 -08:00
Ed Sanders 704ec7ad3f MWCategoryWidget: Improve caching 
For every title request, store an entry in noramlizedTitle to
avoid ever making an API request for that category again.

This prevents API requests from being fired every time a
category was moved, which in turn prevents the list from
flickering as it waits for the API request to resolve.

Also normalise the spelling of normalize to en-US/en-GB-oxendict

Bug: T127317
Change-Id: Ie26d9d60fb83981c45ff27199e38ae98e5560a28
 2016-02-18 17:14:33 +00:00
Ed Sanders 7eeb136d94 MWCategoryWidget: Use namespace constants from config 
Change-Id: I63661ce49dbb0fac62cb7dbd65c466cfdd6e57b0
 2016-02-18 11:36:31 +00:00
James D. Forrester ada58df361 build: Bump file copyright notices for 2016 
Change-Id: I3c618c196e504a80ca297a4132a17f1977a24fb7
 2016-01-03 14:57:25 -08:00
James D. Forrester 85f91f394e build: Enable jscs jsDoc rule 'requireNewlineAfterDescription' and make pass 
Change-Id: I7c0fabc93834d19198caea8f5dd1834e9e473d0a
 2015-08-19 11:21:01 -07:00
James D. Forrester 945242a55a build: Enable jscs jsDoc rule 'checkAnnotations' and make pass 
Change-Id: I76abb1eb1f3e1a2e8a4c03f577a080f4889b3a6d
 2015-08-19 11:09:34 -07:00
James D. Forrester f5c6f61163 build: Enable jscs rule 'requireSpacesInsideBrackets' and make pass 
Change-Id: I846d36c15e1b1f810d2ef7fd422f8412790bcb0f
 2015-08-19 10:33:02 -07:00
James D. Forrester 57f8fc5368 build: Drop last jscs over-ride and make pass 
Change-Id: I4ff60af79cfc6e09e284d51f9b7ac2afa900f0f5
 2015-07-22 15:13:09 -07:00
C. Scott Ananian 85b86fb45d Stop using deprecated aliases for OO.ui.mixin.* 
These classes were renamed in OOUI v0.11.4.

Change-Id: Ie932eb3bf5e65866ae4ba3bf2317facb1e740d3b
 2015-06-10 20:25:04 +00:00
James D. Forrester df79ed8c4b Update VE core submodule to master (5befc34) 
New changes:
3368c4c Remove some assumptions about the state of the context
79918af Move contexts to subfolder
820eaec Tests for some drag/drop functionality
e5f0e3e Convert CE surface tests to use a mock UI surface
c81dbcf Localisation updates from https://translatewiki.net.
7561ff3 Create a mock UI surface that only contains a model for model-only action tests
ad60333 Convert test timings on APIResultsQueue from seconds to milliseconds
b52d7df Table cursoring tests
3f8e821 Localisation updates from https://translatewiki.net.
9c737df Update OOjs UI to v0.11.4
5befc34 Stop using deprecated aliases for OO.ui.mixin.*

Change-Id: Ida6d4ba724686d8189975c55a18c4a6c2cfe4875
 2015-06-10 12:44:55 -07:00
Roan Kattouw 95bffa22a0 Stop using this.$ 
Has been a backwards-compatibility alias since OOjs UI 0.7.0.

Change-Id: I17d7c03e9d1b9fa991d88444d22abfd403269ee0
 2015-04-14 02:54:01 +01:00
Ed Sanders 0a2fa11a4e Fix choose event listeners 
* Choose can't emit with null
* Connect search straight to results' choose event.

Change-Id: I434829511ea70859d14e26f39095e0d094dea6c0
 2015-03-27 10:51:06 +00:00
jenkins-bot 557e0e28ad Remove use of ve.indexOf and ve.getObjectKeys 
Change-Id: Icbaa729209605fca8018e4bcbbe29c9ded64e7f2
 2015-03-10 17:28:00 +01:00
Alex Monk 9246fcd2ff MWCategoryWidget: Remove entries from this.categories when appropriate 
So for example MWCategoryWidget#getCategories doesn't return stuff that was removed.

Bug: T89923
Change-Id: Id99ea2e3b7c74e186bacbcf796b6df3a131a37b1
 2015-02-27 22:05:58 +00:00
Alex Monk 4082af335b Make category widget items draggable 
Depends on I859ff276

Bug: 50809
Change-Id: Idae3e293a6f7c29b70bc27c3db58e014d23b3e47
 2015-02-05 16:06:45 -08:00
James D. Forrester bed038b509 build: Bump devDependencies to latest 
Updates:
* grunt-contrib-csslint  0.3.1  ->  0.4.0
* grunt-contrib-jslint   0.10.0 -> 0.11.0
* grunt-jscs             0.8.1  ->  1.2.0

For jscs, leaving requireSpacesInsideArrayBrackets to avoid headaches for now.

Change-Id: I62d34444edbba65c8bd22d2fa5e50e16cabb0042
 2015-02-02 14:30:39 -08:00
Bartosz Dziewoński 6de4ed2f26 Change uses of LookupInputWidget to LookupElement 
Also moved around some code from MWCategoryInputWidget to
MWCategoryWidget to be a bit less evilly interdependent.

Change-Id: I0b8a58fb669e232a990b19c4b7f872a320bfab58
 2015-01-15 18:26:30 -08:00
James D. Forrester 2f8b3e0d96 build: Bump copyright notices to 2015 
Change-Id: Ie92dab7411116d3410195c3fb0a3513c664c0c30
 2015-01-12 20:34:19 -08:00
jenkins-bot cb9a96f845 Merge "Follow normalisation response from category status query" 2014-11-26 02:02:27 +00:00
Alex Monk 378ab667e9 Follow normalisation response from category status query 
To do things like strip off invalid invisible characters from the end of names.
(see bug)

Also rename that function because it covers more than just hidden status now

Bug: T74080
Change-Id: I8374695a991c4d3e397992ad9277b99d9288eec4
 2014-11-25 23:35:43 +00:00
Ed Sanders 2997cee444 Fix lots of spelling mistakes and typos 
Change-Id: Icf78d3d599326d3f12d09edcd2b8491ed35ade04
 2014-11-21 13:00:50 +00:00
James D. Forrester 7317114187 Update VE core submodule to master (029fc7e) 
New changes:
029fc7e Update OOjs UI to v0.1.0-pre (1fa4eb7a73)

Update changes:
Changes were generated by running this script:
https://gist.github.com/trevorparscal/265f1b8c854190637a1e

File changes:

Scripts (modules/ve-mw/ui/widgets)
- ve.ui.MWInternalLinkMenuItemWidget.js → ve.ui.MWInternalLinkMenuOptionWidget.js
- ve.ui.MWLinkMenuItemWidget.js → ve.ui.MWLinkMenuOptionWidget.js

File content changes:

Scripts (*.js)
- MWInternalLinkMenuItemWidget → MWInternalLinkMenuOptionWidget
- MWLinkMenuItemWidget → MWLinkMenuOptionWidget
- ContextMenuWidget → ContextSelectWidget
- ContextItemWidget → ContextOptionWidget
- TextInputMenuWidget → TextInputMenuSelectWidget
- MenuWidget → MenuSelectWidget
- MenuItemWidget → MenuOptionWidget
- MenuSectionItemWidget → MenuSectionOptionWidget
- OutlineWidget → OutlineSelectWidget
- OutlineItemWidget → OutlineOptionWidget

Styles (*.less)
- contextMenuWidget → contextSelectWidget
- contextItemWidget → contextOptionWidget
- textInputMenuWidget → textInputMenuSelectWidget
- menuWidget → menuSelectWidget
- menuItemWidget → menuOptionWidget
- menuSectionItemWidget → menuSectionOptionWidget
- outlineWidget → outlineSelectWidget
- outlineItemWidget → outlineOptionWidget

Change-Id: Ifded7f9e17923dbb56a722b7424ccd2854194c21
 2014-11-19 17:04:26 -08:00
Alex Monk de73246ee1 Show category items as red if they don't have description pages 
Also fix some lies I wrote in related code/docs

Bug: 65517
Change-Id: Iafacee7d8e460913d84808fe38ecc8da4a1817c0
 2014-11-08 14:27:27 +00:00
Ed Sanders 0efbfa7e21 Use hasOwnProperty instead of 'key in obj' 
Change-Id: I48f044c547b48a97cdfb31f7b887dca0ed7e341b
 2014-11-05 20:54:50 +00:00