Make it clear that this scenario is supposed to test
and take screenshots of the "Edit source" and "Edit" tabs.
Change-Id: Ia480eacb2629553c378ecad52a9b0ed1336cd0f3
Make sure that the validation method accounts for local api
vs remote api when checking for valid variables.
Bug: T90795
Change-Id: Ia6877ca6ccc4e65d1db053f107e7702721e2da3c
It uses modules/ve-mw/init/ve.init.mw.Platform.js via addParsedMessages
The missing dependency triggered an error when working on the Flow/VE
integration.
Change-Id: I64347aa6a0cf94fe51dd724432c22d54eea0cfd9
Again. Originally done in I5a664f86, the crucial part of which was reversed
in I1500f480.
Bug: T89913
Change-Id: I39b0cdcdb5f76fa75f506c874ef6223d8d8d53e6
The screenshot here is supposed to capture the menu that opens
when the hamburger icon is pressed.
The previous code captured the whole toolbar. This is now fixed.
A sample screenshot is here:
https://commons.wikimedia.org/wiki/File:VisualEditor_More_Settings-en.png
Change-Id: Id9501b8b1b8d41411c2f81bf4d4954a6bb41addc
This screenshot only needs the "Cite" button,
and not the whole dropdown menu.
* The clicking step is removed.
* The element is reconfigured.
Change-Id: If4b863e51db611b96186ca6381d0426a335a9a17
New changes:
80fa805 Remove use of getDocument/getWindow in ve.utils.js
763c0df Fix disconnect of focus change handler in surface destroy
f017882 Clear surface observer when re-activating a surface
56cf369 Revert "ve.ce.FocusableNode: Remove superfluous ve.ce.Surface#appendHighlights call"
Change-Id: I2df30e9c67da5246c0ec58e211b34c8fe0886339
This will allow us to more easily split the API request
into two requests (one for the HTML, one for metadata)
by returning a $.when() promise, and to initiate these
requests earlier (by storing a promise and returning it
in this method).
Change-Id: I4a5d1b8c47a3dc2edfe89925e63dcf90d7038e45
* jquery.placeholder: Wasn't being used at all, removed
* rangefix: Only used in ce.Surface, moved to the module that contains ce.Surface
Change-Id: Idea65687752a9fd31e4ad7594181e402d26b579d
It depends on jQuery UI so it pulls in a bunch of things
that we can do without while loading VE.
This does mean there's a network delay while we load
mw.feedback (if it's not in localStorage cache already),
so after the user clicks "Leave feedback", nothing happens
for a little bit until the code arrives and the feedback
dialog appears. There is no spinner or anything during this
time; we may possibly want to add one.
Change-Id: Ie4dd9efcfff238fefad2783e22575ffd3fc648e7
New changes:
2e75a9b newFromDocumentInsertion: Also remap store indexes in internalList data
f04b980 Transaction#newFromDocumentInsertion: Add some more tests
60d051c ve.ce.FocusableNode: Ignore children of elements using CSS column-count in Chrome
1089125 [BrowserTest] Update Gemfile.lock
3f376f5 [BrowserTest] Define Rubocop LineLength as 100
ee63e73 Work around Firefox bug allowing cursor in cE=false
505369a Unify data transfer handlers for paste and drop
Change-Id: I5e9c3bdf45610cd4a46de7af9bec78fa1847c23c
The toolbar now uses a CSS transition for its height instead of
JavaScript animation through slideDown().
* The animation is on toolbar instead of toolbar-bar so that it
contains the padding and borders. Otherwise it slides up until
there is the top and left (quite thick) borders stacked on
each other which then disappear at once.
* Add transform/translateY so that toolbar also transitions
when it is in floating state.
* Move class addition to attachToolbar() to avoid additional
reflow.
Bug: T89543
Change-Id: I30a7b69b77b874d220f60ebe7f7e616cd77bcc36
Still to load at this point are
* Additional modules (first load only)
* Parsoid HTML
To account for this we disable the toolFactory event listeners
to prevent flickering, and create a hidden blank dummy surface to
attach the toolbar to.
Bug: T76523
Change-Id: Iab24858f23f4db944dcaa6683a82b950ea9ee1b1
These were there to match Vector, however as of 4cec8a70589
Vector no longer has these. Having these in VisualEditor causes
the toolbar to be a few pixels behind (like a slingshot) when the
rest of the skin has already moved.
Change-Id: Ia5886a58316ccb3b0420553c3f466b5256089c73
We can't use wgTitle directly because it has spaces
but no namespace prefix (e.g. "Foo bar"), and we can't
use wgPageName directly because it has the namespace prefix
but underscores instead of spaces (e.g. "Project:Foo_bar"),
so run wgPageName through mw.Title.
Bug: T90433
Change-Id: If431f5b9f6efa2690cfd964f80d6ac71cb568087
