Commit graph

7650 commits

Author SHA1 Message Date
jenkins-bot 08afdfadbd Merge "Use parseInt(), not Number.parseInt()" 2015-03-27 23:23:22 +00:00
Roan Kattouw b858332667 Use parseInt(), not Number.parseInt()
For whatever reason, Number.parseInt doesn't exist in IE11.

Change-Id: I62366ee027283a8f70d3fff2e29c4f333ad5f697
2015-03-27 16:14:13 -07:00
jenkins-bot f7adb9d7d6 Merge "Don't position category popups -10px up" 2015-03-27 19:30:18 +00:00
Trevor Parscal a3c2ed7d27 Don't position category popups -10px up
Bug: T94114
Change-Id: I05ddbeb42b49dab925fe9b46caf12c6201e68441
2015-03-27 12:14:09 -07:00
jenkins-bot 4fbb11e40a Merge "Verify welcome dialog exists before trying to close it" 2015-03-27 18:48:39 +00:00
Moriel Schottlender db9e565a09 Verify welcome dialog exists before trying to close it
When deactivating, verify first that the welcome dialog was
initialized before calling 'close' on it.

Change-Id: Ife98b396f3d8641e2bd313c549fe867bcd84db9b
2015-03-27 11:45:26 -07:00
ecotg 175e60edaf Strip X-Parsoid Performance Headers from Visual Editor
Stripped out X-Parsoid Performance Headers, previously used to gather and
forward Parsoid's performance information, from ApiVisualEditor.php,
ve.init.mw.Target.js and ve.init.mw.TargetLoader.js. Change I936ada7b1 strips
out the corresponding X-Parsoid Performance Headers from Parsoid. Parsoid's
current performance instrumentation is achieved using Graphite and txstatsd.

Change-Id: I57d6f866a7d8287a5115e6236b0fb25bc4d0eabd
2015-03-27 12:03:15 -06:00
Amir E. Aharoni 9962663f81 [BrowserTest] Disable the Cite button screenshot
It looks differently in different languages,
and it is likely changing now with Citoid being deployed,
so it shold be disabled for now and revived when Citoid deployment
stabilizes.

Change-Id: If6a6ecf450060eb1387aaf90fd0cfb937b08bd3d
2015-03-27 14:46:39 +03:00
Amir E. Aharoni 8cb387a269 [BrowserTest] Redefine the Apply changes element for language screenshot
Redefine the element to include the full button
and remove the padding, which is now not needed.

Change-Id: I1ac244bc97b38c9d8b47ddd778a653783a748a49
2015-03-27 14:16:48 +03:00
Amir E. Aharoni d941263d33 [BrowserTest] Add padding to some more screenshots
Change-Id: If103488927e3309479b7b5f9f380135052c7ac9d
2015-03-27 14:11:14 +03:00
jenkins-bot a0fbb388f6 Merge "[BrowserTest] Add padding to the "Apply changes" button screenshot" 2015-03-27 08:23:56 +00:00
jenkins-bot 6d2aa585e1 Merge "[BrowserTest] Add padding to screenshots of the page settings dialog" 2015-03-27 08:23:54 +00:00
jenkins-bot 0ef3c0c20c Merge "[BrowserTest] Add padding to the Edit Links screenshot" 2015-03-27 08:23:52 +00:00
jenkins-bot 94be597053 Merge "[BrowserTest] Add padding to the page settings item screenshot" 2015-03-27 08:23:50 +00:00
jenkins-bot fafeb3396f Merge "[BrowserTest] Show the full Formatting pull-down in the screenshot" 2015-03-27 08:23:48 +00:00
Roan Kattouw 6bd5142f2a When content and metadata have different revids, explicitly retry the higher one
It's much less likely we'll get another conflict if we retry
with ?oldid=12345 than if we retry omitting the oldid again.

Change-Id: I10e40f714fd44d7f0ac16c9d0dc6239a95c0ec51
2015-03-26 16:07:43 -07:00
Roan Kattouw b19104ed04 Send requests to RESTbase directly when so configured
Also introduces paction=metadata in ApiVisualEditor which
doesn't hit Parsoid but gets all the other information we need.

Bug: T90374
Change-Id: I71edbc0f8dc15a6f8d3672c10ca3c641cc172be7
2015-03-26 16:00:54 -07:00
Amir E. Aharoni 0745d38a72 [BrowserTest] Add padding to the "Apply changes" button screenshot
Change-Id: I1a7aaca8013bf671ff39c310d5ad0dd1725b094a
2015-03-27 00:43:49 +02:00
Amir E. Aharoni 0cd5797a56 [BrowserTest] Add padding to screenshots of the page settings dialog
Change-Id: I460fc82a10ca5172537a97f28f3a50573c784a93
2015-03-27 00:43:01 +02:00
Amir E. Aharoni a1271abae3 [BrowserTest] Add padding to the Edit Links screenshot
Change-Id: Ife795e5f34b69fc6790cd04b217f823205737c0c
2015-03-27 00:41:38 +02:00
Amir E. Aharoni 5795b84d59 [BrowserTest] Add padding to the page settings item screenshot
Change-Id: I38f9d81cbfaa28c51997105bdc2cbaa81ed02783
2015-03-27 00:40:31 +02:00
jenkins-bot c9cfcc1a92 Merge "Fixed the empty Transclusion Box problem" 2015-03-26 22:38:05 +00:00
Amir E. Aharoni fb4212232d [BrowserTest] Show the full Formatting pull-down in the screenshot
The scenario for the Formatting pull-down screenshot didn't click
the "More" element in the bottom. This is now added.
The "More" element itself is redefined to be generic and work with
all pull-down menus - there is supposed to be only
one active menu at a time.

Change-Id: I27122f3192b220919311993ecd9a10d85ef5828d
2015-03-27 00:31:11 +02:00
ankita-ks 9096ebf7a1 Fixed the empty Transclusion Box problem
Bug: T52281
Change-Id: If6ba91497849b5ba311908359fde7f1db82b1fd0
2015-03-26 21:45:27 +00:00
jenkins-bot a950b213a4 Merge "Replace buttons with select widgets in GeneralReferenceDialog" 2015-03-26 20:52:35 +00:00
jenkins-bot 1d99839288 Merge "Remove this.fragment setting from ReferenceDialog" 2015-03-26 20:47:53 +00:00
jenkins-bot 6688867c49 Merge "Move append to after list builder" 2015-03-26 20:47:32 +00:00
jenkins-bot 226b1e8e25 Merge "Vertially centre cite-web icon" 2015-03-26 20:44:35 +00:00
jenkins-bot abf55bea87 Merge "Move template icon code to setup event" 2015-03-26 20:38:55 +00:00
jenkins-bot 25aedfd0fb Merge "Show beta welcome dialog before surface is ready" 2015-03-26 19:40:54 +00:00
Moriel Schottlender 74c3b758e2 Show beta welcome dialog before surface is ready
Split up beta and meta dialog show methods so that beta dialog
is displayed as soon as possible, regardless of the surface being
ready. Also make sure that we destroy the temporary window
manager on destroy.

Bug: T90454
Change-Id: Ib8f94518af431487ce940a74a8c268dbdbe403d2
2015-03-26 12:36:40 -07:00
Ed Sanders a1bc7aeac1 Move template icon code to setup event
We must wait until setup before we can measure this.$element.

Change-Id: If657b29e30e44af750516c20d318707293066910
2015-03-26 18:12:46 +00:00
jenkins-bot ac067538ab Merge "Fix revId check on new pages" 2015-03-26 17:50:04 +00:00
Alex Monk 024823e560 Fix revId check on new pages
Makes it possible to edit new pages again.

Follows up Ifbf44b7772

Change-Id: If170a367dc2f531d11f09569c7ab45ebd414dff6
2015-03-26 17:39:45 +00:00
Ed Sanders 1c3cfea6d8 Vertially centre cite-web icon
Change-Id: Iab1ba7a0616821717ee68cf2f290b6dd40fc5b24
2015-03-26 15:53:45 +00:00
jenkins-bot c3ac0f0dd1 Merge "[BrowserTest] Add padding to the Formatting menu screenshot" 2015-03-26 14:28:45 +00:00
jenkins-bot cc4ac9c327 Merge "[BrowserTest] Add the toolbar to the special chars screenshot" 2015-03-26 14:28:39 +00:00
Amir E. Aharoni 0631a42735 [BrowserTest] Add the toolbar to the special chars screenshot
This makes it clearer which button opens the special character tool.

Change-Id: I34a2ba182af0bdce164c4b21f97ee1bb13152593
2015-03-26 16:20:19 +02:00
jenkins-bot b669d5a95d Merge "[BrowserTest] Add padding to editing tabs screenshot" 2015-03-26 14:17:22 +00:00
Amir E. Aharoni 96a2aad660 [BrowserTest] Add padding to the lists and indentation screenshot
Change-Id: I7ef7f1b0bbf3a0a7b56cb7051677a0df3ff8a41b
2015-03-26 15:59:44 +02:00
Ed Sanders 872c7a3f98 Replace buttons with select widgets in GeneralReferenceDialog
Change-Id: I22016f1a362ece79894c5577e737b1df5180d82d
2015-03-26 13:58:40 +00:00
Amir E. Aharoni f7c2edf886 [BrowserTest] Fix the lists and indentation screenshot
Capture the whole button and menu.

Change-Id: I035109916a90efbd12e5f3ddb58b98a53b8e57d3
2015-03-26 15:57:42 +02:00
Amir E. Aharoni ef5bd83e55 [BrowserTest] Add padding to the Formatting menu screenshot
Change-Id: I606678381a9d291342b3c5d9cba67aef125725ee
2015-03-26 15:40:47 +02:00
Ed Sanders 4650010f4d Remove this.fragment setting from ReferenceDialog
This functionality is already provided by inheritance from FragmentDialog

Change-Id: Ie7bde7310d91d13b6eae95b826d59c06d286b749
2015-03-26 13:38:39 +00:00
Amir E. Aharoni d7926f460c [BrowserTest] Add padding to editing tabs screenshot
Change-Id: I60b915f470a751c041718bf339fa5bd27d5291ef
2015-03-26 15:38:00 +02:00
Amir E. Aharoni 8eb5ca1536 [BrowserTest] Add padding to Insert button screenshots
Change-Id: Ic79942bddf811b7f219424c9ae317c7664f9a193
2015-03-26 15:23:49 +02:00
Amir E. Aharoni b62be2355e [BrowserTest] Capture the whole Insert button in the screenshot
Change-Id: I7551914d57adace5ceb385f16cc93e146e4774a7
2015-03-26 15:13:47 +02:00
Ed Sanders 8352cde31d Move append to after list builder
Change-Id: Idf4407de8ad86e3f147308c82e533f9294c65aad
2015-03-26 13:10:30 +00:00
Translation updater bot 4e8463ae60 Localisation updates from https://translatewiki.net.
Change-Id: Ie96cb2761aff02432673024f5a9211f2a3ec9b4c
2015-03-25 22:21:47 +01:00
Alex Monk 9019f02130 Check for the two revision IDs returned by the server being different
With RESTbase we'll be able to retry the older one, but right now we have to do
both with the same request.

This commit retries loading once, then starts emitting errors.

Bug: T92993
Change-Id: Ifbf44b777279dafbe31ab438838d70acd44de726
2015-03-25 20:46:27 +00:00