Commit graph

14862 commits

Author SHA1 Message Date
Ed Sanders 07e05c7954 Cleanup: Get rid of surfaceReady callback
Just call the method after surface init.

Also move all the post-dm building code into
an #addSurface override.

Change-Id: Ie40baadfa6cd826a92f8fb7d928f4d995286f69f
2018-08-25 14:04:00 +01:00
Kunal Mehta 01433dc393 Configure phan-taint-check-plugin
The plugin checks and flags potential security issues (XSS, SQLi, etc.)
using static analysis.

See <https://www.mediawiki.org/wiki/Phan-taint-check-plugin> for more
details.

Change-Id: I6628c3faddd240024fa8f96967e3541e96ea0ff3
2018-08-24 21:34:28 -07:00
petarpetkovic 30f099382a Replace jQuery.grep with Array.prototype.filter
Change-Id: I912fb68060d88b618cb2a2502417c1bccc5fecec
2018-08-25 00:11:30 +02:00
jenkins-bot e7f462de32 Merge "WelcomeDialog: Check at least one editor is available" 2018-08-24 15:37:35 +00:00
Ed Sanders 23ec1973d8 Match width of template lookupMenu to input
Bug: T196117
Change-Id: I58909b2f0138b512df03a8990d3c19cb0b184cad
2018-08-24 14:22:00 +01:00
Translation updater bot 5c8ebdcd13 Localisation updates from https://translatewiki.net.
Change-Id: I355f188e103333fe8dc82a7023f92580ebddcbee
2018-08-23 23:26:31 +02:00
Ed Sanders 0f81aae133 Template dialog: Lazy resize multiline text inputs on first focus
Bug: T134814
Bug: T200834
Change-Id: I3ec84ad01db1ed896c41ac8ef38cce8eddb0b8c2
2018-08-23 17:34:25 +01:00
Ed Sanders 8f49bb391a WelcomeDialog: Check at least one editor is available
Bug: T201928
Change-Id: Ibac6cf921fdc3daba2d671d9bd668fa7bcb9e7a2
2018-08-23 14:21:40 +01:00
Ed Sanders 1d1d2c4e8e Update VE core submodule to master (aece1dbea)
New changes:
3ea0c7621 Fix calculation of scroll restoration in mobile window management
87ee219fa Update selectionBefore every time breakpoint is called
aece1dbea Localisation updates from https://translatewiki.net.

Bug: T191878
Bug: T202516
Change-Id: I0812ecaac059bf304ca7cf8b450635e3cbc45ff2
2018-08-23 11:51:19 +01:00
Translation updater bot f61f8070fa Localisation updates from https://translatewiki.net.
Change-Id: Ifc5dc55cabeb8c777e39a7af942c2964403e1458
2018-08-22 22:36:06 +02:00
James D. Forrester f4ad32173f Update VE core submodule to master (2f4c0537e)
New changes:
a80089a36 Add missing command help registration for HR tool
330311722 Define command group order separately
35ea5b8f0 build: Bump `grunt-css-url-embed` and `karma` to latest to avoid security issues
31b134668 Cursor into table captions if present, instead of the first cell

Bug: T201870
Change-Id: I4e3a946a992a07215a3af8351c3b54ceae664d40
2018-08-22 11:36:01 -07:00
David Lynch 26f6429702 TemplateStyles support
MWTransclusionNode will preserve TemplateData <style> in its generated content.

Disable TemplateStyles stylesheets in the original page content, and reenable
them when the surface deactivates.

Remaining TODO: if multiple copies of a template with deduplicated styles are
on the page, and the one containing the actual <style> is removed, all will
lose their styling.

Bug: T197563
Change-Id: Ibd8939eef7d8eb532719f4ee0ce200600449ef81
Depends-On: Ia9f2afcdba5456238e3ef444c202c9b0c78838bf
2018-08-22 17:03:27 +00:00
Ed Sanders 2ee76a4df4 Update VE core submodule to master (874470c1b)
New changes:
6911f2c33 GeneratedContentNode: make rendered element filtering overridable
874470c1b ve.ce.LinearSelection: Guard against node=null in getNodeClientRectFromRange

Bug: T197563
Bug: T202525
Change-Id: Ib1465a532bd0e5feaa3df61ea8ac61e7bf9872a8
2018-08-22 16:03:52 +01:00
Translation updater bot fad2cdf72b Localisation updates from https://translatewiki.net.
Change-Id: I98cced8346fec29a9a656500f4732939f94d547c
2018-08-21 23:39:03 +02:00
James D. Forrester 11b9816cd9 Update VE core submodule to master (a8116266a)
New changes:
7b257fd99 Show whitespace HTML chars in converter preview mode

Bug: T178780
Change-Id: Ia9152b2618a9699a933f0ccb64261f47f0b31f4d
2018-08-21 08:52:22 -07:00
jenkins-bot d6adfb7d1b Merge "Update VE core submodule to master (510506739)" 2018-08-20 22:55:58 +00:00
Bartosz Dziewoński 79cf74c3fd Update VE core submodule to master (510506739)
New changes:
e2c338cfa Bump dependency versions
b6077ef74 Author appearance tweaks
3f9480f9a Localisation updates from https://translatewiki.net.
bfce500be build: Temporarily disable qunit testing in Firefox due to CI issues
564e48ad0 Reactivate mobile surface in onModelSelect for native selections
510506739 Blur activateElement when deactivating the surface

Bug: T147304
Bug: T200347
Bug: T201329
Change-Id: Ifbaf21819b862f8dcaa557d0453086529b88aa04
2018-08-21 00:34:09 +02:00
Bartosz Dziewoński 1481f70b9e ve.ui.MWSettingsPage: Fix missing icon (renamed in OOUI)
Bug: T202101
Change-Id: I3ed199269e1f4452739628ae8d51a04fb911cc04
2018-08-21 00:26:01 +02:00
Translation updater bot ec6a0f45ed Localisation updates from https://translatewiki.net.
Change-Id: Ic5ad7edac4e32567ffbcf7e601c3f2906e5f8697
2018-08-20 22:21:15 +02:00
Translation updater bot 3b295f8791 Localisation updates from https://translatewiki.net.
Change-Id: I1099a37b8b5a5e92e6e01841aae32ada4acb5974
2018-08-19 22:39:14 +02:00
jenkins-bot 9498b6a72b Merge "Export to page using action=submit" 2018-08-19 12:02:48 +00:00
jenkins-bot 564909cbb5 Merge "Store more edit metadata after import" 2018-08-19 11:40:09 +00:00
Ed Sanders cb10316a7b Export to page using action=submit
Change-Id: I0d719905203d24a545d9b7dcea5bb9d032f10a76
2018-08-19 11:25:17 +00:00
Translation updater bot a00fb54fd0 Localisation updates from https://translatewiki.net.
Change-Id: I18771172e068481aeb8c0ece5ea9648d2ab44872
2018-08-18 22:16:53 +02:00
Bartosz Dziewoński f5ec61ef37 Update VE core submodule to master (a73097d43)
New changes:
f64698dbb Localisation updates from https://translatewiki.net.
13268e629 Reactivate surface on toolbar close
d55e19e90 Make invisible icon button unfocusable
31ca7c558 Follow-up Ib463485: Get rid of broken ve.ui.Surface#isMobile

Bug: T198912
Bug: T201329
Change-Id: I3603be4c3cd19fdf33060d815e90e73c18f380d0
2018-08-18 00:09:22 +02:00
Translation updater bot f1657c1a14 Localisation updates from https://translatewiki.net.
Change-Id: Ia3430c6f5dd7c9c7ad0e73292575856d368ff44b
2018-08-17 23:36:56 +02:00
Ed Sanders 85b33a9c5f Store more edit metadata after import
Change-Id: Ib6f1a77ef61982ea54de0bfc1ddf1dd78afd4a6f
2018-08-17 15:26:09 +01:00
jenkins-bot e6d89cd1ec Merge "Show signatures in NWE visual diff" 2018-08-17 13:29:41 +00:00
jenkins-bot 82396bef71 Merge "Update VE core submodule to master (aac36db2c)" 2018-08-17 10:15:31 +00:00
jenkins-bot 4d78073001 Merge "Replace 'settings' by renamed 'pageSettings' icon" 2018-08-17 00:28:05 +00:00
Volker E 07f58084cd Replace 'settings' by renamed 'pageSettings' icon
Bug: T190581
Change-Id: Ie0307ebc16d516463302773ef4226f2ba2dbd16c
2018-08-16 17:00:38 -07:00
James D. Forrester cf63f462c8 Update VE core submodule to master (aac36db2c)
New changes:
3a1d9b70a Update OOUI to v0.28.0
fcae61794 Fix icons broken by OOUI update
30df9c4e3 Deactivate the surface when the toolbar is active

Bug: T109529
Bug: T201329
Change-Id: Id2af11f4bca968eba964d8685baa3e2e15d208ca
2018-08-16 15:58:51 -07:00
Ed Sanders 20662e6dde Fix icons broken by OOUI update
Change-Id: I44edf30dc578787935c0052e8675bfde7fdd746d
2018-08-16 22:41:31 +01:00
Thalia 4a1d52ccb3 Show signatures in NWE visual diff
Parse document with pre-save transform for the diff.

Bug: T184166
Change-Id: Iffc9ed8ba88dcb55bef73f1708118663b0c38068
2018-08-16 21:45:28 +01:00
Translation updater bot 93aa72da9a Localisation updates from https://translatewiki.net.
Change-Id: Iff49d5230647266eb2e6289cab5db519229f146d
2018-08-16 22:28:58 +02:00
Translation updater bot a37e9abe53 Localisation updates from https://translatewiki.net.
Change-Id: I0ba9e84a8c841a29df9cccecf7c1195ccc2a5df5
2018-08-15 22:18:55 +02:00
jenkins-bot 0491369ff2 Merge "ApiVisualEditor: Use MediaWikiServices rather than $wgContLang" 2018-08-15 05:00:19 +00:00
James D. Forrester 5c9f4f9820 Update VE core submodule to master (e7fd43cfb)
New changes:
b1e14c16a build: Update eslint-config-wikimedia to 0.7.2 and simplify config
e7fd43cfb Move DOM selection from a block slug even if model selection is unchanged

Bug: T201599
Change-Id: I7e53da897f6cb4910a180ff86cae18982a9453e4
2018-08-14 14:08:08 -07:00
Translation updater bot d606e427c5 Localisation updates from https://translatewiki.net.
Change-Id: I017f26780081052542e376690e5f69cd9dd1c191
2018-08-14 22:35:42 +02:00
James D. Forrester 4755d7f1be build: Upgrade eslint-config-wikimedia to 0.7.2 and simplify config
Change-Id: Ib78c51a177b9f4b4764587232c7d32ffcfdd8aca
2018-08-14 11:02:20 -07:00
James D. Forrester 1f452626d6 ApiVisualEditor: Use MediaWikiServices rather than $wgContLang
Change-Id: Ie0a5deaa17db91f0866e35bd51e1e7067345d796
2018-08-14 17:10:40 +00:00
jenkins-bot 2270987788 Merge "ve.init.mw.MobileArticleTarget: Tweak toolbar items' height" 2018-08-14 17:03:48 +00:00
jenkins-bot ad675d06d7 Merge "Add Converter test cases for captions in images and gallery images" 2018-08-14 17:03:45 +00:00
jenkins-bot 2b43a24eea Merge "ve.init.mw.ArticleTarget: Skip prompt when switching to VE from NWE section editing if unchanged" 2018-08-14 16:09:49 +00:00
Bartosz Dziewoński 2512baa68e Add Converter test cases for captions in images and gallery images
Many of the details of the behavior don't really matter, but
I suppose it doesn't hurt to document them.

We really want to test two things:
* When converting from DOM to model data, a <mwImageCaption>
  or <mwGalleryImageCaption> is always generated, even if
  DOM has no caption.
* Model data that doesn't have <mwImageCaption> or
  <mwGalleryImageCaption> is nevertheless still valid and
  converting it to DOM doesn't fail.

Follow-up to Ie82fb339f6bd8ae1b289235bf5402490722d9a7c.

Change-Id: I0a10351e9c1589afbee76d8a85f869987de3de22
2018-08-14 11:02:09 +02:00
Bartosz Dziewoński 39208b7d40 Update VE core submodule to master (2859146e5)
New changes:
fa5d35054 Only re-use session token if docname matches
58d7cd280 Localisation updates from https://translatewiki.net.
d0716d8e7 Update files generated with new l10n language 'my'
2cc7a4423 Create unit tests for sequences
873fdd01e Upstream horizontalRule sequence and fix command

Local changes:
* Register unit test file for sequences
* Remove duplicate horizontal rule sequence

Change-Id: Ibc65cf5c086428bb0d13c8e2f2de5819e1e23d43
2018-08-14 09:20:07 +02:00
Bartosz Dziewoński 835b68db2a ve.init.mw.MobileArticleTarget: Tweak toolbar items' height
This padding needs to come out to an exact integer pixel value (14px),
otherwise things are off by less than a pixel and look ugly: F24664180

1em = 16px
0.875em = (14/16)em = 14px

Bug: T190596
Change-Id: Ieb292ed14e0b9205d15254667e97613fbf339260
2018-08-14 07:12:51 +02:00
Translation updater bot 3a4c923192 Localisation updates from https://translatewiki.net.
Change-Id: I8c21a5a4b67d181f5f951d1e4193be06415bbdf2
2018-08-13 22:15:11 +02:00
Translation updater bot 2e2f9d49f3 Localisation updates from https://translatewiki.net.
Change-Id: Ic0a2f3004e4562d28eb1f8109dda80819b457919
2018-08-12 22:18:07 +02:00
jenkins-bot f1fad0b8d7 Merge "Store importTitle in document, and display in sub heading" 2018-08-12 18:31:10 +00:00