Commit graph

11 commits

Author SHA1 Message Date
David Lynch 65b695ea2f Edit check: another counter for the save process
preSaveChecksShown + preSaveChecksNotShown = preSaveChecksAvailable
allowing us to use simple stat counters to detect errors in check
generation.

Follow-up to 57daf35bd6

Change-Id: I0586b766b5beec3bd059c90875ad0e2d1f092fab
2024-08-07 21:01:17 -05:00
David Lynch 57daf35bd6 Edit check: some simple counters for steps in the process
Change-Id: Iac0faea1f06eb30ac075a702cdcaaec29e0fbaf0
2024-08-01 11:21:46 -05:00
David Lynch 955bfc4b68 findAddedContentNeedingReference was removed accidentally
Replace it with a hasAddedContentNeedingReference that'll need to be
kept in-sync with the internal logic in AddReferenceEditCheck while
we're tagging this.

Follow-up to d69d366469.

Bug: T367920
Change-Id: I9f4f96bf5c6c4b7b3131b1435426b2e283c9833a
2024-06-18 16:12:30 -05:00
David Lynch d69d366469 Edit check API
Change-Id: Ic5504eb2fe8d1d3f22e88abe1dd88790bdfd8b9c
2024-06-12 11:01:04 +01:00
David Lynch d0a57f5197 Add code to support showing multiple checks in pre-save workflow
Leave the feature disabled for now.

Change-Id: Id70762a887c57d9255df22d50bf7badad89040de
2024-06-12 11:01:04 +01:00
Ed Sanders dbc696124f ESLint: Enforce no-var and autofix
Temporarily disable prefer-const as this requires
manual fixing.

Change-Id: I477b69a57e8d33535c6fc71dba196a8605780725
2024-05-21 17:40:52 +01:00
Ed Sanders e3659d4846 Prefer arrow callbacks
Change-Id: Ia05b27f7c71c33580ffd0718e3bbc673dd8b3d63
2024-05-01 14:11:54 +01:00
David Lynch 9c7f772d4f Only activate edit check in visual mode
Change-Id: I9b2dac998cd33a855f56e91c77332ef6ae156f7d
2024-02-15 12:20:03 -06:00
David Lynch 5d6463ebba Edit check config for whether to ignore references in certain sections
Adds two new configs:
* ignoreSections, array of section names that'll be compared
* ignoreLeadSection, bool for whether to ignore the lead section

Bug: T346949
Depends-On: I7ded925b91b1d86b3c76c4135c85a3f0be1dee5e
Change-Id: I44f18fadcafbe011008d8abff566e2ccd7682f4f
2023-12-05 15:47:17 +00:00
David Lynch 094c007df0 Allow a global variable to forcible enable edit check
The URL parameter turns out to be a bit painful for people to use in
some situations.

Bug: T350749
Change-Id: I7c88dc604dd321a7c78810b21f7ad8306ff9dab6
2023-11-30 10:27:50 +00:00
Ed Sanders 876a947a7b Move EditCheck files to ./editcheck and structure as a sub-extension
Change-Id: I4085223a93b37e601b3627fc2d6db7978cac820e
2023-11-28 15:56:43 +00:00
Renamed from modules/editcheck/init.js (Browse further)