Commit graph

17519 commits

Author SHA1 Message Date
Bartosz Dziewoński b91c8647fe Ignore user prefs for enabling/disabling VE which are not settable
We have two preferences used for enabling/disabling VE:
'visualeditor-enable' and 'visualeditor-betatempdisable'.
(And 'visualeditor-autodisable', which sometimes overrides
them both, but it's not relevant here.)

The user can only set 'visualeditor-enable' when VE is Beta Feature,
and they can only set 'visualeditor-betatempdisable' when it is not.

However, when deciding if VE should be loaded, we always checked both
of the preferences. This gives incorrect results when the preference
that is not supposed to be settable actually exists, due to being set
in GlobalPreferences on another wiki where it's settable.

A similar issue could occur if VE configuration is changed from Beta
Feature to a normal preference (or the other way around), and the
preference values for the previous configuration still persist.

Bug: T271434
Change-Id: I7399b3c516f762429050a662ac85d1d392392323
2021-02-05 12:40:51 +00:00
Bartosz Dziewoński 4b1f141511 Do not define contradictory user preferences for enabling/disabling VE
Depending on the config, we would sometimes define both the
'visualeditor-enable' and the 'visualeditor-betatempdisable'
preferences, even though they contradict each other.

Bug: T273188
Change-Id: I6ac7e4580bf232a5198ad8842f814bc381131e00
2021-02-05 12:40:38 +00:00
Bartosz Dziewoński b1fa5839c4 Remove two unused configuration options
* VisualEditorNewAccountEnableProportion
* VisualEditorAutoAccountEnable

Seemingly never used on Wikimedia wikis, and untested since 2016.

Bug: T273177
Change-Id: Ic132ef2091399fd223626ae307830f278e72ec01
2021-02-05 12:40:28 +00:00
Translation updater bot d8ee3f7c2f Localisation updates from https://translatewiki.net.
Change-Id: Ie991bfb16232022586368e2a9299a7bc07abb740
2021-02-05 08:47:56 +01:00
jenkins-bot 2d6214b186 Merge "Rename magic header to be consistent with WMF CDN infrastructure" 2021-02-04 23:38:23 +00:00
Bartosz Dziewoński fd3ea87352 Fix Parsoid HTML of broken images
Parsoid doesn't like it when we send it an <img> tag for a missing image.

Bug: T266588
Change-Id: Ie42d667301b22942ac5bddd4c11db17c60a0fb5e
2021-02-04 20:39:05 +01:00
C. Scott Ananian fce9192e82 Rename magic header to be consistent with WMF CDN infrastructure
This name is consistent with T91820.

Bug: T91820
Bug: T259685
Depends-On: I0c4ec63bb26641b237c92dbd3bc5367811ca0675
Followup-to: 3561167493
Change-Id: I4c4c5f83ad56a198d08095d629a6ba86ce9dc1a4
2021-02-04 12:54:21 -05:00
jenkins-bot f284c350bd Merge "Fix sqlite compatibility by opting out of obligatory write lock" 2021-02-03 21:38:46 +00:00
Translation updater bot b944c321ab Localisation updates from https://translatewiki.net.
Change-Id: If06ab07f562192a8ce0dedeab5515d5e828c4bcb
2021-02-03 08:40:09 +01:00
C. Scott Ananian 3561167493 Fix sqlite compatibility by opting out of obligatory write lock
Bug: T259685
Depends-On: If37dc890a24a45c3a914e310b5b5bf625965e9e6
Change-Id: Ib203145f4c9ddfdc6701a916cbbbe17dae85efb9
2021-02-02 18:05:21 -05:00
Adam Wight d5ba11d3b2 Track whether an event was oversampled
This is needed to reconstruct population estimates from a sample.

Depends-On: Ie5cf24e84a2ed041bf7c4f0b891387c45667467b
Bug: T273454
Change-Id: I3a40e74f8ccb80aa6ed7d3313a5394aa31baf572
2021-02-02 13:02:01 +01:00
Translation updater bot 3107705c39 Localisation updates from https://translatewiki.net.
Change-Id: I3ee469f220d9381905a10cd268aefcef98c5c715
2021-02-02 08:40:10 +01:00
jenkins-bot 54f61eb54c Merge "Update save failure logging for EditAttemptStep schema, simplify code" 2021-02-01 18:28:10 +00:00
jenkins-bot f9aa74563a Merge "Logging init mechanism consistency" 2021-02-01 17:08:48 +00:00
jenkins-bot de4c11270c Merge "Log the DiscussionTools a/b test bucket for relevant schemas" 2021-02-01 17:08:43 +00:00
jenkins-bot b6033895f5 Merge "Add edit count bucket to VisualEditorTemplateDialogUse events" 2021-02-01 10:22:38 +00:00
Translation updater bot 796ff55473 Localisation updates from https://translatewiki.net.
Change-Id: Ibf083734bfd963bf01249997e7ce12b5f4c40fd1
2021-02-01 08:49:13 +01:00
David Lynch 2ee500ed70 Logging init mechanism consistency
Support the `url-new` mechanism so we can distinguish between
new/existing sections in direct navigation.

Also, mechanism will now correctly be `new` when clicking the "create"
tab on a previously empty page.

Bug: T272544
Change-Id: I667a1c45c3948ec6dfed8f348a1327bffaba58a5
Depends-On: I3cee7a3a4c4b646692dce4a1180c4ba18a61f4bc
2021-01-29 20:28:11 -06:00
David Lynch 284d43de93 Log the DiscussionTools a/b test bucket for relevant schemas
If someone is enrolled the DT a/b test, we want to know about their
editing here as well.

Bug: T273096
Change-Id: I235f4ccbcbfbf95c6aa0df327a9a5a7d5ddb1038
2021-01-29 20:28:11 -06:00
Bartosz Dziewoński 185db3a157 Remove tabindex="-1" from "Add more information" button in template dialog
This makes it button keyboard-accessible, like the other buttons.

Bug: T179136
Change-Id: Ib2824176fe861e0ad8511f755521bee941119b29
2021-01-29 21:06:12 +01:00
Translation updater bot 7fd9a6e9b0 Localisation updates from https://translatewiki.net.
Change-Id: I41eb682a5fb5e59f1c14f785412f64683abeaaef
2021-01-29 08:39:06 +01:00
libraryupgrader 56724d13db build: Updating dependencies
composer:
* mediawiki/mediawiki-codesniffer: 34.0.0 → 35.0.0
* mediawiki/minus-x: 1.1.0 → 1.1.1

npm:
* eslint-config-wikimedia: 0.18.0 → 0.18.1

Additional changes:
* Added the "composer phan" command to conveniently run phan.

Change-Id: I2f9210c6a02e34a59c8ebc9284e0711612c4098e
2021-01-28 21:37:51 +00:00
jenkins-bot 096f2ba8ba Merge "Implement mwPlatform#decodeEntities" 2021-01-28 20:57:40 +00:00
jenkins-bot 750d08c642 Merge "Update VE core submodule to master (fe9082b21)" 2021-01-28 20:51:25 +00:00
jenkins-bot 30cc9f43cd Merge "SpecialCharacter: Small refactor of list building" 2021-01-28 20:11:20 +00:00
Ed Sanders cab608057d Implement mwPlatform#decodeEntities
Logically depends on I3c1e3aa3cee but can be merged before it.

Bug: T70429
Change-Id: I4ded7f1563b9de4cc81e05d890a24392f88de4f2
2021-01-28 19:57:58 +00:00
James D. Forrester d4044d6161 Update VE core submodule to master (fe9082b21)
New changes:
0b5cf3e43 Fix typo in comment
6f79dab51 Localisation updates from https://translatewiki.net.
c24bc7824 Update OOUI to v0.41.1
613f3c405 Move entity decoding into a utility function
4161f4338 Allow HTML entities in the special character list

Bug: T70429
Change-Id: I15eca7813598b76ebb5e7cb07fed6d377bde0fc2
2021-01-28 11:55:29 -08:00
jenkins-bot b193cd95a5 Merge "Show non-breaking spaces in the editor" 2021-01-28 19:38:28 +00:00
Ed Sanders 0edaf11ef4 SpecialCharacter: Small refactor of list building
Change-Id: I720cccbaa1d27771336a9969c4b6c776a696cde9
2021-01-28 19:14:07 +00:00
Bartosz Dziewoński d65fe812f5 Show non-breaking spaces in the editor
MWEntityNode representing &nbsp; is now displayed with a light
grey background and has a tooltip explaining that this is a
non-breaking space and not a random grey blotch.

This is not done for TextNode (in core VisualEditor), as that doesn't
actually work: Parsoid converts all &nbsp; in input to regular spaces.

It's still not easily possible to insert a non-breaking space.

Bug: T96666
Change-Id: Icbdf7cc3e5d675b199d08777a3439dc5dedceac1
2021-01-28 19:09:29 +00:00
Translation updater bot 923f1e8e6d Localisation updates from https://translatewiki.net.
Change-Id: I337559487f8312db4b6f45596eb7c623b1de26a0
2021-01-28 08:37:35 +01:00
jenkins-bot 4b969eec8f Merge "Adjust CE markup of broken images so that Parsoid styles apply to them" 2021-01-27 19:16:13 +00:00
jenkins-bot 6a8350b92b Merge "ve.dm.MWTemplateModel: Don't add spurious empty parameters" 2021-01-27 16:31:10 +00:00
Bartosz Dziewoński 91291d3e98 Parse relative hrefs on image nodes like on regular links (try 2)
Previous, reverted attempt: da9b6fffbd.
This attempt also includes 6037fefbe0,
and fixes minor conflicts with other changes.

* In normal images, parse relative 'href' attributes instead of
  expanding them to absolute. This resolves Parsoid generating
  |link= options for copy-pasted images (T193253).

  Keep them in the underscore-form to avoid causing dirty diffs like
  T237040 again. Unlike in the previous attempt, we don't need to be
  super-careful about the 'resource' attribute, thanks to the Parsoid
  changes in T108504.

* In gallery images stuff, prefix the 'resource' attribute with './',
  same as normal images do. This causes no functional changes, but it
  makes updating tests easier, and the consistency is probably good.

* Update test examples to also prefix 'resource' and relative 'href'
  attributes with './', like the real Parsoid does.

Bug: T193253
Change-Id: I91131728a87c9406bf069d46d3c94c9a8905a003
2021-01-27 11:53:15 +00:00
Bartosz Dziewoński 0e9dd1751d Adjust CE markup of broken images so that Parsoid styles apply to them
Depends-On: I11fc7fc955656eee2a78461b509c3fee555e8613
Change-Id: Ieb958b372212423427ac0a36cd5ec374c927d232
2021-01-27 10:12:52 +01:00
Translation updater bot 9667c20298 Localisation updates from https://translatewiki.net.
Change-Id: I74654eac3db1d6a1be934832371d8fd666b72d32
2021-01-27 08:35:53 +01:00
jenkins-bot 9149272d7c Merge "Update VE core submodule to master (65f1aed5b)" 2021-01-26 15:59:29 +00:00
jenkins-bot 1cbe8e5313 Merge "Compute entire old DM doc for section diffs" 2021-01-26 15:37:13 +00:00
James D. Forrester bcc40e7058 Update VE core submodule to master (65f1aed5b)
New changes:
06a44681a Fix referencesListDiff variable names
eb70fd2df Localisation updates from https://translatewiki.net.
7ea4efb7c build: Upgrade eslint-config-wikimedia from 0.17.0 to 0.18.0 and make pass
becd23d48 Show ref list diffs which aren't found in the document

Bug: T272813
Change-Id: I5378230b3a86a91e67a2cfcba9e6f8ce1798c3ab
2021-01-26 16:27:10 +01:00
Translation updater bot 997c32f768 Localisation updates from https://translatewiki.net.
Change-Id: I3f0eead170e4803db1e0c966c7200d7e8abb571e
2021-01-26 08:54:18 +01:00
James D. Forrester cb9a31adac build: Upgrade eslint-config-wikimedia from 0.17.0 to 0.18.0 and make pass
Change-Id: I8c45850965ed5b96a0980de70a25f6d5b355350d
2021-01-25 10:21:32 -08:00
Translation updater bot 397c172f4a Localisation updates from https://translatewiki.net.
Change-Id: I035835b7e08feaa5c18f3b7a5b9f3f243544cf19
2021-01-25 08:55:18 +01:00
Ed Sanders 865a59d640 Compute entire old DM doc for section diffs
We need the whole DM doc to show reference diffs
correctly. We can filter down to the active section
after the conversion like we do with the editor.

Bug: T272813
Change-Id: I2081dd520ff414caadaed2efda955d600953c957
2021-01-24 23:12:26 +00:00
Ed Sanders f8c403dffb Update VE core submodule to master (a8919f78e)
New changes:
c17816c5f Diff sidebar: Make font size slightly smaller
f8439f4cc Deep-freeze linear data
a8919f78e Deep-freeze linear data added by transactions

Local changes:
Fixes for deep-frozen linear model

Bug: T119236
Change-Id: Iae4362c8dab0f2bd335e24498f3e0522b8b1d4fc
2021-01-23 19:55:14 +00:00
jenkins-bot b11f6997df Merge "Update VE core submodule to master (ca6a97f42)" 2021-01-22 20:08:08 +00:00
jenkins-bot 5dbc152990 Merge "MWExternalLinkAnnotation: Call core method to evaluate diff" 2021-01-22 19:51:32 +00:00
Ed Sanders d831370ed4 Update VE core submodule to master (ca6a97f42)
New changes:
4589f5f00 Clear node offset cache when leaving read-only mode
68b0f8372 Show attribute changes as diffs when appropriate

Local changes:
Pull through for Ic6ec7f5ebabc912235ff7e688425f415f2c3ff20

Bug: T272603
Change-Id: I574fc56799ed165e63e16881429c4ed740850234
2021-01-22 20:40:28 +01:00
Ed Sanders 5a51096e5e MWExternalLinkAnnotation: Call core method to evaluate diff
For this key ('href') the core method is identical.

Change-Id: Ibec341c8a5a685f13e690be4107e3066fc7d7040
2021-01-22 17:33:24 +00:00
Translation updater bot c2256cf754 Localisation updates from https://translatewiki.net.
Change-Id: I64cbb3bbebf5474e5e1f80da932bb8e44fbfeccf
2021-01-22 08:31:47 +01:00
James D. Forrester 90b3b18480 Update VE core submodule to master (98c07ef95)
New changes:
376686e36 Follow-up I1361852: Only cache node offset in readOnly mode
007c25aa9 Add test for node offset caching in readOnly mode
6df84533e Diff sidebar: Fix vertical alignment of move arrow

Bug: T244114
Bug: T272612
Change-Id: I5bcc697677b6b2bb2e3d1b02d8931516aa853374
2021-01-21 09:24:33 -08:00