Commit graph

11924 commits

Author SHA1 Message Date
Alex Monk e639525a9c Follow-up I9202066d: array_unique leaves gaps in keys, we need to run array_values on it afterwards
While that commit fixed the issue it was intended to address, it also
completely broke VE everywhere else. Basically you'd end up with a result
like this:

array(5) {
  [0]=>
  int(14)
  [1]=>
  int(6)
  [2]=>
  int(2)
  [5]=>
  int(0)
  [6]=>
  int(250)
}

With the lack of 3 and 4 keys making the JSON formatter think we've got an
object.

Bug: T139094
Change-Id: Ia21fd4bd352afc9170357576a3e0eb17b4528326
2016-06-30 20:35:45 +01:00
Ed Sanders 40d606abdc Test removing all table classes
Bug: T138896
Depends-On: I2698428f0aa69e2dcec2680efed44d064bf6e542
Change-Id: I5df5d51fc5b69df6eae40ac29f6b82f446b26ae8
2016-06-30 17:41:42 +01:00
James D. Forrester 52c2ac9582 Update VE core submodule to master (513f0bd)
New changes:
513f0bd Don't restore class attribute on class attribute nodes

Change-Id: Ic818bb997e9b50277d9d14e58908f0989e918495
2016-06-30 17:41:06 +01:00
jenkins-bot a95ffcdc42 Merge "Fix preference namespace list to handle duplicates" 2016-06-30 16:29:48 +00:00
James D. Forrester d9d6a567d8 Follow-up e2f6d798: Make MWTemplateModel#addPromptedParameters work
Change-Id: I27e82aed207e1352ccb5f5a177fd53d5c1868c42
2016-06-30 16:46:38 +01:00
Ed Sanders 3a4ff4eb5f Make edit tab dialog wider to accommodate long messages
Bug: T138731
Change-Id: I96d0a9e5efbe0b462fc4e13a4fa6008987d749cf
2016-06-30 13:43:58 +01:00
Alex Monk 16c38ec27a DAT.init#setEditorPreference: Change section edit alongside tab labels
When our remember-last preference changes work, alongside changing the
label of the edit tab, also change the label of the edit section links.

I seriously have no idea WTF I was thinking back in December when I
put some of this code into #activatePageTarget.

Bug: T137424
Change-Id: I581c0acf0a3ad11ad3bcf4e2e46242907ca9166f
2016-06-30 10:22:44 +00:00
jenkins-bot fc8d1b9d25 Merge "screenshots: Restore save button to more settings task" 2016-06-29 22:51:24 +00:00
jenkins-bot c430cbd9bc Merge "screenshots: Add task for plain insert menu" 2016-06-29 22:51:21 +00:00
jenkins-bot 750078ab63 Merge "MWTemplateDialog: When opening the dialog, add in any unset suggested and required parameters" 2016-06-29 22:42:25 +00:00
Alex Monk ea1a621c47 Fix preference namespace list to handle duplicates
Change-Id: I9202066d23eca527571ac817cf3ae64bc2d57bea
2016-06-29 23:24:34 +01:00
Ed Sanders 0246f77cb6 screenshots: Restore save button to more settings task
Change-Id: I847cf81f3092be50f0fcf019eea3226decedd445
2016-06-29 23:02:43 +01:00
David Lynch 3c5695e87d Don't use array_merge for namespace configs
array_merge renumbers numeric keys. The namespace configs can be either
numeric or names. If they're numeric, they shouldn't be renumbered. So just
add them.

Bug: T138980
Change-Id: I3e3ecb3e9e65443ba0d44f8eeb67d6b390eca0bd
2016-06-29 16:13:21 -05:00
Alex Monk bf0953b07b Remove consideration of extension registry configured namespaces until we can find the correct way to merge them
This will disable ProofreadPage's addition of the Page namespaces (e.g. on
wikisources), but this is more important right now.

Bug: T138980
Change-Id: I23ee26fa95a01b3e0881a4ca16e70247839d9cd9
2016-06-29 21:48:33 +01:00
Ed Sanders 2780c86bff screenshots: Add task for plain insert menu
Change-Id: Id77df7ff88e030b283b1f94ff85537bfd4f20345
2016-06-29 20:39:42 +01:00
James D. Forrester e1b2734ce0 Update VE core submodule to master (3ea50c4)
New changes:
67c1d75 DesktopContext: Positioning a maybe-floated not-embeddable popup
d5b6725 Localisation updates from https://translatewiki.net.
3ea50c4 Update OOjs UI to v0.17.5

Change-Id: I84ebf1947778446c573b0791c915e99fde1487a1
2016-06-29 18:02:27 +01:00
jenkins-bot 026848c369 Merge "Fix display of subpage breadcrumbs show after save" 2016-06-29 16:41:05 +00:00
jenkins-bot 85f6d7867d Merge "screenshots: Add category and page settings menu item tasks" 2016-06-29 16:20:17 +00:00
jenkins-bot dc59190e64 Merge "Set an automatic summary of empty string when switching from VE into WTE" 2016-06-29 16:16:57 +00:00
jenkins-bot 472e960c90 Merge "Tell the client whether we created a redirect or not properly." 2016-06-29 16:16:54 +00:00
jenkins-bot 0d45972cb3 Merge "Fix our display of redirects during and after editing" 2016-06-29 16:15:43 +00:00
jenkins-bot 913d3c0cf4 Merge "New decodeURIComponentIntoArticleTitle method" 2016-06-29 16:15:41 +00:00
Ed Sanders fcc343eb20 screenshots: Add category and page settings menu item tasks
Change-Id: Iacf52612eedc74b050a78f1ddb23e7a443afebe2
2016-06-29 16:02:32 +01:00
James D. Forrester 5ef5d4d24c screenshots: Run on enwiki rather than Beta Cluster for content
Change-Id: Ia06c2a39905d0a899f7ff45f1beec4e0e4236fee
2016-06-29 14:30:15 +00:00
jenkins-bot 7ac5943daa Merge "screenshots: De-duplicate menu screenshotting code" 2016-06-29 14:23:31 +00:00
jenkins-bot 3e8d3ce9b1 Merge "screenshots: Correct name of a list menu screenshot" 2016-06-29 14:19:25 +00:00
James D. Forrester 65d24b0dea screenshots: Correct name of a list menu screenshot
Change-Id: I3d0921e82b7c9608ab0cca15ffdbcb2d98f56cf5
2016-06-29 15:12:39 +01:00
Ed Sanders 0b89467ab9 screenshots: De-duplicate menu screenshotting code
Change-Id: I88ace5b2b6ab3b629ddf217f314e1a33c2e33287
2016-06-29 15:10:58 +01:00
jenkins-bot e93f06fe00 Merge "screenshots: Add screenshots for highlighted items in the insert menu" 2016-06-29 13:46:27 +00:00
Ed Sanders 8cc9a81857 screenshots: Add screenshots for highlighted items in the insert menu
Change-Id: I4232a0709ea241ad173543fdf4eab0b4c3ce02a2
2016-06-29 14:32:31 +01:00
jenkins-bot fa8bad0836 Merge "screenshots: Add delay to wait for link inspector images to load" 2016-06-29 13:01:44 +00:00
jenkins-bot 161b7a7bc7 Merge "screenshots: References list dialog" 2016-06-29 13:00:28 +00:00
Ed Sanders 5c1a2607d9 screenshots: Add delay to wait for link inspector images to load
Change-Id: I36168f08cc2a8ec320afc8c87ae6518d50db2c57
2016-06-29 13:44:25 +01:00
jenkins-bot 11b6611095 Merge "screenshots: Add task for link inspector search results" 2016-06-29 12:40:18 +00:00
jenkins-bot a464120331 Merge "screenshots: Crop to viewport" 2016-06-29 12:39:54 +00:00
Ed Sanders 4fef9d141c screenshots: References list dialog
Change-Id: I5a14412198cdc3cf48cd574195716fe0070f0158
2016-06-29 13:36:00 +01:00
jenkins-bot 81f9eb7c2f Merge "When logging in, if VEE cookie is set, change the user's preference to match it" 2016-06-29 12:20:12 +00:00
jenkins-bot f0a529085d Merge "Replace section edit click handlers in DAT instead of doing it badly in init" 2016-06-29 12:18:49 +00:00
jenkins-bot 5f59caf036 Merge "Execute the EditFormPreloadText hook on load for non-existent pages" 2016-06-29 09:59:32 +00:00
jenkins-bot ae8758e895 Merge "screenshots: Add task for cite button" 2016-06-29 09:59:29 +00:00
Alex Monk 984823a77d Replace section edit click handlers in DAT instead of doing it badly in init
If you deactivate without saving (e.g. using the back button), the page
contents aren't replaced and so adding the page click handlers is pointless
and harmful because they will run twice.

This was my fault in Iad1713e1

Bug: T135387
Change-Id: I3c83009bfc0f42125cdcde7f7a51de9bc2f72abf
2016-06-29 03:58:57 +01:00
Ed Sanders d29f874983 screenshots: Add task for link inspector search results
Change-Id: I0cbe71a21e85eeaf4edaf49c8499c6f87a36c1fd
2016-06-28 22:43:01 +01:00
Ed Sanders 7278771254 screenshots: Crop to viewport
Change-Id: I2a50e4b090cdd9a6d60c85fad438cee3cc7e0b1f
2016-06-28 22:43:01 +01:00
jenkins-bot 324ae24f98 Merge "Ensure text version of counter is written to external links when copying" 2016-06-28 16:23:50 +00:00
jenkins-bot bcd2dad806 Merge "screenshots: Add task for Math dialog" 2016-06-28 15:45:15 +00:00
jenkins-bot 30673ba468 Merge "screenshots: Groups some tasks into sessions to improve performance" 2016-06-28 15:45:12 +00:00
jenkins-bot 24deea5a5c Merge "screenshots: Add multi-language support" 2016-06-28 15:45:09 +00:00
jenkins-bot 12b1b3a2b3 Merge "Add screenshots grunt task for taking documentation screenshots" 2016-06-28 15:44:54 +00:00
jenkins-bot eccf56685c Merge "Update VE core submodule to master (be57e9c)" 2016-06-28 13:44:35 +00:00
Ed Sanders 37c45b83b8 screenshots: Add task for cite button
Change-Id: Ibb5677835df4ca157c53ce9d1990197b4cd30c28
2016-06-28 12:12:02 +01:00