Commit graph

21390 commits

Author SHA1 Message Date
Ed Sanders b9b966de6e Avoid Array.concat
See I9addf43b2857de7bcac.

Change-Id: Ic1998ab6f7dedf6946d7ae63a985a76031f8eecf
2024-05-29 21:16:25 +01:00
jenkins-bot 66c6fa294c Merge "Change confirmation behaviour when abandoning template edits" 2024-05-29 16:58:43 +00:00
Translation updater bot e089bb4911 Localisation updates from https://translatewiki.net.
Change-Id: Ib7d2781895091d4c2323ff4e790e0d686552e974
2024-05-29 09:32:42 +02:00
jenkins-bot 28fae02c8b Merge "Tests: Use spread syntax on string literals" 2024-05-28 19:39:59 +00:00
jenkins-bot 8990a273e7 Merge "Update VE core submodule to master (e3298c4a5)" 2024-05-28 19:37:16 +00:00
jenkins-bot 48823cad4b Merge "JSDoc: convert @cfg to @param" 2024-05-28 15:13:20 +00:00
jenkins-bot f41d5740c1 Merge "Consolidate minor code duplications in DiffPage" 2024-05-28 15:12:39 +00:00
jenkins-bot c3204463de Merge "Remove redundant elements from Unicode-enabled regex" 2024-05-28 15:11:37 +00:00
Zoë 3c6f0a918c Change confirmation behaviour when abandoning template edits
Previously, it was possible to close a dialog with active edits by
pressing the "<" button or pressing escape. A change was made to confirm
the user's intent before abandoning their changes, see Ia8935b5b1acb

This patch fixes a bug where the user's intent is always confirmed while
editing a template, even if the user has made no changes. This was
because for technical reasons we trimmed whitespace before making a
comparison with the new template case, but that caused the comparison
with the edit case to always fail because existing templates are padded
with whitespace.

This could have been solved by moving the trim operation into the new
template flow. This patch would still have been necessary to prevent
a bug if the default value had trimmable whitespace. I have opted to
keep the whitespace behaviour for edits for consistency.

Bug: T334513
Change-Id: I7b3370c86df67c36fc63a1f1d0e7004a098a1950
2024-05-28 15:49:19 +01:00
Translation updater bot 5d42b0dc4e Localisation updates from https://translatewiki.net.
Change-Id: Ibce2d79bec7f603d0eaf15bb24ea60eab95b9567
2024-05-28 09:31:37 +02:00
Translation updater bot adaf850420 Localisation updates from https://translatewiki.net.
Change-Id: I7a7a57812ac174ae50f16531fffaf8ed17e72019
2024-05-27 09:30:17 +02:00
Novem Linguae 9ffbfc77cd JSDoc: convert @cfg to @param
Bug: T250843
Change-Id: I53ef4fa4a65b017eec90cc1f2cbb7e7f0681e317
2024-05-26 21:59:02 -07:00
Ed Sanders 155549ab60 Tests: Use spread syntax on string literals
Because `...'Foo'` is more legible than `'F', 'o', 'o'`.

Change-Id: I09ac584ee79b8f89c48f135182e60d7fb1b54557
2024-05-24 22:23:42 +01:00
Bartosz Dziewoński b498d2bfd3 Update VE core submodule to master (e3298c4a5)
New changes:
7ff4a9eac Use arrow functions in tests
2d0800ea6 Tests: Use variadic args
f399101cf ve.ce.TestRunner: Fix return type documentation
e29d42433 Allow ES2018 syntax in tests
f675c0ad7 Test: Use (assert,caseItem) signature for test runners
adc47cb9b Localisation updates from https://translatewiki.net.
88abebb2b Update OOUI to v0.49.2
b4c8921aa build: Updating grunt-banana-checker to 0.13.0
7c31e4f25 Run TableAction/ListAction tests with a full view
24340c13b Localisation updates from https://translatewiki.net.
8ae691114 ESLint: Autofix no-var violations
043558ab3 ESLint: Manually fix remaining no-var errors
5f88cf5eb Move let/const declarations closer to usage
06b7b0da8 ESLint: Enforce prefer-const
4c654dca5 Prefer arrow callbacks in build, collab, demos & rebaser
e3298c4a5 Remove unnecessary context variables

Bug: T365052
Change-Id: I9e8e6287ca077e21f74bd4fbd8d9c0993cceb653
2024-05-24 22:05:05 +02:00
thiemowmde 3a7d345093 Remove redundant elements from Unicode-enabled regex
Same as in If6c7e85 in the TemplateWizard codebase. [a-z] is already
part of \p{L}, and [0-9] is part of \p{N}.

Change-Id: I8008ac7e504739b8f4b5fb5dd732b0deca20cefc
2024-05-24 15:47:02 +02:00
thiemowmde e867a49a69 Consolidate minor code duplications in DiffPage
Change-Id: I4969616c75cf201dde1094715ccbb796a92c1d92
2024-05-24 15:45:20 +02:00
thiemowmde c3953814e4 Fix typos and outdated links in comments
That property in the magic word class doesn't exist any more.

Change-Id: Ife275944bd1c8dec603bd01dea6075ad36acf59e
2024-05-24 15:40:01 +02:00
Translation updater bot a8d1907e69 Localisation updates from https://translatewiki.net.
Change-Id: I4413677d60eb0325c1d916a6be452d04b4ceb157
2024-05-24 09:44:34 +02:00
jenkins-bot c1b3daddb1 Merge "ESLint: Re-enable prefer-const and fix" 2024-05-23 16:17:38 +00:00
jenkins-bot c003151db5 Merge "ESLint: Enforce no-var and autofix" 2024-05-23 16:17:37 +00:00
Translation updater bot a25440e146 Localisation updates from https://translatewiki.net.
Change-Id: Id8377c8b8f8c0d34c4dc16579dc727965c06702d
2024-05-23 09:28:51 +02:00
Ed Sanders cb657e0bdf ESLint: Re-enable prefer-const and fix
Change-Id: I9dbc12335016a326f00bf5b9a960551f828c685d
2024-05-21 17:50:12 +01:00
Ed Sanders dbc696124f ESLint: Enforce no-var and autofix
Temporarily disable prefer-const as this requires
manual fixing.

Change-Id: I477b69a57e8d33535c6fc71dba196a8605780725
2024-05-21 17:40:52 +01:00
Translation updater bot 1be5baf2ee Localisation updates from https://translatewiki.net.
Change-Id: I5f14905d40a0878e01b30bf2581cdc8681b6267c
2024-05-21 09:29:07 +02:00
Translation updater bot b3b30bb4a5 Localisation updates from https://translatewiki.net.
Change-Id: I464cad219aa2f71ec6b2688a2cc2a91ea950c90f
2024-05-20 09:26:33 +02:00
C. Scott Ananian b91c47b1c0 Remove unused reference to ParsoidOutputAccess
Change-Id: I543a6e9da4fc473a2ac54ac635286453f2aff96a
2024-05-17 12:44:36 -04:00
Ed Sanders 064a30b911 MWExtensionDialog: Fix documentation of confirmAbandon
Change-Id: I30b13f524d97e098d7ce0ae374e452871e500770
2024-05-17 15:53:26 +01:00
Translation updater bot 2aa6decc27 Localisation updates from https://translatewiki.net.
Change-Id: Icdf52e217e6a2cf23a746ff36c8e78d06c08a723
2024-05-17 09:50:05 +02:00
libraryupgrader fd1344b319 build: Updating grunt-banana-checker to 0.13.0
Change-Id: Ie76534426f8a03dc2bcf8d602ccb5131589e88bc
2024-05-17 03:15:17 +00:00
jenkins-bot aeb32aa223 Merge "Update VE core submodule to master (27296e0e3)" 2024-05-16 19:17:18 +00:00
Ed Sanders d5f9b15e39 Update VE core submodule to master (27296e0e3)
New changes:
8a1eda8af build: Updating jsdoc-wmf-theme to 1.0.1
7e2e7ebaa JSDoc: Fix generated documentation of Storage objects
2a0229ea1 JSDoc: Fix more warnings
227a38f79 JSDoc: Use upstream version of externals plugin
e1b2cbc3b Localisation updates from https://translatewiki.net.
a588efb7c Convert inline functions to arrow functions so context variables can be removed
2a12cfd15 Localisation updates from https://translatewiki.net.
27296e0e3 Disable MutationObserver in ve.ce.Surface

Deleted files:
- build/jsdoc-externals.js

Bug: T230323
Bug: T365052
Change-Id: Ia9710a52cf407c1b1cc11216ed9e54cf89e3478d
2024-05-16 18:34:25 +01:00
jenkins-bot cec87f4ba1 Merge "Use codex tokens for .mw-editsection-bracket" 2024-05-16 15:54:15 +00:00
jenkins-bot 22e6758092 Merge "tests: Adopt QUnit.test.each() and native async-await in a few places" 2024-05-16 11:32:29 +00:00
Translation updater bot bf5921ffc1 Localisation updates from https://translatewiki.net.
Change-Id: Iea5af57ebfab0425d87d4ded9d1f98a591dc809d
2024-05-16 09:27:46 +02:00
Sohom 22d25a48d2 Use codex tokens for .mw-editsection-bracket
Bug: T365089
Change-Id: I21ab4016dd38811501684867a41c3de3b9a342df
2024-05-16 00:54:42 -04:00
Novem Linguae 3d96eedbee eslint: remove redundant ruleset wikimedia/jsdoc
The ruleset wikimedia/client-es6 already contains
the ruleset wikimedia/jsdoc. So wikimedia/jsdoc
doesn't need to be declared.

Bug: T365047
Change-Id: Ibc13c9bf4bbbe36d5c8296372f59cc13a0c0940b
2024-05-15 18:38:53 +00:00
Translation updater bot 7ff70b7fdf Localisation updates from https://translatewiki.net.
Change-Id: Ib42551cb801467a78459d7ff133605f9fd305761
2024-05-14 09:27:37 +02:00
Ed Sanders 2615070b42 Convert function to arrow function to fix context
Bug: T364783
Change-Id: I02100e193554fa359b7be2c52d1ee67f63734a2d
2024-05-13 22:31:00 +01:00
Translation updater bot bc73596aca Localisation updates from https://translatewiki.net.
Change-Id: I6642078b72c4d947d7b6959695f6b9de2a2556e2
2024-05-13 09:28:17 +02:00
jenkins-bot 6f307830af Merge "ArticleTarget: Fix return of getVisualDiffGeneratorPromise" 2024-05-10 20:34:01 +00:00
Ed Sanders b247c70a22 ArticleTarget: Fix return of getVisualDiffGeneratorPromise
The promise is supposed to return a function that can be used
to lazily generate the visual diff, not the visual diff itself.
This was broken when switching to arrow functions.

Bug: T364635
Change-Id: Ifa971333aa22af346bb62d031dc20afc8979992c
2024-05-10 20:09:09 +00:00
jenkins-bot bd1c1593a7 Merge "Fixes incorrect transition from searched image preview to upload panel" 2024-05-10 14:06:04 +00:00
Zoë 220088e13e Fixes incorrect transition from searched image preview to upload panel
This line was introduced by If59979f.

This action is only invoked from the 'safe' action when the dialog mode
is 'info' - uploads are under 'upload-info' instead - so I believe we
shouldn't end up here from an upload and whatever condition this was
guarding against is no longer a concern.

Bug: T362015
Change-Id: I6a6551eab3fb698a6ae781be4623b48e4b4c7edb
2024-05-10 10:57:11 +01:00
Translation updater bot ee05f4fb9e Localisation updates from https://translatewiki.net.
Change-Id: Id2459aff3f36498288f04ee116bee0021e6d19ca
2024-05-10 09:30:34 +02:00
jenkins-bot f95f6768fc Merge "Disable eslint security regexp warnings" 2024-05-09 16:33:35 +00:00
jenkins-bot 2bda8c5d19 Merge "checkModules.js: Warn about unused ignore paths, and remove currently unused ones" 2024-05-09 12:24:58 +00:00
jenkins-bot 98cbaf651a Merge "checkModules.js: Run as part of CI" 2024-05-09 11:36:41 +00:00
jenkins-bot b8160ee1be Merge "checkModules.js: Move out of build/tasks" 2024-05-09 11:36:39 +00:00
jenkins-bot 51d89e53bc Merge "Use arrow callbacks in other modules" 2024-05-09 11:19:08 +00:00
jenkins-bot c53bdb8407 Merge "Convert local functions to arrow functions and remove this bindings" 2024-05-09 11:17:01 +00:00