Commit graph

160 commits

Author SHA1 Message Date
Ed Sanders 605f7b625b Hid category links in source edit mode
Change-Id: Ib44e393d3a8d070a4ced002a11cb26f58447e67c
2016-10-07 16:24:23 -04:00
Ed Sanders 1ce3a81c63 Fix styling of categories now they are editable
Bug: T147084
Change-Id: I8c2acf507c72f6a35aadf595bad0c8c378140a0b
2016-10-02 15:43:17 -04:00
Ed Sanders 4c8a97f9e8 Temporarily override broken toolbar border colour
Will be fixed in the next OOUI release via I91862c2e609.

Change-Id: I741bb8d5396bed256ee1907eaa4ba86e4697f325
2016-09-20 22:51:02 -07:00
jenkins-bot f6b7c64e92 Merge "Open meta dialog to edit categories when user clicks on the category footer" 2016-09-20 00:58:29 +00:00
Volker E ecab9df8bb Update progressive color to WCAG 2.0 level AA compliant color palette
Aligning instances of `progressive` color to WCAG 2.0 level AA compliant
color palette similar to changes in
I6fdb90af8b9dc5e5e026eb0c1bd13138c73da4cd

Change-Id: I2eda190f0a68de6dc8aa33724f2c8975327a061f
2016-09-19 15:25:45 -07:00
Alex Monk 0c07caafc7 Open meta dialog to edit categories when user clicks on the category footer
Bug: T145267
Change-Id: Ie88c4d9c6327baffdb83c1affbc0515a68c0fc03
2016-09-19 21:35:45 +01:00
jenkins-bot af13aae426 Merge "Fix z-index issue on floating toolbar dialog" 2016-08-01 16:42:16 +00:00
Ed Sanders d86bdccf89 Only apply font fix to global overlay
Bug: T141262
Change-Id: I6a99eefc683bb72c79bf13de2a1f89c37c443310
2016-07-25 14:48:49 +01:00
Volker E 6fff13b898 Fix z-index issue on floating toolbar dialog
Fixing `z-index` issue of floating toolbar dialog not overlapping when
Special Character dialog is active.

Bug: T140237
Change-Id: I24e9ed5b1f65c6ea4cffbd408953623540542bca
2016-07-13 16:16:08 +02:00
Ed Sanders b33cd5d8f1 Fix loading bar opacity
* Ensure ve-loading isn't removed early
* Quickly detach then reattach the loading bar during
  activation so it doesn't get moved and marked as original content

Change-Id: I263c9627348953a11966f8bcc435d0d89b0b6084
2016-06-01 14:52:57 +01:00
jenkins-bot eb9c346221 Merge "Update VE core submodule to master (a4a5afa)" 2016-05-30 17:03:51 +00:00
Ed Sanders 5581394ea3 Update VE core submodule to master (a4a5afa)
New changes:
4a5aa37 Clean up debug bar buttons
15f016c Undo sequence input stripping if window is dismissed
e874734 Localisation updates from https://translatewiki.net.
8db33b4 Follow-up e874734: Fix build for added languages 'gom-latn' and 'gor'
79c5d51 build: Update stylelint config version and make it pass
3804f5e build: Remove grunt-cli
cea7b63 Update OOjs UI to v0.17.3
9f648f4 [BREAKING CHANGE] Always get registries/factories via surface
1252814 Add cloneWithData() utility
5ccdef3 [BREAKING CHANGE] Fix debug bar encapsulation

Local changes:
* Fix debug bar encapsulation

Change-Id: I2c5d722278c5f71b59ee2f8849d9babb5aff6af2
2016-05-30 09:53:31 -07:00
jenkins-bot c2c997081f Merge "Fix z-index of surface for debug bar" 2016-05-29 17:19:29 +00:00
Ed Sanders 73a1127981 Fix font size in target widget debug bar
Change-Id: Ic5120fd1d2cc4955a502fa57478a19851f9f6b33
2016-05-29 17:39:09 +01:00
Ed Sanders 293163131b Fix z-index of surface for debug bar
Change-Id: I938f2d959cd7cb72c43c2efd666838a9cd9d3e39
2016-05-28 20:53:40 +01:00
Ed Sanders 5d9ed11815 DesktopArticleTarget.init: Make surface hiding hack work with padding
Change-Id: Ia8508199c80ef3da7f4ae30bd4e053273fe44d8a
2016-05-27 18:33:33 +00:00
Ed Sanders 1dc933bead Genericise target initialisation across namespaces
Define $editableContent on target construction, and mark
all non-ancestor nodes between that at the target container
as uneditable (50% opacity, no pointer events).

Bug: T58289
Change-Id: I7fe51104bd5aa1bd53ffc604e5f02752c7553578
2016-05-25 12:50:36 +01:00
James D. Forrester 8c7ed92288 Update VE core submodule to master (eeaf1e2)
New changes:
c54a48a build: Fix watch list (csslint -> stylelint)
58ba3d9 Add stylelint rules for @-rules
3f8c75a Stylelint: Add rule for unsupported browser features
3b96ff3 Fix minimum Opera version (15 -> 12)
9a1110b Stylelint: No ID selectors
9800bb8 build: Remove remaining references to csslint
b6ab14a stylelint: Re-enable features by names
6cc1f3c Move stylelint to npm
1d15fa0 build: Bump stylelint version to v0.2.0
ccc1724 stylelint: Use the preset rather than extending

Change-Id: I22fa8098592338a5e912aba9ad21131b21d9c0ea
2016-05-18 07:06:53 +01:00
jenkins-bot d2c995594a Merge "Remove remaining references to csslint" 2016-05-17 12:41:48 +00:00
Ed Sanders 8d749518ec stylelint: Comment uses of 'unsupported' browser CSS features
Change-Id: Ia88575d3fe71c22551cc601f03d8f4dea6d7fe16
2016-05-17 12:28:07 +00:00
Ed Sanders df49e5deb9 Remove remaining references to csslint
Change-Id: I1b5177bf746985a199bcc1ec713f886164c74760
2016-05-17 13:27:47 +01:00
Ed Sanders 99d3320573 build: Replace csslint with stylelint
For now just use the rules file in lib/ve, but eventually
this will be a preset.

Change-Id: I7fd79d3e1dce37aef066d416cd969e5fff1e962f
Depends-On: I17e0d23ddfedf64985495ab35d113ea08c03b1df
2016-05-16 22:30:49 +01:00
jenkins-bot 80636c235e Merge "Add a popup after switching into VE from WTE" 2016-04-25 22:42:55 +00:00
Ed Sanders 9898b7ea2c Move monobook global overlay styles to generic DesktopTarget
Fixes the font size in non-article desktop targets,
e.g. Flow.

Change-Id: I8f7e0af5061ef5dda2564b62e9b94e606ca77799
2016-04-22 12:42:52 +01:00
Alex Monk 0bbe2e38ee Add a popup after switching into VE from WTE
Bug: T131066
Change-Id: I2294da7d09dfbacb9187aba5e6e703511cec3c9f
2016-04-20 18:46:00 -07:00
Alex Monk 89ed0ccbf5 Only style originalContent when VE is active
Otherwise there is a white block above the resulting content after save

Change-Id: If9239556ed5b1038aa86e4ba161da2abfd9e6bf2
2016-04-15 02:26:44 +01:00
Ed Sanders f342dc01c3 Adjust DOM and CSS so UI surface runs from top to bottom of page
Place things like the page title and redirect link inside a new
container $originalContent, which is appended to the surface
when ready. Replace margins with padding in various places.

This will allow us to surface-height-matching sidebar for dialogs.

Change-Id: I60d80fb303bdaf93e9d121f62d534ee3a3056e59
2016-04-11 13:18:36 +01:00
Alex Monk 3288d4e3f9 Show redirect target inside target
Bug: T63861
Depends-On: I71d3d415fe918e8b0a090860cad9271092b1bd7e
Change-Id: I5a138b95e04773885ca9ee548026729805eb11f0
2016-03-17 15:21:06 +00:00
Ed Sanders 229a088f34 Make surface measurable while activating
If the surface is display:none then $.width always
returns 0, which breaks features like FocusableNode's
invisible icon.

Bug: T127319
Change-Id: Ib157ffaeb56fca2bdc26868d830c4bf8feafa2a8
2016-02-23 17:05:09 +00:00
jenkins-bot 4a751524c4 Merge "Edit mode switch: Show popup next to VE switch button" 2016-02-10 01:51:57 +00:00
Ed Sanders 80124c88a6 Edit mode switch: Show popup next to VE switch button
Only show if the user came from VE.

Change-Id: Ic362ba534d135fca5516c8ba401f6b2a22886ff1
2016-02-10 01:36:32 +00:00
Ed Sanders 739f924e98 Follow-up I7e1edcf05c: Remove MonoBook z-index hack
The cited reasons were that the the logo and search bar
have a z-index of 3, but that doesn't matter as they are
nested in other elements with z-indexes.

Change-Id: I7ff279efe7c01ba1ffb1fa0d460d59a493ccc47a
2016-02-07 17:40:50 -08:00
Ed Sanders c51cef07b9 DesktopTarget: Move generic VE desktop styles into a separate module
Here they can be re-used by other VE desktop targets,e.g. Flow.

Change-Id: I18431ff73fc1c6ab5639a579e85b0f0cc48cb9ce
2016-02-07 17:39:57 -08:00
Ed Sanders efd41fbc74 Remove global overlay hack now fixed in Vector
Change-Id: Ic5cfb7ae4d244799be56e12b4b0a44b6ddd00303
Depends-On: I5ebb4e59e3714dfaa3d755ecf6285009efe7b62a
2016-02-07 03:26:02 +00:00
Ed Sanders 9bf010c33c DesktopArticleTarget: Cleanup styles
* Use more specific ve-init-mw-desktopArticleTarget class
* Add comments and reorder in places

Change-Id: Ic9291d3e50304fe3a0efa7ace1ce93c7fba91d98
2016-02-06 19:26:06 -08:00
James D. Forrester 68ea08cd5e Drop support for adding prefix/appendix labels to edit tabs/links
Depends-On: I264599a1c4f60b37a46d49c808cf271ba0a8f882
Change-Id: Icebc378f5c00aac57ad361f8ba85da93b8178650
2016-01-18 03:06:33 +00:00
James D. Forrester ada58df361 build: Bump file copyright notices for 2016
Change-Id: I3c618c196e504a80ca297a4132a17f1977a24fb7
2016-01-03 14:57:25 -08:00
Ed Sanders 29f33a57d5 Rename mw.Target to mw.ArticleTarget
This makes way for a base mw.Target class which is
not specific to articles (e.g. Flow boards).

Bug: T97166
Change-Id: If72650bdf87aa9f195b004da0a4d815f1a8063a3
2015-12-10 16:26:20 +00:00
Ed Sanders 86a1d1bfa3 Edit mode switching: Separate styles
Ensures that these styles are loaded *after* OOUI by making
them dependent on it, unlike DesktopArticleTarget.init
which isn't.

Change-Id: Ia1fff16432d20fb56707c5e21c6a930d2478e311
2015-11-11 18:50:55 +00:00
jenkins-bot 1f2905c39f Merge "DesktopTarget: Fix opacity of #siteSub and #contentSub" 2015-11-10 23:39:03 +00:00
Ed Sanders b05d9fcb0e Target init: Add edit mode switch icons to VE and WE toolbars
VE already has a a switch icon in the options menu, so bring that
up to the main toolbar.

Append an OOUI button to the WikiEditor toolbar if present, and bind
to the same functon as the edit tab.

Bug: T49779
Change-Id: Ic1e83ea7b13c4fef68024bf05ffc244060666103
2015-11-04 14:07:41 +00:00
Ed Sanders b222696675 DesktopTarget: Fix opacity of #siteSub and #contentSub
siteSub and contentSub are both children of bodyContent so
no need to give them opacity directly.

Bonus: Make them user-select:none to avoid confusion as they
are in the edit area.

Bug: T116755
Change-Id: Iea4c35abc1eedb892e02c54b61e40726fa2b096e
2015-10-27 14:41:45 +00:00
Ed Sanders c9fc5fb171 Add theme-specific drop shadows to target loading bar
As a modal popup it should have a drop shadow

Change-Id: I5b4a07c268c30124ed7ba6cc5391005595abeb7b
2015-10-22 16:02:25 +01:00
Ed Sanders 9749ff5187 Create separate skinStyles for target loading bar
Change-Id: I74eff697711641a7c111564ddb9e493ad358b8d4
2015-10-22 16:01:44 +01:00
Ed Sanders 1eb0ef2011 Consistently use spaces inside brackets in CSS
Change-Id: Ie63a50cb16cb89dac7060857220485d7d23f2fe3
2015-10-04 18:33:43 +01:00
Ed Sanders 42d04b6f47 DesktopArticleTarget: Fix page title (first H1) font size in Vector
Change-Id: I87409ad5da3819732d13943a64b2ca22f65f9418
2015-09-22 17:12:23 +00:00
Ed Sanders ade9bfda4b Skin specific fixes for external link cartouches
Change-Id: I84edb509e7ecaae00befbfdeeee7a75373564536
2015-09-20 23:35:23 +01:00
eranroz 051066ead6 Server-side replace Edit=>Edit Source on talk NS
If VE is enabled for consistency edit section links become edit source in all NS.
This patch fixes it to be done on the backend for namespaces where VE is not enabled
(instead of user side) to avoid noticeable flickers on page load.

Bug: T112366
Change-Id: Iba090bfc1b2ff4886fb0cf2b37db7870b6be792d
2015-09-16 00:39:13 +03:00
Ed Sanders 7114463cc5 MobileArticleTarget: Restructure the toolbar
* Rename the actions toolbar the 'pageToolbar', and place the save button in
  its actions section.
* Inject the title amongst the pageToolbar tools, so we can have tools either
  side of it.
* Don't use the hamburger icon, as this has a (different) expected behaviour
  in MF. Replace it with a back button, and move the edit switch action over
  to the right in an 'advanced' group.

The toolbar is back to being laid out like the source editing toolbar in MF.

Change-Id: I4e00a8cdf603968ee32872323c88e587c1e1a487
2015-08-15 14:33:10 -07:00
Ed Sanders 596151acbe MobileArticleTarget: Centre toolbar tools
Popup tool requires special attention to make it work
and keep the tool list left aligned.

Bug: T92027
Change-Id: I77a0dcbba382dce1669a30d48471b0c501c3d851
2015-08-10 21:03:56 +00:00