Commit graph

429 commits

Author SHA1 Message Date
jenkins-bot 3ccfacf7f9 Merge "Use wgEditSubmitButtonLabelPublish from upstream" 2018-01-30 19:48:01 +00:00
James D. Forrester 4ce103abb9 Update VE core submodule to master (c5fddd508)
New changes:
21a5d55b8 [BREAKING CHANGE] Store metadata as block nodes in the main data list
2f9868aae Localisation updates from https://translatewiki.net.
7a224cf4b Remove <style> tags from pasteTarget ASAP
fb4e894b6 Workaround missing child selector in OOUI for menuLayout
fa4f35281 rebaser: Fix sequencing of server operations
931ee29f6 SurfaceSynchronizer: Also translate selections that are not mentioned in the change
d232b8f04 Disable undo/usurp within SurfaceSynchronizer
d1b7fc597 ve.dm.Change: Truncate stores as well as transactions on conflict
7606f684d rebaser: Only apply artificial delay to submitChange events
9473e8b42 Toolbars: Replace $.width with clientWidth/offsetWidth
abb8f2075 ve.ui.DesktopContext: Remove unused CSS
050414205 ve.ui.DesktopContext: Remove old unnecessary CSS
7b8cbb830 Failing test case for losing annotations
5447d33e4 CommentNode: Protect against call after teardown
bf98ca2b6 Rebaser: Use better hack for disabling history commands
90c07f46c Rebaser: uninitialize fully
2a59016e4 Move updatingName recursion guard out of debounce

Bug: T56299
Bug: T185532
Bug: T185544
Bug: T185599
Bug: T185716
Bug: T185747
Change-Id: I45251811e3fbb3323a25ca5cf364e4cb94aa1d01
2018-01-29 08:43:08 -08:00
James D. Forrester b083e07a5d Use wgEditSubmitButtonLabelPublish from upstream
Change-Id: I772a21025771f82cdb7260e53996c2c6fd6fa718
Depends-On: I065f733bd8b27bda68023cd1b718e257fd135aa2
2018-01-17 11:07:46 -08:00
Ed Sanders 7661081ab9 Remember preferred diff viewer
Separate the preference by surface mode, so you can
use a different preference for NWE.

Bug: T178691
Change-Id: Ib8494a4562ce766a7c8ef7ec1447d06f5d0f17c5
2018-01-17 13:31:07 +00:00
jenkins-bot 683ac88fcc Merge "doc: Bump copyright year" 2018-01-03 19:20:07 +00:00
James D. Forrester 0a7a845a42 doc: Bump copyright year
Change-Id: I0b299c840ede1a1b8552cecfc70c5760ab036181
2018-01-03 17:45:07 +00:00
Bartosz Dziewoński 4987c07793 Move things that are not modules out of modules/ directory
* Move SpecialCollabPad.php to /.
* Move screenshots for BetaFeatures to images/.
* Move localisation messages to i18n/.

Change-Id: I874ae135a3ac58118c3dea105136c8c8b6fb41bc
2018-01-02 11:05:23 +01:00
Ed Sanders 4b0eeb5b0a Preserve 'oldid' on custom edit page
Bug: T179994
Change-Id: Ibc7c9c9dc12c94538c5052e6e8ae3c8ae68b3293
2017-11-08 14:41:40 +00:00
James D. Forrester 9fd8def8dd Move Beta Features screenshots into modules
Change-Id: I6b46f334d226a3e061a3534fd2982397b66e2c6f
2017-10-26 14:27:52 -07:00
jenkins-bot 9574395d96 Merge ""Automatically enable all new beta features" should enable 2017 editor" 2017-09-26 22:59:39 +00:00
David Lynch 72ad051e0b Hooks: remove preloadtitle from unsupported list
Bug: T51622
Change-Id: I480bbc5b9906f82b06667c69a559360f9083f06a
2017-09-20 10:16:32 -05:00
Deskana b96ebad5e5 "Automatically enable all new beta features" should enable 2017 editor
Bug: T176181
Change-Id: I588dd08b788689fb89de7fd001bded30caa07e64
2017-09-20 14:31:00 +01:00
David Lynch ea274c94cd Enable preload in VisualEditor
This allows the use of the preload and preloadparams query parameters. They
should behave as they do in the old editor, loading substituted content in
visual and source modes.

Bug: T51622
Change-Id: I522fb5b480d17912f6d6116be6aa043ead855b52
2017-09-15 17:17:51 -05:00
Ed Sanders b280ae985c Make ve.dm.Change part of core module
Also:
* Add ve.dm.Change.test.js to MW test suite
* Remove server scripts from ext.visualEditor.rebase, they
  only need to be in rebaser.build in core.
* Don't load ext.visualEditor.rebase on every page

Bug: T175828
Change-Id: I0ed0c320373b0d653b0d7a012aa7416e88e43e00
2017-09-13 16:36:17 +02:00
James D. Forrester d9739c0b2e Update VE core submodule to master (834fd702f)
New changes:
86bd6c879 Localisation updates from https://translatewiki.net.
6d7a4cef0 Update OOjs UI to v0.23.0
37d1512a7 TransactionProcessor: modify DM tree branches instead of rebuilding them

Bug: T162762
Bug: T166041
Bug: T167027
Change-Id: Idfaa990dd940e26d7d572513220282bc97ca65fa
2017-09-06 13:44:33 -07:00
Kunal Mehta 34ba904d68 Use Html::hidden()
This simplifies a little bit of code.

Change-Id: Ie76d68864f34000fc60d78f862f447f4260fb551
2017-09-03 00:30:13 -07:00
Ed Sanders 2e7577849b Set wgRevisionId on overridden edit page
Bug: T166131
Change-Id: I9ec865bce27292513c0aea4f0cd0747f5b4deaa0
2017-08-25 15:26:30 +01:00
Kunal Mehta 70777051ed build: Update mediawiki/mediawiki-codesniffer to 0.11.1
Change-Id: I12e117267450539ca9051b22f4f41040b53889b2
2017-08-16 01:23:51 -07:00
C. Scott Ananian 9ee713d480 Display LanguageConverter markup in VisualEditor
Implement special node types for language variant markup, so that they
display appropriately based on the currently-selected variant.

(Parsoid uses empty elements to represent this markup, so without this
patch anything in -{ ... }- is alienated and disappears.)

A follow-up patch will implement context items and inspectors to
allow editing these nodes.  This patch is basic "read-only" support.

Depends on I4fcdebc2290ec35ba188f4c2e69d578791fbcd67 in Parsoid to
generate the appropriate markup, but this patch is safe to merge
independently.

Bug: T49411
Change-Id: Ie11e9301d2513bfe4a36036481cee9a047f46d37
2017-07-25 15:26:41 +00:00
Ed Sanders cedf3758d2 Update mediawiki-codesniffer 0.10.0 -> 0.10.1
Change-Id: I40707991ff2931593ae44046369f2d7955ff324e
2017-07-25 15:49:56 +01:00
Ed Sanders 602b8b7782 Only enable VisualDiff on VE-supported content models
Change-Id: I71ea11aaed207c4f67cfd69455b90d87e5f14498
2017-07-18 23:09:04 +01:00
Mukunda Modell c14b1c46a9 Set onDiffViewHeader argument defaults = null
As suggested by Bartosz in https://gerrit.wikimedia.org/r/#/c/361938/
Just set a default value but keep the type hint. This should avoid
the logspam while retaining type safety.

Bug: T169132
Change-Id: I1221357746f5d4ba1430bcf0bfe773202484eebc
2017-06-28 16:16:20 -05:00
James D. Forrester 27467c32d4 VisualEditorHooks#onDiffViewHeader: Don't add type hint as the hook sucks
It'd be nice if the hook didn't.

Bug: T169132
Change-Id: Iabe75448bbedebf8164d9c8223a4d59d0281e66e
2017-06-28 20:42:37 +01:00
Jforrester 15c6011875 Merge "Ensure MWInlineImages get the ve-ce-leafNode class" 2017-06-27 17:15:44 +00:00
Ed Sanders c4f93b1411 Ensure MWInlineImages get the ve-ce-leafNode class
Without this class, offset calculations fail and model/view
sync can be lost.

Bug: T167009
Change-Id: Ie7b6551ac5a532949c14122b9ee7584a794af0f2
2017-06-26 12:43:23 +00:00
Ed Sanders 0e6d8d5fff Show visual diffs on DiffPage
Only shown if VisualEditorEnableDiffPage is set, or query
string param 'visualdiff' is present.

Currently:
* All VE javascript is loaded (could be cut down to just DM code)
* The entire Parsoid HTML of both revisions being compared is loaded
* Both Parsoid HTML docs are parsed into VE DM trees and diffed

Bug: T167508
Change-Id: I151fc9bab3d3032f50c8d11be6b54e45a06fcc34
2017-06-16 19:29:19 +01:00
Ed Sanders 574baf2e8e Provide VE-rebaser in MediaWiki as Special:CollabPad
Change-Id: I3ffe0e2b6af43d4018dcd79877f4f27ed7d6a7e7
2017-05-20 19:51:09 +00:00
Ed Sanders 63c36c87da Always prefer wikitext for action=edit on non-SET wikis
Ideally we could use the preferred editor, but this breaks
tab switching to the old editor.

Bug: T165238
Change-Id: I5f5ee5566cdd2080ba7c89d43cf127b457537768
2017-05-15 12:48:30 +01:00
James D. Forrester 7819eda622 build: Enable MediaWiki.Commenting.FunctionComment.MissingParamComment
Change-Id: I29bd2c3dcc3a90a52036ab7e6bf2227af61703d7
2017-05-11 21:20:37 +00:00
James D. Forrester 2a81a95782 build: Enable MediaWiki.Commenting.FunctionComment.MissingParamTag
Change-Id: Ia6d758bebd45d31143a3dfd3357cc4687449a1cb
2017-05-11 08:19:44 -07:00
James D. Forrester 59715b66c2 build: Enable MediaWiki.Commenting.FunctionComment.MissingParamName
Change-Id: Id0b92c026690799db84f53402ce29913754bba0b
2017-05-11 08:19:44 -07:00
James D. Forrester 307a8f0ed7 build: Enable MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment
Change-Id: Id11360a266b5a5269856a9adbf3cd27cda52f178
2017-05-11 08:19:44 -07:00
James D. Forrester 945719f43e build: Enable MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName
Change-Id: Ib1e607addcb13c8fced2058ef5a80a96c95ff31e
2017-05-11 08:19:44 -07:00
James D. Forrester 9a27f80b3e build: Enable MediaWiki.Commenting.FunctionComment.MissingReturn
Change-Id: I714220880e91583a6e3cc575810fe02e3e822538
2017-05-11 08:19:44 -07:00
James D. Forrester e12651b1c2 build: Enable MediaWiki.Commenting.FunctionComment.ParamNameNoMatch
Change-Id: Ie1c745c4ea6ddaad6d41285ad444e7a91dc48cc9
2017-05-11 08:19:44 -07:00
James D. Forrester 56bfb7828c build: Bump mediawiki-codesniffer to 0.8.0 and make pass
Change-Id: If509e5ba639bcda497fe7898f6eb79265967139d
2017-05-11 08:19:44 -07:00
James D. Forrester f016f3dc9a Un-blacklist the lintid parameter
Bug: T160102
Depends-On: I59a7e0a3e8be32e4689cbf41c4904970902c4dff
Change-Id: Ie0e8d82db2dc3589c58a90a600ac0feb06159ed3
2017-05-02 07:41:11 -07:00
James D. Forrester 314bb053c7 Re-sync tests from VE-core into ext.visualEditor.test
Newly added:
* 'lib/ve/tests/ve.EventSequencer.test.js'
* 'lib/ve/tests/ve.Scheduler.test.js'
* 'lib/ve/tests/ve.Range.test.js'
* 'lib/ve/tests/dm/ve.dm.Annotation.test.js'
* 'lib/ve/tests/dm/ve.dm.TransactionBuilder.test.js'
* 'lib/ve/tests/dm/ve.dm.SourceSurfaceFragment.test.js'
* 'lib/ve/tests/dm/ve.dm.Scalable.test.js'
* 'lib/ve/tests/dm/selections/ve.dm.LinearSelection.test.js'
* 'lib/ve/tests/dm/selections/ve.dm.NullSelection.test.js'
* 'lib/ve/tests/dm/selections/ve.dm.TableSelection.test.js'
* 'lib/ve/tests/ce/ve.ce.RangeState.test.js'
* 'lib/ve/tests/ce/ve.ce.TextState.test.js'
* 'lib/ve/tests/ce/nodes/ve.ce.TableNode.test.js'
* 'lib/ve/tests/ui/ve.ui.Trigger.test.js'
* 'lib/ve/tests/ui/ve.ui.DiffElement.test.js'
* 'lib/ve/tests/ui/actions/ve.ui.ContentAction.test.js'
* 'lib/ve/tests/ui/actions/ve.ui.TableAction.test.js'
* 'lib/ve/tests/ui/ve.ui.DataTransferHandlerFactory.test.js'

Moved:
* 'lib/ve/tests/dm/ve.dm.LinkAnnotation.test.js' (up)
* 'lib/ve/tests/dm/ve.dm.LinearData.test.js' (down)

Ones skipped because they're currently broken:
* 'lib/ve/tests/dm/ve.dm.Change.test.js',
* 'lib/ve/tests/dm/ve.dm.TestRebaseClient.js',
* 'lib/ve/tests/dm/ve.dm.TestRebaseServer.js',
* 'lib/ve/tests/dm/ve.dm.RebaseServer.test.js',
* 'lib/ve/tests/init/ve.init.sa.Platform.test.js',
* 'lib/ve/tests/ui/dialogs/ve.ui.FindAndReplaceDialog.test.js'

Change-Id: I8343a67ffdb7255710e70bb9c822b9b006ae5aa7
2017-05-01 15:24:56 -07:00
James D. Forrester 84ec8739e3 Update VE core submodule to master (3b8a164a3)
New changes:
c61044a89 tests: Cover LinkAnnotation#getFragment()
a18e7bd75 tests: Cover <bdi> tags
4e6b991e2 VisualDiff: Don't describe internalItem changes
572ca6d09 VisualDiff: Don't try to render empty node changes
f794e511e LinkAnnotation: fix getFragment behavior
a5deb2b73 tests: Test rich annotations' describeChange()
88e1493a9 [BREAKING CHANGE] QUnit: Remove all code for counting tests
bbabdc425 Remove eslint:fix
31e6b40ce ve.dm.ElementLinearData.test: Cover getAnnotationIndexesFromOffset
97f7eda77 Transaction#isNoOp: Simple code is simple
dd97c627b MergeCellsContextItem: Make sure we're on a TableSelection

Bug: T163945
Bug: T164199
Change-Id: Iba64f64373e05f2dbe56d07dc9e8a8fe282887a9
2017-05-01 11:31:21 -07:00
Ed Sanders cd8b059e7d Synchronise VE availability checks in frontend and backend
Adds better support for NWE loading on action=edit.

Change-Id: I35208cce0696607377378a1b58d426e914a3ba7d
2017-04-28 17:45:27 +01:00
Ed Sanders fefb76eebc Rewrite logic for choosing initial editor
Expanding from a single if-expression lets us make the
code much more readable, and reveals some minor bugs.

Change-Id: I49e57bfc093e019c837a73eab5c25fdbd14de0af
2017-04-26 12:07:51 -07:00
jenkins-bot babba81a66 Merge "Fix logic for redirecting unsupported browsers to old editor" 2017-04-19 21:45:44 +00:00
jenkins-bot 459dac8de2 Merge "Make onUserLoggedIn() check read-only mode" 2017-04-19 18:03:05 +00:00
Aaron Schulz e7f430e5a0 Make onUserLoggedIn() check read-only mode
Also try to defer the master connection to post-send.

Change-Id: I6c8f5b2e48493cd09de3c93604b3a546d7fa1454
2017-04-19 08:15:06 -07:00
Bartosz Dziewoński 21bd2a5b18 Fix logic for redirecting unsupported browsers to old editor
Browsers that support JavaScript, but that get served a no-JS
experience by MediaWiki (for example, IE 6), would always get
redirected to an URL with &venoscript=1 - even when it was unnecessary
because we're not in single-tab mode, and even when the form was
previously submitted, causing the loss of user input.

Follow-up to 188ec0f5d2.

Bug: T163226
Change-Id: I212baa0f4305559fa6f6abdfa230b76c122d4909
2017-04-18 20:05:25 +02:00
Bartosz Dziewoński ae8b0a1f36 Replace $wgVisualEditorSupportedSkins with a check for required elements
The bare minimum of elements that must be present on the page for
VisualEditor to start and mostly work is:

* '#content' to attach our interface (toolbar etc.)
* '#mw-content-text' to replace with the editing surface
* '#ca-edit' to start up the editor

When those elements are missing (and we expect them to be present,
e.g. we're not on a special page), we print a console warning.

For example, VisualEditor now launches on Timeless and CologneBlue.
It does not launch and prints a warning on Modern and Erudite.
(It is actually possible to edit and save pages on CologneBlue,
although various pieces of the interface look funny.)

This does not change which skins we claim to support: these are still
currently only Vector, MonoBook and Apex. But it allows third-party
skin developers to more easily test the editor and fiddle with their
CSS to make it look right.

Bug: T161373
Change-Id: I97c786f3c8c795c238b10bef332a129ea26f86c2
2017-03-29 18:13:05 +00:00
David Lynch 217640624a DesktopArticleTarget: Make the waiting module list extensible
So that GlobalCssJs and other extensions can hook in.

Bug: T156899
Change-Id: I045c7b045ce28047298b28a05e77ef27749c1ee1
2017-03-16 17:48:03 -07:00
James D. Forrester c07a6df74c Don't load VE or NWE on lint-targetted pages (until that works)
Bug: T160102
Change-Id: Ibb364ff2d89975d5907fa887cca666eee6e78d37
2017-03-15 14:23:17 -07:00
Ed Sanders f51d86df20 Update VE core submodule to master (8211ebc70)
New changes:
c99e7f0b6 Diacritic insensitive search in find & replace dialog

Bug: T154195
Depends-On: I95eb851c10a44e18382a6a4a0cb22559db6752b7
Change-Id: I6b74fc3dbaa27de67a565a3c2c6bf8a951b24364
2017-02-28 16:30:22 -08:00
James D. Forrester 667dc5231b Allow the signature button to work in NWE as well as VE
Previously we were only letting the button work in VE-enabled namespaces,
which means that on namespaces where you can use NWE but not VE (oh, you
know, most of them) the signature button was always disabled, which was
somewhat discombobulating.

Bug: T159211
Change-Id: I4ffffb3a7e14df78a45a6e3afa49718c0329ca55
2017-02-28 13:38:26 -08:00