Refactoring in 92c4e23 didn't account for the case where there are multiple
tabs and source mode isn't NWE, which caused the "edit source" tab to just be
a page- navigation that always discarded changes. onEditTabClick handles this
case fine, so just always bind the handler.
Bug: T199655
Change-Id: I3dca87a7a3b0ea88ef0008be89cd1f6007167916
New changes:
b7e84c989 rebaser: Make create/edit button primary+progressive
316496c15 Localisation updates from https://translatewiki.net.
65fd7fb40 Update OOUI to v0.27.6
a7b2cb4e2 rebaser: Unpaint authors on disconnect
4b549306b ve.ce.Surface: Handle null native selections in #getSelectionState and #showSelectionState
76d1afe62 Localisation updates from https://translatewiki.net.
14d29a5c0 rebaser: Force user state back to active=true when connecting
8530b6762 rebaser: Methodise AuthorList/Widget
9c79de597 rebaser: Emit author colors as well as names in initDoc
5d44160eb rebaser: De-activate surface when author list popup is visible
243e02650 rebaser: Upstream storing username in session storage
22de08438 Remove unused second parameters to ve.ce.Document#getNodeAndOffset
Bug: T199011
Bug: T199754
Bug: T200128
Bug: T201017
Bug: T201244
Change-Id: I2f053c986a5720ddc66cb310ff642b33556e270c
New changes:
29331acd8 lib: Update jQuery.i18n to 1.0.5
9bb7abf84 libs/CLDRPluralRuleParser/README.md: Drop `x` flag from file
Change-Id: I7d6446bd3a4a87b77a8569d8279b3fc984b1529c
While all of the following are valid in the model:
1. <mwBlockImage></mwBlockImage>
Image with no caption. Must use the media dialog to insert one.
2. <mwBlockImage><mwImageCaption></mwImageCaption></mwBlockImage>
Image with empty caption. There is a slug to insert a paragraph.
3. <mwBlockImage><mwImageCaption><paragraph></paragraph></mwImageCaption></mwBlockImage>
Image with caption with empty paragraph. Nice and intuitive!
(Same for <mwGalleryImage> / <mwGalleryImageCaption>.)
The third option is the most convenient for the user. We should always
generate that when converting documents from HTML and from the editing
tools (MWGalleryDialog, MWMediaDialog/MWImageModel).
Previously, the editing tools generated option 2 if no caption text
was entered, and the converter generated option 2 if there was no
caption node or if it was empty. Curiously, option 1 was never used.
Wikitext for manual testing:
```
[[File:Foo.png|thumb]]
[[File:Foo.png|thumb|]]
[[File:Foo.png|thumb|Caption]]
<gallery mode="packed">
File:Foo.png
File:Foo.png|
File:Foo.png|Caption
</gallery>
```
Bug: T200387
Change-Id: Ie82fb339f6bd8ae1b289235bf5402490722d9a7c
New changes:
9aecc6946 Add CheckList type
be0469524 Allow cursoring between active nodes
954b21f33 Localisation updates from https://translatewiki.net.
38e1e7667 Do not try searching outside of valid range when using regex
deec79971 ve.dm.TransactionProcessor: Fix edge case handling, avoid ES6 methods
Bug: T196521
Bug: T200455
Bug: T200525
Change-Id: Ie87e19d13c68425f5d46bd1be5121c9169c2ebf4
New changes:
3e46076f7 Localisation updates from https://translatewiki.net.
8ea59e50d ce.Surface: Debounce position events
17e3d3aa0 Amend `border-radius` to conform to Apex theme standard
c573f3513 docs: Replace fake ellipses with real ones (or in one case, a vertical one)
a4e24a992 Make mode for getting document data without metadata
Bug: T199298
Bug: T200429
Change-Id: I36dad61ed614f007b16d7e9f47fcbfd02347f239