Catrope
5784d2b55c
Fix external link inspector
...
Wasn't loading the link target due to a typo
Change-Id: I77533f949363e79dab9b478e6ba10d05b9486acc
2012-06-21 12:40:28 -07:00
Trevor Parscal
f35c8adac8
Merge "Aggressive keyboard shortcut fix for all browsers and platforms"
2012-06-21 18:09:24 +00:00
Christian Williams
8f7ce742de
Aggressive keyboard shortcut fix for all browsers and platforms
...
Change-Id: Ic9e6359a06752861a05526dba090b08ccd39b83f
2012-06-21 11:09:30 -07:00
Inez Korczynski
847fddd639
Fix for drawing selection in IE - temporary approach
...
Change-Id: Ia944e4c96b1d1d78274f9c23e7120954f694ca08
2012-06-21 11:04:26 -07:00
Trevor Parscal
fc7e96b2b5
Merge "Rename watch to watchpage, per https://gerrit.wikimedia.org/r/12423 "
2012-06-21 17:52:25 +00:00
Catrope
ff39a448a3
Merge "Fixed output of translateOffset when collapsing a range"
2012-06-21 17:48:43 +00:00
Catrope
a904bcc0f3
Rename watch to watchpage, per https://gerrit.wikimedia.org/r/12423
...
Change-Id: Ic38ea27ead9f98b22b1fbbad5dcbb8de2205f51a
2012-06-21 10:46:47 -07:00
Trevor Parscal
5aa3bbedc7
Fixed output of translateOffset when collapsing a range
...
Change-Id: Ifb40dd1f9de557d4237660f5fb7119d6aa940c65
2012-06-21 10:45:58 -07:00
Christian Williams
f27425eb91
Firefox has some crazy bindings for browser features. This prevents it and properly annotates.
...
Change-Id: Ide294efda8b661e16f24cc1f3584a8f08785ff5b
2012-06-21 10:33:40 -07:00
Trevor Parscal
861ce8d54f
Fixed pressing backspace in a slug, now we just move the cursor to some nearby content
...
Change-Id: Idaf61264fb493169cfef1c48613036c292d590f0
2012-06-21 00:01:32 -07:00
Trevor Parscal
c548b3cdba
Merge changes I44515c86,Ife902ace,Ia6510de1
...
* changes:
Got rid of iteration to get the surface
Removed attach and detach methods from ve.ce.Node
Track adjustments in DocumentSynchronizer and apply them to oldRange
2012-06-21 06:41:57 +00:00
Trevor Parscal
07eb2df53a
Got rid of iteration to get the surface
...
Also added a safety check to make it easier to spot a regression
Change-Id: I44515c867852f2f726be74161f6b8e466c0933da
2012-06-20 23:40:38 -07:00
Trevor Parscal
00c555ebe5
Removed attach and detach methods from ve.ce.Node
...
Added some needed functionality in ve.Node to make up for this
Change-Id: Ife902aceb4e8535411dc653ae61087aecf67a0c6
2012-06-20 23:40:38 -07:00
Catrope
dc646ff32c
Track adjustments in DocumentSynchronizer and apply them to oldRange
...
This is needed because oldRange is relative to the state of the model before any changes were made, but when we call selectNodes() it's gonna operate on a partially updated model tree.
This is a genuine bug in DocumentSynchronizer proper, which means I owe the entire team lunch
Change-Id: Ia6510de19df02e961c7f25fb8e7833abceb8d25b
2012-06-20 23:40:38 -07:00
Trevor Parscal
cb3eba185d
Merge "Fix adjustment of newRange in TransactionProcessor"
2012-06-21 06:38:42 +00:00
Catrope
df4e5f0200
Merge "Fix minor bug with space replacement in TextNode"
2012-06-21 06:37:56 +00:00
Catrope
0b9934b2cc
Fix adjustment of newRange in TransactionProcessor
...
* Adjust both start and end for preceding operations
* Adjust end for the current operation as well
Change-Id: I2f96d609bddf3788aa5700ad1f0b46208f3517d7
2012-06-20 23:37:55 -07:00
Inez Korczynski
74440be132
Fix minor bug with space replacement in TextNode
...
Change-Id: Iafdc59d9fd8654444079e55a2ad36a40cc21fa4c
2012-06-20 23:33:22 -07:00
Inez Korczynski
ab16987ae8
Better support for left & right arrow keys
...
Change-Id: Iad56f8179d3ed90828e31ad0203a5cec9e9d2458
2012-06-20 23:06:47 -07:00
Trevor Parscal
3008b04126
Merge "Properly hide and show inspectors."
2012-06-21 05:56:30 +00:00
Trevor Parscal
709c5946ed
Merge "Allow initial value to be accepted in link inspector if it is the default text."
2012-06-21 05:55:40 +00:00
Trevor Parscal
88ef5b1517
Merge "Logic for moving cursor left and right programmatically"
2012-06-21 05:54:50 +00:00
Trevor Parscal
c12eca96fc
Merge "Support protocol-relative URLs in the link inspector"
2012-06-21 05:53:43 +00:00
Trevor Parscal
7e892daac9
Merge "Fixing backspace when at the beginning of the document."
2012-06-21 05:52:45 +00:00
Trevor Parscal
a7b47a2c00
Merge "Pressing enter in the last listItem, if empty, will exit the list"
2012-06-21 05:50:51 +00:00
Trevor Parscal
e657cd802f
Merge "Support for insertion in slugs."
2012-06-21 05:50:09 +00:00
Rob Moen
4d7e467780
Properly hide and show inspectors.
...
Change-Id: I1de85c8364df67bf547b4fec498829e61f7ab07f
2012-06-20 22:29:50 -07:00
Inez Korczynski
9b1e96cd46
Logic for moving cursor left and right programmatically
...
Change-Id: I48844cfbebaf3933ad61dc462ab5ea73be45a8aa
2012-06-20 22:24:12 -07:00
Inez Korczynski
772716bce9
Fix the exception that is thrown when document is passed as a start parameter to traverseLeafNodes method.
...
Change-Id: Ie8c5a0fd9ad8e003fef706fdf61749499ad27e31
2012-06-20 21:53:42 -07:00
Rob Moen
11c3e8b0fb
Allow initial value to be accepted in link inspector if it is the
...
default text.
Change-Id: Ife8e8742b57bc9ff75cf147d6abc913f2a2ada7c
2012-06-20 21:52:42 -07:00
Catrope
dd1db50a3c
Support protocol-relative URLs in the link inspector
...
Change-Id: I78ed64d90e562de1a972807c16196f10d805b959
2012-06-20 21:51:07 -07:00
Christian Williams
4df69b01de
Fixing backspace when at the beginning of the document.
...
Change-Id: Ib4c463c6a1eb27897a39c96c46617047d8ee4325
2012-06-20 21:34:11 -07:00
Inez Korczynski
7eae9cdba6
Support for insertion in slugs.
...
Change-Id: I8e144206520b59271edf854020b87ce947fe0559
2012-06-20 21:32:26 -07:00
Christian Williams
0ab3b65c03
Pressing enter in the last listItem, if empty, will exit the list
...
Change-Id: I084fabac09654adf50db97b554e937d2772f9a37
2012-06-20 21:10:48 -07:00
Catrope
48bba8fcb8
Merge "Added onbeforeunload handler which warns before someone leaves the page if they have unsaved changes"
2012-06-21 03:51:36 +00:00
Catrope
ed399608fc
Merge "Added getSelectionText method to link inspector so that the default text for a link is the selected text. patchset 2 - add case for if data offset is an object, be sure it is a string prior to adding it. truncate to 255 chars. patchset 3 - actually add the patched file Change-Id: Ibddf942c2a0ba3412d93cf9730f74eb858025fad"
2012-06-21 03:48:53 +00:00
Rob Moen
8bccdf9d78
Added getSelectionText method to link inspector so that the default
...
text for a link is the selected text.
patchset 2 - add case for if data offset is an object, be sure it
is a string prior to adding it. truncate to 255 chars.
patchset 3 - actually add the patched file
Change-Id: Ibddf942c2a0ba3412d93cf9730f74eb858025fad
2012-06-20 20:45:56 -07:00
Trevor Parscal
36ee49614c
Added onbeforeunload handler which warns before someone leaves the page if they have unsaved changes
...
Change-Id: I0ffb17987ee40995f7f7e3ffc386aa71c9db37a7
2012-06-20 20:16:10 -07:00
Christian Williams
8556888a9a
Fixing handleEnter to allow splitting headlines
...
Change-Id: I4f75ee1b454f66c4b112a1ab59386994bb249792
2012-06-20 20:02:25 -07:00
Trevor Parscal
a9d62184ed
Merge "Disable indentation button tool, doesn't work yet"
2012-06-21 02:42:53 +00:00
Trevor Parscal
9c0b8f57b2
Merge "Use getClonedElement() rather than manually building a node"
2012-06-21 02:40:11 +00:00
Trevor Parscal
1bfb8f7579
Merge "Hide each inspector in the iframe, works for now. Will need to be rewritten for multiple inspectors"
2012-06-21 02:38:25 +00:00
Trevor Parscal
f529c5ebbe
Merge "i18n for error messages"
2012-06-21 02:37:21 +00:00
Trevor Parscal
9ecb3053e4
Merge "Document how to remove attributes"
2012-06-21 02:36:29 +00:00
Christian Williams
691de5fb76
i18n for error messages
...
Change-Id: Ib0d3350985a64df28a4a2d2c5e68d7dc341330b3
2012-06-20 19:33:19 -07:00
Catrope
9b514b7cbf
Fix off-by-one bug in the ve.msg's fallback $1 replacement
...
Change-Id: I62df4ce4b801c7eec5c08958e1c3b4f835f60957
2012-06-20 19:26:03 -07:00
Trevor Parscal
f49ef7dfc0
Cleaned up selection and focus code for inspectors
...
Change-Id: Iee1a3525015967f1de461c9e0ebea84834346172
2012-06-20 19:22:38 -07:00
Inez Korczynski
7291485ce5
Move slugs logic into doSlugs since it is being used in onSplice and in cleanup methods.
...
Change-Id: I10395bbdfd71fda2913e6da736189f0ff8216702
2012-06-20 19:10:28 -07:00
Catrope
ac835c2d69
Merge "Keyboard shortcuts for bold and italic"
2012-06-21 02:09:28 +00:00
Christian Williams
14054becb5
Keyboard shortcuts for bold and italic
...
Change-Id: I12b80134152bbbbd2dfa42b32fec072cde29baa5
2012-06-20 19:09:06 -07:00