In order to get the desired padding, the `em` values were pre-multiplied
by the parent font-size, which was assumed to be `0.875em` for normal
surfaces and `(13.3333/16)em` for wikitext surfaces. (That should have
been `(13/16em)`, by the way, but that's a negligible difference.)
Unfortunately, the font-size for wikitext surfaces is actually `13px`.
Unlike `em`, `px` values are not affected by custom browser font-size,
so when one was set, the final padding was all out of whack.
Use `rem` units instead to respect the custom browser font-size,
without getting problems due to the parent element font-size.
We don't need separate rules for .ve-ui-mwWikitextSurface now.
Bug: T222217
Change-Id: Ib7ffbf09d5aa23fddb894aa3b081ec993ddcee2d
New changes:
6bbfd9ecc Split TreeModifier into a tree diff generator and tree diff applier
f55f042dd TreeModifier: delete text nodes emptied by moveText operations
d7ccb2442 ve.ui.Surface: Fix check for active virtual keyboard in #adjustVisiblePadding
a9d533280 Localisation updates from https://translatewiki.net.
73a166cb0 build: Upgrade eslint-config-wikimedia from 0.13.1 to 0.14.0
077aaed03 build: Upgrade grunt-banana-checker from 0.7.1 to 0.8.1
81e2e57a5 Unwrap a solitary paragraph from data transfer items
Bug: T215567
Bug: T217769
Bug: T232942
Change-Id: Id943b49dd58a12553ddc19dcf8abcfb8e8a5b712
This meant we were returning invalid documents with bare content outside
content branch nodes. Instead let ve.ce.Surface in VE core do the unwrapping.
Bug: T232944
Depends-On: I8799d51958b966c99307f4c70546ea326e67385c
Change-Id: I0479116b51cc3135a992fdf36b8edfb2c44916ba
Follows-up 35eead0f3. This caused an extra stylesheet and HTTP
request to be added to all page views, because
'ext.visualEditor.desktopArticleTarget.noscript' is a styles
module, which should be allowed to join the regular batch.
Also remove it from other styles-only modules known to be loaded
with addModuleStyles().
Bug: T233095
Change-Id: Iea1f33199ec8dc83a42ac7102595a033300e33e6
New changes:
e31dae794 Update OOUI to v0.34.1
fa584b5c6 Localisation updates from https://translatewiki.net.
06548e806 ve.ce.Surface: Actually default to showAsActivated=true in #deactivate
Change-Id: I3879dfe180707aad775f6fe45b385e32f7ceed34
No longer needed after Id36aa6bdb8f873fe7deb8123a7fc774103721c01,
which teaches SpamBlacklist to return its own error messages.
Depends-On: Id36aa6bdb8f873fe7deb8123a7fc774103721c01
Bug: T211443
Change-Id: I462c2002f9b596cbdfd7ce3673d4e362e5bd1aaf
New changes:
79b8dde0b Localisation updates from https://translatewiki.net.
af9512298 Localisation updates from https://translatewiki.net.
564d90dee Test utils: Use current target in mock surface
dff861435 Don't apply surface padding in dialog target widgets
Change-Id: Ia85f5aed91aa3800878d6b470660826ba4ea8f45
The call to selectFirstContentOffset() below would re-activate the
surface and (attempt to) show the keyboard if the surface was
deactivated, but not shown as deactivated.
This might have worked correctly by accident before
I39fe44eee8eab7129340bcff796b6b9b3a59a398 in VE core.
Change-Id: I500309cc0aa8cd794175ae683a17c2614fd58cc9
Some post-save scrolling would try to access the view before the
handlers were cleaned up.
Bug: T232347
Change-Id: I30433ef027c52d541351972f8ebb09fe6d45e436
As of I6c043e039fbef62a56f475b0dc365e171ab7bf59, this method is never
called. It was previously used to update the size of the toolbar when
context menus were displayed inside it, but they are now displayed
elsewhere.
Change-Id: I53030de1203a7f0d75780ae796bbb10082d5ef7a
As of I2f2495ab6c10116a6660f4361e49272cb95b988a in MobileFrontend,
the overlay never uses the default spinner.
Change-Id: Ie0aa624e33a5bd21fc20459697cca175d9de5606
New changes:
d4cb2f03e Update OOUI to v0.34.0
b0b481693 jsduck: Stop listing OOjs in upstream, it's using JSDoc now
0b17a137b Update OOjs to v3.0.0
Change-Id: If29a97ce689523763431face5a13929a461735b4
New changes:
347e8622e Localisation updates from https://translatewiki.net.
f2b6e7db9 Upstream mobile toolbar flexbox layout
Change-Id: Id38a67050522f33a8a5d3228925b4518a138b2ac
New changes:
fc0875b19 WindowAction: fix documentation reference to Promise
6d32154b3 Update (remove) native selection when model selection is null
ce4a16063 ui.FragmentWindow: override action widget config on mobile for done actions
Bug: T228230
Change-Id: Ie42ba84a798c40cc7e2228f2beba23c32f6d7fc8
Unnecessary suppression causes build failures. Probably fixed by the
EditPage.php changes in e2e543f7c2a98f40c9b43ba3989d0f6689f4cb67.
Change-Id: I2ac7e95886ce6bef2ba08e1614728caae7d26442
