Alex Monk
87affb5ca4
Restructure education popup code to work without overriding onSelect
...
That code was breaking on mobile which uses a subclass of the normal
link inspector.
Bug: T117603
Change-Id: I75541230c21b1ee9eb73f6fb4b1fe5a5f9c14e75
2015-11-09 23:18:01 +00:00
Alex Monk
5f162522eb
Merge "ve.init.mw.DesktopArticleTarget.init: Make switching to VE for new pages work"
2015-11-09 22:42:34 +00:00
Translation updater bot
e87b56b53e
Localisation updates from https://translatewiki.net .
...
Change-Id: Ie37b9b551d0af53d2420af4a798a26c1954ecf0b
2015-11-09 21:50:10 +01:00
Bartosz Dziewoński
7d69e86265
ve.init.mw.DesktopArticleTarget.init: Make switching to VE for new pages work
...
Work around RESTBase problem that causes errors if we try to switch to
VE when the wikitext is empty. This would prevent non-power-users from
opening VE entirely.
This only solves the issue for new empty pages, and not when the user
intentionally empties the edit box. In that case, though, they get a
dialog where they can choose to "keep" or "discard" changes, and
discarding lets you open the editor.
Bug: T118152
Change-Id: Ie808bcaa9826deacac392dd6cbc90a9446602b79
2015-11-09 18:55:21 +01:00
jenkins-bot
b966333009
Merge "Unset 'action' query parameter from veEditUri, which should always point to VE"
2015-11-09 15:26:18 +00:00
Translation updater bot
280b68b183
Localisation updates from https://translatewiki.net .
...
Change-Id: I96650b4066bf3a33e0b31e53ddefa15dac49d5b7
2015-11-08 22:14:22 +01:00
Alex Monk
1e4889bbc7
Unset 'action' query parameter from veEditUri, which should always point to VE
...
Bug: T117780
Change-Id: I1377145bbbe05611ee75ae27922cf7a2cc5895e7
2015-11-08 20:32:28 +00:00
Translation updater bot
a8dbf5f828
Localisation updates from https://translatewiki.net .
...
Change-Id: I37ec76d17c9c7f24c6691d8cb85faf7422f28633
2015-11-07 22:45:38 +01:00
Alex Monk
3e23d3b96d
Only load switching module (depending on OOUI etc.) on edit pages
...
This wasn't as bad as T112401 (that was blocking render), but we
still shouldn't be loading the module on page views.
Bug: T118088
Change-Id: If86701ed7ff4e8d6defb1c682aa9a38c211be0fa
2015-11-07 19:08:29 +00:00
jenkins-bot
69bce26579
Merge "Drop any beforeunload handlers when loading from existing wikitext"
2015-11-07 16:09:50 +00:00
Alex Monk
6247a2f430
WikiEditor integration: Fix dependencies for switch button
...
Change-Id: Ic8fb607e8c467e89c0b9af0a9baab84e59b19ba8
2015-11-07 04:15:14 +00:00
Alex Monk
2910cd2384
Drop any beforeunload handlers when loading from existing wikitext
...
Bug: T117769
Change-Id: I823737b17e5af8ed15bc2b62db61a31886e8d418
2015-11-07 03:57:19 +00:00
jenkins-bot
4a582d7abf
Merge "WikiEditor integration: Only add VE switch button if VE is available"
2015-11-06 22:13:36 +00:00
Translation updater bot
5a771525dd
Localisation updates from https://translatewiki.net .
...
Change-Id: I50f024e4704930c59b8dd225f7ea975351c3e895
2015-11-06 22:29:08 +01:00
Alex Monk
87931fb3f2
WikiEditor integration: Only add VE switch button if VE is available
...
Bug: T117968
Change-Id: Ibfe73b7170083bc9ee0a0322768999c8650da4e7
2015-11-06 18:23:44 +00:00
Translation updater bot
db5c453648
Localisation updates from https://translatewiki.net .
...
Change-Id: Ifa98bbba31c83dbd4052674081333991cf7b473d
2015-11-05 21:46:47 +01:00
jenkins-bot
9f036c10f6
Merge "Update CommandHelpRegistry calls for breaking change in core"
2015-11-05 15:35:48 +00:00
Ed Sanders
216d0ea7a7
Update CommandHelpRegistry calls for breaking change in core
...
New changes:
281b543 Slugs: Remove vertical alignment hack
d6ddbe4 Localisation updates from https://translatewiki.net .
94bb263 Follow-up d6ddbe4: Fix build for added language 'sd'
bc8579d [BREAKING CHANGE] CommandHelp: Cleanup registry API
Change-Id: I65e2bfc299fbd60d6bdc7a57a030980b6cb8ab18
2015-11-05 07:29:44 -08:00
Bartosz Dziewoński
4a1a9bbf82
ve.init.mw.Target: Update TitleBlacklist error code
...
The error code has changed after T115258 and is now consistently
'titleblacklist-forbidden' for all TitleBlacklist errors.
The API now also provides information about the exact error message to
display (error.message) and the TitleBlacklist rule that matched
(error.line), but we probably don't have that message client-side, so
we're not trying to display it. Maybe when we can load it (T40280).
Bug: T116198
Change-Id: I32fccc7d0b2b66c739d59db05c568a56d9f07eec
2015-11-05 04:07:38 +01:00
Bartosz Dziewoński
8afae11a1c
ApiVisualEditor: Return the correct notice when user is not allowed to create page
...
'nocreatetext' is only the right error message when anonymous users
are generally not allowed to create pages on the wiki. But there are
other situations, for example a title might be blacklisted.
Change-Id: I7b8e83fa0bf98449e63e67705b709d227d9a379f
2015-11-05 04:02:42 +01:00
Ed Sanders
3716682570
CommandHelpDialog: Move registrations to where sequences are defined
...
Change-Id: I031575bbf40cd789252ac5e082bb5fa435eab257
2015-11-04 15:03:58 -08:00
Translation updater bot
3b6ee5ca68
Localisation updates from https://translatewiki.net .
...
Change-Id: I09939347d8aec3aadc28673736f50eba94b42c1b
2015-11-04 21:22:59 +01:00
David Lynch
6df227d4e0
MWCommandHelpDialog: update for core changes
...
Also: update VE core submodule to master (61f3fe7)
New changes:
4ef3666 Localisation updates from https://translatewiki.net .
cfa3482 Localisation updates from https://translatewiki.net .
d3486d4 CommandHelpDialog: Rename 'category' to 'groupName'
b5578d1 Localisation updates from https://translatewiki.net .
926595e Update OOjs UI to v0.13.1
61f3fe7 [BREAKING CHANGE] Create CommandHelpRegistry for CommandHelpDialog
Change-Id: If651ed30ab85175c7a262d9ccccc2e1613b0f3d6
2015-11-04 12:01:45 -06:00
jenkins-bot
dd897a3e67
Merge "Don't allow keeping changes when switching from wikitext *section* editing"
2015-11-04 16:34:54 +00:00
jenkins-bot
633bc55f9d
Merge "Apply same hide/show logic to both education popup dots"
2015-11-04 16:21:22 +00:00
Alex Monk
9c7a058b09
Don't allow keeping changes when switching from wikitext *section* editing
...
Bug: T117713
Change-Id: I16f17fa2aa4c9a1b74d8cde072c611e2685f5448
2015-11-04 16:19:36 +00:00
jenkins-bot
d24844af2e
Merge "Unbreak 404 handling code"
2015-11-04 16:06:09 +00:00
Alex Monk
6341c4a3b5
Apply same hide/show logic to both education popup dots
...
Bug: T117627
Change-Id: Icbde23f396935b7f6275ed89ce264ce5e49ebf6a
2015-11-04 15:56:40 +00:00
Alex Monk
dbf79f15fd
Unbreak 404 handling code
...
Broken in I2a529434
Bug: T117697
Change-Id: Ic34ef81afdde0851f4935971a808f22cdd5cde89
2015-11-04 15:31:19 +00:00
James D. Forrester
09800aa249
Replace 'source' icon with OOUI's 'wikiText' one
...
Change-Id: Id66d436b9140604ace7ebfbec1f80dc8f3830a20
2015-11-04 06:15:29 -08:00
jenkins-bot
3b30ea8916
Merge "Source icon: Use double brakcets"
2015-11-04 14:14:52 +00:00
jenkins-bot
4dacc683f5
Merge "Target init: Add edit mode switch icons to VE and WE toolbars"
2015-11-04 14:14:49 +00:00
Ed Sanders
42b3463e7d
Source icon: Use double brakcets
...
This is now a candidate for upstreaming to OOUI as the
'wikitext' icon, which is slightly larger.
Bug: T111038
Change-Id: I19a287926d6f100d2cb5ed1d713387a2dac56b37
2015-11-04 14:07:41 +00:00
Ed Sanders
b05d9fcb0e
Target init: Add edit mode switch icons to VE and WE toolbars
...
VE already has a a switch icon in the options menu, so bring that
up to the main toolbar.
Append an OOUI button to the WikiEditor toolbar if present, and bind
to the same functon as the edit tab.
Bug: T49779
Change-Id: Ic1e83ea7b13c4fef68024bf05ffc244060666103
2015-11-04 14:07:41 +00:00
Alex Monk
bc6fe7dc77
Set wgAction when messing with the action URL parameter
...
Also get rid of an unused variable.
Bug: T117596
Change-Id: I8479fa930397cff48c3a103f3a2c99e89190dc4a
2015-11-04 01:41:46 +00:00
Alex Monk
eb63b57d32
Fix check for loading from modified action=edit
...
Bug: T117596
Change-Id: Icad04dac7dc94927cff9b93b175d4a6c4dddee5a
2015-11-03 16:19:26 -08:00
Alex Monk
b550323b53
Use mw.loader.using instead of weird hacks to load OOjs UI on action=edit
...
Change-Id: If03dab6130aed7662b04000b809884a514bb2762
2015-11-03 23:55:17 +00:00
Ed Sanders
6dd7576941
AceEditorWidget: Add method to clear undo stack
...
After the widget is initialised the caller will probably
want to clear the undo stack, so that the first state
is the initial value provided.
Bonus: Add documentation for the widget.
Change-Id: Ia331acc4177e32784061cae55c450eb0f83fd744
2015-11-03 13:41:09 -08:00
Translation updater bot
a9befc64b3
Localisation updates from https://translatewiki.net .
...
Change-Id: I9dd2d16b514a0f576f6b886ba16c4db8fc112069
2015-11-03 21:54:34 +01:00
Ed Sanders
1b40e6434f
VESwitchConfirmDialog: Set pending on the correct button
...
Button indices were the wrong way around; find the button by
name to avoid future problems.
Change-Id: I778ff11875539d38f5a8905c9ff472fd3bd6baae
2015-11-03 18:58:59 +00:00
Ed Sanders
28a5d0db84
VESwitchConfirmDialog: Use modes to hide 'keep' button
...
Change-Id: I92110ea14ded335db330721c08314c7a20169886
2015-11-03 18:57:15 +00:00
Alex Monk
07c6c17e5c
Unbreak loading of VE in the read page
...
Change-Id: Ic3e4e65296fa63b3a7d5114366f2859f4ce3f21d
2015-11-03 18:16:47 +00:00
Ed Sanders
17898270ee
CommandHelpDialog: Move insertions into a separate group
...
Also add table and comment insertions.
Change-Id: If87261bf3d01854ab1f7ce1b447589fa8098dcf2
2015-11-03 17:03:56 +00:00
Ed Sanders
91152e2c05
CommandHelpDialog: Use new method for getting access key prefix
...
Change-Id: I85628e9282d7b78a4fdd2ea2f3b0b72019302dcc
2015-11-03 11:06:54 +00:00
jenkins-bot
36e2e85e53
Merge "Update VE core submodule to master (062cb26)"
2015-11-03 10:59:23 +00:00
James D. Forrester
c714eb173c
Update VE core submodule to master (062cb26)
...
New changes:
6cae77b ElementLinearData: Add another case to hasContent
d2e15f2 SurfaceFragment: Improve handling of delete all
16db2a3 Return 'null' instead of null in ve.Filibuster observers
24de6b2 Introduce key down handlers to separate logic from ce surface
f77fe99 Localisation updates from https://translatewiki.net .
062cb26 Localisation updates from https://translatewiki.net .
Change-Id: I61c94983c7898af219266af3022761638c7578b7
2015-11-03 10:36:53 +00:00
jenkins-bot
adb0c427ef
Merge "[PULL THROUGH] Remove resize detection now that TextInputWidget implements it"
2015-11-03 01:47:41 +00:00
Alex Monk
f71a5a5bca
Dialog for switching between wikitext and visual editing
...
Change-Id: I7046ffbe318d046b4baee11f4148ab77fc2af7fd
2015-11-03 01:36:29 +00:00
jenkins-bot
56af2bb742
Merge "MWSaveDialog: Fix styling of border radii"
2015-11-03 01:28:30 +00:00
jenkins-bot
cfef14dd4a
Merge "Tags: Switch 'VisualEditor' out for 'the visual editor' as elsewhere"
2015-11-03 01:24:38 +00:00