Commit graph

18330 commits

Author SHA1 Message Date
jenkins-bot 8a295512d3 Merge "Don't try to focus a removed template parameter" 2021-10-22 11:09:46 +00:00
Thiemo Kreuz 29ef00fa29 Rework all code using template type related conditions
This is a more radical change, compared to the previous patch.
I will post more detailled explanations as comments on Gerrit.

Change-Id: I6909b3f0b2c153b7ee9995441e995ffa793eab40
2021-10-22 10:42:16 +00:00
WMDE-Fisch 6e7332193b Add title to sidebar search
Also to improve screen reader a11y.

Bug: T291284
Change-Id: Ib56d3ee542cb880edd7788ff524a72436e102627
2021-10-22 12:34:57 +02:00
WMDE-Fisch 79f1270593 Add a11y label to sidebar parameter selection
Bug: T291284
Change-Id: I581800d2c92c06c3585ac48be0242860f476022b
2021-10-22 12:31:24 +02:00
jenkins-bot 66bcfc856b Merge "Set aria-multiselect on OutlineParameterSelectWidget" 2021-10-22 08:53:14 +00:00
Translation updater bot 9b6f7891d5 Localisation updates from https://translatewiki.net.
Change-Id: I83bcf0c42a2de2c2d7313d68ce86c1fb44a97246
2021-10-22 08:15:35 +02:00
jenkins-bot c78556c083 Merge "Handle annotation tags as nodes rather than metaitems." 2021-10-21 22:52:31 +00:00
Bartosz Dziewoński 5aa6b396e5 Update VE core submodule to master (7e8550432)
New changes:
36058d0b6 Localisation updates from https://translatewiki.net.
f80b286ed Update language lists
6f310f990 Prevent iOS Safari from re-focusing the doc when clicking on links

Bug: T293661
Change-Id: Idb60f983d5436fa909250614fa8a2ff90b991bae
2021-10-21 20:25:38 +02:00
Thiemo Kreuz 0a13fd9459 Use cheaper jQuery constructor for minor template param label
This is done for a lot of the elements in this class. They are trivial
jQuery elements instead of OOUI widgets. While we usually want to use
OOUI widgets, this is different in this case. Think of a template with
1000 parameters.

Bug: T291284
Change-Id: Ie1960ee706dca17aa4963c23a2e89c1cfff106f9
2021-10-21 15:55:13 +02:00
WMDE-Fisch b84d5f99d6 Set aria-multiselect on OutlineParameterSelectWidget
Bug: T291284
Change-Id: Iedb731d528b7f73c188aaa40eba74ba18dc8781e
2021-10-21 15:54:01 +02:00
Bartosz Dziewoński 661279f7be Update VE core submodule to master (b50ed2975)
New changes:
b50ed2975 Follow-up Ibac94edb: Fix offsets when rebuilding attachedRoot

Bug: T293254
Change-Id: I6beb4bf4e5fab9da140e2541e7c85dad54f92097
2021-10-21 12:00:29 +02:00
Thiemo Kreuz 937352a138 Don't try to focus a removed template parameter
The event "focusTemplateParameterById" targets the right side of the
dialog. The input field for the parameter should be focussed. This
doesn't make any sense when the parameter was just removed (i.e.
unselected).

Change-Id: Ie75b1edaebe9d0444b98e66cb56a5c7774393bea
2021-10-21 08:46:37 +00:00
Isabelle Hurbain-Palatin 3a3437007a Handle annotation tags as nodes rather than metaitems.
Preserve the place of annotation meta tags; adds information for the
users about annotation and, if necessary, annotation range extension.
The messages and individual handling of annotations for the annotation
range can be defined by the extensions: see I0b58a418 for an example
of how that can look like.

The structure of this patch closely follows the one from I104e7abbd
(handling of <noinclude> et al.).

Bug: T261181
Change-Id: I39029e4a63d22b37107edec066006557bcff34bf
2021-10-21 10:39:04 +02:00
Translation updater bot 0a8b462b0f Localisation updates from https://translatewiki.net.
Change-Id: I6d86764d2ccf7359d9fbc0246a0e12cb0659500c
2021-10-21 08:22:55 +02:00
jenkins-bot fed17e94b6 Merge "Give skins/extensions ability to trigger VisualEditor" 2021-10-20 23:45:14 +00:00
jdlrobson d5b3d2bcbe Give skins/extensions ability to trigger VisualEditor
It should be possible for extensions/skins to trigger the click event

It should be possible to do $('#ca-edit').trigger('click') so that
Vector's sticky header can trigger the VisualEditor.

Bug: T293159
Change-Id: I58625ffca982edfbc4cdcb14a666d79093e1b89d
2021-10-20 16:20:02 -07:00
jenkins-bot aaeb144b85 Merge "Update VE core submodule to master (386526a35)" 2021-10-20 18:47:20 +00:00
jenkins-bot 1d6d0b6264 Merge "Change template dialog hotkeys" 2021-10-20 18:35:30 +00:00
jenkins-bot 92df44d952 Merge "Workaround to prevent removing the selected item" 2021-10-20 17:49:49 +00:00
WMDE-Fisch 2f9fe11231 Change template dialog hotkeys
Changed to be less conflicting see investigation in ticket.

Bug: T290262
Change-Id: If2b75cb1dd8bb26c685f8e51beebfa0e6ab6599c
2021-10-20 10:53:44 +02:00
Translation updater bot a0cfdf7cde Localisation updates from https://translatewiki.net.
Change-Id: I67ef6fff8b227267b3553de27840eb0262bc8928
2021-10-20 08:38:09 +02:00
Adam Wight 5a451e0dd8 Workaround to prevent removing the selected item
Removing the selected item causes StackLayout to select (and scroll
to) its first item.  To prevent this, we preemptively unselect.

Note that even when an unselected item is removed, StackLayout still
clears the selection, so this patch doesn't lose any useful
behaviors.

Fix should be pushed down into OOUI, unless there's a use case where
we want to select the first item?

Bug: T293635
Change-Id: I0c1fddfa32b76621a9f1328c8173f0158386aee8
2021-10-20 00:07:18 +02:00
James D. Forrester b9f3073e5a Update VE core submodule to master (386526a35)
New changes:
f233370d6 Localisation updates from https://translatewiki.net.
df49011d1 Give nails a width to 0.1px to allow cursor placement at end of paragraph
386526a35 Never infer a mobile link annotation click from the DM

Bug: T274068
Change-Id: I39fecc036cbb3e11200b687530c74465ccfb121b
2021-10-19 13:16:08 -07:00
Ed Sanders abcd8428fa Fix rendering of render-less templates in preview snippets
The signature of createInvisibleIcon was changed but this
was never updated.

This fixes invisible template renderings inside previews, e.g.
inside the reference context item for:
<ref>{{InvisibleTemplate}} Content</ref>

Change-Id: I3d1b7a177408032957ac3fa8ead813438aa6bda7
2021-10-19 15:32:00 +01:00
Bartosz Dziewoński 9f9f27eb08 Fix unintentional raw HTML message
Change-Id: Ib5d37d4bdc8a36f7b077995d35cea70fb84e4476
2021-10-18 22:37:25 +02:00
jenkins-bot 185d5be1ee Merge "Localisation updates from https://translatewiki.net." 2021-10-18 14:02:23 +00:00
jenkins-bot dfa08be3f5 Merge "Don't close the old sidebar when the add parameter button is pressed" 2021-10-18 14:02:21 +00:00
Translation updater bot 47fa7bc308 Localisation updates from https://translatewiki.net.
Change-Id: I6dcd90a920473f3811d302b21571aca72cbb2fdc
2021-10-18 15:21:43 +02:00
jenkins-bot 99f7acddf7 Merge "Auto hide the sidebar when only a single placeholder is present in narrow mode" 2021-10-15 08:13:41 +00:00
jenkins-bot 2873d4b328 Merge "Fix broken focus when using the add parameter button in the old sidebar" 2021-10-15 08:08:06 +00:00
jenkins-bot 8b2c78222f Merge "Update VE core submodule to master (4373b0a6e)" 2021-10-14 19:18:10 +00:00
jenkins-bot 9521442b04 Merge "Add mobile 'content' class to visual diff" 2021-10-14 19:18:07 +00:00
jenkins-bot c5e6c9f9e1 Merge "Minor documentation fixes" 2021-10-14 19:07:09 +00:00
Bartosz Dziewoński e389e7ebfe Update VE core submodule to master (4373b0a6e)
New changes:
e1ada5fd8 Localisation updates from https://translatewiki.net.
4373b0a6e Create new stacking context for diffElement

Bug: T292491
Change-Id: I0399a57443404e20066c3292b78fe01f6947faf3
2021-10-14 20:48:58 +02:00
jenkins-bot 9d199fb287 Merge "Replace IIFE with block scope in ES6 code" 2021-10-14 17:55:55 +00:00
Ed Sanders 789519012e Add mobile 'content' class to visual diff
Bug: T293392
Change-Id: I7d0d6fee5a50fc2d965ebf0ad20c49dd26c70901
2021-10-14 17:26:03 +01:00
Ed Sanders e1fb20d8be Replace IIFE with block scope in ES6 code
Change-Id: I635f72a62ae44943a7705d28e92c9a0d265800b6
2021-10-14 15:11:45 +01:00
Andrew Kostka bf846d2313 Don't close the old sidebar when the add parameter button is pressed
Change-Id: I635d741a028196d9ad3b68cb26e5eac58b199fe5
2021-10-14 13:59:46 +02:00
Andrew Kostka 18964cdf2c Fix broken focus when using the add parameter button in the old sidebar
Bug: T293203
Change-Id: I9b9658ea05afe9c0d76e0956e8037842f540f74d
2021-10-14 13:43:35 +02:00
Svantje Lilienthal 9b9c6ff492 Remove focus from first input field when clicking on template name in sidebar
Bug: T293250
Change-Id: I017bd9fa5e566762b78e354f9ff94902b2c8968a
2021-10-14 10:25:34 +00:00
Andrew Kostka 0350b742c8 Auto hide the sidebar when only a single placeholder is present in narrow mode
Bug: T293202
Change-Id: I0226ca7d39e04a69617c0d8a5d3c293cfc9e0709
2021-10-14 11:37:23 +02:00
Bartosz Dziewoński 4e2318f2f0 Fix value of 'namespacesWithSubpages' in wgVisualEditorConfig
After filtering the PHP array to only include the ids
of namespaces with subpages enabled, add an array_values()
call so that the ids are again indexed numerically beginning
from 0, which is needed for the array to be passed to the
JavaScript as an array rather than an object.

Bug: T293310
Follow-up: Ia0ecac71721eceed52cc90f39ecc560bdf1b7f9b
Change-Id: I45bb281314caf5da0b7836829eb44f858836566f
2021-10-13 23:50:39 +00:00
jenkins-bot a0eb10487a Merge "Revert "build: Remove max-len over-ride (leave as warning)"" 2021-10-13 18:31:15 +00:00
Bartosz Dziewoński fa629a42a9 Update VE core submodule to master (35412f822)
New changes:
026d0cb4f Localisation updates from https://translatewiki.net.
f16f2179c Never rebuild above the attachedRoot
78bedf8be ElementLinearData tests: Refactor for loops
aed112aa8 Follow-up Ia593dad856: Use set data when changing character in sanitize

Bug: T293254
Change-Id: Ic5d5c1b77ae86eb18ebcb250c4b9c0ed64ccba6d
2021-10-13 20:04:55 +02:00
Ed Sanders 295d139ef1 Minor documentation fixes
Change-Id: I6822c04c8d160431510e62752783e6829950dc36
2021-10-13 14:02:57 +01:00
Ed Sanders 3801aa1bac Move var declarations inline
Change-Id: I12639c515e33b3d9e7a819581b5022ea42fd7046
2021-10-13 14:02:31 +01:00
Esanders aaf27e3901 Revert "build: Remove max-len over-ride (leave as warning)"
This reverts commit 2c75722ff1.

Reason for revert: Creates too much warning spam (>50) which makes
errors hard to spot. Most of these should be fixed before enforcing
the rule.

Change-Id: I8a785ec73d3429d4681d5c965a0efdbf0c86893d
2021-10-13 12:54:46 +00:00
jenkins-bot ebeeed35bb Merge "Remove duplicate load error handling code" 2021-10-12 16:07:07 +00:00
jenkins-bot 48f6436034 Merge "ve.dm.MWExtensionNode: Clarify documentation of 'extensionName'" 2021-10-12 13:52:20 +00:00
Bartosz Dziewoński e603613a7c ve.dm.MWExtensionNode: Clarify documentation of 'extensionName'
Bug: T291900
Change-Id: I70db47747aef7693ade6b8b7ea68e6212f78fe29
2021-10-12 00:16:42 +02:00