Commit graph

15234 commits

Author SHA1 Message Date
James D. Forrester 169602ea44 Update VE core submodule to master (bef57a528)
New changes:
7bd7f4143 Cache calls to ve.dm.Document#getBranchNodeFromOffset
870b49f1a .eslintrc: Enable and fix "max-statements-per-line": 1
aeb21bd1e Unit tests for TransportServer
158a8eeb3 Refactor ve.ce.*Selection#getDirectionality
10990294a Store and verify unique server ID

Bug: T208228
Change-Id: Ib9f4114ac2dbd966644eb55cbb1f7d1cd74ec0a7
2018-10-30 07:41:29 -07:00
jenkins-bot 357bda995f Merge "Update VE core submodule to master (c8e22de61)" 2018-10-30 10:47:24 +00:00
jenkins-bot c01c178ae3 Merge "Update VE core submodule to master (236effcd7)" 2018-10-30 10:47:20 +00:00
Bartosz Dziewoński af1a898380 ve.ui.MWMediaDialog: Open to the "Upload" tab when dropping/pasting file
Bug: T208286
Change-Id: I1f203b3a9b9401de22420e21f5553c78321cdbf8
2018-10-30 03:07:30 +01:00
jenkins-bot a0e73a1a80 Merge "Add another test case for stripping RESTBase IDs" 2018-10-30 00:22:42 +00:00
Ed Sanders f8bfe84bc6 Update VE core submodule to master (c8e22de61)
New changes:
3d2ffae4e [BREAKING CHANGE] Have ve.htmlMsg return a node array instead of jQuery collection

Local changes:
* Have ve.init.mw.Platform#getHtmlMessage return a node array

Change-Id: Iabd823c851f94356f1902918278f88068dfe4d25
2018-10-29 23:51:01 +00:00
Bartosz Dziewoński 9e47873a65 Update VE core submodule to master (236effcd7)
New changes:
0e923fe1b Use initClass in test class
900962720 Add ve.deepFreeze for detecting inadvertent data modification during testing
0761cd90c Localisation updates from https://translatewiki.net.
0e44545b7 Update .gitignore
82b6b80bb Use consistent method for finding nearest cursor offset
0b604de30 ve.ce.TableArrowKeyDownHandler.test: Remove eww gross FIXME

Bug: T202359
Change-Id: I73c46edfbf66a0c76bc719010c017ef71670931b
2018-10-30 00:50:37 +01:00
Bartosz Dziewoński e7fd1ac847 .eslintrc: Enable and fix "max-statements-per-line": 1
I am surprised this was disabled. I investigated this after reviewing
some code by a new contributor which I was certain should have failed
the lint check, but passed.

Change-Id: I5b3c837b8ca3292f6e268b3922443bd9587eadbe
2018-10-30 00:19:16 +01:00
Jforrester 4e539c8e3d Merge "Use data.cloneElements when converting pasted wikitext" 2018-10-29 22:20:23 +00:00
Ed Sanders 16548af330 Use data.cloneElements when converting pasted wikitext
To avoid duplicate about attributes.

Bug: T204007
Change-Id: I97a92512d7b114ed46bc48d3d416eebc86df13f7
2018-10-29 21:36:10 +00:00
jenkins-bot 3dc5c2f7d3 Merge "build: Updating mediawiki/phan-taint-check-plugin to 1.5.0" 2018-10-29 20:41:52 +00:00
jenkins-bot 16e6856500 Merge "Update EventLogging code for Edit->EditAttemptStep schema migration" 2018-10-29 19:59:42 +00:00
Roan Kattouw 392e5a00a4 Update EventLogging code for Edit->EditAttemptStep schema migration
The schema itself is being renamed, many of the field names are
different, and two new fields were added (page_token and session_token).

Bug: T207803
Depends-On: I2949c9782669b75cf17978698c8cef21fdee6dea
Change-Id: I3ec11d74d71207acac130689bac93d5bf0c70715
2018-10-29 12:06:57 -07:00
David Lynch 803f476528 Analytics: track more things for Growth
Bug: T207802
Change-Id: I77652325ce7b9dda9c4f4a86c1d34421451cf025
2018-10-29 10:21:49 -05:00
jenkins-bot a022a27a30 Merge "Simplify handling of messages for section edit links" 2018-10-29 11:02:37 +00:00
jenkins-bot 89b061455d Merge "Use the right localisation message for edit tab on Vector skin" 2018-10-29 11:02:34 +00:00
jenkins-bot 9a5840d96d Merge "Define localisation messages for File namespace edit tab in visual mode" 2018-10-29 11:02:10 +00:00
Translation updater bot bce39bcb59 Localisation updates from https://translatewiki.net.
Change-Id: I8554f97e2fae61ccfd7c21d965a18650b3b3305b
2018-10-28 22:22:07 +01:00
Translation updater bot 0f52c1aa6a Localisation updates from https://translatewiki.net.
Change-Id: Iaa8b7d92d6daa583afdeb7b4624ac6551858b82b
2018-10-27 23:00:15 +02:00
Umherirrender ffd7ad22fc Start showing warning for deprecated PHP entry point
Change-Id: I9091c04b9902a57bee6c89e829efe40e8d1867a1
2018-10-26 22:26:40 +02:00
Translation updater bot 6b45167bed Localisation updates from https://translatewiki.net.
Change-Id: I8adff2cd879d7900e82dd386aebb5f3e418411c9
2018-10-26 22:24:18 +02:00
Umherirrender 44b43b3825 build: Updating mediawiki/phan-taint-check-plugin to 1.5.0
Change-Id: I1273bcfd31d7b950ddc47ff921c909f05282e54d
2018-10-26 20:26:59 +02:00
Translation updater bot 04c938b33e Localisation updates from https://translatewiki.net.
Change-Id: If033e080b826af012a0000f4edb1b5c802718b97
2018-10-25 22:39:09 +02:00
jenkins-bot 991cc23020 Merge "Oversample Schema:Edit events when configured to do so" 2018-10-24 21:21:28 +00:00
Bartosz Dziewoński ac45e919ab Update VE core submodule to master (d89186159)
New changes:
d89186159 Add F2 keydown handler

Bug: T172042
Change-Id: I3bc2bb33bec2f5f08f26af49ab8b72e436dbe4cf
2018-10-24 20:51:36 +02:00
Ed Sanders ad3fc3c12d Add missing ce.Selection tests from core
Change-Id: I95f19bbf12e92b7062f3a332dc6c3d68cc6af492
2018-10-23 23:19:09 +01:00
Ed Sanders c895c60907 Add Promise.prototype.finally polyfill and restore failing tests
Change-Id: Ia6cdb85d33d2b3e0e2e868838defaa39ae60572a
2018-10-23 22:56:34 +01:00
James D. Forrester e4724b3f26 Update VE core submodule to master (6c288b44f)
New changes:
7c9fe89b8 Simplify ve.test.utils.runSurfaceHandleSpecialKeyTest API
0e3c75e66 Add more tests to LinearArrowKeyDownHandler
058362830 LinearArrowKeyDownHandler: Test Selection#extend fallback
8c6617d90 Keydown test refactor
91a909d63 Assert defaultPrevented state in KeyDown tests
003dacf3b LinearDeleteKeyDownHandler: Test shift+delete
1872158c5 LinearDeleteKeyDownHandler: Test delete next to link
b2af2a2c3 LinearEnterKeyDownHandler: Add more tests
4e5efa956 KeyDownTests: Remove unused constructor calls for all static classes
1cafb7328 KeyDown tests: Add tests for missing cases to cover tab/escape/enter
58af8d497 Add tests for ve.ce.AnnotationFactory/NodeFactory
617bc24a4 Delete unused ve.ce.modelChangeFromContentChange
50704fa1c Keydown tests: run asynchronously
af9a01b97 Use native promises instead of jQuery promises
df212669a Localisation updates from https://translatewiki.net.
f6af901dc Fix test in Chrome 70
9cc6dae7e Remove broken checks for DM code coverage
ce3a9199a LinearEnterKeyDownHandler: Add test for edge case
0a9dd3636 Remove false coverage of TableNode/TableSelection code
16679a3c0 Remove setupToolbar from DummyTarget to avoid false code coverage
7ac88df77 Basic tests for getClientRects in ve.ce.Selection and FocusableNode
78f14ac1f ve.ce.Selection: Add getDirection tests
7ec7efff0 KeyDown tests: Remove unnecessary setTimeout
26e022d23 KeyDown tests: Un-nest functions
df1e0af6c KeyDown tests: rename defer -> then
f03a9f90b Allow ES6 in tests
0ee55022b ES6 eslint follow-up
6c288b44f ve.ce.Surface tests: Trim when asserting expected text

Local changes.

Bug: T207077
Bug: T207078
Bug: T207079
Bug: T207080
Bug: T207083
Bug: T207654
Change-Id: I2e1f664d6f657e2ac26a271f401dc790c2a8b193
2018-10-23 11:49:34 -07:00
jenkins-bot 047f7bd596 Merge "Move styles that are not theme-wide out of themes/" 2018-10-23 10:28:32 +00:00
Bartosz Dziewoński aa137ef2ad Move styles that are not theme-wide out of themes/
Reasons why these files should not be in a directory named "themes/":
* They are specific to MediaWiki skins, not OOUI themes
* They are specific to one module, rather than affecting many widgets

The new locations/filenames are consistent with other modules that
have skin-specific styles.

Note that we have one more themes/ directory elsewhere in this repo
(and another in VE core) and that is okay.

Bug: T96704
Change-Id: I70bb61e339aeccb3afea657f665785ceaa091777
2018-10-23 05:04:27 +02:00
Translation updater bot cfacbf4746 Localisation updates from https://translatewiki.net.
Change-Id: I48d618ea77e87ad7a5d9ab7e3f56fe0fe2c34449
2018-10-22 22:15:43 +02:00
Translation updater bot a3cc7515b3 Localisation updates from https://translatewiki.net.
Change-Id: I7637a80063025c778cc0f17956fa0156a358fdb7
2018-10-21 22:37:52 +02:00
Roan Kattouw 0243fb1863 Oversample Schema:Edit events when configured to do so
Respect the config var exported by WikimediaEvents that, if set to true,
forces oversampling. When oversampling, all events are logged even if
they would have been sampled out. The isOversample property is set to
true if the event was oversampled and would not otherwise have been
logged.

Bug: T206543
Depends-On: I5fdf5fdd2dc0d99a0a0d7eb7ab2e3dce4798009b
Change-Id: I314da47d7d250672f1a9b34edeeeb720850f8fac
2018-10-19 22:29:41 +00:00
Ed Sanders 858d34ae31 Update VE core submodule to master (6cedee5ff)
New changes:
5b386d8da Move *KeyDownHandler tests into separate files
48ed2a670 Localisation updates from https://translatewiki.net.
e5a6d2a05 Move server.js to app.js
db38aa076 Separate Logger class
f1099fd48 Use service-runner
9d378d4cc Move util to /tools, make executable

Bug: T207287
Change-Id: I3163ed47c0bdeb72b229f6d4c0000e796e3d84fb
2018-10-19 00:23:11 +01:00
jenkins-bot 6758008628 Merge "Use Schema:Edit sampling rate config from WikimediaEvents" 2018-10-18 21:54:23 +00:00
Translation updater bot c26f80d097 Localisation updates from https://translatewiki.net.
Change-Id: I1ac635d2c02a258b744cd00b075f340cc4c735b3
2018-10-18 22:34:38 +02:00
jenkins-bot 4db6191652 Merge "Handle mw:MediaLink" 2018-10-18 03:34:21 +00:00
David Lynch 8c2a34b732 Handle mw:MediaLink
Bug: T198511
Change-Id: Ia7fbb9db79c9b776e0cf44b065c03b1aa090da79
2018-10-17 21:43:07 -05:00
Translation updater bot 5fd16bb7de Localisation updates from https://translatewiki.net.
Change-Id: I93028c508ca3998dbf7726d5e3fd22e87a8343fb
2018-10-17 23:44:38 +02:00
Roan Kattouw 8d08b032e7 Use Schema:Edit sampling rate config from WikimediaEvents
Instead of hard-coding the 6.25% sampling rate, allow it to be
controlled by the config variable in the WikimediaEvents extension
(which also defines the RL module for the Edit schema).

Also use sampling code from EventLogging so we can configure the
sampling rate as a number, rather than using a hex-digit based strategy.

Bug: T206543
Depends-On: I00383cec62f6c2a0137b329565b0ca84bfbb223f
Change-Id: Ia3e9a0f93d5d3001f222a64f31e82a63db36d7ab
2018-10-17 14:20:32 -07:00
James D. Forrester 63bb1354c8 Update VE core submodule to master (474034ad8)
New changes:
01729d1ec Localisation updates from https://translatewiki.net.
c33dc3b44 Asynchronous document store
70ee7c343 Tracking: various annotation and dialog actions

Bug: T202656
Change-Id: I99add8d3a1a9ecf9eaa70522dd49d3c64909a34c
2018-10-16 18:39:40 -07:00
Roan Kattouw d8ceb889b0 trackSubscriber: Use early return for 6.25% sampling
Rather than computing all the data then throwing it away 93.75% of the
time. Also use .charAt() for consistency with WikiEditor.

Change-Id: I6360b5c636e94db3483f542791d158f240c542f8
2018-10-15 15:05:27 -07:00
Translation updater bot d3d399b845 Localisation updates from https://translatewiki.net.
Change-Id: I477632773d59751873011fa1501db0e6767c4925
2018-10-15 22:16:11 +02:00
jenkins-bot 54abc29ca1 Merge "Improve the gallery dialog layout for mobile" 2018-10-15 10:19:41 +00:00
Translation updater bot da28f190ec Localisation updates from https://translatewiki.net.
Change-Id: I9698270527f007eb32052c1f8b6152486d91bd86
2018-10-14 22:25:47 +02:00
jenkins-bot f2dfb630b0 Merge "trackSubscriber: log activity events for VisualEditorFeatureUse" 2018-10-13 17:11:56 +00:00
Translation updater bot 5b9bfc2cae Localisation updates from https://translatewiki.net.
Change-Id: Ic1164dc5173c9e6a09827002b3092ce430303c6e
2018-10-13 10:19:29 +02:00
Bartosz Dziewoński 62273183a8 Simplify handling of messages for section edit links
Change-Id: I5b84fc3863747b4d092a7025475730bb28efeff2
2018-10-13 03:16:53 +02:00
Bartosz Dziewoński e048c3e188 Use the right localisation message for edit tab on Vector skin
Bug: T206892
Change-Id: If9494be10c684c1d8892a990dd7ba9c68caa4b69
2018-10-13 03:16:53 +02:00
Bartosz Dziewoński 6540bbd422 Define localisation messages for File namespace edit tab in visual mode
I think we must have not been allowing visual editing of File pages
when this code was written?

Bug: T206892
Change-Id: If38642492825877c4b65e395a00b789acdc27eef
2018-10-13 03:14:40 +02:00