Commit graph

16855 commits

Author SHA1 Message Date
Ed Sanders c8c81d2894 Grunt: Expand js{,on} pattern
Change-Id: I5061da3bced0a5c943038a9ec7bdbf8f38b35009
2019-08-05 21:15:37 +01:00
Ed Sanders d8461241f2 Update VE core submodule to master (aae84a489)
New changes:
1375d1500 Document that toJSON takes a key argument
27056b919 Localisation updates from https://translatewiki.net.
aa52f476f Only create context footer on mobile
ab6d942c5 Deactivate surface during replaceAll
aae84a489 MobileContext: Ensure isVisible returns true while opening

Bug: T229734
Bug: T229879
Change-Id: Ic03c22a785a2e9e8a4d38c17789ea2d4f16ef3ed
2019-08-05 21:13:05 +01:00
Ed Sanders bae45b63d2 Use flexbox for mobile toolbar
* Makes edit tools equal width
* Improves horizontal alignment within tools

Change-Id: I01b9668b638c21607b12381efc198edfe02f23da
2019-08-05 12:01:32 +01:00
jenkins-bot 644f409d61 Merge "Use MobileFrontend license message on mobile when available" 2019-08-02 22:12:12 +00:00
Ed Sanders 0b1f0a0eda Use MobileFrontend license message on mobile when available
Bug: T229579
Change-Id: I861f0d997607a34ca04727afd55771cbf14e253b
2019-08-02 16:29:54 -05:00
jenkins-bot a0a8213dc0 Merge "build: Upgrade eslint-config-wikimedia from 0.12.0 to 0.13.1" 2019-08-02 18:38:56 +00:00
James D. Forrester 67087af16d Update VE core submodule to master (0de28ce64)
New changes:
cd5e54f78 MediaSizeWidget: Make methods chainable
1606e2dd5 Localisation updates from https://translatewiki.net.
5a2f5fdb5 ve.ui.AnnotationInspector: Select inserted elements (not text) after inserting
6f2206ee2 Fix ve.dm.Change#toJSON to cope with arguments passed by JSON.stringify
7c78f1db7 Document ve.dm.TransactionProcessor#process better

Bug: T227630
Change-Id: Ic79e8bb8ef9a6288d80b591a83bf43cafc83743d
2019-08-02 10:26:51 -07:00
James D. Forrester 05fb44ae56 build: Upgrade eslint-config-wikimedia from 0.12.0 to 0.13.1
Change-Id: I43f407da92f59a8bf758cc2586e84aa5e18d9ab0
2019-08-02 09:51:07 -07:00
James D. Forrester dce6efb31e Update VE core submodule to master (a7d95c35b)
New changes:
d6d0ff8ce Localisation updates from https://translatewiki.net.
f57c6344c Move common code from FragmentDialog and FragmentInspector to FragmentWindow
a7d95c35b build: Bump lodash for npm audit

Change-Id: Ide09983d0b8c2006b25ab257fc048416a83b50c6
2019-07-31 18:50:04 -07:00
Ed Sanders 89ecd64a55 Make extension body the default description for extension nodes
Change-Id: Ifada2a6a0279e64a1ba82f49e03884e362516a83
2019-07-31 16:38:27 +01:00
jenkins-bot 51b93cea94 Merge "ve.init.mw.DesktopArticleTarget: Fix generated URL when loaded using veaction=edit in single-tab mode" 2019-07-31 13:28:59 +00:00
jenkins-bot 2d2e7dcdb2 Merge "ve.ui.MWLinkAnnotationInspector: Correct code comment" 2019-07-30 23:58:16 +00:00
Bartosz Dziewoński 7d3154fea8 ve.init.mw.DesktopArticleTarget: Fix generated URL when loaded using veaction=edit in single-tab mode
We were incorrectly always adding action=edit to the URL in that case.
The condition was always passing because `this.section` is `null` when
unset, but `this.currentUri.query.section` is `undefined` when unset.
This is a similar fix/bug to a68cc38b22.

Bug: T209163
Change-Id: Ic80ac377b763aea53678c4209ba6b3a6ba2996c9
2019-07-31 01:10:56 +02:00
Bartosz Dziewoński 0f5fe34534 ve.ui.MWLinkAnnotationInspector: Correct code comment
The way this works changed in ff9bf1fcb3 (2015).

Change-Id: I61617723ec6ada8018cdca55eb3fcc971796fded
2019-07-31 00:21:45 +02:00
Translation updater bot 06de101c54 Localisation updates from https://translatewiki.net.
Change-Id: I10fbdb1e085741706f650abd3fe74d3fde764954
2019-07-30 09:09:10 +02:00
Bartosz Dziewoński 7ac972d408 ve.ui.MWInternalLinkAnnotationWidget: Remove 'maxlength' to fix pasting URLs
Bug: T228240
Change-Id: I1f1be3a0893bdf8b7f9d07301ed01673eda8327d
2019-07-29 22:07:51 +02:00
Translation updater bot 982af588cc Localisation updates from https://translatewiki.net.
Change-Id: I0560fd667f24b8820c4bd56e224a4d8e24553940
2019-07-29 09:16:20 +02:00
Translation updater bot 8bd19828c9 Localisation updates from https://translatewiki.net.
Change-Id: Ic10e902185dbb343420c092f52a25c1e13253d9e
2019-07-27 09:32:02 +02:00
Bartosz Dziewoński 8dd0bd23d4 Work around a Parsoid bug with creating interwiki links
As detailed in T95850#5078990, Parsoid incorrectly converts HTML to
wikitext when a link `href` refers to an interwiki page and contains
percent-encoded colon characters ':'. VisualEditor doesn't know
anything about interwiki pages (it treats those links as normal local
links, and expects MediaWiki and Parsoid to handle them specially),
so we can't easily special-case them. But since leaving the colon
unencoded is valid for all links anyway, we can just do that.

Bug: T103635
Change-Id: I87d7e6952983a72d90ea739b0bc8488d9f6a9be3
2019-07-26 01:01:01 +02:00
James D. Forrester e0272fef60 Update VE core submodule to master (fe0f165df)
New changes:
2e14259db ve.ui.FragmentInspector: Fix positioning of additional actions

Change-Id: I1702552df1eba492251c8388710c8b2f194a0991
2019-07-25 13:52:43 -07:00
jenkins-bot 138c3eb53a Merge "ve.ui.MWLinkAnnotationInspector: Update size after showing/hiding errors" 2019-07-25 20:51:33 +00:00
Ed Sanders 32042d76e8 Update VE core submodule to master (fbbb9c4cb)
New changes:
854a1fa2c Distinguish active link styling

Local changes:
* Pull through active link styling

Bug: T228220
Change-Id: I925f88d32a514a749b96f501a211003bc4c924f0
2019-07-25 20:25:54 +00:00
Ed Sanders 9a1994e47c Update VE core submodule to master (7cb9caca1)
New changes:
28aea2e4d Edit cards v2 design
739017973 Track usage of the new "close context" button

Local changes:
* Edit cards v2 pull through

Bug: T222396
Change-Id: I1ca885e8d8127e7827a059755315ed789a7b9210
2019-07-25 22:24:48 +02:00
Bartosz Dziewoński 473bf1bf94 Update VE core submodule to master (e63fe33b1)
New changes:
e6531ada8 Follow-up 06f1ebb8: Drop deprecated ve.init.Platform methods
65a6870b3 Localisation updates from https://translatewiki.net.
e63fe33b1 Instrument ActionProcess for FragmentDialogs as well

Bug: T221305
Change-Id: I9e4d4249167dae7b8593c0fa88e6227c9714957d
2019-07-25 22:05:45 +02:00
Bartosz Dziewoński bfc549e720 ve.ui.MWLinkAnnotationInspector: Update size after showing/hiding errors
Change-Id: I84af3fbfea4aa89d76de95cfcdbfd3bc9e69ee83
2019-07-25 00:06:02 +02:00
David Lynch 5424a5e6bb Update VE core submodule to master (788d449ae)
New changes:
2d326b1fe Re-enable karma Firefox testing
4d95bdf2c ve.ui.Surface: Update iOS padding on focus/blur/activation
5cf567d34 Generalize the tracking of window opening

Bug: T200347
Bug: T221305
Change-Id: I3da0e81ac906f2426060fcaea4d268aa8b82e82c
2019-07-24 15:04:45 -05:00
Ed Sanders b35241497a Use type=url for external link input
Change-Id: I13cfdaaf5e94f07d16270df2933d1b23cf9f0ff7
2019-07-24 13:50:11 +01:00
jenkins-bot ef25e831b9 Merge "MobileArticleTarget: Compat for OOUI scrolling fix on iOS Safari" 2019-07-24 11:34:23 +00:00
Bartosz Dziewoński cc1cb63aca targets: Fix silly indirection via a global variable
Since we're inside the Target instance, `ve.init.target` refers to
this object. Some of the code I'm changing even uses `this` instead
of `ve.init.target` on the next or previous line.

Most of the mistakes are a result of mass search-and-replace changes
(478b0bcb, e1a887cc), or moving the code from other classes (d294006d).
But I can't explain the "ve.init.target.getSurface().getDom()" line,
it would be good to figure out why it was this way before we change it.

Change-Id: I0d7c6a48369242d4c99620fcd775ab537420d84a
2019-07-23 22:39:47 +00:00
Bartosz Dziewoński 2b6857d89a Update VE core submodule to master (6045a533f)
New changes:
5e8865931 Don't hide the context when opening an inspector on mobile

Bug: T228229
Change-Id: I32ff3962cdff332d51f32c5c3fd36e8062c3ac6f
2019-07-23 22:13:39 +00:00
Bartosz Dziewoński 0fb7d5efda Update VE core submodule to 962335a40293cf4b1314c0236788f35f080ae877
New changes:
a06204317 Fix TableNode unit test getOffsetFromCoords failure on Firefox
dfe0eb025 Refactor mobile context logic into ve.ui.MobileContext

Local changes:
* Pull through for edit cards refactor

Bug: T227532
Bug: T228767
Change-Id: I6c043e039fbef62a56f475b0dc365e171ab7bf59
2019-07-23 22:13:27 +00:00
Ed Sanders 393de5985f Update VE core submodule to abf2bfa85e64e67cdf963601fe1da2a11fd9e89a
New changes:
1a7460058 Remove ve.newMobileContext feature flag

Local changes:
* Remove ve.newMobileContext feature flag

Change-Id: Ia8def997b7cba4623866080752b06068d2118cc3
2019-07-23 22:12:48 +00:00
jenkins-bot 3597db04e5 Merge "MWEditingTabDialog: Don't use ve.init.target because it may not be loaded" 2019-07-23 20:49:17 +00:00
daniel b898c417b4 Removes forward-compat code needed for method rename in core.
Depends-On: If47a93878f87d69800e5f305404c22528dac5e94
Change-Id: I2181f1a39b47078a32a8de68ac63d3144fc5b807
2019-07-23 21:38:52 +02:00
Bartosz Dziewoński a5867818ff MWEditingTabDialog: Don't use ve.init.target because it may not be loaded
We also show this dialog on the old wikitext editor, where
ve.init.target is not set, because the relevant code is not loaded.

Follow-up to 478b0bcbb9.

Similar to e88cd81f94, which fixed the
same issue in a different file.

I checked all uses of ve.init.target in files under ve-mw/init/ and I
think this was the only remaining mistake.

Bug: T228684
Change-Id: I15551870cdb01d570e24ba9668e67330b8072e01
2019-07-23 19:09:37 +00:00
James D. Forrester df0e56a8fc Update VE core submodule to master (d33f296d1)
New changes:
da6d39555 Use collapsed selection for "set label" button on mobile
03d6ccf50 Localisation updates from https://translatewiki.net.
d33f296d1 Update OOUI to v0.33.4

Bug: T228227
Change-Id: I20e39928fb6ca6e0d72c399987d76cc579b4f842
2019-07-23 07:34:03 -07:00
jenkins-bot 81fda630e7 Merge "SaveDialog: Hide options bar when empty" 2019-07-19 18:44:46 +00:00
Bartosz Dziewoński c354e17388 Update VE core submodule to master (e2f4b0e96)
New changes:
1f9b02179 ve.ui.AnnotationContextItem: Use ve.ce.Surface's logic for detecting annotations
570acddfb Revert "Call handleInsertion on beforeinput"
e2f4b0e96 Localisation updates from https://translatewiki.net.

Bug: T217223
Bug: T227241
Bug: T227852
Change-Id: I439872773aee5a78928cf8af1a44c8eb080a8bf0
2019-07-19 18:09:51 +02:00
Bartosz Dziewoński b00190a398 MobileArticleTarget: Compat for OOUI scrolling fix on iOS Safari
Our overlay could be higher than the viewport, allowing the viewport
to scroll again.

Bug: T212159
Change-Id: I1e97d1963b214fc7673c33ae6c14ab7b0b80f31d
2019-07-18 02:11:53 +02:00
James D. Forrester c82238b0b6 Update VE core submodule to master (3d0cc9eac)
New changes:
9171b9afd Update OOUI to v0.33.3
d22e876e0 SurfaceFragment: Fix typo in docs
11b04e1b6 HashValueStore: Shortcut merge if other === this

Change-Id: Ibfe03293675f6484d0758ebc239246713bfa7d95
2019-07-17 14:38:09 -07:00
Ed Sanders 5aea61add7 Update OOUI icons names for article icons in link cache
Bug: T222079
Change-Id: I8ac2d02dfeaec3a197432d1718792a458d626917
2019-07-17 13:08:50 +01:00
jenkins-bot aca81dbca8 Merge "ve.dm.MWTransclusionNode: Protect <style> nodes too when copying" 2019-07-16 22:21:51 +00:00
Bartosz Dziewoński 59bc6f6a76 Add dependency on 'mediawiki.interface.helpers.styles'
This module is now needed to correctly display log excerpts,
like in our edit notices popup for protected pages.

Bug: T227190
Change-Id: I19dec69a33a2b3246ff1abe6bec90b2359ac36a4
2019-07-16 20:58:38 +00:00
Bartosz Dziewoński 3ca8319dfc ve.dm.MWTransclusionNode: Protect <style> nodes too when copying
Bug: T226374
Change-Id: Ie7853382642336638e0a1de9ca506d750ce054ce
2019-07-16 22:51:28 +02:00
jenkins-bot f0acb0d427 Merge "Update VE core submodule to master (311a3dff1)" 2019-07-16 15:41:49 +00:00
Ed Sanders 085764ddd6 SaveDialog: Hide options bar when empty
Since I7f6fd7ee9 it is now possible for the options bar to be
completely empty if the user is logged out. In this case hide
it and only show it again when the character limit needs to be
show.

Ideally we wouldn't have the height change, but it is quite rare
that a user gets to 400 chars and is logged out.

Bug: T228165
Change-Id: Ifbdf352afcbf4e549889e04fdb70fd30ce233aad
2019-07-16 14:28:25 +01:00
libraryupgrader ef3906b82b build: Updating dependencies
composer:
* mediawiki/minus-x: 0.3.1 → 0.3.2

npm:
* lodash: 4.17.11 → 4.17.14
  * https://npmjs.com/advisories/1065
  * CVE-2019-10744
* grunt-banana-checker: 0.7.0 → 0.7.1

Change-Id: Idaf7723adc2136f1fc39573897604c056f814e49
2019-07-16 04:47:13 +00:00
jenkins-bot 2d25d15a39 Merge "Add number of images to gallery context" 2019-07-15 23:26:30 +00:00
Bartosz Dziewoński 8aac97cc30 Update VE core submodule to master (311a3dff1)
New changes:
bb8471c98 Edit cards: Don't show keyboard when going from focusable to link
80feb00ae BranchNode: Add comment to internalItem hack
9c2f1241b FocusableNode: Avoid DOM manipulation in setup

Change-Id: Iad906dc3aeff1b777ad11f276a277381a99b4113
2019-07-16 01:06:27 +02:00
Ed Sanders c958ea383d Add number of images to gallery context
Change-Id: I3e54c6cb2b29ecb1153afd5f2f61adaabceb095b
2019-07-16 01:04:08 +02:00