Add a parentDoc parameter to the MWImageModel constructor and use
it to inherit language, direction and HTML document. Remove
getLang(), setLang(), getDir() and setDir() whose only purpose
was to propagate the language and direction from the parent document
in a hacky way.
Also add a parentDoc parameter to newFromImageAttributes(), replacing
the lang and dir parameters. Remove the unused and ill-conceived
caption parameter.
This causes caption documents to always have an HTML document
for URL resolution. Previously, this worked when editing existing
images because a document generated by cloneFromRange() (which
propagates the HTML document) was passed into setCaptionDocument(),
but it didn't work when creating new images.
Bug: T109599
Change-Id: Ida36862092cd779ffc2f04c0ecbc1164f8d71453
Add a parentDoc parameter to the MWReferenceModel constructor and use
it to inherit language, direction and HTML document. Remove
getLang(), setLang(), getDir() and setDir() whose only purpose
was to propagate the language and direction from the parent document
in a hacky way.
This causes ReferenceModel documents to always have an HTML document
for URL resolution. Previously, this worked when editing existing
references because the newFromReferenceNode() code path calls
cloneFromRange() which propagates the HTML document, but it didn't work
when creating new references.
Bug: T109599
Change-Id: I5d9d34d4343be8428318fa0b795fa54c110e34f4
New changes:
39bde8f Localisation updates from https://translatewiki.net.
1594ab6 Update OOjs to v1.1.9
e35bb54 Update OOjs UI to v0.12.6
6140eb6 Don't using start selection to position context for focusable nodes
81e5876 Localisation updates from https://translatewiki.net.
9123d3b [BREAKING CHANGE] Remove ve.selectEnd()
Change-Id: Icd1899b9e28bb12ab789f727a3f428b09a05fffb
New changes:
4344098 Increase width of desktop context, inspectors to 400px
0970f8a Refactor surface config compilation
58c0491 Put spaces between multiple links when pasting
9d13857 Localisation updates from https://translatewiki.net.
bf76dd7 LanguageInspector: Make the widget use one line for language
Change-Id: I79688eaf55547af8749230f589427df7ded5bcb0
E.g. when viewing User:Example/common.js there was previously
both Edit and Edit source (or Create and Create source) and the
client-side JavaScript then removed the ve-edit tab after checking
the content model for 've.isAvailable'.
Change-Id: Ic2daeefa439648ef0602f8606773655cf9ab188a
Collapsible relates to the Vector menu behaviour where an item
is moved into the dropdown menu if the window is narrow.
This should only apply to the secondary tab when there are two tabs.
If there is only one tab (non-VE, e.g. in a non-VE namespace) then
this tab should not be collapsible.
Server-side code handled this correctly, but client-side was
adding the class unconditionally.
Change-Id: Iecd195e92f43fe9f11b3938a1a24caed7b331e5f
Follows-up 6bc797f which added an early return in namespaces
where VE is not enabled. However, just like the init-init JS code
does already, we should still update the Edit tab message to say
"Edit source" regardless of whether VE is enabled.
After 6bc797f this started to cause a flash where the tab first
says "Edit" and then becomes "Edit source" client-side.
And since the Title::isKnown logic is not available client-side,
this actually exposed a bug with regards to MediaWiki-namespage
messages. Currently the client-side considers these "Create source"
when they are in fact "Edit" (or "Edit source").
Change-Id: If88d648b657d8a571beb7991805f8af8bd547975
This allows the URL paste handler to use the normalized title
as the text content. Add a test to cover this behaviour.
Depends on Ica48fea69cc in core.
Bug: T109980
Change-Id: I2784adaf2949a73256049921227dde0917ef9aef
Fix the back-reference to \1 (1st set of brakcets).
Add an test to make sure the example sequences actually trigger the
wikitextString handler, and tweak test to ensure that the start-of-line
restriction in the heading regexp doesn't affect link matches.
Change-Id: I76187a12292a4923d1ee2505cfb955431ac252bb
Also store the abortable API request so it can be cancelled
by the dialog.
To test this, put sleep(4); in ApiVisualEditor.php.
Depends on Ied21e574baa in core.
Change-Id: I83ffa9e0b7164ca4a34eae86cde452d8f38dc853
New changes:
736fe7f Localisation updates from https://translatewiki.net.
ed9a86f Don't autolink or autoconvert on "Paste Special"
35ffb6f Don't select pasted content
8a4fbe2 Localisation updates from https://translatewiki.net.
f62011c Move progress bar functionality up to DataTransferHandler
9abba55 Give links a getDisplayTitle method for use by transfer handler
7f1f965 Localisation updates from https://translatewiki.net.
0b3e045 ve.ce.Surface: Only perform blur-on-destroy hack if surface is focused
dbd6d88 UrlStringTransferHandler: Don't insert a space after URL paste
Change-Id: Ieb8cc541a189a0a5ff2e21077584a9c63c6c7d6f
New changes:
89f6c2d Strip trailing quotes when autolinking URLs
Local changes:
* Strip trailing quotes and non-URL characters when auto-linking
Update ve-mw to match I58a9c7f97ef10d9f495e65da17f208b9fc431aa4 in core,
since otherwise the ve.ui.LinkAction.test.js case with a quoted link
will begin to fail.
Make the set of stripped characters better match the combination of
EXT_LINK_URL_CLASS in the PHP parser and the explicitly-stripped
trailing punctuation in Parser.php::makeFreeExternalLink().
Add some international quotation marks while we're at it to make
everyone equally happy.
Change-Id: Iaffac4b073aeafa4f1137265c2d95e425c24d553
Depends on Ibdad2fa98fca08eeaa96bf33a08dd7723c1edb8c in Parsoid.
Depends on I3dcd289ed7b565b9162ee671038eeb45449e1215 in ve-core.
Bug: T109498
Change-Id: I5650410d7fca30c90baddd4f0c3f6d80e6b39042
New changes:
0590b07 build: Enable jscs's checkParamNames jsdoc rule and make pass
8b845d7 doc: Fix jsdoc for ve.ui.WindowAction#getWindowManager
3819ff6 Localisation updates from https://translatewiki.net.
94651ca Follow-up 3819ff6: Fix build for added language 'su'
5feb0c7 build: Enable jscs's requireParamTypes jsdoc rule and make pass
0605837 build: Enable the remaining jscs jsdoc rules we can
e70f972 build: Enable jscs's checkTypes jsdoc rule and make pass
44eb8fe Localisation updates from https://translatewiki.net.
dc7c8ed Make focusing surfaces work in Firefox
Change-Id: I11248b4c190839cb87948b13b844d6171341d5c8
Upgraded mw-selenium to 1.x, following the docs at
https://doc.wikimedia.org/rubygems/mediawiki-selenium/file.UPGRADE.html
Created an `environments.yml` file, converted page object definitions to
use relative paths, and refactored references to the global `ENV` using
methods of `MediawikiSelenium::Environment`.
Upgraded commons_upload as well to resolve a dependency conflict on
mediawiki_api.
Paired with: Rummana Yasmeen <ryasmeen@wikimedia.org>
Bug: T99661
Change-Id: I2a05cd816ea43afb48157e5dbe1ae42c6c124f6b
