Commit graph

11852 commits

Author SHA1 Message Date
Ed Sanders 7f31507e12 Link inspector: make height consistent
Make the DOM order sensible so we don't have to
use SearchWidget's position:absolute hacks.

Bug: T129173
Change-Id: I3517e0e0cfe2ab0eee4bed7390e41710d3140eb0
2016-03-08 10:26:31 +00:00
James D. Forrester 80139533ab i18n: Don't refer to the name of the tab in the beta notice given it changes
Change-Id: I9beb322aeabece0df483271b33dbaa41f5da732a
2016-03-07 16:58:32 -08:00
James D. Forrester b247ffd7bd i18n: Explain to returning users that their preferences are mutable
Change-Id: I8a47725d7271af54b30f2130e97b08edec0f0b59
2016-03-07 16:56:13 -08:00
James D. Forrester 9a6650ae1f i18n: Relabel the SET preference and dialog to 'mode'
Change-Id: Id876f4ba102800237cbc4a671d4db9a26f7f116d
2016-03-07 15:51:19 -08:00
jenkins-bot 8d7baccd5f Merge "DesktopArticleTarget: Add Edge and MSIE to whitelist" 2016-03-07 23:28:58 +00:00
jenkins-bot 7a5f34fac3 Merge "Education popup: Also handle clicks on dots" 2016-03-07 23:28:55 +00:00
jenkins-bot 1a64d83138 Merge "Simplify showtabdialog logic a little bit" 2016-03-07 23:28:50 +00:00
jenkins-bot 39f3cfa4a7 Merge "Keep summary and checkbox selections when swtiching WTE->VE" 2016-03-07 23:17:08 +00:00
jenkins-bot 075f569e51 Merge "Update ArticleTarget for new API token handling" 2016-03-07 23:14:32 +00:00
jenkins-bot 6ed2d23b13 Merge "Don't give the user the option to discard changes when changing editor" 2016-03-07 23:14:29 +00:00
jenkins-bot 15f8efed70 Merge "DesktopArticleTarget.init#getLastEditor: Check values for validity" 2016-03-07 23:14:26 +00:00
James D. Forrester 3986326050 Update VE core submodule to master (5d4881e)
New changes:
51c16df LinkAnnotationWidget: Implement createInputWidget's documented config parameter
6678cc3 Localisation updates from https://translatewiki.net.
5444bbe build: Bump various devDependencies to latest
c8c93ab Search documentNode for unicorn, not document
2cf61b6 Use normal whitespace for focusable nodes
628de0e DimensionsWidget: Return numbers as documented
7c48393 ve.ui.CommentInspector: Simplify autoresizing

Change-Id: Ic70cf04898beac2a675851925e4978593bc6ac39
2016-03-07 15:04:40 -08:00
James D. Forrester 79d1f92b42 DesktopArticleTarget: Add Edge and MSIE to whitelist
Bug: T128447
Change-Id: Ia7afe4ddd5abd4fd1de85ba2d2df1fefa6735d79
2016-03-07 14:58:10 -08:00
jenkins-bot 4d34f9ad75 Merge "Follow-up I65d96627: Remember the user's preference in WikiEditor too" 2016-03-07 22:31:54 +00:00
James D. Forrester d8eb68d7b6 Don't give the user the option to discard changes when changing editor
Bug: T128585
Change-Id: I02f31e46ae7b2dc7505ed55fc56cd00f538a90e3
2016-03-07 13:39:32 -08:00
Translation updater bot 98052e165d Localisation updates from https://translatewiki.net.
Change-Id: I1e160b1149c6f0a5abb31ad51ba0a099de151a1f
2016-03-07 22:27:34 +01:00
James D. Forrester b0407d840d Follow-up I65d96627: Remember the user's preference in WikiEditor too
Oh dear.

Bug: T129130
Change-Id: I12481ded12f99ab1ba59dbd403c1eed038235fd9
2016-03-07 13:03:35 -08:00
jenkins-bot 789979f223 Merge "Try to fix handling of empty document on WTE->VE switch" 2016-03-07 19:48:22 +00:00
James D. Forrester 302aeefd85 DesktopArticleTarget.init#getLastEditor: Check values for validity
Change-Id: I23e0884a97b3689dd42c3df11a6311cd0601c348
2016-03-07 11:27:23 -08:00
jenkins-bot fe19bfb0af Merge "Use iconWhenInvisible for alien extension nodes" 2016-03-07 18:34:38 +00:00
Ed Sanders bbf86a6768 Use iconWhenInvisible for alien extension nodes
Change-Id: I0bc9bfd040685855402f705f46973e36c42dc0db
2016-03-07 18:15:45 +00:00
jenkins-bot c930ac2779 Merge "Wikitext paste: Move MWWikitextStringTransferHandler matchRegExp into a registry" 2016-03-07 16:32:13 +00:00
Translation updater bot 4dd9110c18 Localisation updates from https://translatewiki.net.
Change-Id: I894adeef0ad09824fad0d3fff544ced1f7f3b1ae
2016-03-06 22:18:45 +01:00
Alex Monk 73969d74cd Simplify showtabdialog logic a little bit
Don't unnecessarily nest if statements, don't check tabs preference twice

Change-Id: I788d978b2e13030104be7ea295137a09abc032a8
2016-03-06 00:07:06 +00:00
Ed Sanders 5cc10a810a Wikitext paste: Move MWWikitextStringTransferHandler matchRegExp into a registry
This allows extensions to register their own rules for detecting wikitext,
e.g. matching '<ref>'.

Bonus: Strip the autogenerated <references/> tag which
gets inserted when converting a <ref>.

Bug: T128805
Change-Id: I7a38db45d25e86ff3f3f6199aa04425ec98f7cc4
2016-03-05 22:47:00 +00:00
Translation updater bot bcb8aed482 Localisation updates from https://translatewiki.net.
Change-Id: Icffb9dc8b7f78d2debad38046ba42ea678b969ae
2016-03-05 23:01:12 +01:00
Ricordisamoa 993015e03b Update ArticleTarget for new API token handling
action=query&prop=info was being used because it can be combined
with action=query&meta=userinfo, while action=tokens cannot.

However, since MediaWiki 1.24 the 'intoken' parameter of
action=query&prop=info is deprecated, while the preferred way of
retrieving tokens is action=query&meta=tokens which not only can
be combined with action=query&meta=userinfo but also spares the
need of dealing with page ids.

Change-Id: I5ded3c303ede20514eeb2840715fe240b3b2c7e1
2016-03-05 14:44:07 +01:00
jenkins-bot ea11c33e6d Merge "Handle API errors when refetching the edit token" 2016-03-05 02:16:32 +00:00
Roan Kattouw 6322be2e07 Handle API errors when refetching the edit token
This can happen when the user gets logged out on a private wiki.
We get a badtoken error, so we try to refetch the token, which
itself returns an error. Token refetches didn't have error handling
at all and got the save dialog stuck in the pending state.

We can't offer the user to proceed with a different identity here,
because we encountered an error while trying to figure out what their
current identity is. The best we can do is encourage them to
log back in in a different tab.

Bug: T128934
Change-Id: I17d4452f688ec22631dbd12af223731635004d66
2016-03-04 18:06:33 -08:00
jenkins-bot 074885d7cf Merge "Follow-up 2c24efae: fix typo in event name for unknown save errors" 2016-03-05 02:01:57 +00:00
Roan Kattouw 84d534997e Follow-up 2c24efae: fix typo in event name for unknown save errors
This probably means we stopped logging unknown save errors
back in August.

Change-Id: I4a5bac244a469e73643e8a7d978d9212dd838fb0
2016-03-04 17:31:40 -08:00
James D. Forrester 022d7c2694 Update VE core submodule to master (f77ac2b)
New changes:
4cef3da ve.test.utils: Don't require QUnit expect() anymore
70ee810 Localisation updates from https://translatewiki.net.

Change-Id: If37267012a10e611b3eae63e58a5da3c77ab8fdb
2016-03-04 15:56:36 -08:00
Translation updater bot 0d94d8312d Localisation updates from https://translatewiki.net.
Change-Id: I92baebf577ce098877cff730f2ff8de4974f79b2
2016-03-04 22:56:47 +01:00
Željko Filipin dc3944726a [BrowserTest] Disable failing language screenshots
Bug: T119482
Change-Id: I165fcb2ee94430d29e287b80e13a48e05a021f77
2016-03-04 15:54:13 +01:00
Alex Monk dde45949a3 Try to fix handling of empty document on WTE->VE switch
Bug: T128635
Change-Id: Iff83e1d71e7186b8da875aa507f9e19e8d9c23ce
2016-03-04 02:05:41 +00:00
Ed Sanders 67c207a6f5 Use abstract target widget creation
Change-Id: Ic7e43e80f4f48df99842cee702963d54205e5055
Depends-On: I6a667a641540b347052ea0c645af4e1e59cf333a
2016-03-03 11:49:44 -08:00
Ed Sanders d64436cc0c Use new surface executeCommand method
Change-Id: I84c718d9da4b7dd0627ba37d9c29c3a25cc5d73e
Depends-On: Id975ea9da43654cd9991a302b49a9fb32782078e
2016-03-03 11:49:44 -08:00
James D. Forrester 9e060a27e2 Update VE core submodule to master (46f34e1)
New changes:
a560a59 FocusableNode: forcibly update the active link on click
78572e8 FocusableNode: Clean-up CSS
1d5efd2 Pass command and sequence registries to the surface
0816db3 Abstract target widget creation

Change-Id: I93774021c41392e6e829904a571b703a0762d46b
2016-03-03 11:48:03 -08:00
Ed Sanders 62d16e5a8a Update VE core submodule to master (ac24b50)
New changes:
0b7e689 FindAndReplaceDialog: don't use tabindex
17b10a5 Localisation updates from https://translatewiki.net.
a4133e4 [BREAKING CHANGE] Make whitespaceHtmlCharacters a real static property

Local changes:
* MWEntityNode: Fix lookup of whitespaceHtmlCharacters

  Property is now in 'static', and use registry to look up
  TextNode by symbolic name.

Change-Id: Ied8c0c6feb69141c7c53fc4cc790774dee2cb63c
Depends-On: I7537b46a9fd58dfb2bd18dc4ed469aa221b96e86
2016-03-03 08:13:33 -08:00
Ed Sanders 115bf4b3d2 CategoryWidget: Remove reorder event fix after upstream fix
Change-Id: I9088c931433b0824f72b4c77d0fd05cb062068f7
Depends-On: I67945db3652b0edb24b490089b8ea5a43f0b29d0
2016-03-03 15:53:49 +00:00
Željko Filipin 8e0e40d5cc [BrowserTest] Fix Selenium::WebDriver::Error::StaleElementReferenceError
Sauce Labs browsers raise
Selenium::WebDriver::Error::StaleElementReferenceError
if a test tries to use an element but VisualEditor is not loaded.

Bug: T128731
Change-Id: Icb01b4dee256a0270d722492d11dabf0cfc4f8c4
2016-03-03 14:58:14 +00:00
jenkins-bot 659b9c3576 Merge "[BrowserTest] Fix ve.init is undefined and ve.init.target is undefined error messages" 2016-03-02 23:33:32 +00:00
Translation updater bot 61cda9824f Localisation updates from https://translatewiki.net.
Change-Id: Ife76752d154e4b595a570e8c8fefed114362dc9f
2016-03-02 23:40:57 +01:00
Alex Monk a3f77d9479 Education popup: Also handle clicks on dots
Bug: T128440
Change-Id: I25728cf3dd3462cb1a13476fe45d7fc3755429dd
2016-03-02 21:48:05 +00:00
Alex Monk 4ed6fd4010 Change Accept header a bit
Per post-merge commit on I77af4b58 by Subbu

Bug: T128233
Change-Id: I30c4c1ad5b68e5b8a006d7a6c7bcbaac7e2eb164
2016-03-02 15:37:37 +00:00
Željko Filipin 301b152ec8 [BrowserTest] Fix ve.init is undefined and ve.init.target is undefined error messages
Looks like local browsers raise
Selenium::WebDriver::Error::JavascriptError while remote (Sauce Labs)
browsers raise Selenium::WebDriver::Error::UnknownError if a test tries
to use an element but VisualEditor is not loaded.

Bug: T126966
Change-Id: I89c8eaba996e95e7859084fe26e15befee9dce77
2016-03-02 13:50:44 +01:00
Alex Monk 21334a0fa8 Keep summary and checkbox selections when swtiching WTE->VE
Bug: T128529
Change-Id: I8a7deac1c4d9390c1db7d78c3e0a11d927ef127b
2016-03-02 11:55:50 +00:00
James D. Forrester 078886b5a4 Update VE core submodule to master (6b85afc)
New changes:
2fe0d1a Localisation updates from https://translatewiki.net.
6b85afc Update OOjs UI to v0.16.1

Change-Id: If35da77772d2bd188fe26372a02fe8cbfa6e304d
2016-03-01 16:35:43 -08:00
Ed Sanders d94d98ebfe ArticleTarget: Update documentation
'onReady' no longer exists

Change-Id: I6fbcf619ba471f69380a64ba02994bd6ef0ca246
2016-03-01 22:03:07 +00:00
jenkins-bot 7d1ddae652 Merge "MWTemplateSpecModel: Use namespace constant" 2016-03-01 21:56:51 +00:00