Ed Sanders
470a4a551b
AceEditorWidget: Refactor to ensure setValue runs synchronously
...
Also ensure setEditorWidget is only called once when
loadingPromise resolves.
Change-Id: I1a95bda5e9ff17d7575326f29fa01d273193c4a5
2015-11-16 11:36:08 -08:00
Ed Sanders
b21b939a67
AceEditorWidget: Emit resize event at end of cycle
...
Ensures the widget has taken its new size before emitting the event.
Bug: T117926
Change-Id: If1dab2ecadb2a581100c0ae154b341ce8d173a7c
2015-11-13 18:48:35 -08:00
Ed Sanders
6dd7576941
AceEditorWidget: Add method to clear undo stack
...
After the widget is initialised the caller will probably
want to clear the undo stack, so that the first state
is the initial value provided.
Bonus: Add documentation for the widget.
Change-Id: Ia331acc4177e32784061cae55c450eb0f83fd744
2015-11-03 13:41:09 -08:00
jenkins-bot
adb0c427ef
Merge "[PULL THROUGH] Remove resize detection now that TextInputWidget implements it"
2015-11-03 01:47:41 +00:00
Ed Sanders
e582fae840
[PULL THROUGH] Remove resize detection now that TextInputWidget implements it
...
This depends on the OOUI release which contains Iaadaf1f9f.
Change-Id: I24d3756d627fc3514d8b476f9af87fdecbaa1e09
2015-11-03 01:13:26 +00:00
Ed Sanders
bd22be33db
AceEditorWidget: Preserve selection on setValue
...
Also avoid calling setValue when the value hasn't changed
so as not to pollute the undo stack.
Change-Id: I07fc5db0480a8583b361d472723f863ca90046f7
2015-10-30 16:14:09 +00:00
Ed Sanders
def886b845
AceEditorWidget: Make setters chainable and support invalid flag
...
Change-Id: I78f395459f526164c0c506beec62a0083817e64b
2015-10-27 19:02:17 +00:00
Ed Sanders
35b9c4119a
AceEditorWidget: Use mw.loader#getState instead of private moduleRegistry
...
Change-Id: I845651af837ccc042b6193876e17ba2b571dfe9c
2015-10-26 09:31:37 +00:00
Ed Sanders
21aec73795
AceEditorWidget: Use showLineNumbers instead of showGutter
...
The gutter is still useful even if line numbers are hidden.
Change-Id: Ia85ce7cd4987eb0b7022dc35cfd1029fbe78e3dc
2015-10-23 00:04:57 +01:00
Ed Sanders
60c1ee7d56
Introduce Ace editor widget
...
The widget attempts to load the ext.codeEditor.ace.modes module
and if it fails, will fall back to regular TextWidget behaviour.
Bug: T49742
Change-Id: Ie483f6eba25e3732a396c18decc0e1844b806b23
2015-10-21 20:59:08 +01:00
