Commit graph

9344 commits

Author SHA1 Message Date
Ed Sanders c56a921585 Change command list from whitelist to blacklist
Also remove toolbar definitions as they can now be derived from
command availability.

Depends on If32d514a in core.

Change-Id: I2313f3cc2531686b27f96dc1110b28bb4b295f89
2014-11-24 18:28:37 +00:00
Ed Sanders 325bd0994e Filter out comments from external paste
Bug: T71821
Change-Id: I165efd75adf3d4092860c6d2bc408469dba31388
2014-11-24 11:20:18 +00:00
Alex Monk 1c04d32d75 Only try to close save dialog before destroying surface if it's currently open
Otherwise the closure promise will be rejected as it was already closed with
different data, if you ever opened and closed the save dialog before pressing
the 'Read' button. This means the code in the $.when will never be run, and
the surface never destroyed.

Bug: T75589
Change-Id: I3ffdd1c82506bcd2accc0f3fa113c0950a31918e
2014-11-23 22:30:40 +00:00
Translation updater bot 07a265c3a1 Localisation updates from https://translatewiki.net.
Change-Id: Ib4cb30426f2e42f56da8efa725f9a81259703ea3
2014-11-23 22:43:42 +01:00
jenkins-bot 6b11f8d05e Merge "Always return boolean from an action" 2014-11-23 21:21:58 +00:00
jenkins-bot b69fef2196 Merge "Focus the bookletLayout on ready in the template dialog" 2014-11-23 17:19:11 +00:00
Ed Sanders 2ee4fc0b36 Always return boolean from an action
Command#execute expects this so it knows if the action was
successful.

Change-Id: Iaef1b7d217f0a6cd848b8df4a920c6546a79f503
2014-11-23 17:19:10 +00:00
Translation updater bot a4986e0ee2 Localisation updates from https://translatewiki.net.
Change-Id: If3ccefe94168c271b5bb812a7367e2322cf5bc96
2014-11-22 22:44:08 +01:00
Ed Sanders 2653ce3bb3 Fix MW skin hacks
* Ensure surface widget font size matches main surface,
  move vector-specific hack to vector css file and fix.
* Fix base font size in non-isolated monobook windows.
* Move monobook z-index hack to global overlay only.

Change-Id: I1607dc77f81ac9c522e09a3b502aeb38fee02178
2014-11-22 17:52:46 +00:00
jenkins-bot 268a852455 Merge "Follow-up I19da270a: Make overlay appear above non-VE skin items in Monobook" 2014-11-22 02:29:01 +00:00
Roan Kattouw 9b3316a360 Fix the "you are now logged in/out" warning
It would tell you you were logged out when you were actually
logged in, and when I looked into it, I found lots of broken
things, including lots of confusion between the current
anon-ness and username and the new anon-ness and username.

ve.init.mw.Target:
* Check the new isAnon value, not the old one
* Pass the username to the event, rather than just anon-ness

ve.init.mw.ViewPageTarget:
* Use the passed username (new username) rather than the
  username from mw.config (which is updated, but confusing)

Change-Id: Icf406d49100d81e87c677fd6b57ff93cc29f601f
2014-11-21 18:23:11 -08:00
Roan Kattouw 0bc3edfd91 Focus the bookletLayout on ready in the template dialog
Depends on I60377cb5 in oojs-ui

Change-Id: I5d8b73f878bf136efdc97493ef1f6e7bd6f56066
2014-11-21 18:13:27 -08:00
Bartosz Dziewoński e2d4f5b533 [BrowserTests] Fix class name: ve-ui-contextMenuWidget → ve-ui-contextSelectWidget
Change-Id: I70f44e71819e9147886bd70baf3460daf9ebbaf2
2014-11-22 01:56:29 +00:00
James D. Forrester a8b4fc4966 Update VE core submodule to master (c8201dd)
New changes:
ff237d4 Fix z-indexes in core
e88d43e Localisation updates from https://translatewiki.net.
cf61803 Consistently use ve.ui.WindowManager everywhere
f9dfdb8 Update OOjs UI to v0.1.0-pre (23565e7519)
f79f7e3 Update OOjs UI to v0.1.0-pre (8f8896196f)
c8201dd Update OOjs UI to v0.1.0-pre (9ed4cf2557)

Local changes for the breaking change to OptionWidget and sub-classes.

Change-Id: Ife6abd312d4dc97be67cb84eea4cb9c6a0a31b1d
2014-11-21 17:41:04 -08:00
jenkins-bot 0ed86dd9da Merge "Add instrumentation for edit schema" 2014-11-22 00:26:31 +00:00
jenkins-bot adb186e454 Merge "OO.ui.WindowManager -> ve.ui.WindowManager" 2014-11-21 22:12:59 +00:00
Roan Kattouw 4cf254a31b OO.ui.WindowManager -> ve.ui.WindowManager
In keeping with Id6660a4b54 in VE core.

Change-Id: I6fa6c0cdc3e514a66889e41c2eb4c710650a3405
2014-11-21 13:58:53 -08:00
Alex Monk 9bb766c5bb Catch pagedeleted errors and give the ability to re-create the page
Bug: 52073
Change-Id: I86a6e1510ccb5e59e94a5262dd3ccd91fdf05a70
2014-11-21 21:44:15 +00:00
James D. Forrester 6f446e0d1a Follow-up I19da270a: Make overlay appear above non-VE skin items in Monobook
In I19da270a we bumped the z-index for the overlay from 4 down to 2, to avoid
clashing with the toolbar. However, the site logo, search box and personal
tools all have a z-index of 3, so 4 is required. Instead, bump the toolbar's
z-index up by 1 to 5.

Change-Id: I7e1edcf05cde054c7bcb8c13b5633930fb5ed3b5
2014-11-21 13:29:16 -08:00
Cmcmahon 34f3572372 [BrowserTest] love for test that targets test2wiki
Change-Id: Ie37d88e891b592745e8f430da4481f2f1d2bd530
2014-11-21 21:28:25 +00:00
Cmcmahon f7a7a89d00 [BrowserTest] remove tests from the Jenkins builds known to fail for Chrome
No combination of WebDriver for any version of Chrome on Linux
works 100% correctly.

Remove the failing tests for now.

Change-Id: I46be2c2c857e93234c839d32f1c0d4224733d0f7
2014-11-21 21:26:20 +00:00
Translation updater bot bc031a78ba Localisation updates from https://translatewiki.net.
Change-Id: I2cd1e9f2abf494d61a1a2011e7a271c0dd937f97
2014-11-21 22:12:28 +01:00
jenkins-bot 7416393354 Merge "[BrowserTest] consolidate some duplicate elements" 2014-11-21 20:30:28 +00:00
Cmcmahon 2449ebde99 [BrowserTest] consolidate some duplicate elements
and remove one unused

Change-Id: Ica50cf74edd9a21423800a7d58f4832b77a7e8bc
2014-11-21 13:28:01 -07:00
Roan Kattouw 6d21d83244 Add instrumentation for edit schema
Move ve.track() subscriber to its own file, and have it
route mwtiming.* events (for TimingData) and mwedit.* events
(for Edit schema) differently. Most of the data population
lives in the subscriber, so actual ve.track() calls are
pretty lightweight.

Existing ve.track() calls with timing data were kept with
their names intact for backwards compatibility, but
we may eventually want to throw them out and start from scratch.

ve.init.mw.ViewPageTarget.init.js:
* Remove old track subscriber
* Track init and ready events
* Remove old ve.track( 'Edit', ... ) crap that didn't work

ve.init.mw.ViewPageTarget.js:
* Fire the saveWorkflowBegin event before the save dialog
  loads rather than after
* Remove unnecessary this.events.trackSaveError() calls:
  TargetEvents already listens to these events itself
* Remove badtoken handler because all it was was an
  unnecessary trackSaveError() call
* Add abort tracking
** Pass trackMechanism through deactivate() and cancel()

ve.init.mw.Target.js:
* Add static.integrationType to populate the 'integration'
  field in the schema

ve.init.mw.TargetEvents.js:
* Simplify onSaveError* methods away into connect bindings
* Map track topics to mwtiming.* so they can be routed separately
* Track save-related mwedit.* events

Depends on I978eda96c in WikimediaEvents

Change-Id: Iae677d9b15c71d2b18e795bd5179d11876c06abd
2014-11-21 11:59:15 -08:00
jenkins-bot 1b3fe26a3a Merge "Move tearDownBeforeUnloadHandler() to cancel()" 2014-11-21 19:42:59 +00:00
jenkins-bot ad908a666d Merge "Prevent JS errors when surfaceReady fires after deactivation" 2014-11-21 19:41:00 +00:00
James D. Forrester a1d75042c0 Update VE core submodule to master (fb57e24)
New changes:
7d8ed7f Copy in some IE CSS hacks from ve-mw
a2e962e Update OOjs UI to v0.1.0-pre (20c61ec865)
d99c62f Update OOjs UI to v0.1.0-pre (d4cfcce969)
7fe02b3 Fix lots of spelling mistakes and typos

Local changes:
Remove redundant IE CSS rules since core's I013688c5

Bug: 73565
Change-Id: Ic60cd5290932ec38fab26492fffa17c3a8e91398
2014-11-21 10:28:34 -08:00
jenkins-bot d8b82d2de7 Merge "Fix lots of spelling mistakes and typos" 2014-11-21 17:54:05 +00:00
Cmcmahon 7c190978c9 [BrowserTest] RuboCop should not complain about number of lines in a method
Change-Id: I9d5f040c9a2da7a3d18e7cc62b79bc9274275274
2014-11-21 16:57:27 +00:00
Cmcmahon f6526cb0a9 [BrowserTest] comments for classes
Change-Id: I3d5e063ee4dd36632ab9c2a433660567b70777ea
2014-11-21 09:49:50 -07:00
Cmcmahon 473877202b [BrowserTest] rubocop change to an if()
Change-Id: I5ae9ec4d94af88fa67ac8de58a38b6ea03b14acc
2014-11-21 09:40:40 -07:00
jenkins-bot 3d61fe724d Merge "[BrowserTest] update Gemfile to prevent rubocop failures in gerrit" 2014-11-21 16:33:54 +00:00
Cmcmahon e89692ddf8 [BrowserTest] update Gemfile to prevent rubocop failures in gerrit
Change-Id: I9d98542583050829a63c297736c12d835aa55c2c
2014-11-21 09:30:04 -07:00
Cmcmahon 95a798867c [BrowserTest] rubocop proper format for comments
Change-Id: I2fe136f29e0bc430420a0931092695d3f4147112
2014-11-21 09:21:53 -07:00
Cmcmahon 1b69fc97c7 [BrowserTest] Fixed Style/SpaceAfterComma RuboCop offense
Change-Id: Ia11c32c74acf4c2226f84ea566f4074b193f4e20
2014-11-21 16:15:58 +00:00
Cmcmahon ede14c75fb [BrowserTest] rubocop updates to replace double quotes with single
Change-Id: I0608aea2bd634156bf800b3be47a5c2a6d9fadca
2014-11-21 09:06:09 -07:00
Ed Sanders 2997cee444 Fix lots of spelling mistakes and typos
Change-Id: Icf78d3d599326d3f12d09edcd2b8491ed35ade04
2014-11-21 13:00:50 +00:00
jenkins-bot c8028dfe06 Merge "Fix ridiculously small font size in overlays under MonoBook" 2014-11-20 20:01:22 +00:00
James D. Forrester 9afdcfe712 Follow-up I7eb0d0e: ve.ui.MobileContext.css doesn't exist any more, Toto
However, ve.ui.MobileContextOptionWidget.js & ve.ui.MobileContextOptionWidget.css
do, so let's actually use those…

Bug: 73646
Change-Id: Ie79fe549f146e0dfdf775594092211ecf97bc13a
2014-11-20 11:46:18 -08:00
Roan Kattouw 9ed9c6cfe0 Move tearDownBeforeUnloadHandler() to cancel()
Make sure it always gets torn down on deactivate, not
just on save. Otherwise we end up with multiple copies of it.

Change-Id: I7b95c316641fc48ce7087a0042ec6174fe03180b
2014-11-20 19:23:17 +00:00
Roan Kattouw 5317ce8082 Prevent JS errors when surfaceReady fires after deactivation
If you clicked "Read" while the editor was loading
(but only while the "Edit" tab was already active, not before)
then you could get in a situation where surfaceReady fired
on an already-aborted target, which caused JS errors.

It seems like we should clean more things up in this
case, but I don't know what they are. In any case,
we should not try to set things up on a non-activating
target when surfaceReady fires.

Change-Id: Id57bd63ff288156725e472e7d89009022090253a
2014-11-20 19:22:49 +00:00
jenkins-bot dc6eec0bb7 Merge "[BrowserTest] more rubocop style fixes" 2014-11-20 19:13:30 +00:00
jenkins-bot d8808da403 Merge "Insert last modified text as HTML" 2014-11-20 19:12:07 +00:00
Cmcmahon 2f05d1b10a [BrowserTest] more rubocop style fixes
Change-Id: Ibc1cabbdc00f569b10fd6aae0e5bb998211745b1
2014-11-20 12:07:45 -07:00
jenkins-bot 0394e23516 Merge "[BrowserTest] Rubocop style fixes" 2014-11-20 19:00:03 +00:00
Cmcmahon 65e4d91cf0 [BrowserTest] Rubocop style fixes
Change-Id: Ieb1ba49f2a987b41f82a3b66c542fba48313eb1f
2014-11-20 11:55:40 -07:00
jenkins-bot 921f606209 Merge "Remove unused CSS: toolbar contains no PopupButtonWidgets" 2014-11-20 18:27:55 +00:00
jenkins-bot 3bad2c8ffb Merge "Use super to call parent constructors" 2014-11-20 18:27:51 +00:00
Alex Monk 8a1adef97c Fix ridiculously small font size in overlays under MonoBook
Copy in the font-size:127%; rule from MonoBook's main.css which is applied to
div#globalWrapper

Caused by Id425c56d

Bug: 73660
Change-Id: I05502295b81c62fd1180dff860dea68d76c2dfa9
2014-11-20 17:56:38 +00:00