Commit graph

5 commits

Author SHA1 Message Date
Ed Sanders f81c4a6f8c Update VE core submodule to master (7a128e5)
Fix failing test in handleDelete. New functionality
moves cursor to content offset.

New changes:
fb595ea Also annotate metadata in TransactionProcessor
028e442 maintenance: Simpler OOjs UI pullthrough-script
fdd5e17 Follow-up I81663929: Use grunt git-build to ensure we get the hash
58db9a8 Update OOjs UI to v0.1.0-pre (a63f03882e)
c790488 Use more standard format for displaying keyboard shortcuts
c15a6f1 Add a ve direction class to all surfaces
5c3a914 Remove old ce-surface classes
2f565b6 Fix up selection after deletion if at non-content offset
7b39328 Correct various things in rangy-position to make it work in IE

Change-Id: Ia46f4c7ded52911574b6c1104682335aaaac08d5
2014-06-30 11:21:20 -07:00
James D. Forrester 0ffd654bed Bump copyright like it's 2014
Change-Id: Ic469ebda2c061dc7da0b4c1625f43a7be55da4fa
2014-01-05 20:06:50 +08:00
Ed Sanders 62e9b6a939 Prevent content selections ending up inside handlesOwnChildren nodes
The delete logic sees the caption inside the image as a valid place to
put a cursor and therefore a valid range to delete up to. This means
paragraphs can be merged into image captions by backspacing them in.

Add in a flag that keeps track of whether we are in a handlesOwnChildren
node so we can skip over them.

Bug: 57927
Change-Id: I19e91d2d3a871806d207cbd419f4a45e41d69dc0
2013-12-05 16:45:28 +00:00
Ed Sanders 96e2313e6e Genericise runSurfaceHandleDeleteTest to work with other 'handle' methods
We will want to reuse this test runner for handleEnter and handleInsertion.

Change-Id: I7489bf2d20fa17b1c164ff20e0cfcd9b9d5102d2
2013-12-02 15:52:44 +00:00
Ed Sanders bffa0df53f Prevent deletion of FocusableNodes from a collapsed selection
Instead select the node and require the user to press delete
again if they really meant to delete the node.

Also test cases!

Bug: 55336
Change-Id: I66520e18740e78ce6313f9b31bb575d06b91bea8
2013-10-09 17:41:31 +02:00