Commit graph

20351 commits

Author SHA1 Message Date
Ed Sanders 3d8315f4c3 Simplify code for showing "Loading" message in template context
Instead of passing a "teardown callback" to a specific dialog,
run the command as usual and clear the loading message once
the dialog has successfully opened.

Change-Id: Icacabb298f1a0d7a587ab8b992759b04ff59c5c3
2023-07-12 11:04:59 +01:00
Translation updater bot 5dc4f474b4 Localisation updates from https://translatewiki.net.
Change-Id: I779b27c282bf064800584e2d57f40f97efe36c68
2023-07-07 09:11:30 +02:00
Esanders b33bb734af Revert "Revert "Add tag when reference added to the page""
This reverts commit 235e5aca00.

Reason for revert: Re-applying with fixes

Change-Id: I9dc5a77045ea5f15c90cf84a15815e13dffd5739
2023-07-06 17:50:08 +01:00
jenkins-bot 25f7097e9f Merge "Revert "Add tag when reference added to the page"" 2023-07-06 13:04:30 +00:00
Bartosz Dziewoński 235e5aca00 Revert "Add tag when reference added to the page"
This reverts commit d4460219bd.

Bug: T341202
Change-Id: I8e608a5a34a3bb18d1994d5c182c3918e6d6f89d
2023-07-06 11:35:50 +00:00
Translation updater bot 5d902e4fde Localisation updates from https://translatewiki.net.
Change-Id: Ifdcb1c757ec4803f4e8f907381de31899d05ceab
2023-07-06 10:17:11 +02:00
jenkins-bot 7b121b4fec Merge "screenshots: Fix some bounding box reference elements" 2023-07-05 13:35:36 +00:00
jenkins-bot 81b256ca4f Merge "screenshots: Fix environment setup" 2023-07-05 13:32:32 +00:00
Translation updater bot f74aeaa843 Localisation updates from https://translatewiki.net.
Change-Id: Iee641fc5169a82b544fc3f9d037c5af52340dce8
2023-07-05 08:31:52 +02:00
Translation updater bot c9fceaedaa Localisation updates from https://translatewiki.net.
Change-Id: Ifac15d0fe9568b93b73e919113cac02e973c1864
2023-07-04 09:22:29 +02:00
Ed Sanders d4460219bd Add tag when reference added to the page
Bug: T325713
Change-Id: Ia4abe256c7ffffa749ad6cdb537dd26091ea07da
2023-07-03 15:09:12 +00:00
Ed Sanders d7d344035c Add tag when content added, according to EditCheck heuristic
Bug: T333714
Change-Id: Id806e6d4d856aead4af98d43078c534d4d46c7f0
2023-07-03 14:43:14 +01:00
Ed Sanders fc41331470 EditCheck: Exclude nodes that aren't at the document root (i.e. image captions, table cells)
Bug: T340086
Change-Id: I8f5343f908efb3d39f20be97d132b146115910f9
2023-07-03 14:40:21 +01:00
Ed Sanders d582c75a6f screenshots: Fix some bounding box reference elements
* $actions is now $after
* Use #ca-view to support Vector 2022

Change-Id: I458dff192fa5bca78e0d1cd99a38478bdf4865e3
2023-07-03 14:19:55 +01:00
Ed Sanders 7616f5124f screenshots: Fix environment setup
* Use global.langs instead of just langs
* Wait for new welcomeDialogPromise

Change-Id: I7c4d48bca47eb4ce1a699f9160a0176dc77faa4b
2023-07-03 14:13:22 +01:00
Translation updater bot 68983da916 Localisation updates from https://translatewiki.net.
Change-Id: I89bcf683d6cbdf86fe2bdb4a15e55423d19da5d6
2023-07-03 10:16:55 +02:00
jenkins-bot 55b04b8820 Merge "Replace the last use of mediawiki.Uri" 2023-06-30 19:57:45 +00:00
jenkins-bot 1d6a748fed Merge "Revert "Revert "Targets: Use align:'after' instead of actionGroups""" 2023-06-30 18:05:44 +00:00
jenkins-bot 4077345c73 Merge "selenium: run tests concurrently" 2023-06-30 08:18:03 +00:00
jenkins-bot 19904571b8 Merge "Replace ve-ce-surface-enabled with ve-ce-surface" 2023-06-29 19:32:36 +00:00
Bartosz Dziewoński 51b1d7eca7 Update VE core submodule to master (ba83e8451)
New changes:
18b02fdc2 Remove deprecated ve-ce-surface-enabled class
669699d6b Rename generated distribution file to desktop-dist-wikimediaui.html

Bug: T340124
Change-Id: I5b173a96817f4217824d8b132c96c8082c568b17
2023-06-29 20:40:08 +02:00
Bartosz Dziewoński bbda4fc160 Revert "Revert "Targets: Use align:'after' instead of actionGroups""
This reverts commit e2b5e2a1bb.
It should be safe to re-attempt this now.

Bug: T339317
Change-Id: Ia4ebb11ca162a4e6d985076ea2d2dd914d04fc1d
2023-06-29 18:17:01 +00:00
Ed Sanders d857750e12 Make better use of toolbar groups
Bug: T340751
Depends-On: Ie7ca24cbcd95baa082b3b1cb907354f6da21d93c
Change-Id: Ibcc81c90bc9ba6c5fd012c512daf861973b03b2e
2023-06-29 16:58:38 +00:00
Bartosz Dziewoński c245eeca17 Update VE core submodule to master (67a675fec)
New changes:
c46173a95 Localisation updates from https://translatewiki.net.
7cf3264b3 Localisation updates from https://translatewiki.net.
64a30dd23 Update language lists
eaf8355e0 Localisation updates from https://translatewiki.net.
4d3a8104a Make better use of toolbar groups

Bug: T340751
Change-Id: Iddab40b928944cfb43846e5d0b22b01c2df2d213
2023-06-29 18:58:02 +02:00
WMDE-Fisch 70128a0f21 selenium: run tests concurrently
Especially useful to reduce the job runtime here because the VE
tests are executed in a couple of CI selenium jobs of other
extensions.

Bug: T226869
Change-Id: I8a8eae8cf2d548b7c905f00e748974bc5a88d337
2023-06-29 15:14:05 +02:00
Bartosz Dziewoński b986645d0a Fix trying to get a PageRecord for a non-existent page
This reverts a change from 5a792b6558. The hook only requires
a PageIdentity, and we only used toPageRecord() because it takes
a parameter to read latest data, and toPageIdentity() does not.
Instead call another method to update the internal data within the
Title instance. Maybe it's not great to rely on this side-effect…

Bug: T340568
Change-Id: If9cbd95eb84b6c39bf50af4564710839628a9bc3
2023-06-28 21:58:31 +02:00
jenkins-bot 312b1c08ec Merge "Unwrap headings in lists (and <blockquote>) when pasting external HTML" 2023-06-27 18:18:16 +00:00
Translation updater bot 4467bdc37e Localisation updates from https://translatewiki.net.
Change-Id: Ifb1ef09ceebd950fc13a05386e1f8f4cd5edbbc8
2023-06-27 19:28:57 +02:00
Sam Wilson c5040810c7 Switch back to oo-ui-element-hidden from mw-diff-element-hidden
Using the OOUI class name is an established pattern outside of
OOUI widgets, so it's easier to stick with it for the diff page
hiding and showing (switching to and from inline/table diffs, etc.).

Depends-On: I805b6b71d8e137eaa3e000b15455557df42af838
Bug: T324759
Change-Id: I0300b40d4e79319592bfc1f57912460f65c7051c
2023-06-26 17:54:46 +00:00
Translation updater bot cd6c1c65f5 Localisation updates from https://translatewiki.net.
Change-Id: I2c6f8a915a3d900e200dc1e3cb156c692b2b87d5
2023-06-26 12:41:32 +02:00
jenkins-bot f22f0d4c68 Merge "React to hooks that are fired when inline switch is present" 2023-06-26 05:29:44 +00:00
hmonroy 4a028f1336 React to hooks that are fired when inline switch is present
React to hooks fired by core when the inline diff type switch is
present. VE needs to be able to disable the inline switch
when 'visual' mode is selected and enable the switch when 'wikitext'
mode is selected. When the 'wikitext' mode is selected and there is an
inline switch, the interface needs to show the diff type format previously
selected.

Toggle using new `mw-diff-element-hidden` class that is used by core so
that there's no clashes when hidding and showing the diffs.

Bug: T331589
Depends-On: Ie6a48e495f2bb299d8b984e7c40363d534c7915b
Change-Id: I4f790370dbfeb521f3b61c4d604245f77094abe9
2023-06-26 04:20:16 +00:00
Umherirrender 611b1988cf api: Remove old apihelp i18n description messages
No longer used since 1.33

Automatically removed message keys with "doc-apihelp-description" in qqq

Bug: T340253
Change-Id: Ic3d031da376b78d3ccfec27517ec9a288c54fdc4
2023-06-24 00:46:01 +02:00
Bartosz Dziewoński 5a792b6558 ApiVisualEditorEdit: Allow not returning the new revision content
Sometimes we call this API and then reload the page (or navigate to
another URL), without using the page content it returns. Save some
work and some data transfer and don't generate it in those cases.

Change-Id: Ic5fac61f3ef9b2dfce6ff757f1d414a9f41f217d
2023-06-22 21:08:15 +00:00
jenkins-bot 68265fcd14 Merge "Use new helpers to show the post-edit message" 2023-06-22 15:33:28 +00:00
Ed Sanders 94fb927242 Replace ve-ce-surface-enabled with ve-ce-surface
The former is deprecated, and not required here.

Bug: T340124
Change-Id: I874b40bd8288763aeba8946ce40cecfd27e47c1b
2023-06-22 16:26:47 +01:00
Bartosz Dziewoński dd509c1072 Use new helpers to show the post-edit message
Undo some changes from 95454e710f1b619f7c538bc1dc88f238409719ca,
as this functionality is now provided by the core code.

Depends-On: I1c9020b2efb2785279f5c09539a49208a310ccf7
Depends-On: Ifeffcf214719f0d5c1371dc7d51a410fb313c978
Bug: T338003
Change-Id: I90a618897699c844f9c558bbeb4d1563f8050fe3
2023-06-22 13:51:59 +00:00
Bartosz Dziewoński ac8f8791f1 Don't show edit notices popup after switching VE/NWE
The user has already seen the notices, and getting hit with yet
another popup doesn't feel nice.

Bug: T169179
Change-Id: I421e42d32cb67ea210644b705e9c6e5af74e75ee
2023-06-22 13:42:25 +00:00
jenkins-bot bc1a1494c5 Merge "selenium: Disable flaky test" 2023-06-21 21:13:05 +00:00
Kosta Harlan 85c3f13c2c
selenium: Disable flaky test
See https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php74-docker/43144/consoleFull

Bug: T296187
Change-Id: Iba71488ffb10b85598461c0d85fac99cc491a69e
2023-06-21 22:07:17 +02:00
jenkins-bot 1f76a0e8f7 Merge "Make "add undocumented parameter" hotkey ctrl+shift+d work much better" 2023-06-21 19:52:11 +00:00
Bartosz Dziewoński 2b8c3edab2 Replace the last use of mediawiki.Uri
Depends-On: Ia95a27c7d7ebc9e4779f82598152145f02993b29
Change-Id: I8736111c4ec3cf9a9480df2efbdf080b5d72d514
2023-06-21 15:35:06 +02:00
Bartosz Dziewoński a35698fea5 Fix '&editintro=…' not working on Vector with some settings
In Vector the edit tab links have an extra <span> inside, and so
we couldn't find the parameters in the <a> href, because we were
actually looking at the <span>.

It worked in cases where we override the edit tab labels, since
we trample over the spans, e.g. in multi-tab mode.

Bug: T56029
Change-Id: I96935490418d7c3be4d417aaa71cb6e9608fd77f
2023-06-21 13:08:05 +00:00
Bartosz Dziewoński d8c3d007ff DesktopArticleTarget.init: Remove error logging for URL errors
Detailed logging is no longer needed after T328094 was resolved.

Change-Id: I49fa8598aa442445e12e553ebfd6680d9fe12a1b
2023-06-21 15:07:47 +02:00
Bartosz Dziewoński 3008aaf325 ArticleTarget: Simplify switching to NWE with no changes
This code was identical to what happens if you just call
reloadSurface(), except for some half-hearted error handling.
We already do it this way when switching from NWE to VE.

Change-Id: I8027680b7ca272930b951d0403594679ef308083
2023-06-21 15:07:47 +02:00
Bartosz Dziewoński 99b326286c DesktopArticleTarget.init: Fix bad parameter to activateTarget()
The 4th parameter is a boolean 'modified', not a node. I'm not sure
what this was supposed to do. It looks like the parameter was being
ignored in all cases anyway.

Change-Id: I559ab2bdb02c4a3e39b44487cf36122332d61fd1
2023-06-21 15:07:47 +02:00
jenkins-bot ac4032eff5 Merge "Stop collecting stats per wiki" 2023-06-20 11:39:26 +00:00
Translation updater bot 93f8519c66 Localisation updates from https://translatewiki.net.
Change-Id: I2591b819d7d9e41d0d075ad8042e562df828cae5
2023-06-20 09:51:10 +02:00
daniel 4a2b3b580f Stop collecting stats per wiki
Having per-wiki statistics is neat but expensive. Now that VE has been
switched to not use RESTbase on all wikis, Go back to collecting
all stats under a single key. The relevant dashboards have already been
adjusted accordingly.

Change-Id: I9666bfa3fed547f3f619a9e0c9c24b9240edc359
2023-06-19 21:19:35 +00:00
Translation updater bot 4437dd2fd2 Localisation updates from https://translatewiki.net.
Change-Id: Iec733b7bd761300bf844eeca6993ffca94b82bcf
2023-06-19 11:08:25 +02:00