Commit graph

19171 commits

Author SHA1 Message Date
jenkins-bot 5ac61e20ed Merge "ve.dm.MWGalleryImageNode: Add width/height attributes back to images" 2022-05-24 01:39:56 +00:00
Ed Sanders 5d060c34cc GalleryImageNode: Handle broken images
Most of this logic copied from MWBlockImageNode.

Change-Id: I92c860c53741c5ee48c8bce216987d97a92bc05f
2022-05-23 15:29:42 +01:00
Ed Sanders da8de2e509 GalleryDialog: Use correct src attribute when rebuilding DOM
This avoids a meaningless attirbute change with the image
is unmodified (as thumbUrl can be a different size).

Change-Id: Ib79a4703382552e38022a3f345ca5cd762c52303
2022-05-23 14:55:12 +01:00
Ed Sanders 0aa4ee1356 ve.dm.MWGalleryImageNode: Add width/height attributes back to images
These aren't used by Parsoid but help with rendering.

Change-Id: Ifff3be45ab2046ee32f0665285581c1013102dfe
2022-05-23 14:55:06 +01:00
jenkins-bot b6e398fd85 Merge "Improve collapsible descriptions for smaller screens" 2022-05-23 10:27:27 +00:00
jenkins-bot ee0f823f25 Merge "Fix non-collapsible parameter descriptions on smaller screens" 2022-05-23 10:27:24 +00:00
Translation updater bot 24a00796fb Localisation updates from https://translatewiki.net.
Change-Id: I3445bd329c8262e14d0a6e1de94d2bb02fd952a1
2022-05-23 08:17:53 +02:00
Bartosz Dziewoński 1fac5e1c1d Update VE core submodule to master (020488bd1)
New changes:
f4a94fef6 Remove some unnecessary newlines from source code
42900ef34 Fix wrong type hints for string hashes
ae6c7de73 Make some generic Array type hints more specific
020488bd1 Fix various mistakes in JSDoc documentation

Change-Id: I4b7657767b3239800218679104e2a453ea6b99cd
2022-05-21 17:45:54 +02:00
jenkins-bot cf08e7f70a Merge "MobileArticleTarget: Avoid jittering while scrolling" 2022-05-21 15:07:03 +00:00
jenkins-bot adea509816 Merge "ve.init.mw.MobileArticleTarget: Remove hiding keyboard shortcut hints" 2022-05-21 14:53:27 +00:00
jenkins-bot d2c589644e Merge "Update VE core submodule to master (595380444)" 2022-05-21 14:51:31 +00:00
Bartosz Dziewoński 1cfef4232d MobileArticleTarget: Avoid jittering while scrolling
Needed after Ia18f31a299338f94e69f1882e6e477f3a22ae905 in VE core.

Bug: T307849
Depends-On: Ia18f31a299338f94e69f1882e6e477f3a22ae905
Change-Id: I87f3ac0974702ecaf7f5459604371de06f4a5756
2022-05-21 13:43:20 +00:00
jenkins-bot f05ab1042c Merge "Special:CollabPad supports importTitle parameter" 2022-05-21 13:29:35 +00:00
Bartosz Dziewoński e84718d2b1 ve.init.mw.MobileArticleTarget: Remove hiding keyboard shortcut hints
Now done in VE core since Ie86217ba5651df8c427464e460ed836903834a3c.

Bug: T308200
Depends-On: Ie86217ba5651df8c427464e460ed836903834a3c
Change-Id: I3f65b0bc100895f7bd2262c3cbb5231fb055758b
2022-05-21 13:24:09 +00:00
Ed Sanders 0e6c954230 Update VE core submodule to master (595380444)
New changes:
8ede5f447 ve.ui.Toolbar: Always hide keyboard shortcut hints on mobile
df426dd86 ve.ui.Surface: Attach mobile context to global overlay
bbd6c3efa Revert "Ensure mobile context appears above toolbar on mobile"

Bug: T293129
Bug: T307849
Bug: T308200
Change-Id: I530e92a90b95863a8903350d2e10ee335eda68d8
2022-05-21 14:23:23 +01:00
Adam Wight b189ce2825 Special:CollabPad supports importTitle parameter
This lets us begin the import from another page, for example an edit
tab or button.

If the CollabPad page already exists, it will be opened without
overwriting with freshly-imported page contents.

Change-Id: I89293b9b06253243826d8f8144a5e93d55856e7c
2022-05-21 14:48:09 +02:00
Ed Sanders c64f5a78cf MWImageNode: Skip empty change descriptions
As in parent method.

Change-Id: I320d5d7a8b2f5f7c7e2715c95cbc943533c8b335
2022-05-21 04:09:41 +02:00
Ed Sanders fb1ed9e700 MWGalleryImageNode: Avoid converting altText from null to ''
Bug: T308747
Change-Id: Icd811a6baaa2213d8615bdcb3690d26aa35ab302
2022-05-21 04:09:41 +02:00
Ed Sanders f4a7dfa059 Improve visual diff of gallery when image replaced
* Implement ve.dm.MWGalleryImageNode.static.isDiffComparable to
  match ve.dm.MWImageNode, in that images with different resources
  are not compared.
* Diff galleries as documents so remove/inserts are rendered.

Bug: T308747
Change-Id: Ide6f4110e65cad7f6bb6d13766815413602fd991
2022-05-21 04:09:41 +02:00
Bartosz Dziewoński 381381c005 Update VE core submodule to master (aeaac1e84)
New changes:
5c02fa398 DiffElement: Fix ClassAttributeNode tests and ImageNode behaviour
3fa5a0d9c VisualDiff: Consider values going from/to null as being set/unset

Change-Id: I5e17a098cd60831d2cb24ec2e1de06df37c2b7ee
2022-05-21 04:08:11 +02:00
jenkins-bot b0ab170531 Merge "Remove duplicate dependency on mwsave from mobileArticleTarget" 2022-05-20 22:48:46 +00:00
jenkins-bot 8a80076947 Merge "Update schema logging of bucket for new DiscussionTools A/B test" 2022-05-20 22:26:59 +00:00
C. Scott Ananian ede9ffbd43 Bump requested Parsoid HTML version to 2.4.0
Visual Editor currently requests MediaWiki DOM version 2.0.0
when talking to Parsoid.  Since Parsoid treats that as a request
for 2.4.0, its current version, and Parsoid doesn't have a
2.4.0->2.0.0 downgrade path, passing the latest Parsoid version
(2.4.0) should make no difference in practice -- but would better
match current reality.

Change-Id: Ia2bc0c1981db6f573a69fb1910cef4304c80ae00
2022-05-20 15:01:09 -04:00
C. Scott Ananian 57dc7aa630 Zero-configuration VisualEditor for mainline
Now that Parsoid's ServiceWorkers have been merged to core, this adds
support for "zero configuration Visual Editor" to the master branch.
Like earlier zero-conf work, this does not use RESTBase for stashing
or for reliable selective serialization.  Future integration work
with ParserCache will reintroduce this functionality.  Nevertheless,
this implementation should have feature parity with the "loopback interface"
zero conf VE we've been shipping since 1.35.

Bug: T305108
Change-Id: I7b5b4a6d16b07914f947cbaf498ad1d3cf2447a5
2022-05-20 15:01:09 -04:00
Esther Akinloose 9de7c6743d selenium: Improve debugging
Looks like Selenium tests are flaky. To improve debugging:

- Move code from beforeEach hook to specs.
  (Video recording happens only in specs, not in hooks.)

- Increase logLevel from error to info.

Bug: T296187
Change-Id: Iffcfae9a76085670eb8858fbcf622e596a4ff2f0
2022-05-20 16:44:23 +02:00
Ed Sanders 726bbbdb05 Update VE core submodule to master (776219f4b)
New changes:
8030b7e93 Localisation updates from https://translatewiki.net.
fdf1a9201 ve.ce.Surface: Fix typos in documentation
776219f4b Follow-up Ic15dd21f: Fix typo width->height

Bug: T307527
Change-Id: I91149b7806124a3541550eaa7437ffdd9583fd7a
2022-05-20 12:02:28 +01:00
libraryupgrader 0166b79ecd build: Updating dependencies
composer:
* mediawiki/mediawiki-codesniffer: 38.0.0 → 39.0.0
* php-parallel-lint/php-console-highlighter: 0.5.0 → 1.0.0
* php-parallel-lint/php-parallel-lint: 1.3.1 → 1.3.2

npm:
* grunt-eslint: 23.0.0 → 24.0.0
* meow: 3.7.0 → 3.7.0
  * https://github.com/advisories/GHSA-7p7h-4mm5-852v
* trim-newlines: 1.0.0 → 1.0.0
  * https://github.com/advisories/GHSA-7p7h-4mm5-852v

Change-Id: Id518b0dcafa3a6ce480c951c5ea7d0512aaa94a2
2022-05-20 10:06:25 +00:00
Translation updater bot 0d94b62daf Localisation updates from https://translatewiki.net.
Change-Id: If07d11654fd860de91f76b20fd1a33121713c320
2022-05-20 08:37:41 +02:00
Željko Filipin 098e217055 selenium: Use @wdio/spec-reporter
Bug: T280331
Change-Id: Iaa9f8be21c208963ebe3da2062075dc938404172
2022-05-19 15:29:41 +02:00
Ed Sanders 3e1c562898 Remove duplicate dependency on mwsave from mobileArticleTarget
The dependency on mwsave is in articletarget.

Change-Id: Ifb454978aa15974855b60095aeb76263bcb8c190
2022-05-19 14:18:14 +01:00
Andrew Kostka 46846d1b01 Improve collapsible descriptions for smaller screens
Bug: T307986
Change-Id: Iac6205fc90a884965c2e37cf6ed4b403874256d8
2022-05-19 12:39:20 +02:00
Andrew Kostka 0c176752eb Fix non-collapsible parameter descriptions on smaller screens
This patch fixes a bug which causes long parameter descriptions to
be to non-collapsible when adding them from the sidebar-only view on
smaller screens.

Change-Id: If373587a9b2c3841ad6814f74bfcbf0c0f013488
2022-05-19 12:26:30 +02:00
David Lynch b59625158d Update schema logging of bucket for new DiscussionTools A/B test
Bug: T304030
Depends-On: I5e57bb9b7958576f3a04373748331a86f4626fb5
Change-Id: I2ef4c64a55eebc0d2eeca7a57b84b8ba0ded1499
2022-05-19 01:20:33 -05:00
jenkins-bot 86136db386 Merge "Stop passing scrub_wikitext" 2022-05-18 23:41:41 +00:00
Translation updater bot ad76b58b8c Localisation updates from https://translatewiki.net.
Change-Id: Ia59a3041c5c0dfd092b0f6865d45174d59076fdf
2022-05-18 08:20:17 +02:00
Ed Sanders e9b29e7714 Messages: Remove 'visualeditor-donebutton-tooltip'
This was removed from the code a while ago when we switched
to a single toolbar on mobile.

Change-Id: Ic2a807bd8e17a692ad3a6974bbb3028fa1d2d434
2022-05-18 01:06:45 +01:00
Ed Sanders ffa2d2d9d2 Messages: Remove unused 'subject'
Introduced in I1002b9706, but in that same commit we created a
custom message that didn't include the ':' after 'Subject:'.

Change-Id: I28fa059821f740820875c084758d4aa7d1d23b03
2022-05-18 01:04:21 +01:00
Ed Sanders d8c4c54dc8 Messages: Upstream various messages to ArticleTarget module
This messages are used in ve.init.mw.ArticleTarget.js.

Change-Id: I7f694f5b15e86b3d91cce5b7e4534b2e8293361d
2022-05-18 01:03:37 +01:00
Arlo Breault d8aa99e35c Stop passing scrub_wikitext
It's no longer optional in Parsoid.

Bug: T297298
Change-Id: Ice36f4f4b82b0286799e9eedd164ca8d2dfc2b2e
2022-05-17 19:51:17 -04:00
James D. Forrester 377a6523ae Update VE core submodule to master (849c2e8de)
New changes:
152633e2c Localisation updates from https://translatewiki.net.
849c2e8de Update OOUI to v0.44.0

Change-Id: I790613101b2c13a1c04ebcf87a776df834d26b4a
2022-05-17 17:45:02 -04:00
jenkins-bot 37a5099471 Merge "Implement replacePageContent in MobileArticleTarget" 2022-05-17 21:22:50 +00:00
jenkins-bot fc8b909fb7 Merge "ArticleTarget: Always reload the page after save on non-view page" 2022-05-17 21:22:33 +00:00
jenkins-bot c6f45c5f73 Merge "selenium: Content Editable should save an edit" 2022-05-17 16:29:34 +00:00
Translation updater bot 5de8de3b37 Localisation updates from https://translatewiki.net.
Change-Id: I83b84edca3640a3116faed56482ef8bddeb4e89a
2022-05-17 08:29:17 +02:00
Željko Filipin e9ee23aace selenium: Content Editable should save an edit
Bug: T296187
Change-Id: I5a48662bb271fd49b6cfa0365e4775c8865dc5c7
2022-05-16 15:11:56 +01:00
Thiemo Kreuz aa989c00dd Extract MWExpandableContentElement.onButtonClick method
This is done in preparation for Iac6205f to make it easier to review.
This patch here is meant to be a no-op that doesn't change anything,
just moves existing code around.

Bug: T307986
Change-Id: Ie6ccd9528e5799ba340fed344e1f47a443c2c51f
2022-05-16 12:43:10 +02:00
Translation updater bot 7094857fab Localisation updates from https://translatewiki.net.
Change-Id: I921f0bf0cc5cfeb380459482ebda9de1c6631ebd
2022-05-16 08:25:38 +02:00
jenkins-bot fb7beaaa3a Merge "ApiParsoidTrait: Log trace as 'exception.trace' instead of 'trace'" 2022-05-15 22:28:59 +00:00
jenkins-bot 291d4d1374 Merge "Upstream teardown of saveDialog from DesktopArticleTarget to ArticleTarget" 2022-05-15 20:41:46 +00:00
jenkins-bot ace451bede Merge "Upstream isViewPage from DesktopArticleTarget to ArticleTarget" 2022-05-15 20:39:35 +00:00