This avoids a meaningless attirbute change with the image
is unmodified (as thumbUrl can be a different size).
Change-Id: Ib79a4703382552e38022a3f345ca5cd762c52303
New changes:
f4a94fef6 Remove some unnecessary newlines from source code
42900ef34 Fix wrong type hints for string hashes
ae6c7de73 Make some generic Array type hints more specific
020488bd1 Fix various mistakes in JSDoc documentation
Change-Id: I4b7657767b3239800218679104e2a453ea6b99cd
Needed after Ia18f31a299338f94e69f1882e6e477f3a22ae905 in VE core.
Bug: T307849
Depends-On: Ia18f31a299338f94e69f1882e6e477f3a22ae905
Change-Id: I87f3ac0974702ecaf7f5459604371de06f4a5756
Now done in VE core since Ie86217ba5651df8c427464e460ed836903834a3c.
Bug: T308200
Depends-On: Ie86217ba5651df8c427464e460ed836903834a3c
Change-Id: I3f65b0bc100895f7bd2262c3cbb5231fb055758b
New changes:
8ede5f447 ve.ui.Toolbar: Always hide keyboard shortcut hints on mobile
df426dd86 ve.ui.Surface: Attach mobile context to global overlay
bbd6c3efa Revert "Ensure mobile context appears above toolbar on mobile"
Bug: T293129
Bug: T307849
Bug: T308200
Change-Id: I530e92a90b95863a8903350d2e10ee335eda68d8
This lets us begin the import from another page, for example an edit
tab or button.
If the CollabPad page already exists, it will be opened without
overwriting with freshly-imported page contents.
Change-Id: I89293b9b06253243826d8f8144a5e93d55856e7c
* Implement ve.dm.MWGalleryImageNode.static.isDiffComparable to
match ve.dm.MWImageNode, in that images with different resources
are not compared.
* Diff galleries as documents so remove/inserts are rendered.
Bug: T308747
Change-Id: Ide6f4110e65cad7f6bb6d13766815413602fd991
Visual Editor currently requests MediaWiki DOM version 2.0.0
when talking to Parsoid. Since Parsoid treats that as a request
for 2.4.0, its current version, and Parsoid doesn't have a
2.4.0->2.0.0 downgrade path, passing the latest Parsoid version
(2.4.0) should make no difference in practice -- but would better
match current reality.
Change-Id: Ia2bc0c1981db6f573a69fb1910cef4304c80ae00
Now that Parsoid's ServiceWorkers have been merged to core, this adds
support for "zero configuration Visual Editor" to the master branch.
Like earlier zero-conf work, this does not use RESTBase for stashing
or for reliable selective serialization. Future integration work
with ParserCache will reintroduce this functionality. Nevertheless,
this implementation should have feature parity with the "loopback interface"
zero conf VE we've been shipping since 1.35.
Bug: T305108
Change-Id: I7b5b4a6d16b07914f947cbaf498ad1d3cf2447a5
Looks like Selenium tests are flaky. To improve debugging:
- Move code from beforeEach hook to specs.
(Video recording happens only in specs, not in hooks.)
- Increase logLevel from error to info.
Bug: T296187
Change-Id: Iffcfae9a76085670eb8858fbcf622e596a4ff2f0
This patch fixes a bug which causes long parameter descriptions to
be to non-collapsible when adding them from the sidebar-only view on
smaller screens.
Change-Id: If373587a9b2c3841ad6814f74bfcbf0c0f013488
Introduced in I1002b9706, but in that same commit we created a
custom message that didn't include the ':' after 'Subject:'.
Change-Id: I28fa059821f740820875c084758d4aa7d1d23b03
New changes:
152633e2c Localisation updates from https://translatewiki.net.
849c2e8de Update OOUI to v0.44.0
Change-Id: I790613101b2c13a1c04ebcf87a776df834d26b4a
This is done in preparation for Iac6205f to make it easier to review.
This patch here is meant to be a no-op that doesn't change anything,
just moves existing code around.
Bug: T307986
Change-Id: Ie6ccd9528e5799ba340fed344e1f47a443c2c51f