Commit graph

8692 commits

Author SHA1 Message Date
Cmcmahon 0f2310a49d [BrowserTest] no more iframes for "no review" message
Change-Id: I9f7429eff32043c26264faa48404e6f573330b7f
2014-11-04 07:46:24 -07:00
jenkins-bot bb96a9083f Merge "Replacing MWTitleInputWidget.getValue() with MWTitleInputWidget.getTitle()" 2014-11-04 01:18:38 +00:00
suchetag 0165a53044 Replacing MWTitleInputWidget.getValue() with MWTitleInputWidget.getTitle()
Now that we have .getTitle() as a method in MWTitleInputWidget, replacing the callers
of MWTitleInputWidget.getValue() with .getTitle(). This fixes a bug in the .getTitle()
method in MWTitleInputWidget which was not taking the namespaces into account before.

Also fixes: the error when entering "Talk:" as a template title. The button to add template
remains disabled when "Talk:" is given as an input to the title here.

Bug: 71998
Change-Id: I1e629a61ec8b035d93a4b7acfecab81934019166
2014-11-03 17:05:51 -08:00
Cmcmahon 666001ba1c [BrowserTest] no more iframes for transclusion
Change-Id: Ifc50a50e98de18612e6ab4b548b1cf6ec05bc825
2014-11-03 16:27:17 -07:00
Cmcmahon aab1680244 [BrowserTest] no more iframes for switch modes test
Change-Id: Ifebc458f9ff9583954226d86759753b0314db649
2014-11-03 15:51:55 -07:00
Cmcmahon 396d74053b [BrowserTest] no more iframes for References
Change-Id: I7f5cf7b991cfcfd3ebebe0f17bb594802fe7dea0
2014-11-03 15:41:38 -07:00
jenkins-bot b70f2176fa Merge "[BrowserTest] no more iframes for options" 2014-11-03 22:20:55 +00:00
Cmcmahon 9b6e21cf0b [BrowserTest] no more iframes for options
Change-Id: Iee2c88f693edb68017154a497aea05d16eb7453c
2014-11-03 15:18:44 -07:00
jenkins-bot aab271f6e7 Merge "MWReferenceGroupInputWidget: Remove dummy call to onInputChange()" 2014-11-03 22:09:44 +00:00
Cmcmahon 6907583418 [BrowserTest] no more iframes
Change-Id: I8090f95ccd1cf2744649084c863e6034db062d87
2014-11-03 14:45:52 -07:00
Cmcmahon fcfb847276 [BrowserTest] no more iframes for Media test
Change-Id: I724e071935f383185fdc44cf1a139931f8ded557
2014-11-03 14:37:59 -07:00
Cmcmahon a51783983f [BrowserTest] no more iframes for Links test
Change-Id: I72c01981b332a32711e929543a61a780de962a2e
2014-11-03 14:18:21 -07:00
Roan Kattouw fe2895b145 MWReferenceGroupInputWidget: Remove dummy call to onInputChange()
This was needed to make the ComboBoxWidget initialize
its selection, but Idcbf38c53 makes that happen automatically.

Depends on Idcbf38c53 in oojs-ui.

Bug: 72783
Change-Id: I8d3a014f862ece7f4f201af205a8a7ca6c365eaa
2014-11-03 21:12:17 +00:00
jenkins-bot 48cfd29886 Merge "[BrowserTest] click More button, no iframes" 2014-11-03 20:59:37 +00:00
Cmcmahon 61f8cf7ca5 [BrowserTest] click More button, no iframes
Change-Id: I1426f4dcfb65d6e38be5f7e495e9600f98894525
2014-11-03 13:57:29 -07:00
jenkins-bot d4ce90a485 Merge "MWGalleryInspectorTool: Provide the tool in the toolbar" 2014-11-03 20:52:11 +00:00
James D. Forrester 27fc889cc2 Update VE core submodule to master (dc8cf63)
New changes:
38fc5bb Replace native range rectangle hacks with RangeFix library
4713b8e Disable cell editing when a context is opened
1113a13 AUTHORS.txt: Re-update for late 2014
37af5c4 Prevent clicks on focusable nodes in tables
2152877 Localisation updates from https://translatewiki.net.
b766ecc Update OOjs UI to v0.1.0-pre (eee616d664)
20cb077 Follow-up Ifb7ffb1: Update demo.js for breaking OOUI change
6760cdd Localisation updates from https://translatewiki.net.
555c6ea Set insertion annotations when typing over cell contents
819ad6b Fix width of demo page dropdown
9f4705c Catch backwards selection error in Firefox
ac8a4e8 Add missing focus call to pasteTarget
b034657 Add support for non-table nodes in tables (e.g. aliens)
25aef0c Fixes to onDocumentDrop
622957f Add support for dropping text/html from external sources

Change-Id: Ic704b95c1dc91a1ae74f9a60101cb949b34c9e0d
2014-11-03 11:39:46 -08:00
James D. Forrester d0e62e1ab3 MWGalleryInspectorTool: Provide the tool in the toolbar
Now that the toolbar hides extra features by default, we don't need to
use autoAddToGroup and autoAddToCatchall over-rides.

Change-Id: I493f7d46a3f77e7c62af05f8e05ae4dde7147e4b
2014-11-03 11:19:04 -08:00
jenkins-bot 35a7931f10 Merge "[BrowserTest] no more iframes for Cite test" 2014-11-03 19:11:48 +00:00
Cmcmahon 3b57451863 [BrowserTest] no more iframes for Cite test
Change-Id: Ic31521dc8124818df1451a57ae396ca2e9c6beef
2014-11-03 11:57:55 -07:00
jenkins-bot b5e235ea85 Merge "Clean up LookupInputWidget subclasses and use new functionality" 2014-11-03 18:41:48 +00:00
Roan Kattouw a0167c08c7 Clean up LookupInputWidget subclasses and use new functionality
MWCategoryInputWidget:
* Use @inheritdoc
* Don't modify data parameter in getLookupCacheItemFromData()

MWLinkTargetInputWidget:
* Remove this.choosing in favor of setLookupsDisabled()
* Explicitly close menu on choose
* Remove manual emission of change events
** This looks ridiculous, it doesn't seem to be necessary,
   and it causes infinite event loops. But I'm very curious
   why this was added in the first place.
* Remove onLookupInputChange override that is now unnecessary
* Use {} rather than [] for fake empty result
* Prevent programmatic focus from opening the menu

MWTitleInputWidget:
* On choose, close menu and disable lookups while changing value
* Use @inheritdoc
* Remove mentions of "template" from getTitle() documentation

Bug fixed:
* When choosing a suggestion in MWTitleInputWidget,
  new suggestions would be loaded and the menu would reopen

Depends on Iecae9b582 in oojs-ui.

Change-Id: I716f99bb464a5cebd4f17701197f768e4e0e02a9
2014-11-03 10:39:03 -08:00
jenkins-bot e69bc55473 Merge "Pass $overlay to redirectTargetInput in MWSettingsPage" 2014-11-03 18:38:05 +00:00
Cmcmahon 282afbbb2f [BrowserTest] Resume Editing no longer in iframe
Also workaround for Bug 72911

Change-Id: Idbff05837dd97ace534ec732c0ba56b6b523bbe0
2014-11-03 11:02:23 -07:00
Cmcmahon df039a6ee9 [BrowserTest] stuff moved out of the iframe to the main page
step-wise update, probably more changes to come

Change-Id: Ia40c03dd59ab0b28af56176b6da4d30a1e66a195
2014-11-03 10:31:26 -07:00
Translation updater bot 3b3af61679 Localisation updates from https://translatewiki.net.
Change-Id: I13815ef4879f33268d517514dae14d4430340709
2014-11-02 22:00:55 +01:00
Translation updater bot 77454fb02a Localisation updates from https://translatewiki.net.
Change-Id: Ia873b55332f36f07e80bd384e2d10c0b51c183b1
2014-11-01 22:40:04 +01:00
Alex Monk 0dde78bd54 Pass $overlay to redirectTargetInput in MWSettingsPage
So the TOC options don't display over the top of suggestions for it

Bug: 72838
Change-Id: I73f0f9e3a44a9f641b6bed2a42cac2c8293cc5c9
2014-11-01 04:49:36 +00:00
jenkins-bot 8f8613f27b Merge "MWTransclusionDialog: Blur active input when switching modes" 2014-10-31 22:55:24 +00:00
jenkins-bot 1509e318a7 Merge "Add forgotten $overlay pass-through in MWReferenceDialog" 2014-10-31 22:54:15 +00:00
Translation updater bot b33ab8da4b Localisation updates from https://translatewiki.net.
Change-Id: Ice9530a321aba7e64d27c138569c2a7f94ec36a0
2014-10-31 21:47:26 +01:00
jenkins-bot 83b02d9e4b Merge "AUTHORS.txt: Re-update for late 2014" 2014-10-31 19:21:45 +00:00
James D. Forrester c2dfd1ba04 Update VE core submodule to master (b7b56dd)
New changes:
6b820e6 [BREAKING CHANGE] Unisolate dialogs
0bae8f4 Fix selection when inserting a caption
6a31afd Localisation updates from https://translatewiki.net.
ab362b4 Add sparse table demo and fix related selection bug

Change-Id: I8d95b32d01e7a8e1aa9db0e4dc7a2e1e470bd46d
2014-10-31 11:22:45 -07:00
James D. Forrester 0441a8151e AUTHORS.txt: Re-update for late 2014
Add Marielle to principal authors (previously missing).

Add Andrew Garrett, Brad Jorsh, Dan Duvall, Derk-Jan Hartman, Frederico Leva,
Jon Robson, Kaity Hammerstein, Kunal Mehta, Niklas Laxström, Quim Gil, Sam
Reed, Sam Smith, Vikas S Yaligar, & addshore, Helder and Jiabao to the patch
contributors list, based on git shortlog perusal. Moved Neil Kandalgaonkar to
the VisualEditor-core list only.

Change-Id: Ieef11abf208216f22a95cb85cbc8ce54a7f30501
2014-10-31 10:30:30 -07:00
jenkins-bot 4df619c813 Merge "Update "page was last modified on date, at time" footer line when saving" 2014-10-31 05:24:58 +00:00
Roan Kattouw c324ed8b9a MWTransclusionDialog: Blur active input when switching modes
When show/hide options is clicked, the inputs in the main pane
move as the outline transitions in or out. This causes any dropdowns
below these inputs to become mispositioned: they don't move
because they're in an overlay.

To work around this problem, blur the active input when show/hide
options is clicked, so any dropdown attached to it is closed.
I tried blurring and immediately refocusing the active input to
force the dropdown to reposition itself, but that looks awkward
because of the transition (we'd have to wait for the transition
to complete before repositioning it, and during the transition
it'll stay open in the wrong place).

Bug: 72789
Change-Id: Ibd963690573af905066839f7276077089fa893c6
2014-10-31 04:19:41 +00:00
Alex Monk b2af92870a Update "page was last modified on date, at time" footer line when saving
Bug: 52403
Change-Id: I11e00066000e927f0551691d05fe11fe2ae125b0
2014-10-31 01:00:04 +00:00
Translation updater bot 7957ffa53c Localisation updates from https://translatewiki.net.
Change-Id: I1c44ba77871aa8807735127d04a7565acf0db6e7
2014-10-30 23:32:21 +01:00
Roan Kattouw 884aa1f243 Add forgotten $overlay pass-through in MWReferenceDialog
We were doing this for the exact same widget in
MWReferenceListDialog, but not here.

Bug: 72785
Change-Id: I4a905b944be44ec1aec5cdba7580283ec18c5c7c
2014-10-30 14:50:10 -07:00
jenkins-bot 7336a17cd3 Merge "Update VE core submodule to master (260d6c5)" 2014-10-30 21:32:54 +00:00
Alex Monk b71bb51171 Remove more references to ve.bind
Seems some of them have crept back in since I1a7fc7f2 (and we missed one somehow)

Bug: 72156
Change-Id: I5631fb7d5963d06aeb238c1daa44344b2060ef1a
2014-10-30 20:55:44 +00:00
jenkins-bot c83961842c Merge "Preserve original data inside parameter objects too" 2014-10-30 20:47:32 +00:00
Ed Sanders 17f3930203 Missing message from table merge
Change-Id: I67d42ece613358b1e48cd04d8d53df0d94a79cbc
2014-10-30 20:11:27 +00:00
jenkins-bot 9a1ed3ce3d Merge "Toolbar: Make styling and insert menus collapsible" 2014-10-30 19:56:08 +00:00
James D. Forrester a8db969c36 Update VE core submodule to master (260d6c5)
New changes:
eb95f82 Store intended table selection before expansion and use when translating
392d1e6 Add table selection support to clear annotation tool
2529985 Refactor and fix table cell editing code
de1117c Support editing of caption nodes
f831ee7 Table caption tool

Change-Id: I8ddfe6349723bb20d9b530e954f745d1757bfbc1
2014-10-30 12:27:55 -07:00
James D. Forrester 6626450419 Toolbar: Make styling and insert menus collapsible
Also re-synchronise toolbar in MWMediaDialog and MWReferenceDialog.

Change-Id: I8cd5f0d9f7e188fa1a7ab8d34a2796340f5e99b7
2014-10-30 12:22:20 -07:00
jenkins-bot c402528d1a Merge "Also add tableCaption to mwTable parentNodeTypes hack" 2014-10-30 19:19:27 +00:00
Roan Kattouw a054a753be Preserve original data inside parameter objects too
Parsoid has added a "key" property to parameter objects,
so now we have to preserve that rather than regenerating
all parameter objects.

Do this by changing the existing use of this.originalData
to a deep extend.

Change-Id: Ib4d31c2e0f7b567da1a148b51c42e688a2590b8e
Bonus: avoid modifying this.originalData
2014-10-30 11:59:42 -07:00
Roan Kattouw 407ed04ef0 Update VE core submodule to master (f9f51a5)
New changes:
7d36bd8 Don't create tables with a thead
dfee68d Localisation updates from https://translatewiki.net.
dde7897 Fix selection transitions between FocusableNodes and non-linear selections
6f9437f Update OOjs UI to v0.1.0-pre (da4b0d5c14)
1ec4bf5 Always emit context change on null selection

Change-Id: Ib3c175199950822cda7b34a3c8ca4faa20c53cfc
2014-10-30 11:52:59 -07:00
Roan Kattouw 190ba17b74 Also add tableCaption to mwTable parentNodeTypes hack
Change-Id: Ic7e387bdb774699746e6bafb62daf9c843af77b5
2014-10-30 11:38:26 -07:00