Commit graph

14505 commits

Author SHA1 Message Date
jenkins-bot 38a29808bb Merge "styles: Update invalid border color" 2024-04-02 18:13:26 +00:00
libraryupgrader c51ec255d7 build: Updating dependencies
composer:
* php-parallel-lint/php-parallel-lint: 1.3.2 → 1.4.0

npm:
* eslint-config-wikimedia: 0.26.0 → 0.27.0

Change-Id: Icb8391aaa2eb5826cc13bcb2b2a06f53d56bc41c
2024-03-30 16:51:06 +00:00
Volker E. 344add6080 styles: Update invalid border color
For the invalid border color we'll use the current border error color.
With CSS custom properties on the horizon, we'll easily replace them
consistently in the future.

Change-Id: I1ec266e90a974cf79576ee7db6287ea4eac94656
2024-03-28 20:40:27 -07:00
jenkins-bot d52c967bb6 Merge "Move saveWorkflowBegin to before the saveProcess" 2024-03-26 16:38:38 +00:00
thiemowmde 31e1f20570 Gallery: Avoid expensive .getAttributes() call in MWGalleryImageNode
This actually creates an (expensive) clone of all attributes. Even if
this particular code is only interested in a single one of them.
I checked and it's purely used for reading, not writing. So it
doesn't make a difference if it's a clone or not.

Change-Id: I428e684ea2fa20ffcfcc53b618f3fc032d930c75
2024-03-23 23:07:22 +00:00
Ed Sanders b6a7d8c8da Update VE core submodule to master (70279c60a)
New changes:
70279c60a Refactor SpecialCharacterPage into SymbolListPage + SymbolListBookletLayout

Local changes:
* Use new special character layout

Added files:
- src/ui/layouts/ve.ui.SymbolListBookletLayout.js
- src/ui/pages/ve.ui.SymbolListPage.js
- src/ui/styles/layouts/ve.ui.SymbolListBookletLayout.less

Deleted files:
- src/ui/pages/ve.ui.SpecialCharacterPage.js

Bug: T120512
Change-Id: I357595ae490b36bcf5dd477a95c5684f3a246753
2024-03-19 20:03:40 +01:00
Ed Sanders c9c7c06e76 Nest LESS files
Change-Id: Ic9fad12fe4c20793dd54cb3169b9dffe3a6a18da
2024-03-19 13:56:41 +00:00
Ed Sanders 9ee1b51fbe Move CSS files to LESS
Change-Id: Ic818efe7315187bf96ead7bd6468ecb3d44d988d
2024-03-19 13:56:30 +00:00
Ed Sanders 960edae818 Move dialog CSS files to LESS
Change-Id: Ic91cbb285675116e62cb2546b21927c704ad5e65
2024-03-19 12:46:22 +00:00
jenkins-bot d9eebe04ef Merge "Remove unused ve-ui-educationPopup-header CSS" 2024-03-18 20:31:46 +00:00
jenkins-bot f440dd8fbe Merge "styles: Update color in CSS from #d33 to #d73333" 2024-03-15 22:55:53 +00:00
jenkins-bot 9ed8041cf0 Merge "ve.init.MWVESwitchPopupWidget: Add spacing after checkbox" 2024-03-14 20:27:15 +00:00
jenkins-bot 627f0bcbb7 Merge "ve.init.MWVESwitchConfirmDialog: Fix padding of button in Apex/Monobook" 2024-03-14 20:26:12 +00:00
jenkins-bot a2d81882f5 Merge "ve.init.MWVESwitchConfirmDialog: Convert files to LESS" 2024-03-14 20:22:54 +00:00
jenkins-bot ef3c244834 Merge "Compatibility with new heading HTML" 2024-03-14 18:48:26 +00:00
Ed Sanders 570766d96a ve.init.MWVESwitchPopupWidget: Add spacing after checkbox
Change-Id: I40e1c9cf770f5c00d891c71a7d18b0a622264501
2024-03-14 11:37:26 -07:00
Ed Sanders 4fb1c130fd ve.init.MWVESwitchConfirmDialog: Fix padding of button in Apex/Monobook
Change-Id: I3568ee3f1682474d1067f3f6d4456444279469e5
2024-03-14 11:37:26 -07:00
Ed Sanders 13ae41f74b ve.init.MWVESwitchConfirmDialog: Convert files to LESS
Change-Id: Iacb3ee99a3d828d23534e2929a78c469d4af7c16
2024-03-14 11:37:26 -07:00
jenkins-bot 5d27061c63 Merge "Convert ve.init.MWVESwitchPopupWidget.css to LESS" 2024-03-14 17:45:52 +00:00
Divec 013a9216df Merge "Improve opening editor when collabSession is in URL" 2024-03-14 17:00:59 +00:00
gerritbot aa1924faf5 styles: Update color in CSS from #d33 to #d73333
This patch promotes a consistent design decision across projects in
MediaWiki core, extensions, and skins. The darker red color meets the
W3C Web Content Accessibility Guidelines (WCAG) at Level AA that text
or images of text must have a contrast ratio of at least 4.5:1 (or 3:1
for large text).

Bug: T343239
Change-Id: I0f8db861b029c61d524416379a1a842f5137c8cb
2024-03-14 12:15:29 +00:00
jenkins-bot 2a8433ee31 Merge "DesktopArticleTarget.init: Document methods" 2024-03-14 03:52:39 +00:00
Ed Sanders 7aa6e7b250 DesktopArticleTarget.init: Document methods
Change-Id: Ida207aa83b0fb6e646c376fb4a0ff51a3bd67e57
2024-03-13 16:01:15 -07:00
Ed Sanders 46afa48a14 Improve opening editor when collabSession is in URL
* Suppress the welcome dialog
* Always load VE if collabSession is set

Change-Id: Icb61b0b06ecc477125b8deb05d5309fe34605914
2024-03-13 22:45:51 +00:00
Ed Sanders 2158fd57b8 ve.collab: Disable auto-save in clients
Change-Id: I85518c5f2290c3e563a179cd10957d59f7220bb1
2024-03-13 15:44:20 -07:00
Reedy 42df4785e3 Fix casing of MediaWiki
Change-Id: Ic1240acbd90a8bedaeb875bbc393b9892e8dc23d
2024-03-12 15:40:46 +00:00
Ed Sanders d5d2fd0541 Convert ve.init.MWVESwitchPopupWidget.css to LESS
Change-Id: I4c394adc7a510b85b346366f53daf05b96811393
2024-03-11 17:39:22 -07:00
Bartosz Dziewoński 5fb480fa9e Compatibility with new heading HTML
Small fix to support new HTML markup for headings, which will soon be
used by Parsoid page views (T269630) and by the old parser (T13555).

This fixes two issues that were only apparent when using
`$wgVisualEditorEnableVisualSectionEditing = true`:

* When starting an edit from a section edit link, the viewport was
  not scrolled to align with the clicked heading and thus didn't
  provide a smooth transition into edit mode.

* If the editor was started from a section edit link, then when
  leaving the editor without saving changes, the viewport would jump
  to the top of the page instead of returning to the clicked heading.

This is similar to change If71d4d8292 in MobileFrontend editor.

Bug: T13555
Change-Id: I89f8abac521e635f8eaa782703bdb6f6323098b0
2024-03-08 18:54:45 +00:00
David Lynch 01f17958de Move saveWorkflowBegin to before the saveProcess
This causes saveWorkflowBegin/saveIntent to fire as soon as the save
button is pressed. If edit check is enabled, it will be part of the save
workflow in timings.

Mobile was already behaving this way.

Bug: T352130
Change-Id: I3942fd63057c97365d28a443bcc5ac1cd43a8ae6
2024-03-07 15:28:09 -06:00
Ed Sanders 2359b587ed ve.collab: Create ResouceLoader module
Change-Id: I2fd9d604521901e3ccdf862afc0a4f2099c533b1
2024-03-06 16:31:19 +00:00
Ed Sanders 7acda2e158 mw.Platform: Implement getUserName
Change-Id: I5c9d84d1795ffcdacc6722a2cf46a954d9491a48
2024-03-07 00:00:21 +08:00
jenkins-bot 5d63d7470e Merge "Use full filename in LESS include" 2024-03-05 15:59:11 +00:00
Ed Sanders 4ceadc9f8e Use full filename in LESS include
This appears to be standard in core.

Change-Id: I7f543f2eaf03fb32515878130a0ae96a219cb453
2024-03-01 15:38:05 +00:00
lwatson ec11ba3ade styles: Update color in CSS from #d33 to #d73333
This patch promotes a consistent design decision across projects in
MediaWiki core, extensions, and skins. The darker red color meets the
W3C Web Content Accessibility Guidelines (WCAG) at Level AA that text
or images of text must have a contrast ratio of at least 4.5:1 (or 3:1
for large text).

Bug: T343239
Change-Id: I517a8f5bee4f62267b37e66a8da7500ca547217e
2024-02-29 15:16:24 -05:00
Ed Sanders f7eef9ce12 Remove unused ve-ui-educationPopup-header CSS
We just use a standard <h3> in the popup.

Also document generated classes.

Change-Id: I8c61a240fe8c7222c70cad19ea9300b2105484ea
2024-02-28 15:44:36 +00:00
Ed Sanders 3badbe433a MobileSaveDialog: Remove checks for module existence
1. The module always exists because this file is only
   loaded from MobileFrontend.
2. If the module doesn't exist, mw.loader.using will
   just reject anyway.

Change-Id: I6724078b362782813576cad2459e7b7903655e5e
2024-02-27 15:11:18 +00:00
Ed Sanders 245e354b79 Numbered links on mobile: Show "Add label" button
Show this in place of the useless "No preview" message.

Bug: T358258
Change-Id: Ic525aa8cdac5f74b843927b488ace9adbda55a6b
2024-02-22 18:02:10 +00:00
Ed Sanders 37598015b3 Always use the label input for link insertion
Bug: T358258
Change-Id: I17011e0402d9bf84d8a2622b4420eb4a4b5bc722
2024-02-22 17:39:29 +00:00
jenkins-bot 8d70615b5e Merge "Enrollment for the edit check a/b test" 2024-02-19 15:27:16 +00:00
David Lynch e7861de221 Enrollment for the edit check a/b test
The enrollment happens in ArticleTargetLoader so that the bucket will be
set for init logging.

Bug: T342930
Depends-On: I9c7c0fb52a6ec68609df6b518c7d35ddd98a95bf
Change-Id: I03c8dc8beb2eb267c052b856a30343ecab3a7657
2024-02-16 10:18:21 -06:00
Ed Sanders 265f7a5722 Separate Apex fixes from Monobook fixes
Change-Id: I5ac462ecb66d2e16910905ca62db0d9167d843ea
2024-02-13 13:58:55 +00:00
Bartosz Dziewoński b119b633cf Update VE core submodule to master (58a24a62c)
New changes:
f5fe845bc ve.collab UI and bookmarklet
e096b57e9 Localisation updates from https://translatewiki.net.
5ed427d39 FocusableNode: Try to redraw highlights during setup
d966cf7be Exclude OOUI from generated JSDuck documentation
4abb6dfa6 Update OOUI to v0.49.0

Local changes:
* Exclude OOUI from generated JSDuck documentation
* ve.ui.MWConfirmationDialog: Remove copied documentation

Added files:
- .jsduck/external-ooui.js
- collab/ve.ui.CollabProcessDialog.js
- collab/ve.ui.CollabTool.js

Bug: T185396
Bug: T250843
Bug: T356983
Change-Id: I8fcacbbf4f9f213e58af91cc79ef8e89b65895b4
2024-02-08 20:46:40 +01:00
jenkins-bot 0ad8138d73 Merge "editSwitch: Use secondary group for WikiEditor switch menu" 2024-02-03 07:50:09 +00:00
Ed Sanders 3ca82f8d57 Tests: Use CE HTML helpers
Depends-On: I2ac2ecd6937e936f877fc3fb17feaa4d3610ee50
Change-Id: If3790fc7449ea2f7bbf56783f590fcb8d9126cb8
2024-02-01 15:30:22 +00:00
Sam Wilson 9226a67ea1 editSwitch: Use secondary group for WikiEditor switch menu
Instead of inserting the editSwitch menu manually to the WikiEditor
toolbar, use the 'secondary' section which is already aligned to
the right.

Bug: T308423
Depends-On: Iff6d80628ebb5ec5685136fa02c2345eb5b49d42
Change-Id: Ic307f9dc7ad976862c8d8c6551ed29e6071f655f
2024-01-31 06:49:14 +03:00
Jon Robson e17ff06c9b Dialogs: Avoid using the deprecated mw.mobileFrontend function
As mentioned in the ticket access to this library is now
deprecated and consumers should require the module. The existing
method is replaced with the method in the migration table in the
Phabricator ticket.

Bug: T348807
Change-Id: I72a5242399d2cd04b5c9fbee947dc59d94c0ba7c
2024-01-29 20:46:38 +00:00
David Lynch d5cd77b254 MWTocWidget should fetch the metaList from the correct location
Follow-up to 7954f5897c

Bug: T355944
Change-Id: I5070c7e958af918ffd5d5467219026ad114ca4a1
2024-01-26 10:26:48 -06:00
Ed Sanders 4156acc5ba MWBlockImageNode: Re-use existing captionData slice
Change-Id: I9e79897bd3c28265e52c07cf6ab503a745bfd4cf
2024-01-23 15:18:28 +00:00
thiemowmde 81c90568b0 Remove comment mentioning a deleted message
The message is gone via I160a119.

Change-Id: Iaa55aaa62f9f8964b2449ac2e9b22eaa51d96707
2024-01-07 17:52:29 +00:00
Ed Sanders dd4e766d4b Remove { passive: true } from removeEventListener
This option doesn't exist when removing an event.

Change-Id: I74cc8c41ad13ae7d2b4932c41d8dc51b764e1b6b
2023-12-08 11:00:01 +00:00