Commit graph

6878 commits

Author SHA1 Message Date
James D. Forrester 385f895980 Update VE core submodule to master (f5083c6)
New changes:
6ec286e Support for generic file drop handlers
4f2ab66 Generic progress dialog for drag and drop uploads
742e0fe Fix pasteSpecial command
87ea9e9 Fix up/down arrowing off a focusable node
643ea34 spinner.gif: Update with new version from Trevor
ffd8b1e Position the table context relative to the first section node
393776a Fix logic for ignoring (col|row)span=1
f94b10e Don't unmerge spanned cells when spanned cell is removed
3416764 TableContext: Simplify row/column overlays styles
e6c0038 Localisation updates from https://translatewiki.net.
fb1a922 Register select all as a command and perform programmatically
3c1ce93 Make caption tool available when caption selected
dd0ac7d Move disabling logic from tools to commands
8bf33a5 Bold & italic icons for Armenian
058b32c Update OOjs UI to v0.1.0-pre (05f0fefc3f)
c01d115 Create filedrophandlers folder for implementations

Local changes:
* Register new files
* Move disabling logic from tools to commands
  onUpdateState should only ever call setActive. setDisabled should
  already be determined by the command so that it can prevent itself
  being called by triggers.

Change-Id: Icdeaa4c152a0dcd839c8e7cc4e64b2215eb2de1e
2014-11-11 16:51:24 +00:00
Roan Kattouw 0c92ef904c Followup 5c0c117: make the edit tab work with oldid= again
After 5c0c117, clicking the VE edit tab on /wiki/Foo?oldid=123
sent you to /wiki/Foo?veaction=edit , dropping the oldid parameter
and editing the current version rather than the old version.

Fix this by only recomputing veEditUri from scratch when necessary,
and reusing the current URI when possible.

Change-Id: Iee9a745990f1a2bad40f46b8cdaaa727bb7fead8
2014-11-10 18:24:45 -05:00
Translation updater bot 0e87a70e8f Localisation updates from https://translatewiki.net.
Change-Id: I0ca8ed6ded5e577a71cb140609115fa6b8229ed7
2014-11-10 22:12:43 +01:00
jenkins-bot a8f4a5f98f Merge "Remove last usage of ve.bind() in VE-MW" 2014-11-10 20:55:02 +00:00
Roan Kattouw 9533c378ea Remove last usage of ve.bind() in VE-MW
Change-Id: Ia645e3d599da9b65b71dbe67f82b7c0fa3be1683
2014-11-10 15:45:09 -05:00
jenkins-bot ad92b977d5 Merge "Followup a054a75: don't reintroduce removed template parameters" 2014-11-10 20:44:28 +00:00
jenkins-bot c888e2b0d3 Merge "Followup c232083: use getRelativeTitle for template titles" 2014-11-10 20:34:56 +00:00
Roan Kattouw aa84df021a Followup a86d824: fix reference to this in foreach callback
Bug: 73235
Change-Id: Ib8f877f747df6c8047c7e3d2c152e0e7a9f60b8a
2014-11-10 15:22:19 -05:00
Roan Kattouw 5f1e7a651c Followup a054a75: don't reintroduce removed template parameters
Deep-extending originalData is asking for trouble, because there's
no way to delete anything that way.

Bug: 73134
Change-Id: I44d3e582e04942efceae3e0bdbbaa147095b5146
2014-11-10 15:04:42 -05:00
Roan Kattouw 2ba844a372 Followup c232083: use getRelativeTitle for template titles
Otherwise we output stuff like {{Template:Echo|hello}}

Change-Id: Ib6c3996ab40e01a5ddce84b7daffa27a74020ee5
2014-11-10 15:03:10 -05:00
Vikas S Yaligar 901b0deeed [BrowserTest] Fixed failing language screenshot browser tests
Bug: 73033
Change-Id: Iea3a03b1ec628bfe03f10b4cb2a4795d4fabb8bc
2014-11-10 11:07:49 +00:00
Translation updater bot 2addf93fa0 Localisation updates from https://translatewiki.net.
Change-Id: I1aac2fe3ad1eec132d45a7315e5e098ace57c546
2014-11-09 21:55:01 +01:00
jenkins-bot 1f4335a1e2 Merge "Show category items as red if they don't have description pages" 2014-11-09 14:10:32 +00:00
Translation updater bot aa0eab73b6 Localisation updates from https://translatewiki.net.
Change-Id: Ieb369522a74d50eef8cdea0a409abdf29d65b140
2014-11-08 22:20:26 +01:00
Alex Monk de73246ee1 Show category items as red if they don't have description pages
Also fix some lies I wrote in related code/docs

Bug: 65517
Change-Id: Iafacee7d8e460913d84808fe38ecc8da4a1817c0
2014-11-08 14:27:27 +00:00
jenkins-bot 3ebbfe6953 Merge "Fix craziness in template dialog focusing" 2014-11-08 00:54:56 +00:00
Roan Kattouw a86d824c56 Fix craziness in template dialog focusing
setMode() is called multiple times, but it didn't
check whether the mode being set was already set.
Because it's a setter, make it idempotent.

This fixes the problem where the first input will
be focused first, then blurred later, but it
introduces a new problem because the label for
the 'mode' ActionWidget is set from setMode().
To solve that, factor the setting of this label
out into its own function and call it on setup.

Bug: 73138
Change-Id: I9bb127f22f6c0b745b393c523ec42f320fc85cf3
2014-11-07 16:41:03 -08:00
Translation updater bot 6fea75bf7b Localisation updates from https://translatewiki.net.
Change-Id: I76eb90ec1ad222f5887a01a1a4abb38337b8a9ce
2014-11-07 22:15:17 +01:00
Ed Sanders 5238d06dc7 Support pre's in tables
Bug: 73100
Change-Id: I971420047026c91ed92a19a52d2fd3b6fbeac24a
2014-11-07 15:44:13 +00:00
jenkins-bot 27e70a6a21 Merge "Matching pages from suggestions in link dialog now actually work as links" 2014-11-06 21:49:07 +00:00
suchetag cb704dee84 Matching pages from suggestions in link dialog now actually work as links
* A subclass of MenuItemWidget from OOUI, MWLinkMenuItemWidget, is introduced that, when used in MWLinkTargetInputWidget for both
external and internal links, returns actual page links.

* MWInternalLinkMenuItemWidget is extended from MWLinkMenuItemWidget to support the internal links.

* LinkCache is being used in MWInternalLinkMenuItemWidet to stylize the links. Thus, getting rid of some old css classes.

Bug: 51205
Change-Id: I3ac18dabd514ca539fff1db3c67ae97931c3d4fc
2014-11-06 13:46:09 -08:00
Translation updater bot 47295b4441 Localisation updates from https://translatewiki.net.
Change-Id: I0d8f1d19fdae87a23f088dbad5e2dac413b5825a
2014-11-06 21:56:21 +01:00
jenkins-bot 613e69b2c8 Merge "Refactor out show/hide loading spinner" 2014-11-06 18:39:06 +00:00
Ed Sanders 841dfda98d Refactor out show/hide loading spinner
Change-Id: If505a46f54921ce4742ecfed598eb07a9ba5e3eb
2014-11-06 16:41:05 +00:00
jenkins-bot 1a6c46f7ee Merge "Use hasOwnProperty instead of 'key in obj'" 2014-11-06 12:37:04 +00:00
jenkins-bot 81d153b430 Merge "Disable review button while save dialog is pending" 2014-11-06 00:35:17 +00:00
jenkins-bot 209dbe2449 Merge "Allow headings in table cells" 2014-11-05 23:52:23 +00:00
Alex Monk 3628fc0ffc Disable review button while save dialog is pending
Bug: 65310
Change-Id: I7cfb5d84b91b4a20282e126b8c863c15519b5a9d
2014-11-05 23:36:33 +00:00
jenkins-bot cfed84e063 Merge "QA: sort remaining page elements that belong in the iframe" 2014-11-05 22:43:36 +00:00
Cmcmahon beebfff6f9 QA: sort remaining page elements that belong in the iframe
We need to figure out where the language screenshot elements reside

merged as an interim step to share the code more easily, no change
to function

Change-Id: Icae480aaa526a9de6e6926e027c0cac0c7de997e
2014-11-05 15:39:10 -07:00
Ed Sanders 26f567d84f Allow headings in table cells
We possibly want to discourage this somehow but our current
functionality achieves this by doing an isolateAndUnwrap
which for a table is catastrophic.

Bug: 72990
Change-Id: I79f1348da20385dfec014afcac0fb5464580cf2f
2014-11-05 22:34:13 +00:00
Roan Kattouw e144e55972 Followup 31bafa1: forgot to rename 'data' to 'args' for citation commands
Bug: 73001
Change-Id: I8cc436cbe16955130d25b2385e3f561fd2ffb4d5
2014-11-05 13:46:54 -08:00
jenkins-bot ca7ef3be1f Merge "Remove the loading spinner at the end, not halfway through loading" 2014-11-05 21:00:53 +00:00
Ed Sanders 0efbfa7e21 Use hasOwnProperty instead of 'key in obj'
Change-Id: I48f044c547b48a97cdfb31f7b887dca0ed7e341b
2014-11-05 20:54:50 +00:00
Roan Kattouw ccd9142262 Remove the loading spinner at the end, not halfway through loading
We were attaching its removal to the wrong promise in 2 of the 3
places where it was being called.

Also this file is horrible and should be refactored. A lot.

Change-Id: If74b1629266f22e2d110305b139bef4a8e69b13b
2014-11-05 12:50:40 -08:00
Translation updater bot 58ba085453 Localisation updates from https://translatewiki.net.
Change-Id: Icaf0b9a1ce7848d97c1466cdbc1cff4d4335e54a
2014-11-05 21:50:17 +01:00
Cmcmahon f8b34e4e89 QA: remove stuff now that iframes are gone
Change-Id: I6d520acd9d1e18d803f7e44f5ea45502658f14d9
2014-11-05 10:01:55 -07:00
jenkins-bot 06387f7f54 Merge "Revert "Clear selection after tearing down surface to work around Firefox bug"" 2014-11-05 01:39:16 +00:00
Catrope c8396eb65f Revert "Clear selection after tearing down surface to work around Firefox bug"
Superseded by I051ef92eeea9 in VE core.

This reverts commit d68eae6c8d.

Change-Id: Ie5e0a6169cfe3634e20a3b88e8aeb980b4094e10
2014-11-04 17:20:30 -08:00
jenkins-bot d6c3a4aa92 Merge "Kill MWCategoryWidget#onLookupEnter" 2014-11-05 01:18:15 +00:00
Roan Kattouw a5e9e1f456 Fix indicator alignment in MWCategoryItemWidget
We were setting the height to 2.25em which just happened
to be right, but it depended on the browser's default
line-height being a certain value. Now that that's changed
with unisolation, the alignment breaks.

Instead of using a magic value, use height: 100%; so it
takes the parent's height. We don't even have to make the
parent position: relative; because it already is.

Also change the width to 2em, which is a much more defensible
value than 2.25em. Previously 2.25em kind of made sense because
that was also the height (resulting in a square box), but
now we don't have that excuse any more.

Bug: 72962
Change-Id: Id617bfaafefd1fc1530fbee29be5d935ec486b92
2014-11-04 16:53:11 -08:00
jenkins-bot 309305b03e Merge "[BrowserTest] WIP adding cases to test other options under Page Settings to options.feature" 2014-11-04 23:04:40 +00:00
ryasmeen@wikimedia.org 4aa8be0e71 [BrowserTest] WIP adding cases to test other options under Page Settings to options.feature
Also:
* Fixed a typo in options_steps.rb
* Disabled Metrics/ClassLength Rubocop cop.

Change-Id: I7128ba8f7ebf9c63aef9399a9cdf24831e1a2d38
2014-11-04 15:01:45 -08:00
Translation updater bot f9517993de Localisation updates from https://translatewiki.net.
Change-Id: If507707479641bfd07e950f03136b46e53f3c62f
2014-11-04 23:33:19 +01:00
James D. Forrester 31bafa183d Update VE core submodule to master (a942301)
New changes:
2cc219a Update OOjs UI to v0.1.0-pre (571f26d0ab)
3543cb7 Protect against offset=-1 in insertContent()
7a3d456 [BREAKING CHANGE] Move selection restrictions from tools to commands
3d847bb Disable desktop context on table selections
41282dd Missed function rename from RangeFix change
dd6c8b8 Support toDomElements returning an empty array
9be6464 Placholder -> placeholder
9bdd0a8 Restore basic styling to toolbar in core target (only)

Local changes:
Move selection restrictions from tools to commands

Change-Id: I88f3d04946bd1d03ed001d747475a8b495a0f64c
2014-11-04 14:11:04 -08:00
Alex Monk b1e47365d0 Kill MWCategoryWidget#onLookupEnter
This code was somehow broken by Ia47bc897 (wtf, how?)
Actually removing it seems to do no harm (wtf?), as far as I've been able to tell...

Bug: 72906
Change-Id: If7eb34a20cc8060b594a567278241b02a8ee327a
2014-11-04 20:35:55 +00:00
Roan Kattouw c23208371a Followup 0165a53: don't store an mw.Title object instead of a string in TemplateModel
0165a53 overlooked the fact that 'name' is also passed to
the MWTemplateModel constructor, and there it really does
always need to be a string, not magically either a string
or an mw.Title object. Oops :(

Bug: 72961
Change-Id: I0b20f0768aae4d9cc9f7af268abd0a704b6adc3a
2014-11-04 10:58:53 -08:00
Roan Kattouw 362d0ebcdf Followup 0165a53: fix typo causing undefined to be passed to mw.Title
Bug: 72948
Change-Id: I1942f153f18c5a182de38a0e067ec5a92abeefd3
2014-11-04 10:53:58 -08:00
Cmcmahon 3b53b23fb1 [BrowserTest] no iframes for switch mode test
Change-Id: I99e4686144ded173f8d91be87f02a4c144284237
2014-11-04 08:06:33 -07:00
Cmcmahon 0f2310a49d [BrowserTest] no more iframes for "no review" message
Change-Id: I9f7429eff32043c26264faa48404e6f573330b7f
2014-11-04 07:46:24 -07:00