Commit graph

13699 commits

Author SHA1 Message Date
James D. Forrester 79d15b18b8 Update VE core submodule to master (347765f82)
New changes:
8155f98fd Upgrade tree differ to support timeouts, and handle them
f36fcb6c9 Update OOjs UI to v0.21.3
2496f0521 Localisation updates from https://translatewiki.net.
7212fc4ab MobileContext: Fix alignment of label and description
865b2fcc7 VisualDiff: Bring in close dialog fix from downstream
822855b50 Expose arguments in DummyPlatform.getMessage for more thorough tests
cda556554 VisualDiff: Show attribute changes for inline objects

Bug: T164724
Change-Id: Id51a927b540ea55abc1187f3556ad3052afe2453
2017-05-11 12:43:17 -07:00
James D. Forrester 2a81a95782 build: Enable MediaWiki.Commenting.FunctionComment.MissingParamTag
Change-Id: Ia6d758bebd45d31143a3dfd3357cc4687449a1cb
2017-05-11 08:19:44 -07:00
James D. Forrester 59715b66c2 build: Enable MediaWiki.Commenting.FunctionComment.MissingParamName
Change-Id: Id0b92c026690799db84f53402ce29913754bba0b
2017-05-11 08:19:44 -07:00
James D. Forrester 307a8f0ed7 build: Enable MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment
Change-Id: Id11360a266b5a5269856a9adbf3cd27cda52f178
2017-05-11 08:19:44 -07:00
James D. Forrester 945719f43e build: Enable MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName
Change-Id: Ib1e607addcb13c8fced2058ef5a80a96c95ff31e
2017-05-11 08:19:44 -07:00
James D. Forrester 9a27f80b3e build: Enable MediaWiki.Commenting.FunctionComment.MissingReturn
Change-Id: I714220880e91583a6e3cc575810fe02e3e822538
2017-05-11 08:19:44 -07:00
James D. Forrester e12651b1c2 build: Enable MediaWiki.Commenting.FunctionComment.ParamNameNoMatch
Change-Id: Ie1c745c4ea6ddaad6d41285ad444e7a91dc48cc9
2017-05-11 08:19:44 -07:00
James D. Forrester 56bfb7828c build: Bump mediawiki-codesniffer to 0.8.0 and make pass
Change-Id: If509e5ba639bcda497fe7898f6eb79265967139d
2017-05-11 08:19:44 -07:00
Volker E f695877de7 Rename deprecated Card to current TabPanel
Renaming CardLayout to TabPanelLayout and all connected code instances.
Follow-up to Icfe1652cc038dc131b6b855ce9b45040b8ee5178

Bug: T164903
Change-Id: I9ce4e31e390522d469e126fb3a4b05787cef7fef
2017-05-10 11:46:49 -07:00
David Lynch 2f40972807 MWWikitextDataTransferHandlerFactory: Don't reimplement getText
I forgot about getText in 41ca528705, apparently.

Bug: T163237
Change-Id: Ibb646fc03a0293845c4449cbbe6c822ba63751f8
2017-05-10 10:58:42 -05:00
jenkins-bot 862c3ca22e Merge "MWWikitextDataTransferHandlerFactory: skip getWikitextFragment if possible" 2017-05-10 15:51:16 +00:00
jenkins-bot 24e4cb7d8b Merge "Update VE core submodule to master (fbeb0db2c)" 2017-05-10 15:36:39 +00:00
James D. Forrester 229d6cdf3b Update VE core submodule to master (fbeb0db2c)
New changes:
d61440346 Add logging to the rebase server and client
d1d2539ae rebaser: Add script to convert a log file to a test case
0896d5f05 lib: Update README files for OOjs and OOjs UI
045ae87fb Localisation updates from https://translatewiki.net.
04b276e16 VisualDiff: Make annotation whitespace trimming configurable
dd04912e5 Localisation updates from https://translatewiki.net.
11fc30709 MobileContext: fix button spacing
7898acd0b Fix typos and minor lint issues
4e3e2deb9 Avoid using the global namespace in test files
1ed81efa1 build: Update eslint to 0.4.0 and make a pass

Bug: T163473
Bug: T164166
Change-Id: I4bab4260d6b05ff0277cacd167186336acc02080
2017-05-10 10:02:54 -05:00
Translation updater bot 31bea72f3a Localisation updates from https://translatewiki.net.
Change-Id: I1acf037adbf8456802f4321377b7209cb7268462
2017-05-09 23:10:18 +02:00
Umherirrender d4a5ca1d65 Add php-console-highlighter
Change-Id: I7fa246877e01a9c1131671935d1488c779b0b6b0
2017-05-09 17:41:02 +02:00
David Lynch 41ca528705 MWWikitextDataTransferHandlerFactory: skip getWikitextFragment if possible
This lets us avoid a fraction of a second lag when someone pastes a plain URL
into source mode.

Bug: T163237
Change-Id: I0e673856dec5f273fb92731b27494762299d2d6c
2017-05-09 10:19:15 -05:00
jenkins-bot 0f903b09d1 Merge "Generate visual diff only after switching to visual diff tab" 2017-05-09 13:31:36 +00:00
Ed Sanders debcd678b5 Generate visual diff only after switching to visual diff tab
Bug: T164724
Change-Id: I48e49d4b68cc769b3e9d061983de4c78b5ad5c34
2017-05-09 10:09:39 +00:00
James D. Forrester 40d115c806 Follow-up fa2efb9e5 part II: Don't try to call a private function
Change-Id: Icd7c15830c524b4492d0acc0528694cbc9a4f424
2017-05-08 16:42:20 -07:00
James D. Forrester a7f56f02e6 Follow-up fa2efb9e5: Also mount the service in ApiVisualEditorEdit
Whoops.

Change-Id: If1eac7fc745e8b21b47fbc6a8d40c3e45f4f52df
2017-05-08 14:42:21 -07:00
jenkins-bot d4c9638508 Merge "ApiVisualEditor: Move RESTbase initiation from construct() to execute()" 2017-05-08 21:20:42 +00:00
Translation updater bot 4296814235 Localisation updates from https://translatewiki.net.
Change-Id: I24e0b7ee282f937c0e7b1c44798a78439d723b63
2017-05-08 23:01:19 +02:00
Translation updater bot 3e31b869e8 Localisation updates from https://translatewiki.net.
Change-Id: I768ab6f09c49c7d3cdee0f0764a59ac0164bd445
2017-05-06 23:07:00 +02:00
Translation updater bot 021c91811e Localisation updates from https://translatewiki.net.
Change-Id: If05c18f72c4fb8276676c13e145ade05ec309739
2017-05-05 22:54:40 +02:00
jenkins-bot db73a1419c Merge "Run screenshot tests in series" 2017-05-05 15:55:41 +00:00
jenkins-bot a354bc3bf5 Merge "build: Update eslint to 0.4.0 and make pass" 2017-05-04 21:54:07 +00:00
Ed Sanders a866678c36 build: Update eslint to 0.4.0 and make pass
Change-Id: Id02a26bad70504cfe90bee6aab0fa3ea646b15d7
2017-05-04 21:28:17 +00:00
Translation updater bot 6f96b1e9d1 Localisation updates from https://translatewiki.net.
Change-Id: Id74033215796baa8238a3635d8cba3fc1b08e0a2
2017-05-04 23:11:44 +02:00
jenkins-bot 75b762d5c4 Merge "Specify suggested parent node types for tables" 2017-05-04 18:50:48 +00:00
jenkins-bot 20465377db Merge "Allow headings in divs" 2017-05-04 18:49:09 +00:00
jenkins-bot 6edf1522b4 Merge "Allow welcome dialog to be variable height" 2017-05-04 18:47:55 +00:00
jenkins-bot ea97f2ba85 Merge "Export publish-short message for mobile" 2017-05-04 18:09:52 +00:00
jenkins-bot a6f304c347 Merge "Un-blacklist the lintid parameter" 2017-05-04 14:56:51 +00:00
Ed Sanders 9d83efc747 Specify suggested parent node types for tables
This won't do anything useful until T164017 is resolved.

Bug: T164016
Change-Id: I39bffe2dc59a97888b81bdbe990e55ba95b0dd94
2017-05-04 14:50:49 +00:00
Ed Sanders 485a159037 Allow welcome dialog to be variable height
Bug: T164056
Change-Id: I277a709545151dbd51f92c21d6317a45b1088db2
2017-05-04 13:08:33 +01:00
Ed Sanders 8e6105fec8 Allow headings in divs
Bug: T164453
Change-Id: I986b1b376a592095c94d29a102278d4fde0a621f
2017-05-04 12:43:36 +01:00
Ed Sanders 9ea4dc2ad1 Export publish-short message for mobile
Bug: T164472
Change-Id: I143bc119583d73590a776bc0b1a43f90e19f513c
2017-05-04 12:41:21 +01:00
jenkins-bot 9b86ebae7f Merge "Follow-up 57a06a6: Use the same attribute name on read and on write" 2017-05-02 22:00:40 +00:00
James D. Forrester 486bbd7609 Follow-up 57a06a6: Use the same attribute name on read and on write
Bug: T164054
Change-Id: I6770f6c91248fcd9ab39322413874e20a1b65552
2017-05-02 14:42:22 -07:00
Translation updater bot eafe281fa3 Localisation updates from https://translatewiki.net.
Change-Id: Ic48e5776fde9b30c47656b01718bbbf764e6b2da
2017-05-02 23:22:42 +02:00
James D. Forrester fa2efb9e50 ApiVisualEditor: Move RESTbase initiation from construct() to execute()
There's no need e.g. in API documention queries to actually create the
RESTbase service connection, and it's quite an expensive operation to
do there.

Change-Id: I114fe0718338db7233ed94e4ffa90861b4e9ff50
2017-05-02 11:42:31 -07:00
Ed Sanders 54fc920622 Captcha improvements
* Fix focus and resize/scroll into view after the
  captcha has loaded (so after the image has loaded
  for FancyCaptch).
* Add margin between input and captcha
* Enable enter-to-submit on captch input field.
* Unify code for simple/math/questy and correctly
  render math as HTML (by looking at the mime type)

Change-Id: I10433cefbfea8569674c120dde5b489570e20966
2017-05-02 17:49:12 +01:00
Ed Sanders 998ae22b2d Follow-up I488fd7e74: Adjust saveFail calls for new function signature
Bug: T164157
Change-Id: I41b946af5a8b80211b0672d7012835f2c9e1dc2b
2017-05-02 16:39:04 +01:00
James D. Forrester f016f3dc9a Un-blacklist the lintid parameter
Bug: T160102
Depends-On: I59a7e0a3e8be32e4689cbf41c4904970902c4dff
Change-Id: Ie0e8d82db2dc3589c58a90a600ac0feb06159ed3
2017-05-02 07:41:11 -07:00
jenkins-bot a94535e1a1 Merge "Re-sync tests from VE-core into ext.visualEditor.test" 2017-05-01 22:46:24 +00:00
jenkins-bot 68d00a6a42 Merge "init: Fix checks for required skin elements to avoid false positives" 2017-05-01 22:37:16 +00:00
James D. Forrester 314bb053c7 Re-sync tests from VE-core into ext.visualEditor.test
Newly added:
* 'lib/ve/tests/ve.EventSequencer.test.js'
* 'lib/ve/tests/ve.Scheduler.test.js'
* 'lib/ve/tests/ve.Range.test.js'
* 'lib/ve/tests/dm/ve.dm.Annotation.test.js'
* 'lib/ve/tests/dm/ve.dm.TransactionBuilder.test.js'
* 'lib/ve/tests/dm/ve.dm.SourceSurfaceFragment.test.js'
* 'lib/ve/tests/dm/ve.dm.Scalable.test.js'
* 'lib/ve/tests/dm/selections/ve.dm.LinearSelection.test.js'
* 'lib/ve/tests/dm/selections/ve.dm.NullSelection.test.js'
* 'lib/ve/tests/dm/selections/ve.dm.TableSelection.test.js'
* 'lib/ve/tests/ce/ve.ce.RangeState.test.js'
* 'lib/ve/tests/ce/ve.ce.TextState.test.js'
* 'lib/ve/tests/ce/nodes/ve.ce.TableNode.test.js'
* 'lib/ve/tests/ui/ve.ui.Trigger.test.js'
* 'lib/ve/tests/ui/ve.ui.DiffElement.test.js'
* 'lib/ve/tests/ui/actions/ve.ui.ContentAction.test.js'
* 'lib/ve/tests/ui/actions/ve.ui.TableAction.test.js'
* 'lib/ve/tests/ui/ve.ui.DataTransferHandlerFactory.test.js'

Moved:
* 'lib/ve/tests/dm/ve.dm.LinkAnnotation.test.js' (up)
* 'lib/ve/tests/dm/ve.dm.LinearData.test.js' (down)

Ones skipped because they're currently broken:
* 'lib/ve/tests/dm/ve.dm.Change.test.js',
* 'lib/ve/tests/dm/ve.dm.TestRebaseClient.js',
* 'lib/ve/tests/dm/ve.dm.TestRebaseServer.js',
* 'lib/ve/tests/dm/ve.dm.RebaseServer.test.js',
* 'lib/ve/tests/init/ve.init.sa.Platform.test.js',
* 'lib/ve/tests/ui/dialogs/ve.ui.FindAndReplaceDialog.test.js'

Change-Id: I8343a67ffdb7255710e70bb9c822b9b006ae5aa7
2017-05-01 15:24:56 -07:00
James D. Forrester 84ec8739e3 Update VE core submodule to master (3b8a164a3)
New changes:
c61044a89 tests: Cover LinkAnnotation#getFragment()
a18e7bd75 tests: Cover <bdi> tags
4e6b991e2 VisualDiff: Don't describe internalItem changes
572ca6d09 VisualDiff: Don't try to render empty node changes
f794e511e LinkAnnotation: fix getFragment behavior
a5deb2b73 tests: Test rich annotations' describeChange()
88e1493a9 [BREAKING CHANGE] QUnit: Remove all code for counting tests
bbabdc425 Remove eslint:fix
31e6b40ce ve.dm.ElementLinearData.test: Cover getAnnotationIndexesFromOffset
97f7eda77 Transaction#isNoOp: Simple code is simple
dd97c627b MergeCellsContextItem: Make sure we're on a TableSelection

Bug: T163945
Bug: T164199
Change-Id: Iba64f64373e05f2dbe56d07dc9e8a8fe282887a9
2017-05-01 11:31:21 -07:00
jenkins-bot 089d765c0e Merge "Avoid global variables in tests and build" 2017-05-01 15:56:58 +00:00
jenkins-bot dc8935ae41 Merge "MWSignatureNode/Tool: Avoid global variables" 2017-05-01 15:49:37 +00:00