Commit graph

9324 commits

Author SHA1 Message Date
James D. Forrester ccbf32534f MWTransclusionDialog: Add a little margin to the addTemplateFieldset
Change-Id: I2549a9ca3df788cf92761b638a14760f8c413f46
2015-02-04 11:45:06 -08:00
jenkins-bot a7762b66a5 Merge "Adjust to ooui's show/hide css change" 2015-02-04 17:03:45 +00:00
jenkins-bot b43e798bb4 Merge "Make API module's LinkCache data transmission format more efficient" 2015-02-04 01:18:21 +00:00
jenkins-bot b5ea06c276 Merge "Improve references test data" 2015-02-04 01:16:19 +00:00
Roan Kattouw bc51095888 Improve references test data
* Remove unused extsrc
* Add <a>s inside of reference <span>s
* Add <li>s inside of reference list
* Change reference list to one for the g1 group rather than the main group
* Consequently, the reference defined inside the reference list moves to g1
** Due to a bug, explicitly set group="g1" on that ref for now

Change-Id: I266a4323c7353e00bd4288d5de51c252bbcdf3d7
2015-02-03 16:43:15 -08:00
jenkins-bot 82784d2217 Merge "[BrowserTest] Test for checking General Settings for media" 2015-02-04 00:30:16 +00:00
Translation updater bot 94b949db77 Localisation updates from https://translatewiki.net.
Change-Id: I91dae3d789b001b65429a6c38515011f9dfddb14
2015-02-03 22:57:12 +01:00
ryasmeen@wikimedia.org fcb9473c68 [BrowserTest] Test for checking General Settings for media
Change-Id: I503c01642a9fc23684912909e8da8e61998528a6
2015-02-03 21:53:40 +00:00
jenkins-bot 7928974236 Merge "test: Rebuild .rubocop_todo.yml" 2015-02-03 19:46:28 +00:00
jenkins-bot 184feebf1f Merge "ApiVisualEditor: Default format is jsonfm not json, so note this" 2015-02-03 19:45:36 +00:00
jenkins-bot b0dde09990 Merge "Update VE core submodule to master (c9b90ce)" 2015-02-03 19:45:23 +00:00
James D. Forrester 4208c63608 test: Rebuild .rubocop_todo.yml
Change-Id: Id2170f8d0f83edcd318eb469fb1f961d9172c7b3
2015-02-03 11:43:02 -08:00
Roan Kattouw e367ecc948 Make API module's LinkCache data transmission format more efficient
We used to send data like { title: { missing: true|false } }
With this change, we send data like { missing: [titles], existing: true|[titles] }
where 'existing' is set to true (assume all non-missing titles exist)
for current revisions and to an array of existing titles for
old revisions.

This is because we always output this data for links in the current
revision, even when loading an old revision: in that case we rely
on the client to request the omitted information, so there we can't
assume that all pages we don't have information about exist.

Bug: T88259
Change-Id: I7b58b3f669cc78fd81b60859cf76928a9087066f
2015-02-03 11:30:40 -08:00
jenkins-bot 0e926f5fcd Merge "Wait with showing edit notices until after the welcome dialog is closed" 2015-02-03 18:44:02 +00:00
James D. Forrester c3f716add8 ApiVisualEditor: Default format is jsonfm not json, so note this
Bug: T87582
Change-Id: I15952626c50690708d7cff8cc5a2983d8e4fb6bb
2015-02-03 10:24:51 -08:00
James D. Forrester e14626e6b2 Update VE core submodule to master (c9b90ce)
New changes:
39f2c09 Update scalable and view on direct attribute change
f02e8bb Use .prop() instead of .attr() where appropiate
32458db Use new window#updateSize method
50db41d Follow-up 8218942cb: Fix buildloader files (i18n-bot dirty grunt build)
cf6414b build: Use karma to v0.12.31
4856215 Use text input's setLabel functionality in find dialog
0e3ec9a Fix typo in F&R teardown
8c0bdf6 Reinstate keypress filtering for Firefox

Change-Id: I40888c23111ce0566de437be1399b63cf569cbcf
2015-02-03 10:18:40 -08:00
jenkins-bot 07e95ac365 Merge "[BrowserTest] Updating test for Media Settings interface" 2015-02-03 07:42:33 +00:00
Timo Tijhof 1d00894497 mw.Target: Add mw-body-content class before we attach surface
If added afterwards, this causes child elements styles with
'em'-values to get redrawn (or even animated).

Bug: T88387
Change-Id: Ic1aba14b7cfe0ff6e7191f0b6052ed9cc4585fcd
2015-02-02 20:25:02 -08:00
Alex Monk f3dd60dbe3 Hide extra space at the top of the single transclusion dialogs
Bug: T78045
Change-Id: I36974f69128a3e2c303076e3bd740f270e178c6b
2015-02-02 16:49:49 -08:00
Kunal Mehta 55d9e76188 Add extension.json
Needs Iff1523b86f754ca in mediawiki/core to work properly.

Bug: T87992
Change-Id: I869873eef6d19fdaee75201b87d8c4a8d4d05f3f
2015-02-02 16:31:00 -08:00
jenkins-bot 3d6aa68c7c Merge "Use ActionFieldLayout in the template placeholder page" 2015-02-02 23:48:27 +00:00
jenkins-bot 4d53c5d86a Merge "Increase user-input delay in MediaSearchWidget" 2015-02-02 23:47:21 +00:00
jenkins-bot d3bcefffb6 Merge "Do not send search query on whitespace" 2015-02-02 23:46:53 +00:00
jenkins-bot b0915d2df8 Merge "Update VE core submodule to master (8218942)" 2015-02-02 22:43:23 +00:00
jenkins-bot 2388ee443c Merge "build: Bump devDependencies to latest" 2015-02-02 22:43:21 +00:00
jenkins-bot 17ac459ecb Merge "[BrowserTest] Add basic test for table creation" 2015-02-02 22:39:04 +00:00
James D. Forrester bed038b509 build: Bump devDependencies to latest
Updates:
* grunt-contrib-csslint  0.3.1  ->  0.4.0
* grunt-contrib-jslint   0.10.0 -> 0.11.0
* grunt-jscs             0.8.1  ->  1.2.0

For jscs, leaving requireSpacesInsideArrayBrackets to avoid headaches for now.

Change-Id: I62d34444edbba65c8bd22d2fa5e50e16cabb0042
2015-02-02 14:30:39 -08:00
Moriel Schottlender 7734e7e71f Do not send search query on whitespace
If the user inserts a whitespace to the search input we don't want
the API query to be sent out.

Change-Id: I8cd68a6039ca98e3d78c9f1aa88f4098a1a99edc
2015-02-02 14:20:29 -08:00
Elena Tonkovidova 0240a51717 [BrowserTest] Add basic test for table creation
Change-Id: I07022e27da9d7114c18a82cdbd62e4cb82ddc7e2
2015-02-02 15:15:13 -07:00
James D. Forrester 9e8374bc71 Update VE core submodule to master (8218942)
New changes:
49ccab7 Localisation updates from https://translatewiki.net.
2a9dd3b Update OOjs UI to v0.6.4
bdcc3c5 Follow-up 6fc57d41: Update build results with grunt
960ee07 build: Fail in CI if there are resultant changes
ae85883 Rename file drop to data transfer
f8a530a Update OOjs UI to v0.6.5
9e6b090 Provide Platform#getConfig and shortcut ve#config
8218942 Localisation updates from https://translatewiki.net.

Change-Id: I1825668073aae66d33317ce31a6e2e179046ee1a
2015-02-02 14:14:39 -08:00
Moriel Schottlender 5d8108f229 Increase user-input delay in MediaSearchWidget
Increase the timeOut for the typing delay so we send search API
requests less frequently when the user types a search term.

Bug: T88188
Change-Id: Ibaf7184fb0eb9a02b460b0a66eabade791aea620
2015-02-02 14:01:49 -08:00
Translation updater bot 151a683743 Localisation updates from https://translatewiki.net.
Change-Id: I9382244c12e88bde8d58e42e55e40ba1457f1723
2015-02-02 22:32:25 +01:00
Moriel Schottlender 70fb0ea24f Use the new image cache in the media dialog
Prevent another api call for image sizing by caching the chosen
image in the media dialog with the imageInfoCache.

Bug: T88187
Change-Id: If2d905eeb5907f29b6839692509dfc07a06c230e
2015-02-02 19:32:46 +00:00
jenkins-bot d5f7bac940 Merge "Combine imageinfo requests" 2015-02-02 19:32:00 +00:00
Bartosz Dziewoński c0d69dd3db Wait with showing edit notices until after the welcome dialog is closed
Its white overlay is pretty good at obscuring them, and the notices popup
would close when the dialog is closed, making it very easy to miss them.

Also fixed indentation.

Bug: T86987
Change-Id: I9f93c4169de98ef77a1eb33fd31a0ec524b6d2b7
2015-02-02 17:25:02 +00:00
Ed Sanders f4bb7de786 Only re-render if the images is larger than the last rendering
Means we don't make unnecessary requests to the image API
and make the server side image resizer do extra work.

Bug: T88248
Change-Id: I20e1d37c913522eafc45a9a2e263051322b9b083
2015-02-01 13:07:48 -08:00
Alex Monk dc69b15db1 Template dialog: Disable 'Apply changes' until a change is made
Bug: T76926
Bug: T76927
Change-Id: I5a664f865c11690a19b754fc9877baf37e34edad
2015-01-31 03:19:06 +00:00
jenkins-bot 73e05df441 Merge "MWLinkTargetInputWidget: Check title is valid in MediaWiki" 2015-01-31 03:13:36 +00:00
jenkins-bot ed8f711b88 Merge "Don't corrupt href="./" in internal links" 2015-01-31 02:48:11 +00:00
Roan Kattouw 2bdb20b3c1 Don't corrupt href="./" in internal links
href="./" was being corrupted to href=""

Change-Id: Ieedd71a991c6b52225f2ac41ebe1a20e7533c19e
2015-01-30 18:44:57 -08:00
Alex Monk 9841d1012c Update "Watch this page" option when necessary
On load and change the user presses the button

Bug: T78694
Change-Id: I1df2836f8ba4ae647bfb142513e5de9f32ecd0fe
2015-01-31 02:43:59 +00:00
jenkins-bot cc6a629927 Merge "Use padding on save dialog panels so scrollbar is correctly positioned" 2015-01-31 02:31:02 +00:00
Ed Sanders e0d9b062d4 Use padding on save dialog panels so scrollbar is correctly positioned
Previously was using a margin so the scrollbar floated 1.25em from the
edge of the dialog.

Remove Apex-specific hack.

Change-Id: Idc953c492a6527a9216b77256d406fc3435ec0a9
2015-01-30 18:14:07 -08:00
ryasmeen@wikimedia.org eea130381a [BrowserTest] Updating test for Media Settings interface
Fixed the following:
1.The workflow was incomplete and incorporated new changes
2.Wrong css pointer to the first image
3.The Given statement was defined as When in step definition file
4.Removed unnecessary/obsolete steps that was making the test to fail while we can verify the basic functionality with miminum steps.

Change-Id: Ic8a265678900ed52bbed6d90e971d6c016ef610d
2015-01-30 18:11:33 -08:00
jenkins-bot 6230e80904 Merge "MWSaveDialog: Make the diff screen a larger rather than large size" 2015-01-31 02:02:21 +00:00
Moriel Schottlender a25ad02f60 Use ActionFieldLayout in the template placeholder page
Instead of manually attaching a button to the input widget, use the
newly available ActionFieldLayout.

Change-Id: I3a39f476e6115f97f11ea49fac5bfcd93bd8f841
2015-01-31 01:59:26 +00:00
Alex Monk 7876cc957a Combine imageinfo requests
By generalising LinkCache into ApiBatchQueue to request them all centrally

Bug: T75822
Change-Id: I097311ec2487bb1ae9f5d927c2c13c274ba716f9
2015-01-30 17:20:04 -08:00
jenkins-bot 7ff36511e4 Merge "Update VE core submodule to master (f2d7711)" 2015-01-31 00:59:28 +00:00
Ed Sanders e68eba2687 Update VE core submodule to master (f2d7711)
New changes:
4bb50c3 Localisation updates from https://translatewiki.net.
b7a5b87 dm.InternalList: Use DOM methods instead of jQuery .html()
5b09c9b Localisation updates from https://translatewiki.net.
b709d19 Add generic support of alignable nodes
a1f6c3d Localisation updates from https://translatewiki.net.
c29675a Add find next/previous to command help dialog
1e0b1ed Localisation updates from https://translatewiki.net.
7c76542 Don't render rowspan="1" colspan="1" for every table cell
99eb069 Show a message when an invalid regex is inputted in F&R

Local changes:
Bump command help height for new find next/prev commands

Change-Id: I0196775e499132262ba80acdbf1afc26ef4e8c77
2015-01-30 16:12:24 -08:00
Cmcmahon ee79759d5f [BrowserTest] remove old hack and fix "a is undefined" bug
This patch removes an old hack from the early days of VE.

Coincidentally, this hack is the root cause of the bug reported
by me, Erik Berhardson, and Elena Tonkovidova: T87446

Thanks Elena for finding this!

Bug: T87446
Change-Id: I325f60586373427acc2cd8f6e2e7d7accac80695
2015-01-30 22:56:15 +00:00