I have moved this block of code to the wrong place in change
13675e4a81. As a result,
`this.loaded` was being set early, so the dialog was treating
all of the pre-existing transclusion parts as newly inserted,
and the "Apply" button was therefore always enabled.
Bug: T209661
Change-Id: I3c1b45f91738ab6fc4a6f6d61ae5bf925c9a1bb5
Undoing the changes to an image caption or alt text, or to the gallery
caption, or to the order of images, or removing a previously added
image, will now disable the "Apply" button again.
The following cases will *not* disable the button again, and it is not
feasible to implement them:
* Re-adding a previously removed image with identical options
* Changing any caption to the old value by other means than "Undo"
* Changing image caption or alt text to the old value after switching
to a different image and then back
Bug: T206534
Change-Id: I7c19600e741211a6ba61837513497facbafc5cef
Use 'change' event instead of 'reorder' to respond to this event.
This also covers removing images now, so delete that code.
Bug: T206534
Bug: T209451
Change-Id: I9eda383be2ca7f02b42814d43e6b42961b9b96e7
New changes:
9c4d8f893 Place popups instead toolbar.$bar
0a1dd51e8 Only attach scroll listeners is toolbar is floatable
a8e07e026 Convert remaining $.Deferred() to ve.createDeferred()
Bug: T209192
Change-Id: I08328ca5f6aadad7db069dcd81734e1932e616e7
Enable the Apply changes/Done action if (i) the current contents
of the dialog inputs would change the gallery node or (ii) if the
user has interacted with inputs that alter the gallery caption or
images (including dragging/dropping or removing an image).
Bug: T206534
Change-Id: Ia6c1cc60d4f32ac66778e6973e2d400491f74128
New changes:
9be96b536 ve.ui.DesktopContext: Actually hide mobile '.ve-ui-linearContextItem-info'
ee8bceb13 LinearContextItem: Added text wrapping when it is too long
b565dd5c1 Update OOUI to v0.29.5
be24f8d32 TargetWidget: 'change' on document transact, not surface history
ffcd8518a Make table selections immutable (refactor #expand)
55a6f1bc1 Scroll 60px past toolbar on mobile to avoid context menu clash on Android
9bf6d9612 Scroll 30px above bottom of viewport on Android to keep selection handles visible
f391832c5 Localisation updates from https://translatewiki.net.
Bug: T188823
Bug: T202723
Bug: T204718
Change-Id: I7ee8382ef6bd27c0fe2a2b6a43df9c121c5c0a5f
For now this is just moving code. In the future we will
be able to make the handling of edit metadata async.
Change-Id: I7b442dfbdd890154de0e7faab1f6b0346caa8de0
New changes:
2c90701db Guard against ve.dm.Document not existing in argument check
68641c9c5 eslint: Disable jQuery/browser environment expectation in DM code
946d9c9d0 Abstract construction of Deferred objects and $.when
e20c7f8a3 ce.ResizableNode tests: increase coverage
0d1902e04 Localisation updates from https://translatewiki.net.
Bug: T195111
Bug: T208515
Change-Id: I84c08142e7cfe3254e54c0d691bc6dac9bcc30ce
New changes:
0c776b138 Reset styles on ce=false elements
a4b936b5e Update OOUI to v0.29.4
Bug: T207426
Change-Id: I77fb98f1416040902bc030368fddb380431c1198
* Make inserting secondary tab work with Minerva's non-standard structure
of navigation menus
* Distinguish primary and secondary tabs with tiny icons, since Minerva
hides their text
* Hide section edit link dividers (unnecessary when we use icons)
Bug: T208102
Change-Id: Ieaec60165617e3b423ec58857d6f0a0406e22b1d
Our behavior is now closer to the core wikitext editor.
This results in two minor changes:
* `<li>` elements are now correctly wrapped in an `<ul>`.
* "View full log" link is now only shown if there are more entries.
Change-Id: I3f30446fca5cab83155ce26ee4e5ab213fc5847a
New changes:
a190a64ab [BREAKING CHANGE] Do not cache document model data in DM selections
866f48853 Localisation updates from https://translatewiki.net.
Bug: T208228
Change-Id: I2c759ab5e390f3d29070509738191df8995ccf0a
