Commit graph

88 commits

Author SHA1 Message Date
James D. Forrester b518e55ef9 docs: Replace JSDuck with JSDoc (and pull-through VE with said change)
This is not great, but it's a start (and unblocks other pull-throughs).

New changes:
c401efc98 build: Replace jsduck with jsdoc for documentation
16ba162a0 JSDoc: @mixins -> @mixes
9e0a1f53b JSDoc: Fix complex return types
449b6cc0f Prefer arrow function callbacks
1539af2c8 Remove 'this' bindings in arrow functions
b760f3b14 Use arrow functions in OO.ui.Process steps
57c24109e Use arrow functions in jQuery callbacks
9622ccef9 Convert some remaining functions callbacks to arrow functions
f6c885021 Remove useless local variable
1cd800020 Clear branch node cache when rebuilding tree

Bug: T250843
Bug: T363329
Change-Id: I0f4878ca84b95e3f388b358b943f105637e455f9
2024-04-29 16:16:50 +01:00
Ed Sanders 9c24a458fd Update typos.json from lib/ve
Change-Id: Ibbb2cca5279cbf491271949854b6f5c03a3e2690
2024-03-28 13:55:03 +00:00
Ed Sanders 6730748707 Update banana check to use config.MessagesDirs
Add missing qqq strings so the tests will pass.

Bug: T346170
Change-Id: I7c43cb6db24d5c98341de2de4387689982b35e96
2023-09-21 09:18:30 -05:00
Ed Sanders 7616f5124f screenshots: Fix environment setup
* Use global.langs instead of just langs
* Wait for new welcomeDialogPromise

Change-Id: I7c4d48bca47eb4ce1a699f9160a0176dc77faa4b
2023-07-03 14:13:22 +01:00
Ed Sanders c9046685fa eslint: Lint all files except those in .eslintignore
Fix resulting errors (mostly useless escape in i18n files).

Change-Id: Id29c6aecece75d4a462bddb7e547ca5b4eb5c2db
2022-04-13 15:44:49 +01:00
Ed Sanders 60c2239e06 eslint: Lint root files with server rules
Change-Id: I872ab9dd7844eb8885dc30b40a2429875f7591c7
2022-03-17 23:39:53 +00:00
Ed Sanders 6a238b784e stylelint: Remove needless disables
Change-Id: I83c778f1b08b96e6a34068f497c7a72f2887ad4c
2020-11-19 23:38:11 +00:00
Ed Sanders 4545f53245 build: Update eslint-config-wikimedia to 0.17.0
Fix instances of variable shadowing.

Change-Id: I6e2befb020d7d4b506c7b46131eafacd951aa6d1
2020-08-18 13:16:49 +01:00
Ed Sanders b49ab55548 Gruntfile.js fixes
* Allow screenshot lang as option
* Remove unnecessary extensions option from eslint

Change-Id: Ie85fff074bbd9c0ebeae23e4b46f20ccd2faff26
2020-07-21 11:01:28 +00:00
Ed Sanders 6076708ff3 build: Update eslint-config-wikimedia to 0.16.0
Change-Id: I638e0f82949597e2a2e4ea18fc2f0258f225358c
2020-06-02 21:30:00 +01:00
Ed Sanders ffa3742ce1 build: Update linters
Change-Id: I03d1a8e63b730ad98ec07ad5f630ba82698de5be
2019-11-01 16:20:22 +00:00
Ed Sanders 3bb8710715 build: Update linters
Change-Id: If2a45c63f435911ebd7a83df9c0723d45c040a5e
2019-09-18 19:11:45 +01:00
DannyS712 00a98dd8f2 Fix 'paramter' typo in code and add to typos list, now covering PHP
Bug: T201491
Change-Id: I28d3b3871a2de54e575163bec7c364b68da8d5a6
2019-08-20 12:10:04 +01:00
Ed Sanders c8c81d2894 Grunt: Expand js{,on} pattern
Change-Id: I5061da3bced0a5c943038a9ec7bdbf8f38b35009
2019-08-05 21:15:37 +01:00
James D. Forrester aba4eeeda5 build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
Bug: T220036
Change-Id: Ia081ff5429547cf1c7e6d6e8b0cae94e8ca3e0b9
2019-05-06 13:33:16 -07:00
Ed Sanders e41fa15dd9 eslint: Enable caching
Makes re-running eslint faster on dev environments.

Change-Id: I15eea5d33ab8000053d96a3f2e11a7db3722772a
2019-02-19 18:53:11 +00:00
James D. Forrester 4e3511c9b7 build: Don't check for code typos in the i18n files
Change-Id: Icba5245269ca70aac0f6e11f92ecdc3ab63bbd06
2019-01-30 17:20:07 -08:00
Ed Sanders cefade60ea eslint: Turn on reportUnusedDisableDirectives
Change-Id: I61ef82857cd18656066c44d02bc9a3a41023a746
2018-12-14 14:13:03 +00:00
Amir Aharoni d80c383ad2 Move VisualEditor apihelp/apierror messages to a separate i18n file
Should be merged along with the corresponding translatewiki change:
I89310a638e75f974af77db313bb9ca090c437bf2

Change-Id: Ie5be8dc09051907d3aea53e33bdd1b3f849ead1e
Big: T189982
2018-09-26 01:53:54 +03:00
James D. Forrester c07d4815e3 build: Follow-up 99d3320573: Drop babel-polyfill, never used
Change-Id: I3eccd0c345b2c528bbb9458d404a3e0c91ae88f5
2018-04-25 12:59:50 -07:00
Volker E 4194d2ea63 build: Use SVGO option of 'grunt-image'
Making use of SVGO for further minification of
the included SVGs, based on MediaWiki's SVG Coding Conventions.

Also:
- Updating 'grunt image' to the latest version
- Improving SVGs accordingly

Bug: T185596
Change-Id: I882f0c6e2b5011fd51edb6106a3e22581989b834
2018-02-08 17:41:11 +00:00
Ed Sanders 7c8373106f Catch timeout errors in screenshot scripts
Bug: T184724
Change-Id: Ifbc03b1291c291dcfc862487766e3786f9bd437c
2018-01-11 18:42:22 +01:00
Bartosz Dziewoński 4987c07793 Move things that are not modules out of modules/ directory
* Move SpecialCollabPad.php to /.
* Move screenshots for BetaFeatures to images/.
* Move localisation messages to i18n/.

Change-Id: I874ae135a3ac58118c3dea105136c8c8b6fb41bc
2018-01-02 11:05:23 +01:00
James D. Forrester 9e185b8d54 Update VE core submodule to master (8d1c0d026)
New changes:
8581e9d86 LinearEnterKeyDownHandler: Enter behavior in nested lists
a91e77764 build: Put karma coverage reports in the top-level directory
81a88b4f1 build: Replace JSON code coverage report with clover.xml one

Bug: T108595
Change-Id: Ic5d83417d64126d9a27d46504fc8fcd338cd7f21
2017-10-26 15:57:01 -07:00
Umherirrender 9108ac69ee Update VE core submodule to master (6111ca575)
New changes:
6111ca575 Use json extension for .stylelintrc

Local changes:
Use json extension for .stylelintrc

Bug: T173516
Depends-On: Iba3b6cb37c458e896ade0f3a57a02540b4b4a0a0
Change-Id: I977ac6816e97cfb37bb2e0187e9d148bdb2148af
2017-08-21 11:28:34 -07:00
James D. Forrester 3a19558d6e build: Exclude /vendor from stylelint to avoid errors
Change-Id: I0505925ada34d951fd8d0cc810b47ebeccadf6bb
2017-07-06 13:40:38 -07:00
Umherirrender 766c140536 Run stylelint for less file
File was added with I151fc9bab3d3032f50c8d11be6b54e45a06fcc34

Change-Id: I5ef55e47a39e7ec3ea7c6066a048b1c4747b25ad
2017-06-29 19:30:37 +00:00
Ed Sanders 59b3f2e0dc Avoid global variables in tests and build
Change-Id: I44dd3c3980f88e660798962c4aa0229b62760796
2017-04-29 12:37:53 +01:00
Ed Sanders afa6c518d6 Remove eslint:fix
Not very useful now rules are stable.

Change-Id: I934dbae211f4c34f9a28385b125eaba2edda191d
2017-04-28 17:08:40 +01:00
James D. Forrester bef15b7a1e Update VE core submodule to master (bfb35aaef)
New changes:
57f8064b6 tests: Enforce dm unit test coverage at 20% per file and 80% globally
6f757c670 LinkAnnotation: add a getFragment method for consistency with MWInternalLinkAnnotation
c40a3f152 Drop the classList polyfill for IE9
d1af6c6bb Update OOjs UI to v0.21.1
bfb35aaef Localisation updates from https://translatewiki.net.

Bug: T162277
Change-Id: I5146bc421bb88e56bafadccefc7bbdee106504ea
2017-04-20 09:48:46 -07:00
Ed Sanders c0e188c602 VisualDiff automated screenshots
Change-Id: I422fc459ebc41a98f46e1ff7365a8ccaea2501d2
2017-03-28 22:43:02 +01:00
Ed Sanders e7346f57eb Separate screenshot test runner from specific tests
Change-Id: Ic0eb773086aa7b6078c5095c1ad89ef3f6236019
2017-03-28 18:15:25 +01:00
Ed Sanders 2a5f29897f Mark all node files as ES6
Change-Id: I85d1ea2bf26647d04891574d1cc5a9828a5d4bbb
2017-02-03 22:26:55 +00:00
Ed Sanders 8a64006aa4 Introduce grunt-image to minify screenshots
Makes the task a bit slower (~50%) but image filesizes
are reduced by 75% on average.

Change-Id: I90b7a4b7b4a1e4d3452d4e791fef55cdfc780f94
2017-02-03 15:19:12 +00:00
Timo Tijhof 7f613ed571 build: Change pathPrefix for eg-iframe back from '../lib' to 'lib'
Follows-up 94a7e34. The main fix there was adding the promise to
the example execution. The path change was not needed, and actually
breaks the demo, again. Only the 'docs' directory is published.
Accessing ../lib results in 404 Not Found after syncing to doc.wikimedia.org.

This is why we run 'grunt copy:jsduck', which copies those files into
the docs/ directory.

Change-Id: I2ea89bfbd980910510cbd8639f871ec931a768f1
2016-11-18 16:12:16 -08:00
Ed Sanders 94a7e34b9a build: Bring over eg-iframe fixes from core
Bug: T109170
Change-Id: Iccae8f92a19e76d6d203df68d483e0e1d8ca2c38
2016-11-18 15:17:14 -08:00
James D. Forrester 36befda61c build: Replace jscs and jshint with eslint
It's new, it's fresh, it's amazing, it's here.

Change-Id: I5dc784411f704685ed5cc763a2b2b1c5d3e5a610
2016-10-28 18:33:15 +00:00
Željko Filipin a7e216dd94 Increase Mocha and Selenium timeout for language screenshots to 40 s
Bug: T139613
Change-Id: I06499f89f340cfda2f30d80c2f8b721b71627bac
2016-08-31 10:00:48 +00:00
jenkins-bot 912f938fea Merge "Fix language screenshots timeout error" 2016-08-22 15:06:45 +00:00
Željko Filipin 15958af7d2 Fix language screenshots timeout error
Increase Mocha and Chrome timeout from 20 to 30 seconds.

Tool groups (headings/text style/indentation/insert/page settings) needs
more than 20 seconds.

Error message: Error: timeout of 20000ms exceeded

Bug: T139613
Change-Id: Id6d943a78d7109012c2372cbd3c00e6a80ed9583
2016-08-22 14:16:00 +00:00
Željko Filipin cbccba89a0 Remove Ruby implementation of language screenshots
It is now implemented in JavaScript/Node.js.

Bug: T132574
Change-Id: I299332ac4f849b951ba24564bd0282ca0e25afd2
2016-08-22 12:19:21 +02:00
Ed Sanders c3fa707adc screenshots: Add multi-language support
Change-Id: I1da41cffd946a76e5f09097decbc0a25562c9508
2016-06-27 12:23:45 +01:00
Ed Sanders 746321a29f Add screenshots grunt task for taking documentation screenshots
Imported from https://github.com/zeljkofilipin/language-screenshots

Bug: T119482
Bug: T132574
Co-authored-by: Željko Filipin <zeljko.filipin@gmail.com>
Change-Id: Idade622d1f3db0eb4b5f3fbc1a0eee401feeb600
2016-06-27 12:19:35 +01:00
Ed Sanders 91c990993a Fix watch path for css
Change-Id: I451c161c80b9185454b94557950f5b9bc1de117d
2016-05-20 13:55:41 +01:00
Ed Sanders 1dc780bcbd build: Use grunt-stylelint from npm
Add .stylelintrc as a symlink

Change-Id: I3c6d3f7f988f59b12655627e67ffb61fc7f882cd
2016-05-17 16:24:39 +01:00
Ed Sanders df49e5deb9 Remove remaining references to csslint
Change-Id: I1b5177bf746985a199bcc1ec713f886164c74760
2016-05-17 13:27:47 +01:00
Ed Sanders 99d3320573 build: Replace csslint with stylelint
For now just use the rules file in lib/ve, but eventually
this will be a preset.

Change-Id: I7fd79d3e1dce37aef066d416cd969e5fff1e962f
Depends-On: I17e0d23ddfedf64985495ab35d113ea08c03b1df
2016-05-16 22:30:49 +01:00
James D. Forrester 0b39a17870 Update VE core submodule to master (18bac29)
New changes:
3e587b8 sync-gh-pages: Fix "oojs-ui-apex.vector.css" 404 Not Found
0e53633 Toolbar: Add tooltip to structure group
7f0b6f7 Remove icon properties from windows
3a612b2 Fix positioning of mobile windows

Change-Id: I2a6995e61a76abfc0f77d3301c7c76593756463c
2016-03-29 10:10:26 -07:00
James D. Forrester fe8a9eff91 build: Add grunt-tyops
Change-Id: Idb30814e69356eb2b3282fae018c142295df922f
2015-12-09 00:53:34 +00:00
David Lynch 338aaf4064 Make jsonlint ignore more node_modules
Right now jsonlint only ignores the top-level node_modules. If you've
built docs, there'll be a node_modules folder somewhere in there...
containing the highly-problematic jsonlint test suite. So, ignore all
node_modules directories no matter where they are.

Change-Id: Ie6f3b8c5749036dae60551d7f07c1ae6ab72d722
2015-10-29 12:26:47 -05:00