Commit graph

20644 commits

Author SHA1 Message Date
Ed Sanders a2d4cca0f5 Never compare different categories
Bug: T336313
Change-Id: I287b228c5559ff1dd35226a9533a8a160dc70009
2023-05-30 21:13:29 +00:00
Ed Sanders b3673a1042 Converter tests: Use template literals to make HTML more legible
Depends-On: Iee8184dd6524b6dc12d19ac79761f6bd15990297
Change-Id: Idf0dde21e2ca0b01393ddda9e4d722fe50f0314f
2023-05-30 18:22:23 +01:00
jenkins-bot 139975c237 Merge "DesktopArticleTarget.init: Support '&editintro=…' in edit links" 2023-05-30 17:19:39 +00:00
jenkins-bot 94b5ae6ade Merge "DesktopArticleTarget.init: Simplify parameter types" 2023-05-30 17:18:39 +00:00
Ed Sanders be5f04b779 MWImage: Update test data
Add mw-file-element and mw-file-description classes by default.

Change-Id: I8b3a9c39582e1400b628e102c254021772513939
2023-05-30 15:07:19 +01:00
Bartosz Dziewoński 872679aeec DesktopArticleTarget.init: Support '&editintro=…' in edit links
Support gadgets adding '&editintro=…' to the default edit link.
It was already supported when opening the link in a new window, or
following an external link, or when clicking a section edit link.

Also, clean up these parameters when leaving the editor. This also
applies to 'preload', 'preloadparams', 'preloadtitle', 'summary'.

KNOWN BUG: Only works the first time the editor is loaded on the page.
Afterwards, DesktopArticleTarget.init lets DesktopArticleTarget handle
initialization, and it ignores extra parameters. I made a few attempts
at fixing this, but I only broke it further. I don't understand why
the history handling code even works. Maybe I'll come back to this.

Bug: T56029
Change-Id: I38fcde573f728250aaa125b391815e7fac7df362
2023-05-30 12:52:53 +00:00
Bartosz Dziewoński 53217d24e0 DesktopArticleTarget.init: Simplify parameter types
I prefer not having to think what type `link` is.
Just pass `linkUrl` everywhere.

Add and correct some related doc comments.

Change-Id: I5aa03149d7e1b32cd9ec19c589b16d03a9981857
2023-05-30 14:51:53 +02:00
jenkins-bot fda191a1cc Merge "Drop incomplete images generated by legacy parser" 2023-05-30 12:14:23 +00:00
jenkins-bot 5cdc10a9b2 Merge "ve.ui.MWGalleryDialog: Fix showing the search panel" 2023-05-30 12:10:25 +00:00
jenkins-bot 160569211e Merge "Hide 'editnotice-notext' message in VE (and mobile apps)" 2023-05-30 12:10:22 +00:00
Translation updater bot 32288de8a1 Localisation updates from https://translatewiki.net.
Change-Id: I226a77e67253d2c3448986017baa376edd43548f
2023-05-30 08:57:29 +02:00
Bartosz Dziewoński 03571e5a49 Update VE core submodule to master (b66c8ebb5)
New changes:
acfa59ff4 build: Upgrade grunt-tyops to 0.1.1
e214c0c3b Fixes/updates to various JSDoc type hints
ae844f5ea Patch WindowManager fix for multiple window managers

Change-Id: Idd6690b4f74e4bd720707fde96a361e2231e1eb0
2023-05-29 16:31:46 +02:00
Bartosz Dziewoński c5ef3946aa Update VE core submodule to master (1af79a8a0)
New changes:
4061523da rebaser: Update dependencies
ce15d3c90 build: Update eslint-config-wikimedia to 0.25.1
984f89e76 build: Update stylelint-config-wikimedia to 0.15.0
de6b75cc9 CompletionWidget & Action: Add missing documentation
052afafb5 HelpCompletionAction: Remove unused insertAndOpen method
d7c6aaa6a HelpCompletionAction: Remove unnecessary IIFE
7369779a3 Actions: Improve documentation of 'source' argument
7170d5076 HelpCompletionAction: Wait for widget to close before triggering tool
1c5e3bcbd Localisation updates from https://translatewiki.net.
4715457db HelpCompletionAction: Update getToolIndex to use new group titles
ee55ca615 CompletionAction/Widget: Rename 'trigger' to 'sequence'
1af79a8a0 Localisation updates from https://translatewiki.net.

Change-Id: I31c4a23003152d022cf96005f2d0d9eac0fbe4a8
2023-05-29 16:20:48 +02:00
Translation updater bot 8d491e51c3 Localisation updates from https://translatewiki.net.
Change-Id: I53feaf14d606b6aa43e9fd742d2c2f39b88b403d
2023-05-29 10:00:28 +02:00
Bartosz Dziewoński c37633bb83 Hide 'editnotice-notext' message in VE (and mobile apps)
Bug: T337633
Change-Id: I142edff12492e80b9c281353e6a53efc3339159c
2023-05-29 02:07:19 +00:00
Bartosz Dziewoński 3109c82cc4 ve.ui.MWGalleryDialog: Fix showing the search panel
Due to changes in StackLayout in OOUI v0.47.0 it is no longer able to
show a panel that was hidden using `.toggle( false )`.

Hiding it in this way seems to not have been needed anyway.

Bug: T337638
Change-Id: I81ed015986ed03fab1e65a7f3a826ac4296077b7
2023-05-29 01:30:29 +02:00
jenkins-bot 64fec813c3 Merge "Output config var when VE disabled by hook" 2023-05-26 19:01:31 +00:00
Ed Sanders fe14ffb76b Output config var when VE disabled by hook
Currently we only disable the desktop init code when this hook
returns false, but other integrations may want to know about this,
e.g. MobileFrontend.

Bug: T174180
Change-Id: I0268239cc9ea2d397140e617fcb6e4e104a75f31
2023-05-26 18:42:19 +00:00
libraryupgrader c8c1539efa build: Updating grunt-banana-checker to 0.11.0
Change-Id: I5c8d55432660824559aeb98ef3305d64baeb8508
2023-05-26 10:14:39 +00:00
Translation updater bot c0537de1f7 Localisation updates from https://translatewiki.net.
Change-Id: I3fe7c53c661e22acb6214e0284b7de9292d77bdc
2023-05-26 08:31:04 +02:00
jenkins-bot 14fb1dc1de Merge "build: Update stylelint-config-wikimedia to 0.15.0" 2023-05-25 15:40:16 +00:00
jenkins-bot 30a2cf1276 Merge "build: Update eslint-config-wikimedia to 0.25.1" 2023-05-25 15:40:13 +00:00
Ed Sanders dfe0283b07 Drop incomplete images generated by legacy parser
Bug: T337438
Change-Id: I076dd91bad9e5fe2758d41ac158cad8b86dbadce
2023-05-25 16:06:45 +01:00
jenkins-bot f6994eafe4 Merge ".gitignore: Add .vscode directory to .gitignore" 2023-05-25 11:29:55 +00:00
Translation updater bot d9f1e753a1 Localisation updates from https://translatewiki.net.
Change-Id: I5d453991156a7a4e6940ebb5a9fa83575cf8ceb9
2023-05-25 09:11:14 +02:00
Ed Sanders 7d39310830 build: Update stylelint-config-wikimedia to 0.15.0
Change-Id: I87b7975b91a25f994ef9fc55759549e4c27e3e8b
2023-05-24 18:50:35 +01:00
Ed Sanders 0b8884a5b7 build: Update eslint-config-wikimedia to 0.25.1
Change-Id: I1aa9e6d79936932f1af9e90a988a877510ce0565
2023-05-24 18:49:03 +01:00
Ed Sanders 9520ef84aa extension.json: Add missing i18n message
Change-Id: I92ac152c882815aa34e110f86f0e136c9a368724
2023-05-24 18:33:25 +01:00
Bartosz Dziewoński 87def83023 Update VE core submodule to master (b35a89fed)
New changes:
d81cb0acb build: Updating socket.io-parser to 4.2.3
4e651f21b ve.ui.Surface#scrollSelectionIntoView: Always position selection 5px from edge
2d86b5013 Improve setting of surface padding when context opens
c4b96b1c7 Update surface padding when toolbar dialog is positioned 'below'

Change-Id: I1229f009faf07cbdb03ee9b9995688d28f79b161
2023-05-24 16:53:47 +02:00
Ed Sanders a8d89720fb Update VE core submodule to master (12333c596)
New changes:
ae7760836 Localisation updates from https://translatewiki.net.
2307e9098 Update i18n lists
001958fb8 Add fuzzy bar to the help dialog
12333c596 HelpCompletionAction: rename and clean up commandGroups to toolGroups

Bug: T66905
Change-Id: I4f61a20cd199cbc864c9f6eef1e63984decf6e42
2023-05-23 17:38:07 +01:00
Translation updater bot f1a0209b41 Localisation updates from https://translatewiki.net.
Change-Id: Ie1f47e63dadbf626dd0a29bd4a9e427054ccc362
2023-05-23 08:23:14 +02:00
Translation updater bot 198b59b3ab Localisation updates from https://translatewiki.net.
Change-Id: I1284b424d88eb201a3458786c81a9589b7edb95d
2023-05-22 08:46:59 +02:00
jenkins-bot 76ea3c5244 Merge "tests: Make PHPUnit data providers static" 2023-05-21 11:34:36 +00:00
jenkins-bot 7c6c7e2649 Merge "build: Upgrade grunt-tyops to 0.1.1" 2023-05-21 09:59:58 +00:00
David Lynch 50c646050d Update VE core submodule to master (fd2f048e4)
Also supporting changes to support the new HelpCompletionAction,
including adding a preference to disable it if required.

New changes:
985b553cc Localisation updates from https://translatewiki.net.
aa26e27dc Localisation updates from https://translatewiki.net.
4cdc753ab Update OOUI to v0.47.0
bfc96a7ee Completions: always abandon if the first input is a space
616a6458f Fuzzy command bar
92b6525a2 Tweak the fuzzy command bar's behavior
fd2f048e4 Fuzzy bar: change how command groups are generated

Change-Id: Ic77b8822baecf5ad1ab466d94df29bb945172b55
2023-05-20 22:04:27 +03:00
Umherirrender 60e3706f09 tests: Make PHPUnit data providers static
Initally used a new sniff with autofix (T333745)

Bug: T332865
Change-Id: Iad05a3579ec60c576c4aa99567eb3e4fa4c30550
2023-05-20 17:02:35 +02:00
James D. Forrester 02d2689467 build: Upgrade grunt-tyops to 0.1.1
Change-Id: I5636218b0d7f45b9ea9c49b7651cc286e5e3e66e
2023-05-20 12:33:49 +03:00
jenkins-bot d6803f2533 Merge "Use edit intro messages and preloaded content from MediaWiki core" 2023-05-19 13:23:21 +00:00
jenkins-bot 1c5dbf6f79 Merge "Revert "onDifferenceEngineBeforeDiffTable: Return early on Special pages"" 2023-05-18 17:20:49 +00:00
HMonroy d88cd64e52 Revert "onDifferenceEngineBeforeDiffTable: Return early on Special pages"
This reverts commit f693822f64.

Reason for revert: Reworking

Depends-On: Idc96036564291a3887935dbff4ec476f4ad07068
Change-Id: Iee3f41c1b096b82ee61ecca9ddc5fcd044f1237c
2023-05-18 16:45:15 +00:00
HMonroy ba687994d3 Revert "onDifferenceEngineBeforeDiffTable: Update comment"
This reverts commit d7262d8483.

Reason for revert: Reworking

Change-Id: Idc96036564291a3887935dbff4ec476f4ad07068
2023-05-18 16:45:11 +00:00
Samtar 09bb8f9168
Revert "Move the diff-mode selector to the new DifferenceEngineBeforeDiffTable hook"
This reverts commit 7dbe385773.

Reason for revert: Reworking

Change-Id: I60784afa0d47e22acd9e8a981092784c84b250eb
2023-05-18 15:36:38 +01:00
Translation updater bot 32ccacac3a Localisation updates from https://translatewiki.net.
Change-Id: I8de2c3730ef0eda1a9a587cd341a31c6ed61ed89
2023-05-18 10:13:23 +02:00
TheresNoTime d7262d8483 onDifferenceEngineBeforeDiffTable: Update comment
Bug: T336582
Follows-up: I251db11e8cb5b785744ee2c111d20a346937b78c
Change-Id: Ic1a6a3d1fe50aab163ce0fb17ae7379bff172adb
2023-05-16 17:38:05 +00:00
TheresNoTime 9738d283db
.gitignore: Add .vscode directory to .gitignore
Add `.vscode` to `.gitignore`, delete existing `.vscode` directory

Change-Id: I0534fa9f08c8d50e0f7521185c7ed08e01630d3e
2023-05-16 12:50:51 +01:00
TheresNoTime f693822f64
onDifferenceEngineBeforeDiffTable: Return early on Special pages
Add a check of `$diff->getTitle()->getNamespace()` to ensure early
return on NS_SPECIAL pages.

Bug: T336582
Change-Id: I251db11e8cb5b785744ee2c111d20a346937b78c
2023-05-16 12:39:19 +01:00
Translation updater bot f16e870ff5 Localisation updates from https://translatewiki.net.
Change-Id: Ia1b7236830d940f39b957ffd630ce9da81b8ceaa
2023-05-16 08:19:38 +02:00
Bartosz Dziewoński a88084509d Use edit intro messages and preloaded content from MediaWiki core
Use MediaWiki core helpers to provide intro messages (including edit
notices), initial page content, and CSS classes for the edit area.

The following intro messages were previously unimplemented,
and will be shown now:
* 'sharedupload-desc-create'
* 'sharedupload-desc-edit'

The following intro messages were previously unimplemented,
but they only apply to pages where VE should never be available,
and will be shown now when editing those pages with 2017WTE:
* 'code-editing-intro'
* 'talkpagetext'

The following intro messages were previously unimplemented,
and are now explicitly skipped:
* 'editpage-head-copy-warn'

The following intro messages were previously unimplemented,
but they only apply to pages where neither VE nor 2017WTE should
ever be available:
* 'userinvalidconfigtitle'
* 'usercssyoucanpreview'
* 'userjsonyoucanpreview'
* 'userjsyoucanpreview'

Depends-On: If0b05710cb52a977bf4e85947d72d68683a0a29e
Bug: T201613
Change-Id: If26e39e383b983f7ee834ed6dd73b80e0545b068
2023-05-16 02:34:35 +02:00
Translation updater bot 44bcbfbe65 Localisation updates from https://translatewiki.net.
Change-Id: Ib34de1e9968f77caac2964139049501e977f48dd
2023-05-15 08:34:09 +02:00
jenkins-bot b237df5f39 Merge "Update VE core submodule to master (1a98e553b)" 2023-05-12 10:59:22 +00:00