Commit graph

8473 commits

Author SHA1 Message Date
Bartosz Dziewoński 2a55baaef7 Hide page status indicators even if they aren't :visible
The container is zero-height and zero-width, so jQuery doesn't
consider it :visible, and yet it still takes up visual space.

Bug: 72693
Change-Id: I3bed5394a2a64a9f7f0a331f850aa412b5b11b7d
2014-10-29 21:52:38 +01:00
jenkins-bot d73a692f57 Merge "Show warning on reference dialog when editing a reference used in more than one place" 2014-10-28 17:36:07 +00:00
jenkins-bot fe41462fb9 Merge "Update VE core submodule to master (ce4ee02)" 2014-10-28 17:34:37 +00:00
jenkins-bot 538c8769a6 Merge "Move core/MW messages to correct sections" 2014-10-28 17:31:50 +00:00
jenkins-bot 78b2a2885c Merge "Pass $overlay to widgets that need it" 2014-10-28 17:30:57 +00:00
Ed Sanders b89510c18b Move core/MW messages to correct sections
Also bring in visualeditor-version-label message from core.

Change-Id: I91ceba0e0550239a10329b327b5c6b5a01e460a9
2014-10-28 17:30:19 +00:00
James D. Forrester 564a6d0a90 Update VE core submodule to master (ce4ee02)
New changes:
56c30cb Remove font-size: 0.8em; rule for OOUI change
97d5111 Update OOjs UI to v0.1.0-pre (deccd11549)

Change-Id: I6efd0a9a996ae60404e029748ef71672cd5ab07d
2014-10-28 10:28:50 -07:00
jenkins-bot 5eb0baf55d Merge "Sprinke some child selectors around in MWTransclusionDialog.css" 2014-10-28 16:55:27 +00:00
jenkins-bot 370e15c1d9 Merge "Update VE core submodule to master (07b2eda)" 2014-10-28 16:55:26 +00:00
jenkins-bot 1cc342a462 Merge "Put icons back in template parameter search" 2014-10-28 16:48:52 +00:00
Translation updater bot 47115a9e4e Localisation updates from https://translatewiki.net.
Change-Id: I84552cda584f0078f60955c1872178b820beefe7
2014-10-28 15:21:02 +01:00
Alex Monk 3846e20463 Show warning on reference dialog when editing a reference used in more than one place
Bug: 52792
Change-Id: I2b183c3867ddb601041f9989964aa6f78b5f37e4
2014-10-28 12:58:50 +00:00
jenkins-bot ef90da1484 Merge "Override overflow: hidden; for <h3>s in the command help dialog" 2014-10-28 09:58:03 +00:00
Roan Kattouw 97dcee132d Put icons back in template parameter search
These disappeared when DecoratedOptionWidget was split
out of OptionWidget in I508c1555 in oojs-ui back in July,
and apparently no one noticed.

Make MWParameterResultWidget and MWMoreParameterResultWidget
inherit DecoratedOptionWidget instead of OptionWidget so
the icon config parameter is recognized again.

Change-Id: I08d8a0466c211a29eb62043131725073dece4eb5
2014-10-28 01:32:22 +00:00
Roan Kattouw dde33f2297 Update VE core submodule to master (07b2eda)
New changes:
4193898 Remove mw-specific message
f14b214 tests: Prepare repository for running RuboCop after every push to Gerrit
1d81df3 Localisation updates from https://translatewiki.net.
ded6be7 Localisation updates from https://translatewiki.net.
8417636 Localisation updates from https://translatewiki.net.
881d9e5 Make link inspector not close itself in IE... again
07b2eda Recalculate toolbar size on window resize

Change-Id: I5e3becac07cb20d39026786051ca28db0b3a13ca
2014-10-27 18:03:30 -07:00
Roan Kattouw 5876014c8f Override overflow: hidden; for <h3>s in the command help dialog
When this dialog is not isolated, MediaWiki's overflow: hidden;
rules for headings cut off part of the text in the <h3>s.

Compensates for Id425c56d9d24 in VE core.

Change-Id: Id9f6bd2bdbed0c6fe57e897c2415c3eceff900a6
2014-10-27 17:51:46 -07:00
Roan Kattouw 33c5b38b64 Remove oo-ui-{ltr,rtl} special-casing for parameter icons
It works both with and without in isolated dialogs,
but styling things this way breaks in non-isolated dialogs.

Change-Id: Ia498b48d8c199f50df326ddeb61d958cbe2c520d
2014-10-27 17:49:42 -07:00
Roan Kattouw d0f273d6db Sprinke some child selectors around in MWTransclusionDialog.css
Indiscriminately styling all .oo-ui-widget elements with a
descendant selector is very evil, use a child selector instead.
The use of a descendant selector broke inline dropdowns.

Change-Id: I25c5007ef1ffab9e59c46c3b11270b8f77610327
2014-10-27 17:38:20 -07:00
Roan Kattouw 61e8115e8b Pass $overlay to widgets that need it
Also change this.$overlay (which doesn't even exist) to
config.$overlay in MWTemplatePlaceholderPage and document it.

Compensates for I39df86373ea in oojs-ui.

Change-Id: I4a233c058439d6cfb38d80ece890c8fe57d58f49
2014-10-27 17:36:19 -07:00
jenkins-bot 0dad360036 Merge "Disable parameter add icon when there's no transclusion parts" 2014-10-27 20:39:46 +00:00
Alex Monk d128378f5a Disable parameter add icon when there's no transclusion parts
Would put this code in onBookletLayoutSet, but that doesn't appear to be
getting called in this case.

Have to detect whether or not we should be changing the disabled status, rather
than just setting it straight away, which would break every other case where
onBookletLayoutSet is called.

Bug: 63158
Change-Id: I6f62479291424d9b2ee0e42481dec9d085169c63
2014-10-27 20:33:35 +00:00
Translation updater bot dfd00e83c6 Localisation updates from https://translatewiki.net.
Change-Id: I5d874f7c0cfa4bdfcca99b7336efe9de03cfb356
2014-10-27 20:21:32 +01:00
jenkins-bot 4e8cf83265 Merge "Apply pre-save transform to template previews" 2014-10-27 18:38:40 +00:00
jenkins-bot 20b20bc97c Merge "Move autoValue logic from ui.MWParameterPage to dm.MWParameterModel" 2014-10-27 18:15:08 +00:00
jenkins-bot 1f4e77bc05 Merge "Allow removing all parts from a transclusion to remove the transclusion" 2014-10-27 18:13:08 +00:00
Ed Sanders ab365ccacc Fix selection check in wikitext warning
Change-Id: I2f084eb4ee29bd166b05163cd2d6e64e0a4f136d
2014-10-27 16:21:24 +00:00
Alex Monk 8120dac27b Move autoValue logic from ui.MWParameterPage to dm.MWParameterModel
Also add missing MWParameterModel#getDefaultValue

Bug: 72404
Change-Id: I4bb117d419f3845f44e321f848e95bb246a24e24
2014-10-27 03:31:36 +00:00
jenkins-bot 358268be7a Merge "Make sure initialHash exists before checking its value" 2014-10-27 03:25:10 +00:00
Translation updater bot f4a5139012 Localisation updates from https://translatewiki.net.
Change-Id: Icb816a369cf513f88bc05a6792f6ed7aa484fbad
2014-10-25 22:48:51 +02:00
Alex Monk c4dfd834dd Allow removing all parts from a transclusion to remove the transclusion
Rather than make a new function to determine whether it should be apply-able or
not (and run some checks again), move the enable/disable call into a new
function to do these checks and set the result.

Bug: 72191
Change-Id: I133afa1784e1afd44054f93ed84018894f7c6400
2014-10-25 00:13:29 +01:00
Moriel Schottlender b8f96bb512 Make sure initialHash exists before checking its value
(Followup on If17b50cc4a39993)
Make sure initialHash is set before checking and changing its value
in the MWImageModel method. If a user chooses a brand new image to
insert into the document (an insertion rather than update) then the
initial hash is empty, and changing its values will fail with an
error message.

Bug: 72492
Change-Id: I3f9ea74891cc0ab77a07fa5d4e9cbc591f5b93e6
2014-10-24 16:18:06 -04:00
jenkins-bot 5d6ee06b84 Merge "Fix wikitext warning: Get range from selection before trying to find start" 2014-10-24 17:27:44 +00:00
Alex Monk 4639a1c044 Fix wikitext warning: Get range from selection before trying to find start
Bug: 72475
Change-Id: Ib43d9c6b9b46be461354b3b5bbdf9d5de90887a6
2014-10-24 17:18:08 +01:00
suchetag 0b983d9f82 Add template button remains disabled when entering space as a template
Bug: 71998
Change-Id: I69edcf7ece1ccd02df8fbae20a8149e8a1981a44
2014-10-24 06:54:00 +05:30
Translation updater bot 263f28b09d Localisation updates from https://translatewiki.net.
Change-Id: I812e93679a651cabb7cb96ee14757e2ba601be27
2014-10-23 23:27:41 +02:00
jenkins-bot 7c8931f655 Merge "Update initialHash after getting defaultDimensions in image model" 2014-10-23 20:00:20 +00:00
James D. Forrester 50e59f328a Update VE core submodule to master (27de0c4)
New changes:
016642e Remove crazy space exception from link validity regex
b538834 Remove insertion inspector class
50839f5 Work around *another* browser bug in getBoundingClientRect
e2e916a Increase inspector height by 1 to deal with Chrome opacity bug
9e387da Update OOjs UI to v0.1.0-pre (40de4dabe6)
27de0c4 Follow-up I2f34448: ve.ui.InsertionInspector.js was deleted, so remove from manifest

Change-Id: If979beb12fe865c0e217b93381769264e2efdc20
2014-10-22 17:14:29 -07:00
Roan Kattouw 36060a2782 Apply pre-save transform to template previews
Because autoValues often involve {{subst:}}

Bug: 71157
Change-Id: I2787f2595f8c4b8838a3e9ac9ba898af0b43b58e
2014-10-22 15:47:51 -07:00
Roan Kattouw 2d3bf973d2 Actually set parameter autoValues as values
The autoValue was displayed in the UI but was never
actually written into the template model, unless you
changed the text input and then undid your change.

Bug: 71157
Change-Id: I08e2ba88c24fdee030104c6fb9baafb558ce8a80
2014-10-22 15:46:20 -07:00
jenkins-bot 5a3c2a9f4c Merge "MWLinkNodeInspector: Provide an open button here too" 2014-10-22 03:04:15 +00:00
jenkins-bot eaa3b222f7 Merge "Open the linkNode inspector when pressing Ctrl+K on a link node" 2014-10-22 03:03:32 +00:00
James D. Forrester 7149cc5279 MWLinkNodeInspector: Provide an open button here too
Also add validation now that we need it for the open button.

Bug: 71904
Change-Id: I50515671bb3ff08da8dc6c247c9959c27957c867
2014-10-21 20:00:27 -07:00
Roan Kattouw 4bc24e795d Open the linkNode inspector when pressing Ctrl+K on a link node
* Introduced MWLinkAction which opens the right link inspector
  based on what is selected.
* Added MWLinkInspectorTool overriding core's 'link' tool that
  executes MWLinkAction
* Removed MWLinkNodeInspectorTool and linkNode command,
  they're unneeded now

Bug: 72150
Change-Id: I03bd6ab1f67f31a6e6cb717cf4298e80e64637b7
2014-10-21 19:47:42 -07:00
James D. Forrester 4d12d6c443 Update VE core submodule to master (5fed7c4)
New changes:
a554ea6 Add button to debug bar to enable input debugging
8480f41 Add 'valid' event to MediaSizeWidget
a1c42b5 Update OOjs UI to v0.1.0-pre (531d497d3b)
3910521 Prevent JS error in getNativeRange()

Change-Id: I5f13b5d5d0a15579ed2027a09e3fc3933346b2f7
2014-10-21 19:19:29 -07:00
jenkins-bot 9d25c2823d Merge "Drop nonexistent &redirect= parameter from API requests" 2014-10-22 01:38:32 +00:00
jenkins-bot d0c794b08d Merge "Disable the reuse citation tool when selection is null" 2014-10-22 01:36:32 +00:00
Roan Kattouw 942440c7df Drop nonexistent &redirect= parameter from API requests
The correct parameter is &redirects=. Which we really don't want
to use anyway, because if Foo->Bar, using &redirects=1 would
cause a search for "Fo" to return "Bar" as a search suggestion
with no explanation why (and "Foo" wouldn't be visible).

This isn't unsurmountable, we could put in handling similar to
how the category widget handles redirects, but what this code
is trying to do by passing this parameter is definitely wrong.

Change-Id: Idd12c03aaef897d7c1dc70b2a7692e7d71980efe
2014-10-21 18:34:27 -07:00
Roan Kattouw ecc4c6e188 Disable the reuse citation tool when selection is null
This was broken when requiresRange was renamed to requiresSelection
and MWUseExistingReferenceDialogTool wasn't updated.

Change-Id: Ia1018520fc253e2f09755d5e85a94a325df80005
2014-10-21 18:33:19 -07:00
jenkins-bot c724bf3e0e Merge "[BrowserTest] Add "Then…" steps to Cite Basic test" 2014-10-22 01:01:59 +00:00
Cmcmahon 0a3ac40288 [BrowserTest] Add "Then…" steps to Cite Basic test
Change-Id: I43b28e8c95d3da0c3b94a8ea12ff3c376eedb1b5
2014-10-22 01:00:08 +00:00