Commit graph

63 commits

Author SHA1 Message Date
Ed Sanders 651756c4fc eslint: Enable the mediawiki/class-doc rule and make pass
Also minor other adjustments

Change-Id: I9ee48359e3e53799f2f6240e44b53972283ce328
2020-04-17 22:59:11 +01:00
Ed Sanders 5428f5452a screenshots: Fix local test runner
Broke after selenium-webdriver update

Change-Id: I424607c9ba741a88b993d2d279045f30c1d50ab7
2020-02-25 12:45:20 +00:00
Ed Sanders bd848eb386 screenshots: Fix some timing issues
Change-Id: I5cfb4025833699bffd4ade3fb659f41c268b8bb2
2020-02-25 12:45:20 +00:00
Ed Sanders fd43701de2 eslint: Remove unused prefer-template rule; use proper globals values
Change-Id: If98be563304baa46a746d78c94dd8945f94d545c
2019-10-07 17:22:24 +00:00
DannyS712 00a98dd8f2 Fix 'paramter' typo in code and add to typos list, now covering PHP
Bug: T201491
Change-Id: I28d3b3871a2de54e575163bec7c364b68da8d5a6
2019-08-20 12:10:04 +01:00
James D. Forrester 05fb44ae56 build: Upgrade eslint-config-wikimedia from 0.12.0 to 0.13.1
Change-Id: I43f407da92f59a8bf758cc2586e84aa5e18d9ab0
2019-08-02 09:51:07 -07:00
Ed Sanders 20561e7e10 Remove citefromid alias support
Change-Id: I74d67a2ea5118ee18c462ccfea06a72cc73c627b
2019-06-20 16:06:07 +01:00
Ed Sanders f9330c8564 Replace the save button with a save tool
Now shows correct tooltip for save button (including
the access key).

Bug: T163142
Change-Id: If14a1a5a5829fc215cb79827392173dc05c4bdd7
2019-04-30 19:32:33 +00:00
Ed Sanders d784304ed1 Rename 'citefromid' to 'citoid'
Backwards compatible change can be merged ahead of change
in Citoid repo.

Bug: T219512
Change-Id: I2d7e389cc01808e41353681dd2448a0385543f2e
2019-04-03 13:19:45 +01:00
Ed Sanders 332aa1f3d2 build: Update eslint-config-wikimedia to 0.11.0
Change-Id: I5a294705eed1760e2d4dde33934d2ffb12e29525
2019-02-20 20:23:43 +00:00
Ed Sanders 375edf0182 Fix uncaught jQuery linting errors
Change-Id: I17482ec84c95e88881ab4bee9b9cadb27b2dc472
2019-01-18 21:03:38 +00:00
Ed Sanders 74f6c4899c build: Update eslint-config-wikimedia to 0.10.0
Change-Id: I63a0ebf0b31a0d5d4e680a4e2a5a0be4850be165
2019-01-08 17:00:09 +00:00
Ed Sanders 1a3e8a958c build: Use eslint-config-wikimedia v0.9.0 and make pass
Change-Id: Idb57fc12e7822cf17e10dbb726480fc7de0ae199
2018-11-21 16:51:20 +00:00
Ed Sanders 1a4158f6d2 Use Tool.$link.focus() for highlighting now OOUI styles :focus
Change-Id: Ia5b4c68cb49e3954aae7de9a8907f1fb9f205e2c
2018-05-02 12:52:17 +01:00
jenkins-bot aca63b6189 Merge "Catch timeout errors in screenshot scripts" 2018-01-13 11:09:25 +00:00
Željko Filipin 4c44340597 ESLint parserOptions is reduntant when env is set to es6
Bug: T184724
Change-Id: If39d3efc6476a94aaeb5956f142d2b12bd9be9bb
2018-01-12 17:04:35 +01:00
Ed Sanders 7c8373106f Catch timeout errors in screenshot scripts
Bug: T184724
Change-Id: Ifbc03b1291c291dcfc862487766e3786f9bd437c
2018-01-11 18:42:22 +01:00
David Lynch 64944c119a Use mw.storage instead of localStorage
mw.storage catches errors, so we won't crash horribly when the user has
localStorage disabled / full.

Bug: T181822
Change-Id: I212994eb535b9a8fb5f6c09deaa10b16c3d7f10e
2018-01-10 11:44:24 -06:00
Ed Sanders ec4053f2da Add screenshot tasks for manual and re-use tabs in Citoid
Bug: T180363
Change-Id: Icf9a370e7b80611b1f5e897e31e0004b656dabac
2017-11-13 17:39:47 +00:00
Ed Sanders 835a775a49 build: Upgrade grunt-eslint from 19.0.0 to 20.0.0
Mostly indent and regex fixes.

Change-Id: Iaf9d02363c78cb71deec5c4cab53a05b67f60600
2017-07-18 12:55:33 +01:00
Ed Sanders 75d583a0d9 Use static parseDocument method
Change-Id: I545a58ffcbf1c7c57c197f4858958de835a40394
Depends-On: I5b36e187a5e8bb68b47b2fccf5b46c08b81b01d9
2017-06-08 14:43:09 +01:00
Ed Sanders f178061117 [DEPRECATING CHANGE] Make Target#createModelFromDom static
Change-Id: I019689f87ac0f7f40a8a7600029b5ce1bc92e77f
2017-06-08 14:35:31 +01:00
jenkins-bot db73a1419c Merge "Run screenshot tests in series" 2017-05-05 15:55:41 +00:00
Ed Sanders a866678c36 build: Update eslint to 0.4.0 and make pass
Change-Id: Id02a26bad70504cfe90bee6aab0fa3ea646b15d7
2017-05-04 21:28:17 +00:00
Ed Sanders 63d711dd48 Run screenshot tests in series
Use one test context, and store language as a property.

Change-Id: I4809c41331c4d70a024eec48f30eef207a09a098
2017-04-28 16:01:22 +01:00
Ed Sanders 08bfe509df Screenshots: Hack the toolbar to display "Article" instead of "Help page"
Change-Id: Iad632a23939712d8d7feb3097b714bfa30d362a1
2017-04-19 13:07:34 +01:00
Željko Filipin ca46a67843 Fix LanguageScreenshotBot by using an existing article
LanguageScreenshotBot failed because it tries to open VisualEditor on a
page that does not exist.

Bug: T162454
Change-Id: I5539c54b7c0ce1f302df0962dad19797d26953da
2017-04-19 12:28:38 +01:00
Ed Sanders c0e188c602 VisualDiff automated screenshots
Change-Id: I422fc459ebc41a98f46e1ff7365a8ccaea2501d2
2017-03-28 22:43:02 +01:00
Ed Sanders e7346f57eb Separate screenshot test runner from specific tests
Change-Id: Ic0eb773086aa7b6078c5095c1ad89ef3f6236019
2017-03-28 18:15:25 +01:00
Ed Sanders 15c986d128 Use var/let in screenshot.js
Change-Id: I70082dd6e4df38616e5c33c2b71f0aaae22bac63
2017-02-03 22:57:47 +00:00
Ed Sanders 2a5f29897f Mark all node files as ES6
Change-Id: I85d1ea2bf26647d04891574d1cc5a9828a5d4bbb
2017-02-03 22:26:55 +00:00
Volker E 1a7e325eb5 Replace outdated color with current one
Replacing outdated color with `#36c` from overhauled color palette.
Also making focus following common outline-width.

Bug: T153486
Change-Id: I5c76a788fff21c53bd193628bc610f38d388179f
2017-01-11 15:16:59 -08:00
James D. Forrester 36befda61c build: Replace jscs and jshint with eslint
It's new, it's fresh, it's amazing, it's here.

Change-Id: I5dc784411f704685ed5cc763a2b2b1c5d3e5a610
2016-10-28 18:33:15 +00:00
Željko Filipin a7e216dd94 Increase Mocha and Selenium timeout for language screenshots to 40 s
Bug: T139613
Change-Id: I06499f89f340cfda2f30d80c2f8b721b71627bac
2016-08-31 10:00:48 +00:00
Željko Filipin 2777a9fc2d Run language screenshots on Windows
Fonts do not look good on Linux and Mac is slow.

Bug: T141369
Change-Id: I48347dabb8a68c97b615ffda94e515e6347b7d3c
2016-08-24 14:43:05 +00:00
Željko Filipin 15958af7d2 Fix language screenshots timeout error
Increase Mocha and Chrome timeout from 20 to 30 seconds.

Tool groups (headings/text style/indentation/insert/page settings) needs
more than 20 seconds.

Error message: Error: timeout of 20000ms exceeded

Bug: T139613
Change-Id: Id6d943a78d7109012c2372cbd3c00e6a80ed9583
2016-08-22 14:16:00 +00:00
Željko Filipin 22f36fd3ac Run language screenshots from Jenkins
Bug: T139613
Change-Id: I869dd27f58e7972456fb09792262cd1be0aeeaa0
2016-07-25 09:43:40 +00:00
Ed Sanders 0246f77cb6 screenshots: Restore save button to more settings task
Change-Id: I847cf81f3092be50f0fcf019eea3226decedd445
2016-06-29 23:02:43 +01:00
Ed Sanders 2780c86bff screenshots: Add task for plain insert menu
Change-Id: Id77df7ff88e030b283b1f94ff85537bfd4f20345
2016-06-29 20:39:42 +01:00
Ed Sanders fcc343eb20 screenshots: Add category and page settings menu item tasks
Change-Id: Iacf52612eedc74b050a78f1ddb23e7a443afebe2
2016-06-29 16:02:32 +01:00
James D. Forrester 5ef5d4d24c screenshots: Run on enwiki rather than Beta Cluster for content
Change-Id: Ia06c2a39905d0a899f7ff45f1beec4e0e4236fee
2016-06-29 14:30:15 +00:00
jenkins-bot 7ac5943daa Merge "screenshots: De-duplicate menu screenshotting code" 2016-06-29 14:23:31 +00:00
jenkins-bot 3e8d3ce9b1 Merge "screenshots: Correct name of a list menu screenshot" 2016-06-29 14:19:25 +00:00
James D. Forrester 65d24b0dea screenshots: Correct name of a list menu screenshot
Change-Id: I3d0921e82b7c9608ab0cca15ffdbcb2d98f56cf5
2016-06-29 15:12:39 +01:00
Ed Sanders 0b89467ab9 screenshots: De-duplicate menu screenshotting code
Change-Id: I88ace5b2b6ab3b629ddf217f314e1a33c2e33287
2016-06-29 15:10:58 +01:00
Ed Sanders 8cc9a81857 screenshots: Add screenshots for highlighted items in the insert menu
Change-Id: I4232a0709ea241ad173543fdf4eab0b4c3ce02a2
2016-06-29 14:32:31 +01:00
Ed Sanders 5c1a2607d9 screenshots: Add delay to wait for link inspector images to load
Change-Id: I36168f08cc2a8ec320afc8c87ae6518d50db2c57
2016-06-29 13:44:25 +01:00
Ed Sanders 4fef9d141c screenshots: References list dialog
Change-Id: I5a14412198cdc3cf48cd574195716fe0070f0158
2016-06-29 13:36:00 +01:00
Ed Sanders d29f874983 screenshots: Add task for link inspector search results
Change-Id: I0cbe71a21e85eeaf4edaf49c8499c6f87a36c1fd
2016-06-28 22:43:01 +01:00
Ed Sanders 7278771254 screenshots: Crop to viewport
Change-Id: I2a50e4b090cdd9a6d60c85fad438cee3cc7e0b1f
2016-06-28 22:43:01 +01:00