Commit graph

13569 commits

Author SHA1 Message Date
jenkins-bot caa4f555cd Merge "Update VE core submodule to master (7a8829509)" 2017-09-05 19:39:14 +00:00
jenkins-bot 9ef0f71983 Merge "Stop requiring deprecated EditPage::getCheckboxes()" 2017-09-05 18:00:52 +00:00
Arlo Breault 3e96d8ed5a Use figure-inline instead of span for inline media
Bug: T118520
Depends-On: I0681c39301e52a3368b53d38ed518ac66e18f0d6
Change-Id: Id8ec5b77207f43fc7c379b35859dc09f264e2c04
2017-09-05 12:17:14 -04:00
Thalia a3902ebff8 Add feedback link for visual diff inside save dialog
Bug: T170665
Change-Id: I0b09b1089c834a013ad5fee4ecdf75b483b56323
2017-09-05 13:35:37 +01:00
Prateek Saxena 2b923c0346 MWTemplateDialog: BookletLayout: Use findClosestPage instead of getClosestPage
Bug: T76630
Depends-on: I068dad8c79c4bda6ea37ab6a1eb6ba72ab6f7dc0
Change-Id: Ib4e380aa6cd0cacbadd42bdf447ddee6443f22ef
2017-09-05 12:13:41 +10:00
Translation updater bot 828ce717f3 Localisation updates from https://translatewiki.net.
Change-Id: I09c9579992c49851382f4c0d54af59e1552a6532
2017-09-04 22:52:04 +02:00
Translation updater bot ef753a82ce Localisation updates from https://translatewiki.net.
Change-Id: Ib1ff25374fcf0df6c0e8ffc3d402adbd3b36dfa1
2017-09-03 22:41:47 +02:00
jenkins-bot 7a4cdd3cd1 Merge "Use Html::hidden()" 2017-09-03 15:19:32 +00:00
Kunal Mehta 34ba904d68 Use Html::hidden()
This simplifies a little bit of code.

Change-Id: Ie76d68864f34000fc60d78f862f447f4260fb551
2017-09-03 00:30:13 -07:00
jenkins-bot d743fa7c1f Merge "Disable VE on Special:Undelete" 2017-08-31 23:40:41 +00:00
James D. Forrester a18508e7e4 Update VE core submodule to master (7a8829509)
New changes:
4523b11c0 Make RebaseServer asynchronous
2eb09b6ba Localisation updates from https://translatewiki.net.
c806b7131 Remove execute mode from non-executable
622c62c9e Follow-up 2eb09b6b: Add kab to build to unbreak the repo
b69e4ba1c DiffElement: Fix insert/delete-to-end loops
8c6dfdde9 FocusableNode: Redraw highlights using focus toggle
2bded2d16 Debounce FocusableNode#redrawHighlights
3cb7844b1 Localisation updates from https://translatewiki.net.
fb13239b2 VisualDiff: Don't diff close elements
7a8829509 Localisation updates from https://translatewiki.net.

Also, exempt the Rebaser ES6 code from jsduck, as we do in VE itself,
because jsduck doesn't understand ES6 syntax.

Bug: T129541
Bug: T171862
Bug: T173860
Change-Id: Ia08022afb0b94b8a6907f97b161bc04d8a210232
2017-08-31 11:39:36 -07:00
Bartosz Dziewoński 0341c804b6 Remove use of deprecated EditPage::getCheckboxes()
Follow-up to I5bfca5e116fe790302c3b6ac1357e80237fb1ed2.

Bug: T174613
Change-Id: I5747871065416ca23038b099f128b02b5cbb431b
2017-08-31 17:48:06 +02:00
Bartosz Dziewoński df9e564b73 Stop requiring deprecated EditPage::getCheckboxes()
Instead, use getCheckboxesDefinition(), and build our save form
checkboxes from that rather than extracting them from the HTML.

The ability to have non-checkbox fields there is removed, as that was
never intentional and is now impossible.

To avoid transient problems during deployment (old JS code cached in
the user's browser receiving the new format of API responses), the old
property is kept in the API response. We should remove it next week.

Bug: T174613
Bug: T174686
Change-Id: I5bfca5e116fe790302c3b6ac1357e80237fb1ed2
2017-08-31 17:47:15 +02:00
libraryupgrader 8c701904bd build: Updating mediawiki/mediawiki-codesniffer to 0.12.0
The following sniffs are failing and were disabled:
* MediaWiki.Files.ClassMatchesFilename.NotMatch

Change-Id: I662ae2dee1df201993559e46d0069adc937fe1bd
2017-08-31 06:34:00 +00:00
jenkins-bot af756c4c20 Merge "EducationPopup: Add cursor:pointer" 2017-08-30 17:59:26 +00:00
Ed Sanders 24747966b6 EducationPopup: Add cursor:pointer
We still expect the user to click on the tool, and
the actions still works (albeit delayed), so we
should use cursor:pointer.

Change-Id: I6d2b0140f5fd918809f05acc6e405ef430c518fd
2017-08-30 17:48:27 +00:00
jenkins-bot a24be49c01 Merge "ve.ui.MWEducationPopupTool: Position blue dots with CSS only" 2017-08-30 17:42:38 +00:00
jenkins-bot 1a40fd2b71 Merge "ve.ui.MWLanguageVariantNodeContextItem: Fix condition for empty table" 2017-08-30 15:48:07 +00:00
jenkins-bot 61ae9df214 Merge "MWParameterPage: Vertically align actions with label" 2017-08-30 15:42:53 +00:00
Egbe Eugene 2fc6423070 Remove nbsp from Visualeditor-mwlanguagevariantcontextitem-rule-code-label
Since "nbsp" is hard to translate, it is removed from the current
text of visualeditor-mwlanguagevariantcontextitem-rule-code-label,
which was "Language code" - now changed to "Language code".
Instead the table headings (where this message is used) are defined
as non-breaking in CSS.

Bug: T173181
Change-Id: I9794fa010ad908fe772fa6858c25acc6beb973d5
2017-08-29 21:58:33 +02:00
Bartosz Dziewoński bff16fb352 ve.ui.MWLanguageVariantNodeContextItem: Fix condition for empty table
For magical HTML reasons, a `<tbody>` node is automatically inserted
inside the `<table>` node. Therefore the table always had exactly one
direct child, this check always failed and table was never shown.
Instead, count the rows.

Change-Id: Ia8a5387c3f605689ab1053c923952ec955b83253
2017-08-29 21:57:48 +02:00
jenkins-bot 50c31a0b29 Merge "mw.ArticleTarget: strip HTML tags entirely from source-mode summary" 2017-08-29 19:50:04 +00:00
David Lynch dc101c6169 mw.ArticleTarget: strip HTML tags entirely from source-mode summary
Bug: T173711
Change-Id: If8b354b2788285ea27472bf9a16544f8e5c091f8
2017-08-29 12:01:33 -05:00
David Lynch 5d4ff082e6 MWLinkAnnotationInspector: check input validity when switching modes
Focusing a TextInputWidget normally unsets validity. However, because we're
kind of pretending this is the same input, just in a different mode, it
doesn't make sense to the user that the focus behavior occurs. So, make it
recheck validity after we switch.

Bug: T172159
Change-Id: I1d9d6670d72483c7510fd5ed3c539b43af8432bf
2017-08-29 11:28:29 -05:00
Bartosz Dziewoński 0a378318bf ve.ui.MWEducationPopupTool: Position blue dots with CSS only
We can place them in bottom center of the toolbar buttons with
just CSS, no need to manually calculate the position (which
doesn't give the correct results if the toolbar is not visible).

Also add z-index for correct rendering inside TargetWidget,
not overlapped by the toolbar border (e.g. in the media dialog).

Bug: T174120
Change-Id: I556ddfcf252669107cf21810fbed7c9a3751e906
2017-08-29 18:21:44 +02:00
Ed Sanders c8e856bfb2 MWParameterPage: Vertically align actions with label
Also make label consistent height, with or without an
indicator using line-height, and move closer to input.

Change-Id: I1b6e6e2f3caa4c949583cafa9448aae6ebc1e0a1
2017-08-29 14:45:21 +01:00
Ed Sanders 550408f863 Increase width of param actions container
Bug: T174202
Change-Id: I61a175593b087219b22c5be91d00054b1c15e1dc
2017-08-29 14:28:26 +01:00
Translation updater bot 498d1dde0c Localisation updates from https://translatewiki.net.
Change-Id: I85367b5829adcc6402905429b09b00302d1c8585
2017-08-29 09:27:05 +02:00
jenkins-bot 0eda414fd9 Merge "Set wgRevisionId on overridden edit page" 2017-08-28 14:11:18 +00:00
Translation updater bot 632a39446f Localisation updates from https://translatewiki.net.
Change-Id: I86a476a67016ccfec0ece9a6d40576bcc9cc9683
2017-08-28 13:47:03 +02:00
Ed Sanders 3ba918a6ae Disable VE on Special:Undelete
Bug: T173154
Change-Id: I2a7d815a67c9e0f80ab3cdfd3a3755370c831867
2017-08-25 18:09:37 +01:00
Ed Sanders 9ebff2fb12 build: Update eslint-config-wikimedia 0.4->0.5
Change-Id: I57b017752cc377f3e8cc4e6163bebfecd878ae51
2017-08-25 16:08:08 +01:00
Ed Sanders 2e7577849b Set wgRevisionId on overridden edit page
Bug: T166131
Change-Id: I9ec865bce27292513c0aea4f0cd0747f5b4deaa0
2017-08-25 15:26:30 +01:00
Translation updater bot 4677c6837b Localisation updates from https://translatewiki.net.
Change-Id: I5ea49bc6475bf5c10b900b9ade15455ee939b4a8
2017-08-25 10:06:55 +02:00
jenkins-bot b73deb1690 Merge "Create wrapper paragraph when converting block image to inline" 2017-08-24 22:16:16 +00:00
jenkins-bot 842b3336bd Merge "Move historical diff loading to DiffLoader util" 2017-08-24 18:33:45 +00:00
jenkins-bot f315c650f6 Merge "Don't focus media dialog until ready process" 2017-08-24 17:18:54 +00:00
Brad Jorsch 2abb9b1b2d Remove execute mode from non-executable
Change-Id: I46549acd49ca883e9047b8117cb968a9ddbb06cc
2017-08-24 10:57:25 -04:00
Ed Sanders eb2ee52de0 Create wrapper paragraph when converting block image to inline
This prevents the image jumping into another paragraph,
e.g. in a different table cell.

Move the logic for removing the old image out of MWMediaDialog
and into MWImageModel#insertImageNode.

Bug: T121449
Change-Id: Ibd7c92f3f90c382ceffd3e0defb12ba36a3786d2
2017-08-24 15:56:22 +01:00
Ed Sanders b11b144ad6 Don't focus media dialog until ready process
Bug: T174027
Change-Id: I070b5538e12c8a165a714ac6c3fd172f0ed179d4
2017-08-24 15:38:11 +01:00
jenkins-bot 98891a9e92 Merge "Update VE core submodule to master (d7bb71b95)" 2017-08-24 14:05:10 +00:00
Bartosz Dziewoński 101eda99a2 VisualEditorDataModule: Do not expand templates in plain text messages
Changing `->text()` to `->plain()` and some variable
names and comments to match that. This is now the same
as normal ResourceLoader behavior for messages added
via `'messages'` in RL modules.

Also remove a duplicate use of the
'visualeditor-quick-access-characters.json' message.

Bug: T159529
Change-Id: I63593db445433e7da5c71e6800f96daf63054fcf
2017-08-23 20:08:36 +02:00
Ed Sanders 51207e7aa5 Allow for mw.body being null in <selfclosing/> extensions
Bug: T173016
Change-Id: I8daa65e5dc0368b366710f044b621287e83e26f7
2017-08-23 16:13:16 +00:00
James D. Forrester 5ad4f6f7ff Update VE core submodule to master (d7bb71b95)
New changes:
1a726e3ed VisualDiff: Show internal list remove-inserts
94532edbf Update OOjs UI to v0.22.5
feb2ca706 Don't try to close context while opening

Bug: T171377
Bug: T173077
Change-Id: Ifced78dd25c218d671e1bb4d08ee7494ec0bf808
2017-08-23 08:22:27 -07:00
Translation updater bot 21759ac8c9 Localisation updates from https://translatewiki.net.
Change-Id: I39a7dcd4701e7481dadc37a285159ab283d995e2
2017-08-23 09:43:48 +02:00
jenkins-bot 8e29c59e44 Merge "Decrease border contrast on selected Vector tabs" 2017-08-22 20:47:22 +00:00
Volker E a2f70cac8b Decrease border contrast on selected Vector tabs
Decreasing border contrast on selected Vector tabs.

Bug: T173465
Change-Id: I46530c8cdf9161e527f421eeb8186a7695057361
2017-08-22 13:28:24 -07:00
Translation updater bot 03e17c61bc Localisation updates from https://translatewiki.net.
Change-Id: Ibd8a3f757e90d99142994dc73b15f178cf98d90b
2017-08-22 09:24:57 +02:00
Arlo Breault cff2530092 Update link to contributing guidelines
Change-Id: I7fd9ad2cbcda0ee1f2ac6ee3f0a6c16a2cb44a7b
2017-08-21 18:22:35 -04:00
Umherirrender 9108ac69ee Update VE core submodule to master (6111ca575)
New changes:
6111ca575 Use json extension for .stylelintrc

Local changes:
Use json extension for .stylelintrc

Bug: T173516
Depends-On: Iba3b6cb37c458e896ade0f3a57a02540b4b4a0a0
Change-Id: I977ac6816e97cfb37bb2e0187e9d148bdb2148af
2017-08-21 11:28:34 -07:00