Commit graph

7955 commits

Author SHA1 Message Date
jenkins-bot 0c205af338 Merge "Update VE core submodule to master (426f9e4)" 2014-07-23 02:03:08 +00:00
James D. Forrester 27c30322ed Clamp height of MWReferenceDialog to between 300 and 400px to avoid it being too small
Bug: 68232
Change-Id: If32edc5622565b28ae1f6a2423a7c2289965733c
2014-07-22 18:57:39 -07:00
jenkins-bot 08c3f6be04 Merge "Provide contextual help for the page settings dialog's controls" 2014-07-23 01:43:54 +00:00
James D. Forrester 9ba9b35b41 Provide contextual help for the page settings dialog's controls
Change-Id: I5c24d7f41ce33d1145f8bfbfd60bd78d08df39ce
2014-07-22 18:41:17 -07:00
Roan Kattouw 4d9cf59db0 Update VE core submodule to master (426f9e4)
New changes:
1b7b23b Tests: Move …/test/… to …/tests/… to be the same as other repos
cd3fc66 Update OOjs UI to v0.1.0-pre (9cd400e3d5)
81be252 Deprecate 'live' event in favor of 'setup' and 'teardown'

Change-Id: I71277d0a3fc85541cf3a0859f58d6d522ad1db6d
2014-07-23 01:23:02 +00:00
jenkins-bot b1ab2f19bb Merge "Stop conditionally registering oojs and oojs-ui" 2014-07-23 01:20:05 +00:00
jenkins-bot 55dcb46311 Merge "MWLinkNodeInspector: Actually preserve annotations when converting to link annotation" 2014-07-23 00:44:43 +00:00
Roan Kattouw 35e611369b Followup 3dd1a996: don't try to switch to source mode when surface is torn down
If you saved a change, then clicked Edit source, you'd get a JS error.

Change-Id: I589f9edb354afcd47d5c42ef9a6c73d49218b044
2014-07-22 17:29:31 -07:00
Alex Monk de2d5bd31b Don't confirm if there's no changes when switching to edit source mode through the page options menu
Also use a simpler way to discard changes

Bug: 68229
Change-Id: I1efc40f14fca0f743df699a4f3aadd4ba3a249e2
2014-07-23 00:23:53 +00:00
Roan Kattouw 3424721aac Followup b6cc76d4: call parent's onSetup/onTeardown
Otherwise .data( 'view' ) doesn't get set.

Bug: 68415
Change-Id: Id4d8351f6d1d3193de6279bddcfe18d09b3db245
2014-07-22 17:15:13 -07:00
jenkins-bot f220453495 Merge "Give a notice if the user isn't allowed to create the page" 2014-07-23 00:12:04 +00:00
jenkins-bot f7c7efbad7 Merge "test: Move mw into the global list of globals for VE-MW" 2014-07-23 00:02:22 +00:00
Roan Kattouw c1eab5d52a Stop conditionally registering oojs and oojs-ui
We already have wfUseMW( '1.24wmf6' ) so we don't need this any more.

The messages list for oojs-ui had gotten out of date, and rather than
fixing it I figured we should just remove this conditional registration
code altogether.

Change-Id: If0610beb2df8bd85aeba136530a84a793e3dda64
2014-07-22 16:49:06 -07:00
James D. Forrester 413f6e82fa Mention at the top of the MW-specific ve.ce.Surface.test file what it is
Change-Id: Icadbf6afbb7d1b9f3bf7bc65ac3d505b4c091275
2014-07-22 23:41:27 +00:00
jenkins-bot 016c93c29b Merge "Auto-open "Add parameter" part of template dialog when tabbed to or opening with no required/suggested params" 2014-07-22 23:37:41 +00:00
jenkins-bot dec052a4d3 Merge "Deprecate 'live' event in favor of 'setup' and 'teardown' in MW" 2014-07-22 23:36:38 +00:00
Moriel Schottlender b6cc76d49a Deprecate 'live' event in favor of 'setup' and 'teardown' in MW
See also Ieddbf5c684eb0edc3130034de64eb284aeaebbda

Bug: 55505
Change-Id: Ib48ef4f62ac53d41abb69f275f51da3d8b85ce0e
2014-07-22 23:34:32 +00:00
jenkins-bot a602c268d8 Merge "Put "re-use reference" in the toolbar "Cite" menu, and give it an icon" 2014-07-22 21:30:33 +00:00
Translation updater bot 16dccdb527 Localisation updates from https://translatewiki.net.
Change-Id: I1636b3550f51933ad3faf35d69317fd0484b8889
2014-07-22 23:03:10 +02:00
James D. Forrester a9356992d8 Put "re-use reference" in the toolbar "Cite" menu, and give it an icon
Bug: 68201
Change-Id: I9fc61e498748fb086c3e506959bee2438b8cbea6
2014-07-22 13:10:06 -07:00
James D. Forrester 7007f61291 Update VE core submodule to master (244bf0e)
New changes:
32c7edd Localisation updates from https://translatewiki.net.
c7d61bc Round up height of language inspector widget
9473d2f Localisation updates from https://translatewiki.net.
2cffb4d build: Update grunt-jscs (formerly grunt-jscs-checker) from 0.6.0 to 0.6.1
b3f861e Localisation updates from https://translatewiki.net.
76b7992 Localisation updates from https://translatewiki.net.
76f8e90 Make the re-render flash more prominent
d2506a3 Localisation updates from https://translatewiki.net.
244bf0e CommandHelpDialog: Make closing action 'safe' not 'primary' for consistency

Change-Id: I68db9bdfa6078d4ab3b110e140c413fc6b865c1b
2014-07-22 13:05:31 -07:00
jenkins-bot 107ce12f9d Merge "Fix heights of Reference, ReferenceList and Template dialogs" 2014-07-22 16:11:39 +00:00
Vikas S Yaligar e0e1b38f13 [BrowserTest] Language screenshots are uploaded every 5 seconds
Change-Id: I25b7842b827b9d9366aeafb423b1884271bb39f0
2014-07-22 19:09:06 +05:30
Alex Monk 42db347213 Auto-open "Add parameter" part of template dialog when tabbed to or opening with no required/suggested params
Bug: 55925
Change-Id: I8475074e25de3969717a6d4dbb88bbb0000ebb4e
2014-07-21 22:38:05 +01:00
Translation updater bot a7e395f0b9 Localisation updates from https://translatewiki.net.
Change-Id: If6a2f2596eecea1d3d8848435277cba23da12da1
2014-07-21 21:42:28 +02:00
Cmcmahon 7b7d8c02a4 [BrowserTest] update Save button locator
Change-Id: I2383a279ab170c382f465d3a7c2f4a3e6b275c48
2014-07-21 09:19:55 -07:00
Ed Sanders d4cd816b6f MWReferenceSearchWidget buildIndex optimisations
* Each item builds an MWReferenceModel which creates a document
  slice clone. This is very expensive and we only use the model
  for getting basic attributes, so defer the evaluation of the
  document.
* $.show is expensive and, in this case, unnecessary.

Change-Id: I99abc4c1b17f05559a9cae68b15121a8be6d23fb
2014-07-21 14:44:58 +01:00
Ed Sanders 9bc8d07486 Fix reference dialog focus
Wasn't migrated to processes.

Change-Id: Idb5f614c172378aad5d37bf8f726adad338c3eb1
2014-07-21 13:58:48 +01:00
vikassy 365453f2b3 [BrowserTest] Added @login tag to language screenshot feature
Change-Id: I31f58d4321d8dd251d1a0fcb641ca939a60b1aa0
2014-07-21 17:47:44 +05:30
Translation updater bot aa5c6e9293 Localisation updates from https://translatewiki.net.
Change-Id: Id01027bb596eb6274fee0bbb108f53809b16c18d
2014-07-20 21:11:13 +02:00
Translation updater bot c28a48e7fd Localisation updates from https://translatewiki.net.
Change-Id: I09ff4c6b858071ce4d7488c0ddf781f1ac7ca3eb
2014-07-19 22:08:00 +02:00
James D. Forrester c2f37a0450 test: Move mw into the global list of globals for VE-MW
Silly to have 38 MW-specific files needing to declare that they're using mw.

Change-Id: I97891ed922fe0c37d8c96425a4d23bd15098438b
2014-07-19 17:42:45 +00:00
Alex Monk a75bf88f6e Give a notice if the user isn't allowed to create the page
Bug: 67550
Change-Id: I59bc9bf5efe0b2fe9261350276316bfab117e6cf
2014-07-19 15:38:36 +01:00
James D. Forrester ed82afc14c Fix heights of Reference, ReferenceList and Template dialogs
Bug: 68226
Bug: 68232
Change-Id: I93916875a6b4b1e7b837efce33a9aa20857f227a
2014-07-18 19:14:30 -07:00
James D. Forrester cc089d6bd3 Scrap the cancel button from the toolbar
It's unnecessary, big and ugly, way too close to an actually useful button, and
adds oodles of complexity to the mire that is VPT without significant user benefit
whilst taking up an unjustifiably huge amount of the already-over-burdened space.
This means that the minimum browser width for English on default Vector to show
the toolbar correctly is now 945px, down from 1029px.

Bonuses: fix MWCancelConfirmDialog's cancel button to be destructive (it is) and
remove a now-recently-fixed comment asking for the save button to be styled using
a generic class (provided by the constructive flag).

Change-Id: I30dc7020121f0dd6907b61ef674a7cb14eb00652
2014-07-18 16:38:17 -07:00
James D. Forrester 8cc3451be7 build: Update grunt-jscs (formerly grunt-jscs-checker) from 0.6.0 to 0.6.1
Change-Id: I097d63cea436ab6ef2a16fccead10b72103d0b6e
2014-07-18 13:21:27 -07:00
Translation updater bot 83b65db414 Localisation updates from https://translatewiki.net.
Change-Id: I944856f8e79dcd05e1f49af9b6d2663d3e138df3
2014-07-18 21:30:58 +02:00
jenkins-bot 23a0fcb249 Merge "[BrowserTest] Updated random page step to language screenshot page" 2014-07-18 12:46:45 +00:00
vikassy 06f15fb7eb [BrowserTest] Updated random page step to language screenshot page
Change-Id: Ica2ae78afcba264d222b02923863b8f23452e259
2014-07-18 18:06:23 +05:30
vikassy 8e1c3de801 [BrowserTest] Fixed failing Media Icon test
Change-Id: I1d07398f1b8f999c76dc278ed8950778ba1e8fd9
2014-07-18 11:01:11 +00:00
Translation updater bot e151d32054 Localisation updates from https://translatewiki.net.
Change-Id: Ie60ce37f1516f55b32631eabf712bb5848b6b562
2014-07-17 23:00:51 +02:00
Cmcmahon cda44f8a9e [BrowserTest] support for Chrome
Chrome is strict about z-index stuff

Change-Id: Icc477891ce1a9ad0fa75a77bcdd387bf6ca13c48
2014-07-17 12:08:16 -07:00
vikassy f58d98fcb9 WIP [BrowserTest] Modified conflicting step: I go to the (.*?) page
Change-Id: Ie0ff326890efddf255320da62a2dd1ec46ffae20
2014-07-17 17:09:47 +00:00
Cmcmahon dc4db46539 [BrowserTest] Chrome needs to wait for the inspector
Change-Id: Iface30b72959b75d04beb54aa76d5798920a881e
2014-07-17 09:28:31 -07:00
jenkins-bot a69ab13cf1 Merge "[BrowserTest] Added lots of new scenarios for language screenshot" 2014-07-17 14:40:59 +00:00
Cmcmahon 406a4c31ae [BrowserTest] update locator for correct page text
Change-Id: Ida8ce2da1061d557520654d2a45369828eefad42
2014-07-17 07:00:28 -07:00
vikassy 27390478b9 [BrowserTest] Added lots of new scenarios for language screenshot
Bug: 62737
Change-Id: If30a9acbe772b76f8a2656ccf3f219dbede9853c
2014-07-17 18:48:53 +05:30
James D. Forrester 72fa906d9f Update VE core submodule to master (63b10db)
New changes:
63b10db Fix-up mobile context and surface

Change-Id: I4b917615a814cbc609a1cf236bd18ce15ef52fbf
2014-07-16 17:17:14 -07:00
jenkins-bot 20205b1e99 Merge "Set title of page to use if discarding changes when changing to the wikitext editor" 2014-07-17 00:08:58 +00:00
Trevor Parscal 49ffef5a0f Close the save dialog on teardown only, not on save
Closing a dialog with specific data means closing it again with
potentially different data, while the dialog is already closing, means
someone wins and someone looses. Silently failing in this case is bad,
because if the first close call was a cancel, producing no side effects,
but the second close call would have produced some side effect, the side
effect would never occur.

The problem here really was that the save dialog needs to be closed
before we can destroy the surface so we can uphold the assumption that
hold and teardown processes are operating on an attached DOM.

The solution is to automatically close the save dialog on teardown,
rather than on save. Since save triggers teardown, this has and identical
user experience.

Bug: 68048
Change-Id: I669448739f168737d4eddd6496189a819ce894b1
2014-07-16 23:51:58 +00:00