Commit graph

16088 commits

Author SHA1 Message Date
jenkins-bot 9a3d759c00 Merge "Always generate empty wrapper paragraph inside image captions (slugs begone!)" 2018-08-05 18:23:05 +00:00
Ed Sanders 1220efd9e4 rebaser: Fix disable of refs while not supported
Some tools were still showing in the 'insert' menu.

Change-Id: I755e234641623fccd893e78fc3d9973a8a19eb44
2018-08-04 09:41:12 -04:00
Kunal Mehta 8ca03768a1 API: Check whether content is deflated before trying to inflate it
Bug: T201083
Change-Id: I5cad1848b19460ba86043d4627413f939b6d3a5f
2018-08-02 12:38:55 -07:00
Translation updater bot 8025610b8a Localisation updates from https://translatewiki.net.
Change-Id: I331c065708837fa829c1eec99b59f34234b7e740
2018-08-01 22:10:55 +02:00
jenkins-bot 8e43d40cbd Merge "rebaser: Make create/edit button primary+progressive" 2018-08-01 20:02:39 +00:00
Ed Sanders 36d15222bf rebaser: Make create/edit button primary+progressive
Change-Id: I4dc5225ae691a9f8b11d2c7c4a980a2bbc169fd4
2018-08-01 15:34:43 -04:00
David Lynch 5dc09c5cd7 Add horizontal rule sequence (----)
Bug: T199925
Change-Id: I9f76e1e10ff8511252c3b9e5fbe7a9b94dade427
Depends-On: I7a41fa64f2b14ce58aca91feddc791b8648995d0
Depends-On: Ifb7bd4f75aeba38f3ae63fe6ba81cf7fe086461a
2018-08-01 19:28:14 +00:00
Bartosz Dziewoński b159fc4aad Update VE core submodule to master (3c30cac86)
New changes:
76103bb49 Add Horizontal Rule insert command
72c167fe2 Clean up after sequence insertion

Bug: T199925
Change-Id: Id3411dc1e09ca0a0f11cc5bfe452566f932a4b33
2018-08-01 21:27:22 +02:00
James D. Forrester 8f2598f6ee Update VE core submodule to master (9bb7abf84)
New changes:
29331acd8 lib: Update jQuery.i18n to 1.0.5
9bb7abf84 libs/CLDRPluralRuleParser/README.md: Drop `x` flag from file

Change-Id: I7d6446bd3a4a87b77a8569d8279b3fc984b1529c
2018-08-01 14:19:59 -04:00
Bartosz Dziewoński 86f2057c81 Always generate empty wrapper paragraph inside image captions (slugs begone!)
While all of the following are valid in the model:

1. <mwBlockImage></mwBlockImage>
   Image with no caption. Must use the media dialog to insert one.
2. <mwBlockImage><mwImageCaption></mwImageCaption></mwBlockImage>
   Image with empty caption. There is a slug to insert a paragraph.
3. <mwBlockImage><mwImageCaption><paragraph></paragraph></mwImageCaption></mwBlockImage>
   Image with caption with empty paragraph. Nice and intuitive!

(Same for <mwGalleryImage> / <mwGalleryImageCaption>.)

The third option is the most convenient for the user. We should always
generate that when converting documents from HTML and from the editing
tools (MWGalleryDialog, MWMediaDialog/MWImageModel).

Previously, the editing tools generated option 2 if no caption text
was entered, and the converter generated option 2 if there was no
caption node or if it was empty. Curiously, option 1 was never used.

Wikitext for manual testing:

```
[[File:Foo.png|thumb]]
[[File:Foo.png|thumb|]]
[[File:Foo.png|thumb|Caption]]

<gallery mode="packed">
File:Foo.png
File:Foo.png|
File:Foo.png|Caption
</gallery>
```

Bug: T200387
Change-Id: Ie82fb339f6bd8ae1b289235bf5402490722d9a7c
2018-08-01 05:40:57 +02:00
jenkins-bot 33b59909df Merge "Update VE core submodule to master (086de2707)" 2018-07-31 23:11:34 +00:00
jenkins-bot 7c215c4ca3 Merge "ApiVisualEditor: warn of deleted pages in edit notices" 2018-07-31 22:36:14 +00:00
Bartosz Dziewoński 1c3bad67c5 Update VE core submodule to master (086de2707)
New changes:
9aecc6946 Add CheckList type
be0469524 Allow cursoring between active nodes
954b21f33 Localisation updates from https://translatewiki.net.
38e1e7667 Do not try searching outside of valid range when using regex
deec79971 ve.dm.TransactionProcessor: Fix edge case handling, avoid ES6 methods

Bug: T196521
Bug: T200455
Bug: T200525
Change-Id: Ie87e19d13c68425f5d46bd1be5121c9169c2ebf4
2018-08-01 00:12:29 +02:00
Translation updater bot cb552bff26 Localisation updates from https://translatewiki.net.
Change-Id: Iced7e18b9fac3aece29fd38edb8073502a0d7666
2018-07-31 22:33:23 +02:00
Translation updater bot 9bf2762d48 Localisation updates from https://translatewiki.net.
Change-Id: I1a514b5f0f6d1148ab42b18b1e20719dd4f68bad
2018-07-30 22:28:10 +02:00
Translation updater bot 7ad301a563 Localisation updates from https://translatewiki.net.
Change-Id: I5e84a4e8615143598ebb9ff730db5401033506f8
2018-07-29 22:21:28 +02:00
James D. Forrester 2588939256 Update VE core submodule to master (e0f344c72)
New changes:
3e46076f7 Localisation updates from https://translatewiki.net.
8ea59e50d ce.Surface: Debounce position events
17e3d3aa0 Amend `border-radius` to conform to Apex theme standard
c573f3513 docs: Replace fake ellipses with real ones (or in one case, a vertical one)
a4e24a992 Make mode for getting document data without metadata

Bug: T199298
Bug: T200429
Change-Id: I36dad61ed614f007b16d7e9f47fcbfd02347f239
2018-07-28 16:44:28 -07:00
Translation updater bot 69dbd9e245 Localisation updates from https://translatewiki.net.
Change-Id: I97d22f8143b5b3eb0aef50a76ec8f5f373f1bf2b
2018-07-28 22:30:16 +02:00
jenkins-bot b487c3f9a4 Merge "CollabTarget: Add convert to wikitext dialog" 2018-07-28 16:06:36 +00:00
jenkins-bot 659c69ca80 Merge "Remove EasyDeflate libs, upstreamed to core" 2018-07-28 15:59:49 +00:00
Translation updater bot f09d24637b Localisation updates from https://translatewiki.net.
Change-Id: Ie366403c50221528cfe066a0bcf6a629f1752c96
2018-07-27 22:18:21 +02:00
jenkins-bot 6223c44456 Merge "Make link annotations more flexible" 2018-07-27 12:52:08 +00:00
jenkins-bot 611f0a31d3 Merge "build: Update mediawiki/mediawiki-codesniffer to 21.0.0" 2018-07-26 23:46:22 +00:00
Ed Sanders a6ea005f15 Remove EasyDeflate libs, upstreamed to core
Change-Id: I70ac6669038238b91eba8484792b75b09e7355d4
Depends-On: I12a5879188f46f17dc4c33bdad52317d218d4172
Depends-On: I0fa382c2828ff2644ed308dc1ccca85735d0a80d
2018-07-26 18:18:52 +00:00
jenkins-bot 5d7f9ee0b7 Merge "Update VE core submodule to master (740285b11)" 2018-07-26 17:03:23 +00:00
James D. Forrester 2912673b66 build: Update mediawiki/mediawiki-codesniffer to 21.0.0
Change-Id: Ida0126306b33d1e9e405e87a448b7a241ad71d2e
2018-07-26 09:45:02 -07:00
Ed Sanders 5b043520c0 CollabTarget: Add convert to wikitext dialog
Change-Id: I49841fd17dd106154a2f53df2e051c6dc0cc3910
2018-07-26 10:46:12 -04:00
petarpetkovic 50d556e8d2 Make link annotations more flexible
* When ve.ui.MWLinkAnnotationInspector is being initialized,
internal and external annotation inspectors are hardcoded to
new ve.ui.MWInternalLinkAnnotationWidget and
new ve.ui.MWExternalLinkAnnotationWidget. Make this creation
more flexible by creating these inspectors through a method,
which inheriting classes can override.
* In ve.ui.MWLinkAnnotationInspector.getAnnotationFromFragment,
factor out the creation of link annotations, so overriding
classes have the ability to provide different internal and
external annotations.
* In newFromTitle, static method of MWInternalLinkAnnotation,
creation of `element` isn't flexible for reusability with
slight changes to attributes passed to the constructor. By
factoring out the creation of attributes, inheriting classes
can reuse the existing structure and alter the attributes if
needed.

Bug: T195064
Change-Id: I2037464a7be77783837e9810691c8e372c8197c6
2018-07-26 15:12:19 +02:00
Kunal Mehta 53f8f32895 Don't use PAGE_IMAGES_INSTALLED
Bug: T200381
Change-Id: I0b9725fa4b3c4ce4fbb1004cfd3570ba39865fc1
2018-07-25 16:19:09 -07:00
James D. Forrester dde96dfc0e Update VE core submodule to master (740285b11)
New changes:
c60028546 Remove legacy transaction builder comment
d51e5e39e Localisation updates from https://translatewiki.net.
71aa3d159 Update files generated with new l10n language 'tw'
1681bb2f4 Rebaser: Fix changeName handling
44c2d0c71 Remove duplicate apex styles from rebaser demo
87918b3d2 Use opacity for comment annotation background
dd219f941 'pad' -> 'collabpad' logo
c7c75351d Remove extra whitespace
13356ebb6 Move 'canBeActive' to NailedAnnotation
3c660a12a ve.dm.Document: Make getNodesByType build the tree if needed
4c51ee9ec Localisation updates from https://translatewiki.net.
741f6d933 Fix rebaser documentation
6afdf63d0 Further rebaser documentation fixes
740285b11 rebaser: Prevent no-op changes from being sent

Change-Id: I8e5a1b27d5cba7630f71ddeb1af338cbbe6ae0db
2018-07-25 15:21:36 -07:00
Translation updater bot 484a89a30c Localisation updates from https://translatewiki.net.
Change-Id: Iae37afab9f41e32b4f50d2d980c618dafe2e4720
2018-07-25 22:18:31 +02:00
Translation updater bot 9671fbb30b Localisation updates from https://translatewiki.net.
Change-Id: I6330b0d1221c099f88440c6284d6b50acdc18c99
2018-07-24 22:10:14 +02:00
Translation updater bot a7fc1b8869 Localisation updates from https://translatewiki.net.
Change-Id: I24fc96b4b3efa4405fb35d67c56d9d2b1bd9a008
2018-07-22 22:09:25 +02:00
Translation updater bot 055252ad73 Localisation updates from https://translatewiki.net.
Change-Id: Ice5a642601e8f59aef074ee1afcdc50d3fed86cd
2018-07-21 22:12:10 +02:00
Ed Sanders 0f06ad2d76 Add missing debugbar message
Change-Id: Id95bf914601c75eba120e2c0fa14a869ed26c960
2018-07-21 14:13:53 +02:00
Translation updater bot ee7a0f2799 Localisation updates from https://translatewiki.net.
Change-Id: Id526f64432922ed8ee0a00cb5d5ef21112275247
2018-07-19 22:31:13 +02:00
jenkins-bot 33be736e13 Merge "ve.ui.MWTemplateDialog: Prevent focus changes in the setup process" 2018-07-19 17:43:11 +00:00
Ed Sanders ff10c01687 Update VE core submodule to master (d2a120e66)
New changes:
35eaf8209 Move annotation nail functionality to a mixin
d2a120e66 Rebaser: Create a multi-user flag on the surface model

Change-Id: Iffad3c90a9b8ac08f646721bfdbc0503cea2890b
2018-07-19 13:22:25 +01:00
jenkins-bot d18e9e964f Merge "Add missing rebaser messages" 2018-07-19 10:32:02 +00:00
Ed Sanders 8a6f592884 Add missing rebaser messages
Change-Id: I3f969abfc5899350854bf105ef1b16d35ccdc062
2018-07-19 11:02:05 +01:00
Bartosz Dziewoński 668ce071fa ve.ui.MWTemplateDialog: Prevent focus changes in the setup process
This is similar to the hack in ve.ui.MWMetaDialog, except uglier :(
We already explicitly focus the right field in the ready process.

I am not really sure why the focus change causes the issue, but
preventing it definitely fixes it. It would make sense if we changed
the value of the field after focussing it (as setValue() restores the
validity flag cleared by onFocus()), but we don't seem to do it.

Bug: T199838
Change-Id: Ia602551ee0b0885cefbd4cb2fc00d569ff42da67
2018-07-19 01:43:31 +02:00
Translation updater bot efd85144d4 Localisation updates from https://translatewiki.net.
Change-Id: Ic4679590c3a84b925a024e255317192407764d57
2018-07-18 22:12:45 +02:00
Santhosh Thottingal 2eb493bfcf
ve.dm.MWInlineImageNode: Fix undefined data-mw in toDomElements output
Bug: T198941
Change-Id: I52c670dcc1a4dfe03c954b053d344c22e7b48a8d
2018-07-18 16:46:07 +05:30
jenkins-bot db8c585f11 Merge "Apply edit surface jQuery.makeCollapsible overrides to visual diffs too" 2018-07-18 06:36:55 +00:00
jenkins-bot 7856c52f48 Merge "ve.ui.MWMediaDialog: Fix confusion between #getSetupProcess and #getReadyProcess" 2018-07-18 04:51:49 +00:00
Bartosz Dziewoński fc91623b94 ve.ui.MWMediaDialog: Fix confusion between #getSetupProcess and #getReadyProcess
Follow-up to 13675e4a81.

Bug: T185944
Bug: T199841
Change-Id: I2bf08bc0a3684dbfdb9574ea6df0352e8d9d8fd7
2018-07-18 06:30:46 +02:00
jenkins-bot 595a36c9b0 Merge "Update VE core submodule to master (8d0ab0587)" 2018-07-18 01:14:03 +00:00
James D. Forrester f08eb6028a Update VE core submodule to master (8d0ab0587)
New changes:
cd6932096 Fix rebaser dependecies
bdcbf8f81 Rebaser: make the server synchronous again
52e6873b1 Cleanup rebaser
31ef4c5ec Handle authentication and reconnection
22d6feea3 Squash Changes to use fewer transactions
4d93f0819 Fix confusion between #getSetupProcess and #getReadyProcess
8d0ab0587 Localisation updates from https://translatewiki.net.

Bug: T185745
Bug: T185944
Bug: T188026
Change-Id: Ie33d3dd4746c9c91fe676f140f416af72ac218b0
2018-07-18 02:54:07 +02:00
Translation updater bot 01879333d2 Localisation updates from https://translatewiki.net.
Change-Id: I604a757421a65f84885c1cae68bafe8c59150465
2018-07-17 22:14:13 +02:00
jenkins-bot ffaab335ce Merge "Move some styles from mw.ArticleTarget to mw.Target" 2018-07-16 23:16:56 +00:00