Commit graph

18796 commits

Author SHA1 Message Date
Translation updater bot 99878d3634 Localisation updates from https://translatewiki.net.
Change-Id: I42bb2ccf22d9fe6e1ca587593fda2c9454a420b0
2022-02-08 08:07:16 +00:00
jenkins-bot 098791f6c7 Merge "Add vector-body class to diff/previews" 2022-02-07 23:38:15 +00:00
Translation updater bot 05c4329055 Localisation updates from https://translatewiki.net.
Change-Id: Ibc3fbad894f18d0ea73a220951ff43374b38f10d
2022-02-07 08:23:12 +01:00
jenkins-bot 934af1d42d Merge "ApiParsoidTrait: Add "@return never" for Phan" 2022-02-05 23:43:24 +00:00
jenkins-bot 3355918a30 Merge "Remove redundant Phan annotations" 2022-02-05 23:41:55 +00:00
Ed Sanders 5739da585a Add vector-body class to diff/previews
Bug: T287733
Change-Id: I6a4befb2a29489c767df5896a86ef6a607938685
2022-02-05 22:51:05 +00:00
Bartosz Dziewoński 72c68e9e65 Remove redundant Phan annotations
Change-Id: Ic87fcc132b310191b086ccf7facfdf262a544eb9
2022-02-05 16:55:42 +01:00
Bartosz Dziewoński 9e22d21c8e ApiParsoidTrait: Add "@return never" for Phan
Like in MediaWiki core in I895f70e82b3053a46cd44135b15437e6f82a07b2.

Change-Id: I3cc8f887534897153fdefb78a7f28de42ffdf217
2022-02-05 16:49:40 +01:00
jenkins-bot f4824633bd Merge "selenium: Refactor WebdriverIO tests from sync to async mode" 2022-02-04 17:52:51 +00:00
Translation updater bot a839e3c3b1 Localisation updates from https://translatewiki.net.
Change-Id: Ic40782ee2e5d237e7b396927df55f4e274dc9040
2022-02-04 08:22:44 +01:00
Translation updater bot 29f95e78ef Localisation updates from https://translatewiki.net.
Change-Id: I49ff4f0b18621039883f73bb64edcce3a7e7af71
2022-02-03 08:44:49 +01:00
osamaahmed17 40c5c4fe9e selenium: Refactor WebdriverIO tests from sync to async mode
WebdriverIO has dropped support of sync mode, hence changed to async.

Update npm packages: @wdio/*, wdio-mediawiki and webdriverio
because async mode needs at least webdriverio v7.9.

Remove npm package: @wdio/sync.

Bug: T299756
Change-Id: I4a09ccddd8049f84232b035b664b42a4e98d7ff0
2022-02-03 10:41:35 +11:00
David Lynch 9707d5e686 New bucket for abtest data
Bug: T291308
Change-Id: I20fb26fe5e294f6c117038bcef6f5ba92b01340b
2022-02-02 15:54:23 -06:00
Translation updater bot ad563c0222 Localisation updates from https://translatewiki.net.
Change-Id: I990290e7553872ce48f6d28ed44caa2609b12595
2022-02-02 08:20:33 +01:00
jenkins-bot b5cb82bc92 Merge "Re-apply "Re-duplicate deduplicated TemplateStyles"" 2022-02-01 23:36:05 +00:00
Ed Sanders 02cfb4bf71 Introduce VisualEditorBeforeEditorHook
Extensions can return false in this hook to disable VE on specific pages.

Bug: T174180
Change-Id: I764843fcfc07149c50ae6af758df43ca454d3296
2022-02-01 17:57:27 +00:00
jenkins-bot 440620ae73 Merge "Show a keyboard shortcut when hovering over a toolbar button" 2022-02-01 12:33:39 +00:00
Translation updater bot 3bc8a1b4db Localisation updates from https://translatewiki.net.
Change-Id: I589bcb60ccec00f5cf8dde3c417a6c0c6a09a26f
2022-02-01 08:27:43 +01:00
libraryupgrader e28310371f build: Updating npm dependencies
* wdio-mediawiki: 1.1.1 → 1.2.0
* ansi-regex: 5.0.0 → 5.0.1
  * https://github.com/advisories/GHSA-93q8-gq69-wqmw
* json-schema: 0.2.3 → 0.4.0
  * https://github.com/advisories/GHSA-896r-f27r-55mw
* jsprim: 1.4.1 → 1.4.2
  * https://github.com/advisories/GHSA-896r-f27r-55mw
* meow: 3.7.0 → 3.7.0
  * https://github.com/advisories/GHSA-7p7h-4mm5-852v
* node-fetch: 2.6.2 → 2.6.7
  * https://github.com/advisories/GHSA-r683-j2x4-v87g
* optipng-bin: 6.0.0 → 6.0.0
  * https://github.com/advisories/GHSA-44c6-4v22-4mhx
* string-width: 4.2.3 → 4.2.3
  * https://github.com/advisories/GHSA-93q8-gq69-wqmw
* strip-ansi: 6.0.1 → 6.0.1
  * https://github.com/advisories/GHSA-93q8-gq69-wqmw
* sugarss: 2.0.0 → 2.0.0
  * https://github.com/advisories/GHSA-566m-qj78-rww5
* trim-newlines: 1.0.0 → 1.0.0
  * https://github.com/advisories/GHSA-7p7h-4mm5-852v
* validator: 13.6.0 → 13.7.0
  * https://github.com/advisories/GHSA-qgmg-gppg-76g5
  * https://github.com/advisories/GHSA-xx4c-jj58-r7x6
* zopflipng-bin: 5.0.0 → 5.0.0
  * https://github.com/advisories/GHSA-44c6-4v22-4mhx

Change-Id: Idee4aef18cbc4d5ec29d28385081fc0c89ecd50c
2022-02-01 06:57:37 +00:00
Bartosz Dziewoński e212ddcac2 Update VE core submodule to master (37ee8ffcd)
New changes:
ec713a57a Localisation updates from https://translatewiki.net.
c2f60cd96 DiffElement: Don't show meaningless spaces inside added block nodes
78ca42ce2 Localisation updates from https://translatewiki.net.
6aa9549d2 Target: Don't create toolbar in scroll handler
de8319584 Fix regex that replaces nothing with nothing
4a8584a7c Add more complex internal list diff test

Bug: T300444
Change-Id: Ic3299038c589f4b980488ea6ec81b6ef4b3d49cc
2022-01-31 18:16:41 +01:00
jenkins-bot fb6332ad5c Merge "Use OOUI 'play' icon for audio placeholder" 2022-01-31 10:19:18 +00:00
Translation updater bot 614f8425c4 Localisation updates from https://translatewiki.net.
Change-Id: I68fe3156fc2e9631fb24856fd8a169a653aa206e
2022-01-31 08:22:50 +01:00
jenkins-bot 23b8ec2f54 Merge "Don't attempt to pin first visible section if firstHeading is visible" 2022-01-28 17:27:06 +00:00
jenkins-bot d63cbf86f7 Merge "Follow naming convention for static methods" 2022-01-28 15:06:24 +00:00
WMDE-Fisch dac7b5206b Allow disabling VE and 2017 wikitext editor from FileImporter
Bug: T298345
Bug: T174180
Change-Id: I80be4648564630b71e6e61d4c5e50538d134ba7a
2022-01-28 08:55:15 +00:00
Bartosz Dziewoński a2390efbf4 Re-apply "Re-duplicate deduplicated TemplateStyles"
Previous attempt in 005a8d24ef,
reverted in 3c1d167b33.

The deduplicateStyles() function lacked a check for fosterable
positions, which caused T299767. This is now fixed.

Also added tests.

Bug: T287675
Bug: T299251
Change-Id: I0d22be9b66d26d09373cee63dd6ce52c1659e62d
2022-01-28 02:08:09 +01:00
Ed Sanders 4af235822b Don't attempt to pin first visible section if firstHeading is visible
This prevents an unwanted scroll when the main edit link is used
and the first section is below the viewport.

Change-Id: Ib99ebe2dc5c105c3fcbd687ef5740166267f5536
2022-01-28 00:02:09 +00:00
Iniquity 427f8ab3ba Use OOUI 'play' icon for audio placeholder
Bug: T299278
Change-Id: I8cc254fdf28cb83d5c4fe310a61a8a3df2d49270
2022-01-27 21:10:51 +00:00
Thiemo Kreuz 7298834211 Follow naming convention for static methods
Change-Id: Ie2d7fb061fcb46765ba8796911425d58218736d1
2022-01-27 09:12:23 +01:00
Bartosz Dziewoński 7619917149 Update VE core submodule to master (bbeac08b7)
New changes:
60e524fc0 Fix internal list diff when lists are fully inserted/removed
bbeac08b7 DiffElement: Use horizontal scroll when necessary on content area

Bug: T161489
Bug: T298569
Change-Id: I79d1ec33e6d9f14dc46d7eb0aa6fccd28df50b86
2022-01-26 20:18:44 +01:00
jenkins-bot b94265acc3 Merge "Always enable visual diff when diffmode=visual" 2022-01-26 16:19:09 +00:00
Ed Sanders ba739a143d Always enable visual diff when diffmode=visual
We already had a query string hack '?visualdiff' to enable
the feature, but I think the pre-dated the diffmode param.

Now we have the diffmode param, we can just enable the feature
whenever diffmode=visual. This makes posting test links much
simpler.

Keepd the 'visualdiff' param for backwards compatibility.

Change-Id: If777d7f2e6a3b1a1725f174d149cf9eab4535d85
2022-01-26 15:15:53 +00:00
Ed Sanders b80b09f88a Ignore originalWidth/Height when diffing images
Change-Id: Ieec25165a61df8f89e18c01ca4fdf70ac882eb52
2022-01-26 14:51:52 +00:00
Adam Wight 7e7ad97bf6 Don't wrap unknown actions with confirmation
For example, the "apply changes" button was producing a confirmation
dialog.

Bug: T300095
Change-Id: I77e53cc0cf62ff7c0aca052568384e20490ce7ec
2022-01-26 14:40:58 +01:00
jenkins-bot e4cd36b471 Merge "VisualEditorDataModule: Generate definition summary without parsing wikitext" 2022-01-26 11:07:05 +00:00
jenkins-bot 1f8e56a333 Merge "Move copyright warning message parsing from RL module to API" 2022-01-26 11:07:03 +00:00
Translation updater bot 5d98b2b233 Localisation updates from https://translatewiki.net.
Change-Id: I6dcb679d23ecdd78176225b7ec7f681436cbce6a
2022-01-26 08:25:45 +01:00
jenkins-bot 3c7d81aa2f Merge "Remove conflicting section IDs in diff views" 2022-01-26 00:04:22 +00:00
Ed Sanders 312c35077f VE-MW: Consistently use target/surface $scrollContainer to set/get scrollTop
As in Idd97d9e6d3 in ve-core.

Bug: T299841
Change-Id: I728a723cbbb1d992e0e573800298784ba385882e
2022-01-25 22:28:10 +00:00
Bartosz Dziewoński 51ee6c4331 Update VE core submodule to master (c3f56a0b9)
New changes:
b8b12d1c2 Test: Ignore XML parse warnings in other comment escaping test
4147e7401 Consistently use target/surface $scrollContainer to set/get scrollTop
c06f87e83 Consistently use $scrollListener when listening to scroll events

Bug: T299841
Change-Id: I93e39aaa7743c2ff3cf51c7690cd25511eb7640b
2022-01-25 23:27:34 +01:00
Bartosz Dziewoński ab4797400d Update VE core submodule to master (7c6e1b91f)
New changes:
1da4a683b DiffElement/VisualDiff: Use node's root to determine the document model
950d56d09 DiffElement: Add core test for internal list diff
658a420a1 DiffElement: Simplify internal list rendering using list item value attribute
7c6e1b91f Fix list diffs

Local changes:
* Add new test file

Bug: T198529
Change-Id: If4ca99fa4532b33f164e298b53cfa1e202035015
2022-01-25 21:39:24 +01:00
Bartosz Dziewoński c98e6e5e4a Update VE core submodule to master (bbdba097b)
New changes:
94ea92dd0 Follow-up I227a0d70: Remove partially complete mixin of ContentEditableNode from list items
bbdba097b Re-apply "Follow-up I0802440d9: Allow alien <tr>/<td>'s to be focused"

Bug: T298609
Bug: T299730
Change-Id: I532359f03a549316bd20d49db30837dbb4e88081
2022-01-25 20:58:18 +01:00
jenkins-bot a37daf782d Merge "Position VE desktop loading bar with position:fixed" 2022-01-25 19:56:40 +00:00
jenkins-bot aafdc04834 Merge "Include heading margin when running scrollToHeading" 2022-01-25 19:56:38 +00:00
jenkins-bot 06d9a7af94 Merge "Tweak vertical alignment of progress bar within toolbar (source mode)" 2022-01-25 19:56:36 +00:00
jenkins-bot c3e8ecb2ca Merge "Use new *SelectableContentOffset method when setting section selection" 2022-01-25 19:56:34 +00:00
jenkins-bot 4e41b70758 Merge "ve.ui.MWLinkInspectorTool: Parse "education popup" text as wikitext" 2022-01-25 18:41:56 +00:00
jenkins-bot 219e25fb8f Merge "ve.ui.MWEducationPopupWidget: Allow formatting in the popup text" 2022-01-25 18:39:28 +00:00
Ed Sanders 6f5fe8cdb0 Position VE desktop loading bar with position:fixed
This doesn't change the position of the loading bar, but it keeps it
still if any scrolling happens. Previously we expected the user probably
wouldn't scroll while VE is loading, but in subsequent commits we
will trigger automatic scrolling in section editing mode.

Change-Id: I1404ccd77583d808ef79291c6cb4f561e76bd41c
2022-01-25 16:04:12 +00:00
Ed Sanders d1aaf3d451 Include heading margin when running scrollToHeading
This avoids the heading text ending up uncomfortably close
to the toolbar.

Change-Id: Iddd5fea5d75902ed093d3e9839b63a2a3c480775
2022-01-25 16:04:12 +00:00