New changes:
bfa281b77 eslint: Enable no-jquery/no-append-html
89582e214 Localisation updates from https://translatewiki.net.
b420ada2f Use no-jquery/no-html to warn against writing HTML strings to the DOM
Change-Id: Ic0bb7a8444a2e1b28975f53280a797c835cff61d
New changes:
fce94628e build: Update eslint-config-wikimedia to 0.21.0
201f33491 Localisation updates from https://translatewiki.net.
df3700480 Handle TargetWidget submit events in dialogs
e12c2cbba createDocumentFromHtml: Add test for <body> wrapping logic
57cf7485c createDocumentFromHtml: Improve body wrapping logic with regex
ef47d7814 Inject meta tag to disable iOS tel: conversion in HTML head
Bug: T116525
Bug: T289092
Change-Id: Ibb70d0ed0fa8917c3bc4da7d6fffb2c937c69238
In OOUI the close button is always on the left side. See
https://doc.wikimedia.org/oojs-ui/master/demos/?page=dialogs&theme=wikimediaui&direction=ltr&platform=desktop
The CSS hack to move it to the other side doesn't work and must be
removed. You can see the problem the moment the text is longer (which
can easily happen in translated versions).
I tried to come up with a more official way to move the button to the
other side, but gave up. One way is to replace the existing
flags: [ 'safe', 'close' ]
with:
flags: [ 'primary', 'close' ],
framed: false
But this causes other style problems. Let's remove the bogus CSS
first and possibly try again in a later patch.
Bug: T294839
Change-Id: Ia6ddefd99e4a03a87b0450ab94712ff19bb268e4
There was a remaining issue when the window was made very narrow in
desktop mode (smaller than 500px). This patch doesn't aim to really
"fix" the dialog's design in this case. The goal is to make the popup
window appear less broken, so the text can stil be read and the
buttons clicked. That's all.
This patch should not have any effect in:
a) mobile mode,
b) desktop mode when the window is wider than 500px.
Bug: T294839
Change-Id: I3171dbb991533b91eaadba63b78d0ff40aa486dc
Same as I980b72c, but with another shortcut. Again. We tried
Ctrl+Shift+X before (conflicts with RTL feature in VisualEditor), as
well as Ctrl+Alt+D (conflicts with "hide all windows" incUbuntu).
Bug: T294905
Change-Id: Iae7ba759fcd7c107ef586bd5d9ae3cdbe445cedc
New changes:
bde209a1c Add simple equality check shortcut to compareElementsUnannotated
79954cb58 Localisation updates from https://translatewiki.net.
2c84478ba Use null for deliberately empty values instead of undefined
18929710e assert.ok -> assert.true
d29db14ee ElementLinearData: Fix instance of data being modified in place
Change-Id: Ia307a129cc7725b2f5bfa168c48934f6f2aa1e67
Re-enabling some specific rules that are disabled in the upstream
MediaWiki coding standard for several reasons.
Change-Id: I6922995098f9af21e62e1b40d20fabd4b5d74ef7
Replace User::isBlockedFrom with PermissionManager::isBlockedFrom since this method will be hard-deprecated.
Bug: T294823
Change-Id: Iea308ce73e4e91b21f55b60e0b3251d93ba18d7e
Allows setting aria labels and descriptions on elements in a
convinient way. I did not use the the .mixin. convention here for
because there's already another mixin in that folder that's also
not having .mixin. as part of its name. And then there's also no
no need to open up that extra namespace here.
If we move this upstream at some point this can be changed though.
Bug: T291284
Change-Id: I1b3d40400d539f851f13719e16ced200968a7f92
