wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-15 02:23:58 +00:00
Code Issues Packages Projects Releases Wiki Activity
15584 commits 161 branches 1 tag 190 MiB
Commit graph

15584 commits

This branch
This branch
All branches
Author SHA1 Message Date
James D. Forrester 4df2558910 Hooks: Don't set wgVisualEditorToolbarScrollOffset in RL when 0 
We should also move this to packageFiles, but that's more work.

Bug: T220158
Change-Id: I438dc13802d744877921dc612b16cc22b0713e00
 2019-04-05 11:42:05 -07:00
Ed Sanders 64b02f97ce Use nullSelectionOnBlur=false for ArticleTargets 
Bug: T208826
Depends-On: I2c464ec2bbf799cbe1d9bfed1aad05c5a1bfb094
Change-Id: I5bcd6947c1c6e8f278d0cc9f9c95afb835d1b56b
 2019-04-05 13:54:00 +00:00
Ed Sanders c1bc3f00e0 Remove unnecessary duplications of 'default' theme files 
Change-Id: I52b4851a44ad9e472f006d4a892d8cc54c7ab5db
 2019-04-05 14:47:58 +01:00
Ed Sanders e2dfdf0ef7 EditSummaryWidget: Don't show suggestions on focus 
Bug: T220176
Change-Id: Iffad075929d8835eb4f8677b33c3edd30a27b3f8
 2019-04-05 14:04:29 +01:00
James D. Forrester 7f18b4b9d0 Update VE core submodule to master (8653ce4bd) 
New changes:
c4b17a604 Remove deprecated ve-test-toolbar- classes
f31d3be06 Update OOUI to v0.31.3

Bug: T220091
Change-Id: Ib479fe6a7d9f43f7177c5125f9b1c324f0451964
 2019-04-04 15:26:12 -07:00
Bartosz Dziewoński 9143155722 Update VE core submodule to master (2dc41ef9b) 
New changes:
eeaebe220 Make deactivated selections grey
58b96ec5d Make null-selection-on-blur optional

Bug: T219813
Bug: T219829
Change-Id: I0660c60860fd62e838a63aa841253ef19fb2a78a
 2019-04-04 20:46:10 +02:00
jenkins-bot 96dfb99016 Merge "Edit summary autocomplete" 2019-04-04 17:44:36 +00:00
Bartosz Dziewoński 17a0b407fc ve.init.mw.MobileArticleTarget: Remove code causing scrolling issues 
This code is supposed to check if we have scrolled past the end of the
page, and if we did, scroll back up to a more reasonable position.

However, it seems to incorrectly trigger in other cases, and scroll
the page back to the top, because getBoundingClientRect() occasionally
still returns bogus values (even though we try to avoid that). This
happens inconsistently when focussing the surface or closing a dialog.

We can't correctly display the toolbar while scrolled past the end of
the page. Removing this code causes it to go into an endless animation
loop in that case. But that may be preferable…

Bug: T219200
Change-Id: I152f2b39351ffd3c9799eea33cce95e05d2f9ab9
 2019-04-04 17:07:39 +00:00
Translation updater bot 2455b94f18 Localisation updates from https://translatewiki.net. 
Change-Id: I5bb495971e5970f033da8f4f6367e79a8dfe8e9d
 2019-04-04 14:55:17 +02:00
Bartosz Dziewoński 362df66b47 Remove support for page title "hrefPrefix" other than './' 
Parsoid does not use relative links anywhere anymore (T72743). There
is no reason for us to support this. And previous code allowed
"hrefPrefix" to be empty '' sometimes, which is scary, as it could
lead to XSS vulnerabilities if titles starting with 'JavaScript:' are
not handled correctly elsewhere.

Bug: T206357
Depends-On: I8728f63084902c76d1c61193be4367939b069f1a
Change-Id: I99be18877aae2b505cf261bd7cdef6cf0d7a8670
 2019-04-03 20:10:05 +00:00
jenkins-bot f0053e1644 Merge "Avoid keeping excess keys from storeInSerializationCache() in cache" 2019-04-03 19:06:08 +00:00
Aaron Schulz 1a5fc05dda Avoid keeping excess keys from storeInSerializationCache() in cache 
Remove overkill $VisualEditorSerializationCacheTimeout config setting
and just use a simple constant instead (convention over configuration).

Bug: T203786
Change-Id: I94424088a03a3262fcea30132883a612465c546e
 2019-04-03 18:34:07 +00:00
Bartosz Dziewoński 15745d9dd1 Update VE core submodule to master (5c8fd26b8) 
New changes:
0a3a4578a EventLogger demo improvements
e8468dd10 Localisation updates from https://translatewiki.net.
7a98936b2 Remove border radius from buttons in MobileContext
69078dc22 Remove blur/focus event listeners from DesktopContext.
9750d8931 Redraw deactivated linear selections on 'position'

Bug: T219916
Change-Id: I092c01a07799d895ff0b75c05853da0b744f6356
 2019-04-03 19:59:31 +02:00
jenkins-bot 42eb7e0cf4 Merge "Suppress slugs between floated images" 2019-04-03 15:59:09 +00:00
jenkins-bot 0d4e843132 Merge "trackSubscriber: don't populate all fields, to make validation happy" 2019-04-03 13:18:19 +00:00
Ed Sanders d784304ed1 Rename 'citefromid' to 'citoid' 
Backwards compatible change can be merged ahead of change
in Citoid repo.

Bug: T219512
Change-Id: I2d7e389cc01808e41353681dd2448a0385543f2e
 2019-04-03 13:19:45 +01:00
jenkins-bot 62d5c60b82 Merge "ve.init.mw.MobileArticleTarget: Fix placeholder being hidden by the toolbar" 2019-04-02 18:33:17 +00:00
jenkins-bot aeeffb912a Merge "Treat ambiguous values in $wgVisualEditorAvailableNamespaces as names" 2019-04-02 15:20:59 +00:00
Bartosz Dziewoński ac3d5e7925 ve.init.mw.MobileArticleTarget: Fix placeholder being hidden by the toolbar 
Follow-up to 500462f4b2.

Bug: T219066
Change-Id: Ie0c35339c440bf85545e51fb5398d0936757432a
 2019-04-01 22:48:36 +00:00
Derick Alangi 37e978d169 SpecialCollabPad: Remove unused variable $request 
Change-Id: Ie5cce0771c2b7f1f5a521d3129deb2063b5cbf5b
 2019-04-01 23:08:02 +01:00
Translation updater bot 748b3d17c7 Localisation updates from https://translatewiki.net. 
Change-Id: Ib37aa5b29c0ea2f8050dd2492447fe790f1bf0b9
 2019-04-01 22:41:30 +02:00
David Lynch 415cc0d022 trackSubscriber: don't populate all fields, to make validation happy 
The EditAttemptStep schema doesn't have some of the fields we attempt to
submit, because we're generalizing and it only wants specific ones. Be more
selective about what we submit, so validation messages in the console will be
quiet.

Bug: T218163
Change-Id: Iaf9f47b61c138bb0106b2dfc4be2caec02a10d1d
 2019-04-01 11:56:15 -05:00
Translation updater bot c634ea2e99 Localisation updates from https://translatewiki.net. 
Change-Id: I755ca10ff4c352d3857e310d20ff6206f748406e
 2019-03-31 22:17:23 +02:00
jenkins-bot ab17c1095a Merge "ve.init.mw.MobileArticleTarget: Save/restore scroll position on surface (de)activation" 2019-03-29 23:18:17 +00:00
jenkins-bot 91ea11fa8e Merge "Update VE core submodule to master (549f49bb5)" 2019-03-29 23:07:41 +00:00
jenkins-bot 1777203ace Merge "MWInlineImageNode: don't discard alt text when serializing" 2019-03-29 21:36:18 +00:00
Bartosz Dziewoński f46045b69e ve.init.mw.MobileArticleTarget: Save/restore scroll position on surface (de)activation 
Bug: T218650
Depends-On: Ib943ca806b6eaaf1d7b650c8ebb24cc30d9fe700
Change-Id: I18047eaa1068b8d06cd708da9e3853abe6d252bb
 2019-03-29 21:21:45 +00:00
Ed Sanders 4b931a234b Update VE core submodule to master (549f49bb5) 
New changes:
549f49bb5 ve.init.Target: Allow overriding surface (de)activation on mobile

Bug: T218650
Change-Id: I5a411f4fced0af98ee716e8e60049150f3dd5e13
 2019-03-29 17:44:11 +00:00
David Lynch a976f0508f MWInlineImageNode: don't discard alt text when serializing 
Bug: T216285
Change-Id: If81a9925cf32204f825e4da713aa07e860a29a46
 2019-03-29 10:29:26 -05:00
Bartosz Dziewoński 018464a096 Treat ambiguous values in $wgVisualEditorAvailableNamespaces as names 
The config option can contain either namespace names or IDs.

Bug: T219562
Change-Id: I6b3706ea7e26f69427ffac1603b093bcb8fdbd03
 2019-03-29 01:08:03 +01:00
James D. Forrester f15b07d8e3 Update VE core submodule to master (132022a44) 
New changes:
fcd032a8a Update OOUI to v0.31.2
561e52b06 ve.dm.Node: Document attributeChange event
1f1ca22c5 Fix appearance of collapsed deactivated selections

Change-Id: I8a618ab363664dfa59bde99de1b50cf6bc6a236f
 2019-03-28 15:11:15 -07:00
jenkins-bot 0c4ee8528f Merge "ve.init.mw.MobileArticleTarget: Set 'padding-top' on the correct node when section-editing" 2019-03-28 20:54:59 +00:00
Bartosz Dziewoński ff88be0d35 ve.init.mw.MobileArticleTarget: Set 'padding-top' on the correct node when section-editing 
Follow-up to 500462f4b2.

Bug: T219066
Change-Id: I7344fa8f4ad672e4be7a3b98c5b9a1b1c65131dc
 2019-03-28 20:42:30 +00:00
jenkins-bot a2a42890dd Merge "Fix cursor on #firstHeading" 2019-03-28 20:18:36 +00:00
Ed Sanders 03240609d5 Fix cursor on #firstHeading 
Bug: T214790
Change-Id: I68e3837cf71317a18a885d1dc16ad10523c464a3
 2019-03-28 21:02:03 +01:00
jenkins-bot 552969d9ae Merge "Emit 'position' event on surface view after changing doc padding" 2019-03-28 19:40:27 +00:00
jenkins-bot d41366c452 Merge "Clean up serialization cache code a bit and add more metrics" 2019-03-28 17:49:51 +00:00
Ed Sanders 592c84a529 Emit 'position' event on surface view after changing doc padding 
Bug: T219508
Change-Id: I7ffb47e4ba031096879a88355f5fa3048a4ab09f
 2019-03-28 14:40:44 +00:00
jenkins-bot 22e0187d09 Merge "ve.init.mw.MobileArticleTarget: Improve iOS Safari by moving 'padding-top' for toolbar" 2019-03-28 12:43:36 +00:00
Aaron Schulz a56fbba6c3 Clean up serialization cache code a bit and add more metrics 
Change-Id: Ib2024026a2b6f42ed0c56479a0cec2a8cbd1e3bc
 2019-03-28 00:26:37 +00:00
Translation updater bot 77efd7507e Localisation updates from https://translatewiki.net. 
Change-Id: I685d13222ef6274616ccd85b4184757755af298f
 2019-03-27 22:30:08 +01:00
Bartosz Dziewoński 500462f4b2 ve.init.mw.MobileArticleTarget: Improve iOS Safari by moving 'padding-top' for toolbar 
We need to set 'padding-top' matching the height of the toolbar
somewhere, so that the toolbar doesn't cover the top of the editing
surface. Apparently moving it from the current place (the top-level
wrapper for the MF overlay) to the document node (the node with the
'contenteditable' attribute) allows Safari to properly scroll the
cursor into view when focussing, rather than scrolling it offscreen.

Bug: T219066
Change-Id: Iee1e03bce24c2f149a0aa0f393a37b9db43eaca6
 2019-03-27 22:06:14 +01:00
jenkins-bot 277e387295 Merge "MobileArticleTarget: When saving a section don't trust current page markup" 2019-03-27 17:16:17 +00:00
David Lynch 5496d18953 MobileArticleTarget: When saving a section don't trust current page markup 
The edit might have changed the section title, which will change the
section-hash, which will make the redirect break. The only way to avoid this
is to use the HTML provided to saveComplete to check for the new hash.

Bug: T213120
Change-Id: I5adfdb44a8304ed4f30def74400e4512e9e8c0ae
 2019-03-27 16:58:58 +00:00
Bartosz Dziewoński 21e9db7d13 Respect user preference for default thumbnail size while editing 
Bug: T69047
Change-Id: Ibf90d290df5634cd89651a427a6aa1c6f9d7a553
 2019-03-26 22:15:26 +01:00
Translation updater bot 0e51d50c2d Localisation updates from https://translatewiki.net. 
Change-Id: Idf0cf87b157b06301892a5dde02d55a2216b912c
 2019-03-26 08:45:33 +01:00
jenkins-bot 455c95df32 Merge "ve.init.mw.MobileArticleTarget: Bring the toolbar back into view after it scrolls out" 2019-03-23 12:10:29 +00:00
Translation updater bot 29e4ed81d5 Localisation updates from https://translatewiki.net. 
Change-Id: I69e1f95f54472fe657d8b3b6f8ef23088e3b29d4
 2019-03-23 10:23:59 +01:00
jenkins-bot c02b357b39 Merge "ve.init.mw.MobileArticleTarget: Remove unused method" 2019-03-23 04:37:46 +00:00
jenkins-bot 40fb9ce0fb Merge "ve.init.mw.MobileArticleTarget: Restore missing methods" 2019-03-23 04:37:02 +00:00