wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-26 07:15:32 +00:00
Code Issues Packages Projects Releases Wiki Activity
15151 commits 30 branches 0 tags 192 MiB
Commit graph

7046 commits

Author SHA1 Message Date
Ed Sanders 0d54a62858 Use mw.Title.wantSignaturesNamespace 
Change-Id: I60187f0a3eb9cf5d56a4fdaa3401b107758bd8e3
Depends-On: Ib2faa22c429096d545ddb829a6b4025427ad6071
 2018-11-27 18:42:44 +00:00
Ed Sanders 7bd58c52a5 Move extension save error handlers into a registry 
These can now be moved to their respective extensions.

Bug: T136859
Change-Id: I2c35b9443208928db43bcfd515864641b10cc602
 2018-11-23 17:19:36 +00:00
Ed Sanders 70253d450a Cleanup save-error handling 
* Use ve.getProp
* Use .abusefilter key instead of string search (the key
  didn't exist when we first implemented AF support)
* Move AF handler next to captcha handler, and comment
  both as should-be-moved-to-plugin.

Change-Id: I171d63844b84b5a12396b6d6746f92110fc06c6c
 2018-11-23 15:42:39 +00:00
Thalia a5c5bc5116 ve.dm.MWExtensionNode: check for body in describeChanges 
Bug: T210257
Change-Id: Iffda3dc0b5b9dc84d294240546193e4b55c45bb7
 2018-11-23 12:27:13 +00:00
Ed Sanders f2a9ccd5bd Avoid HTML string parsing 
Identified using https://github.com/wikimedia/eslint-plugin-jquery/pull/12

Change-Id: I138e018fdc037d688e055eacddfdc5bfc2cc5abe
 2018-11-21 18:47:19 +00:00
Ed Sanders 1a3e8a958c build: Use eslint-config-wikimedia v0.9.0 and make pass 
Change-Id: Idb57fc12e7822cf17e10dbb726480fc7de0ae199
 2018-11-21 16:51:20 +00:00
jenkins-bot cf32ca44d9 Merge "ve.ui.MWTransclusionContentPage: Fix missing icon" 2018-11-20 16:58:14 +00:00
jenkins-bot 71b127b48c Merge "Filter out junk from the HON browser plug-in" 2018-11-20 15:51:18 +00:00
Bartosz Dziewoński 120788db59 ve.ui.MWTransclusionContentPage: Fix missing icon 
It's missing here: https://phabricator.wikimedia.org/F27262533
We forgot this in 09800aa249 (in 2015).
Oops.

Change-Id: I0f1cda43c6566accf45c82a858158f15c2229f47
 2018-11-20 04:04:25 +01:00
James D. Forrester a5c5176333 Filter out junk from the HON browser plug-in 
Bug: T209619
Change-Id: If399319b2675ac8ca6d3d17acbf96634ab5f6395
 2018-11-19 15:25:12 -08:00
Thalia ceb02d3296 Remove needless function call in DesktopArticleTarget 
Change-Id: I6e691e97fe7330496cdf45a2439d8fd373cf221f
 2018-11-19 18:58:38 +00:00
Bartosz Dziewoński 914e6905ed ve.ui.MWTemplateDialog: Unbreak the logic to enable/disable "Apply" button 
I have moved this block of code to the wrong place in change
13675e4a81. As a result,
`this.loaded` was being set early, so the dialog was treating
all of the pre-existing transclusion parts as newly inserted,
and the "Apply" button was therefore always enabled.

Bug: T209661
Change-Id: I3c1b45f91738ab6fc4a6f6d61ae5bf925c9a1bb5
 2018-11-16 01:08:29 +01:00
Bartosz Dziewoński a66f57643c ve.ui.MWGalleryDialog: Update "Apply" button when image added 
Use 'change' event instead of 'reorder' to respond to this event.
This also covers removing images now, so delete that code.

Bug: T206534
Bug: T209451
Change-Id: I9eda383be2ca7f02b42814d43e6b42961b9b96e7
 2018-11-15 20:56:39 +01:00
Thalia 70c3bc65d9 ve.ui.MWGalleryDialog: Improve how dialog actions are enabled 
Enable the Apply changes/Done action if (i) the current contents
of the dialog inputs would change the gallery node or (ii) if the
user has interacted with inputs that alter the gallery caption or
images (including dragging/dropping or removing an image).

Bug: T206534
Change-Id: Ia6c1cc60d4f32ac66778e6973e2d400491f74128
 2018-11-13 19:14:33 +00:00
Ed Sanders b2718b186a Separate handling of document HTML and edit metadata 
For now this is just moving code. In the future we will
be able to make the handling of edit metadata async.

Change-Id: I7b442dfbdd890154de0e7faab1f6b0346caa8de0
 2018-11-08 18:30:33 +00:00
Ed Sanders 3564006e91 $.extend -> ve.extendObject 
Change-Id: I1def4d63c231da153a52a649e7bab584e789b6d1
 2018-11-07 16:51:39 +00:00
jenkins-bot 89ba8d0ba8 Merge "Fix margin/padding on save dialog enter prompt" 2018-11-07 16:21:45 +00:00
Ed Sanders 2149de7bb0 Fix margin/padding on save dialog enter prompt 
Non integer px values were resulting in scrollbars.

Bug: T208947
Change-Id: Ifeefbcc6068b086a3b351706827b34129b7d0227
 2018-11-07 13:50:18 +00:00
jenkins-bot 73deda8f66 Merge "ve.init.mw.DesktopArticleTarget.init: Move Vector styles to separate file" 2018-11-07 13:18:47 +00:00
jenkins-bot 07856d2a16 Merge "ve.init.mw.DesktopArticleTarget: Edit surface padding and gutter for Minerva" 2018-11-07 13:18:42 +00:00
jenkins-bot 4d0de7744d Merge "MWTempWikitextEditorWidget: Don't rely on skin to set width for textareas" 2018-11-07 13:18:39 +00:00
jenkins-bot 45c9ff5e21 Merge "ve.init.mw.DesktopArticleTarget.init: Make multi-tab mode compatible with Minerva" 2018-11-07 12:26:38 +00:00
jenkins-bot 6016cad43f Merge "ve.dm.MWImageModel: Drop back-compatibility with old versions of VE selections" 2018-11-07 11:23:27 +00:00
Bartosz Dziewoński b0c0553dc2 ve.init.mw.DesktopArticleTarget.init: Move Vector styles to separate file 
Change-Id: Iecf25bf71c1e4fca8964d608082e42ef0c929044
 2018-11-06 16:47:31 +00:00
Bartosz Dziewoński c87b010da0 ve.init.mw.DesktopArticleTarget: Edit surface padding and gutter for Minerva 
Bug: T208102
Change-Id: I0a43550c938144f79f04dc91c2c742229f939177
 2018-11-06 16:47:23 +00:00
Bartosz Dziewoński 1ffdee226c MWTempWikitextEditorWidget: Don't rely on skin to set width for textareas 
Bug: T208102
Change-Id: Ic14105556996a74e2ba656cd88571fb94cf4e49b
 2018-11-06 16:47:08 +00:00
Bartosz Dziewoński 5996cf15e9 ve.init.mw.DesktopArticleTarget.init: Make multi-tab mode compatible with Minerva 
* Make inserting secondary tab work with Minerva's non-standard structure
  of navigation menus
* Distinguish primary and secondary tabs with tiny icons, since Minerva
  hides their text
* Hide section edit link dividers (unnecessary when we use icons)

Bug: T208102
Change-Id: Ieaec60165617e3b423ec58857d6f0a0406e22b1d
 2018-11-06 17:45:48 +01:00
jenkins-bot 458b6e87a4 Merge "MWTransclusionNode: Change HTML messages to plain DOM" 2018-11-05 22:45:35 +00:00
jenkins-bot 678d59fb92 Merge "Revert "Disable VE on Special:Undelete"" 2018-11-05 21:08:46 +00:00
jenkins-bot ef5ad0052a Merge "SaveDialog: Remove scrollable property from nested panels" 2018-11-05 20:46:22 +00:00
James D. Forrester 17377ce65c ve.dm.MWImageModel: Drop back-compatibility with old versions of VE selections 
Change-Id: I38b309ca240b8305a0b29e11f822e1ad6e1ed3da
 2018-11-05 12:44:57 -08:00
jenkins-bot 6ce7ac63d7 Merge "Fix padding around .ve-ui-mwParameterResultWidget-name(s)" 2018-11-05 18:27:43 +00:00
jenkins-bot 3f97176f7c Merge "Use upstream AbandonEditDialog" 2018-11-05 18:19:23 +00:00
Bartosz Dziewoński 259aadaf12 Revert "Disable VE on Special:Undelete" 
No longer needed. The underlying problem was fixed in
1aae17c7a5.

Bug: T173154
Bug: T174748
Change-Id: If10301ee78ba031238a11a9f9b2130a2b47a567c
 2018-11-05 18:41:05 +01:00
Ed Sanders 66972356cf MWTransclusionNode: Change HTML messages to plain DOM 
Bug: T208732
Change-Id: I61a958292984586dc90262989ebb6c181f28a605
 2018-11-05 16:28:11 +00:00
Ed Sanders 381bc46130 Fix padding around .ve-ui-mwParameterResultWidget-name(s) 
Bug: T208720
Change-Id: Iff8bbb702fdceab86d423a9f74aaebac8b41ebc3
 2018-11-05 11:50:12 +00:00
Ed Sanders 956c28bf56 SaveDialog: Remove scrollable property from nested panels 
Scrolling is handled by oo-ui-window-body.

Change-Id: If074b5de859b5a9dbad76d6715739e4d37e68c90
 2018-11-02 20:32:23 +00:00
Bartosz Dziewoński 1aae17c7a5 DesktopArticleTarget.init: Don't load on special pages with action=submit in the URL 
Bug: T168533
Bug: T176022
Change-Id: Ifb7b9cca21423684a901dccabab23fb64e576102
 2018-11-02 17:54:01 +01:00
jenkins-bot 74a744327e Merge "ve.ui.MWMetaDialog: Wait for each page to set up (especially 'category')" 2018-11-01 23:02:59 +00:00
jenkins-bot 9ac196777a Merge "Blocked apply if redirect address is invalid" 2018-11-01 22:17:03 +00:00
jenkins-bot 490b1171e3 Merge "Update the styles for VisualEditor's "Format" dropdown" 2018-11-01 21:20:10 +00:00
flutters f847880292 Blocked apply if redirect address is invalid 
Extracted extractValue to a separate method
Added checkValidRedirect method to MWSettingsPage
Added errors when redirect address is invalid
Added 1 error message to localisation strings
Added 1 TODO (more precise error messages)

Bug: T74971
Change-Id: I8bcf16e97e5211671759acdf0846243df2c03fc2
 2018-11-01 21:20:01 +01:00
Bjornskjald 9490ff370c
Update the styles for VisualEditor's "Format" dropdown 
Now when using the MonoBook skin, the text size for headings inside the dropdown is the same as their size on the page.

Bug: T72559
Change-Id: Ie0c30369021f8022b788730a6de90e44a288b13b
 2018-11-01 20:40:56 +01:00
jenkins-bot 62c81905e6 Merge "Use changed ve.dm.Selection interface, if present" 2018-11-01 13:39:18 +00:00
jenkins-bot c1871d0216 Merge "ve.ui.MWMediaDialog: Open to the "Upload" tab when dropping/pasting file" 2018-11-01 11:48:46 +00:00
Ed Sanders 1f7b239fbb Reset scroll and tab state when closing dialogs 
Bug: T205948
Depends-On: I993455b648b62b97164f55146c75a53da70c322b
Change-Id: I30336caf76e8ff4de4c4dbd3728211c9a58d724e
 2018-11-01 04:11:28 +00:00
Bjornskjald daa1f6eb1e
Add using the article title as the default value for sorting in categories 
This way users can rearrange/edit current name without exiting VE and/or copying it from somewhere else

Bug: T145339
Change-Id: I80690cdf344c2ccbdd8be486642afcf841f36c10
 2018-10-31 19:01:02 +01:00
Ed Sanders eab2b728e9 Use upstream AbandonEditDialog 
Bug: T192333
Depends-On: Ib581528363a3fe5461529515835bd7fb1ce66e56
Change-Id: I206366e096aafc02102357648b9f85f879479500
 2018-10-31 13:38:31 +00:00
David Chan 2c3e33b759 Use changed ve.dm.Selection interface, if present 
Bug: T208228
Change-Id: Ie2027c4d16e0ac591512e90dbdeea012f11ff875
 2018-10-31 12:07:14 +08:00
James D. Forrester c36f3d2214 Revert "Update VE core submodule to master (02f5f0ca4)" 
This reverts commit be628a5b7e.

87b20f9b Revert "[BREAKING CHANGE] Do not cache document model data in DM selections"

Change-Id: I47bbf757a4ad227346d3734f6e50d928a2de1409
 2018-10-30 15:12:30 -07:00