Commit graph

51 commits

Author SHA1 Message Date
Ed Sanders 1a3e8a958c build: Use eslint-config-wikimedia v0.9.0 and make pass
Change-Id: Idb57fc12e7822cf17e10dbb726480fc7de0ae199
2018-11-21 16:51:20 +00:00
Ed Sanders 1a4158f6d2 Use Tool.$link.focus() for highlighting now OOUI styles :focus
Change-Id: Ia5b4c68cb49e3954aae7de9a8907f1fb9f205e2c
2018-05-02 12:52:17 +01:00
jenkins-bot aca63b6189 Merge "Catch timeout errors in screenshot scripts" 2018-01-13 11:09:25 +00:00
Željko Filipin 4c44340597 ESLint parserOptions is reduntant when env is set to es6
Bug: T184724
Change-Id: If39d3efc6476a94aaeb5956f142d2b12bd9be9bb
2018-01-12 17:04:35 +01:00
Ed Sanders 7c8373106f Catch timeout errors in screenshot scripts
Bug: T184724
Change-Id: Ifbc03b1291c291dcfc862487766e3786f9bd437c
2018-01-11 18:42:22 +01:00
David Lynch 64944c119a Use mw.storage instead of localStorage
mw.storage catches errors, so we won't crash horribly when the user has
localStorage disabled / full.

Bug: T181822
Change-Id: I212994eb535b9a8fb5f6c09deaa10b16c3d7f10e
2018-01-10 11:44:24 -06:00
Ed Sanders ec4053f2da Add screenshot tasks for manual and re-use tabs in Citoid
Bug: T180363
Change-Id: Icf9a370e7b80611b1f5e897e31e0004b656dabac
2017-11-13 17:39:47 +00:00
Ed Sanders 835a775a49 build: Upgrade grunt-eslint from 19.0.0 to 20.0.0
Mostly indent and regex fixes.

Change-Id: Iaf9d02363c78cb71deec5c4cab53a05b67f60600
2017-07-18 12:55:33 +01:00
Ed Sanders 75d583a0d9 Use static parseDocument method
Change-Id: I545a58ffcbf1c7c57c197f4858958de835a40394
Depends-On: I5b36e187a5e8bb68b47b2fccf5b46c08b81b01d9
2017-06-08 14:43:09 +01:00
Ed Sanders f178061117 [DEPRECATING CHANGE] Make Target#createModelFromDom static
Change-Id: I019689f87ac0f7f40a8a7600029b5ce1bc92e77f
2017-06-08 14:35:31 +01:00
jenkins-bot db73a1419c Merge "Run screenshot tests in series" 2017-05-05 15:55:41 +00:00
Ed Sanders a866678c36 build: Update eslint to 0.4.0 and make pass
Change-Id: Id02a26bad70504cfe90bee6aab0fa3ea646b15d7
2017-05-04 21:28:17 +00:00
Ed Sanders 63d711dd48 Run screenshot tests in series
Use one test context, and store language as a property.

Change-Id: I4809c41331c4d70a024eec48f30eef207a09a098
2017-04-28 16:01:22 +01:00
Ed Sanders 08bfe509df Screenshots: Hack the toolbar to display "Article" instead of "Help page"
Change-Id: Iad632a23939712d8d7feb3097b714bfa30d362a1
2017-04-19 13:07:34 +01:00
Željko Filipin ca46a67843 Fix LanguageScreenshotBot by using an existing article
LanguageScreenshotBot failed because it tries to open VisualEditor on a
page that does not exist.

Bug: T162454
Change-Id: I5539c54b7c0ce1f302df0962dad19797d26953da
2017-04-19 12:28:38 +01:00
Ed Sanders c0e188c602 VisualDiff automated screenshots
Change-Id: I422fc459ebc41a98f46e1ff7365a8ccaea2501d2
2017-03-28 22:43:02 +01:00
Ed Sanders e7346f57eb Separate screenshot test runner from specific tests
Change-Id: Ic0eb773086aa7b6078c5095c1ad89ef3f6236019
2017-03-28 18:15:25 +01:00
Ed Sanders 15c986d128 Use var/let in screenshot.js
Change-Id: I70082dd6e4df38616e5c33c2b71f0aaae22bac63
2017-02-03 22:57:47 +00:00
Ed Sanders 2a5f29897f Mark all node files as ES6
Change-Id: I85d1ea2bf26647d04891574d1cc5a9828a5d4bbb
2017-02-03 22:26:55 +00:00
Volker E 1a7e325eb5 Replace outdated color with current one
Replacing outdated color with `#36c` from overhauled color palette.
Also making focus following common outline-width.

Bug: T153486
Change-Id: I5c76a788fff21c53bd193628bc610f38d388179f
2017-01-11 15:16:59 -08:00
James D. Forrester 36befda61c build: Replace jscs and jshint with eslint
It's new, it's fresh, it's amazing, it's here.

Change-Id: I5dc784411f704685ed5cc763a2b2b1c5d3e5a610
2016-10-28 18:33:15 +00:00
Željko Filipin a7e216dd94 Increase Mocha and Selenium timeout for language screenshots to 40 s
Bug: T139613
Change-Id: I06499f89f340cfda2f30d80c2f8b721b71627bac
2016-08-31 10:00:48 +00:00
Željko Filipin 2777a9fc2d Run language screenshots on Windows
Fonts do not look good on Linux and Mac is slow.

Bug: T141369
Change-Id: I48347dabb8a68c97b615ffda94e515e6347b7d3c
2016-08-24 14:43:05 +00:00
Željko Filipin 15958af7d2 Fix language screenshots timeout error
Increase Mocha and Chrome timeout from 20 to 30 seconds.

Tool groups (headings/text style/indentation/insert/page settings) needs
more than 20 seconds.

Error message: Error: timeout of 20000ms exceeded

Bug: T139613
Change-Id: Id6d943a78d7109012c2372cbd3c00e6a80ed9583
2016-08-22 14:16:00 +00:00
Željko Filipin 22f36fd3ac Run language screenshots from Jenkins
Bug: T139613
Change-Id: I869dd27f58e7972456fb09792262cd1be0aeeaa0
2016-07-25 09:43:40 +00:00
Ed Sanders 0246f77cb6 screenshots: Restore save button to more settings task
Change-Id: I847cf81f3092be50f0fcf019eea3226decedd445
2016-06-29 23:02:43 +01:00
Ed Sanders 2780c86bff screenshots: Add task for plain insert menu
Change-Id: Id77df7ff88e030b283b1f94ff85537bfd4f20345
2016-06-29 20:39:42 +01:00
Ed Sanders fcc343eb20 screenshots: Add category and page settings menu item tasks
Change-Id: Iacf52612eedc74b050a78f1ddb23e7a443afebe2
2016-06-29 16:02:32 +01:00
James D. Forrester 5ef5d4d24c screenshots: Run on enwiki rather than Beta Cluster for content
Change-Id: Ia06c2a39905d0a899f7ff45f1beec4e0e4236fee
2016-06-29 14:30:15 +00:00
jenkins-bot 7ac5943daa Merge "screenshots: De-duplicate menu screenshotting code" 2016-06-29 14:23:31 +00:00
jenkins-bot 3e8d3ce9b1 Merge "screenshots: Correct name of a list menu screenshot" 2016-06-29 14:19:25 +00:00
James D. Forrester 65d24b0dea screenshots: Correct name of a list menu screenshot
Change-Id: I3d0921e82b7c9608ab0cca15ffdbcb2d98f56cf5
2016-06-29 15:12:39 +01:00
Ed Sanders 0b89467ab9 screenshots: De-duplicate menu screenshotting code
Change-Id: I88ace5b2b6ab3b629ddf217f314e1a33c2e33287
2016-06-29 15:10:58 +01:00
Ed Sanders 8cc9a81857 screenshots: Add screenshots for highlighted items in the insert menu
Change-Id: I4232a0709ea241ad173543fdf4eab0b4c3ce02a2
2016-06-29 14:32:31 +01:00
Ed Sanders 5c1a2607d9 screenshots: Add delay to wait for link inspector images to load
Change-Id: I36168f08cc2a8ec320afc8c87ae6518d50db2c57
2016-06-29 13:44:25 +01:00
Ed Sanders 4fef9d141c screenshots: References list dialog
Change-Id: I5a14412198cdc3cf48cd574195716fe0070f0158
2016-06-29 13:36:00 +01:00
Ed Sanders d29f874983 screenshots: Add task for link inspector search results
Change-Id: I0cbe71a21e85eeaf4edaf49c8499c6f87a36c1fd
2016-06-28 22:43:01 +01:00
Ed Sanders 7278771254 screenshots: Crop to viewport
Change-Id: I2a50e4b090cdd9a6d60c85fad438cee3cc7e0b1f
2016-06-28 22:43:01 +01:00
Ed Sanders 37c45b83b8 screenshots: Add task for cite button
Change-Id: Ibb5677835df4ca157c53ce9d1990197b4cd30c28
2016-06-28 12:12:02 +01:00
Ed Sanders 5186f92f62 screenshots: Add task for Math dialog
Bug: T136675
Change-Id: I3194eb1b8131cfc3f64188cc40c26c1c1525d8de
2016-06-27 13:53:46 +01:00
Ed Sanders ad287c4744 screenshots: Groups some tasks into sessions to improve performance
Change-Id: I975a1fd44020e034a7a65b837c8715a97f308831
2016-06-27 12:25:05 +01:00
Ed Sanders c3fa707adc screenshots: Add multi-language support
Change-Id: I1da41cffd946a76e5f09097decbc0a25562c9508
2016-06-27 12:23:45 +01:00
Ed Sanders 746321a29f Add screenshots grunt task for taking documentation screenshots
Imported from https://github.com/zeljkofilipin/language-screenshots

Bug: T119482
Bug: T132574
Co-authored-by: Željko Filipin <zeljko.filipin@gmail.com>
Change-Id: Idade622d1f3db0eb4b5f3fbc1a0eee401feeb600
2016-06-27 12:19:35 +01:00
Ed Sanders ae26eefb05 Fix typos
Add some common ones to typos.json

Change-Id: I3830be4949ab6a5fd998d6937ed83e9f18091c2b
2015-12-09 16:47:13 +00:00
James D. Forrester fe8a9eff91 build: Add grunt-tyops
Change-Id: Idb30814e69356eb2b3282fae018c142295df922f
2015-12-09 00:53:34 +00:00
James D. Forrester 19df1d4c8a build: Enable jscs rule 'requireVarDeclFirst' and make pass
Change-Id: Ia2f765d12bde001c329c2ff4c080a36b71de9803
2015-08-19 11:05:01 -07:00
Roan Kattouw ee743f869d Use submodule for VisualEditor core
* Add lib/ve.
* Remove modules provided by VisualEditor core.
* Update paths.
* Remove VisualEditor core specific things from Gruntfile.
* Remove entries from external.js already in lib/ve/.docs/external.js.
* Implement build script to compose a jsduck index that includes
  all of VisualEditor core. Right now it includes VisualEditor's
  index as-is, and because those patterns (e.g. ve.dm.*Node) will
  also MW subclasses this means our category page will include
  MW classes under "VisualEditor (core)" (before the repo split,
  this was intentional).
  This is inevitable unless we list every class individually, or
  (the plan) until we move the MW subclasses out of the ve.*
  namespace and into mw.* somewhere.

Bug: 45342
Change-Id: Iff45cd555430634c9fc341fd3b177c1e0625300b
2013-12-20 09:18:41 +00:00
Roan Kattouw c41b60021d Move libraries to the lib/ directory
Didn't move unicodejs because it doesn't have its own repo
and is currently mastered in this repo

Change-Id: I14ab4bd641077d993ac235d8bcdcf8e50a1a72a7
2013-12-19 23:02:52 +01:00
Timo Tijhof 370b07ffaf demo: Convert VisualEditor standalone demo to pure HTML+JS
Change-Id: I9a93abce933e91881e553c0bdb26f31065cf4cda
2013-12-19 03:12:13 +01:00
Timo Tijhof 3e9b227a6a Clean up HTML files, Gruntfile and remove index-phantomjs-tmp hack
Consistently:
* Use <!DOCTYPE html>.
* Use lowercase element tags.
* Indent <head> from <html>.
* Use <meta charset="utf-8">.
* Indent <script> and <style> content from open/close tag.
* Put <link> before <script> when in <head> (in ve/test).
* Use .html instead of .php for indexes where PHP is no
  longer used.
* Use the same license header as we use elsewhere (/*! instead
  of /** and no @file)

Gruntfile:
* Include the new .js files in jshint (demos/**/*.js).
* Order buildloader keys in the same order as the directories
  they go to (alphabetically).
* Add missing jshint patterns:
  - .docs/**/*.js
  - build/**/*.js
  - modules/ve-wmf/**/*.js
* Add missing qunit test:
  - qunit.unicodejs
* Add missing watch patterns:
  - .jscs.json
  - qunit.unicodejs

Also:
* Moved relatively large pieces of script into separate files
  so that they are less repeated (though .template) and also
  able to be linted properly.
* Fixed jshint warnings in newly-created trigger.js and demo.js.
* Moved <script> elements already in <body> to bottom of <body>
  (in ve/test and eg-iframe).
* Moved <script> in eg-iframe from <head> to <body>.
* Fixed buildloader grunt task to use a non-\n whitespace match.
  for the start as well, the newline before the placeholder was
  being stripped.
* Removed the (now obsolete) index-phantomjs-tmp hack.

Change-Id: I7c5a371b82f69f367a8e1c11673d2f37868bc931
2013-12-18 07:00:23 +00:00