Commit graph

195 commits

Author SHA1 Message Date
Translation updater bot 8c54b923b7 Localisation updates from https://translatewiki.net.
Change-Id: Ic09f904de2bf7550cbaf39e8100ceda07b07ab7b
2023-05-11 07:37:57 +02:00
Bartosz Dziewoński 62d3fc128e Remove unused message 'visualeditor-dialog-transclusion-placeholder'
Unused since e1ea921f76.

Change-Id: I88a51de0ae5583ba52bb3477625879d273150b39
2022-12-29 16:14:35 +00:00
Pols12 afca7bf0af TemplateDialog: separate “Add template” messages
Use distinct messages for section heading, button label and input
aria-label, to allow a potentially better localization.

Bug: T304121
Change-Id: I3e3b06a035e2f11f5f32face789b934e22916e49
2022-12-22 15:08:31 +01:00
Translation updater bot b0c98cfaef Localisation updates from https://translatewiki.net.
Change-Id: I9056cb8779beeb4a2958c4fa04210170eda1b564
2022-10-31 09:47:10 +01:00
Thiemo Kreuz 4ca12d6555 Use same formatting for "Parameters:" in qqq.json
Change-Id: I236a8c360a141e68a079f9dd6878e930332ed856
2022-09-27 16:49:13 +00:00
jenkins-bot f8fd06dbaf Merge "Remove 5 more very old unused messages" 2022-08-01 09:46:45 +00:00
Thiemo Kreuz b8b5ed3eaa Remove 5 more very old unused messages
* "visualeditor-dialog-transclusion-options" was added in 2013 via
  I3bcf924. It was used as the label for multiple FieldsetLayouts in
  ve.ui.MWTransclusionDialog.js. In 2013 a larger rewrite was done via
  I51e74b3. The FieldsetLayouts with this message don't exist any more
  since then.
* "visualeditor-dialogbutton-meta-tooltip" was added in 2013 via
  Ibf63329. It was used as the button label in
  ve.ui.MWMetaButtonTool.js. This file was deleted in 2013 via
  I3bb61d5. That patch added a new message "visualeditor-meta-tool"
  that says the same as the old message". The old message is unused
  since then.
* "visualeditor-savedialog-label-create" is a new key for a message
  that existed before. The old key was "visualeditor-create-page". It
  was used in ve.init.mw.ViewPageTarget.js as a button label. This
  usage was removed in 2012 via I5f59482. The renamed message was
  never used.
* "visualeditor-savedialog-label-report" was added in 2012 via
  I5f59482. It was used as a button label in
  ve.init.mw.ViewPageTarget.js. The feature was removed in 2013 with
  no replacement, see I8a5e0ab. Some of the messages that became
  unused got removed in the same patch, but not all of them.
* "visualeditor-savedialog-warning-dirty" was added in 2013 via
  I3daf631. It was used for a confirmation popup in
  ve.init.mw.ViewPageTarget.js. I8c0db01 moved the code to
  ve.ui.MWSaveDialog.js. In 2015 the confirmation popup was removed
  with no replacement, see I9091534.

Change-Id: Iae7961612d5b5be9cdd294a67a9ce40ee8cb9b4d
2022-07-27 09:01:21 +02:00
Thiemo Kreuz 91b5cea852 Remove unused template dialog title message
The message "visualeditor-dialog-template-insert" was added in 2021
via I5da4003. It was used as a dialog title in
ve.ui.MWTemplateDialog.js. In 2021 we introduced three new messages
via Ib9b76ca. One of them still says the same as the old message, but
got a new key assigned. It appears like we forgot to remove the old
message.

Change-Id: Ie3854114197e3f36b48bb7efd8dd96a1f9651198
2022-07-27 08:54:31 +02:00
Arlo Breault 94c4d619a7 Add a checkbox to use the image caption as the alt text for galleries
The need for something like this was anticipated in
I2bf43c7e83283f43e047229eb53c244918fcbb0c.

As of version 2.5.0 of Parsoid's output, if alternate text is missing
for an image but a caption is present and image isn't displaying the
caption (ie. it isn't a thumb or frame), then the text content of the
caption will be set as the alt attribute.  Parsoid will then drop the
alt attribute when serializing if it matches the caption text, since
it's unnecessary.

However, if the caption is modified and the alt text isn't, the alt will
be serialized.  This is likely to be unexpected to editor.  They may
have missed that the both the caption and alt are populated in VE and
only edited one place.

Since all of the above is happening only for images where the caption
isn't visible, it doesn't appear to be a much used feature since, at
least for inline images, the experience of caption editing was already
less than optimal.

However, because of a quirk in how galleries are rendered in Parsoid,
this affects gallery caption editing, which is visible and presumably
used more often.  See T268250 for a discussion on an improved gallery
structure.  But for now, gallery images are effectively inline and set
the alternate text, thus subject to the above.

Here we add a checkbox so that the default is to ignore the alt if it's
the same as the caption.  And only make use of it if it differed
originally or was explicitly unchecked to modify.

Bug: T311677
Change-Id: Idf297d8a98995971c5835b0cea56c3317a3626e2
2022-07-22 15:46:55 -04:00
Thiemo Kreuz 139e6547d1 Remove unused media/meta-related messages
visualeditor-dialog-media-thumbdimensions
Added in 2014 via I7b4d019, but never used, as far as I can tell.

visualeditor-dialog-media-searchselect
Unused since I65aed34 from 2015.

visualeditor-dialog-meta-settings-displaytitle-enable
The feature was removed in 2017 via I46db6b1.

This patch also marks some other messages as being used via comments.

Change-Id: Ia10b6a5c0ea83dd670e2cfdbaa768c41fc0cf392
2022-07-13 13:56:41 +02:00
Andrew Kostka d5b8107902 Use "Add template" label in the sidebar and as the header
Bug: T311107
Change-Id: Ib85c08c5d72e621a7687dc393b2f8d9443f13b06
2022-07-06 10:55:43 +00:00
Adam Wight 0c87f16057 Shorten text for add buttons
This makes layout easier on small screens.

Bug: T311107
Change-Id: I506ac8ae721cf7b77f20c39b8049455d40d319de
2022-07-05 13:50:47 +02:00
jenkins-bot 1e094a8868 Merge "Fix broken error message 'visualeditor-saveerror'" 2022-06-27 19:07:18 +00:00
jenkins-bot c19a44e246 Merge "Remove unused media info messages" 2022-06-22 19:36:00 +00:00
Adam Wight 15ef2dc3c6 Remove inaccessible ARIA annotation from old sidebar
This was added via I3b792ff. It's about the old sidebar which isn't
accessible any more.

Bug: T311069
Change-Id: I29919285255a84bd58aa06ee1b2816d25a8112a6
2022-06-22 13:44:23 +02:00
Thiemo Kreuz f0bce1c845 Remove unused media info messages
The "visualeditor-dialog-media-info-…" messages are part of a larger
info panel that appears after searching for an image. This was
introduced via I7b4d019, a patch with 52 patchsets, developed between
September 2014 and January 2015.

The "credit" message appeared first in patchset 2, see
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/161342/2/modules/ve-mw/i18n/en.json

The "dateformat" message appeared first in patchset 12, see
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/161342/11..12/modules/ve-mw/i18n/en.json
This message appears to be special in so far that it was never used
to begin with.

The other two messages appeared first in patchset 21, see
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/161342/20..21/modules/ve-mw/i18n/en.json

3 of the 4 messages are used at this point. The message keys are
constructed in code via `"visualeditor-dialog-media-info-" + key`.
This piece of code was also introduced in patchset 21, see
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/161342/20..21/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js#629

This was entirely rewritten in patchset 41, see
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/161342/40..41/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js#b670
Since then the messages are unused. The info panel still exists and
still shows all information, but the 3 fields "ImageDescription",
"LicenseShortName", and "Credit" just show an icon and the field's
value, but no label (any more).

Change-Id: Ief35a85d8c5cbf49b662adbfd068dbecd8e4f154
2022-06-22 09:09:07 +00:00
jenkins-bot 1ba1bc76f4 Merge "Remove dead code in MWTemplatePage" 2022-06-22 06:29:47 +00:00
jenkins-bot 4eceae3962 Merge "Remove two unused placeholder messages from gallery dialog" 2022-06-22 00:38:19 +00:00
WMDE-Fisch 11f5f6cb59 Remove dead code in MWTemplatePage
Bug: T310859
Change-Id: Ie55d82fb6f3be0b90b8f42aecdd761624b94afca
2022-06-22 00:20:00 +00:00
jenkins-bot 3b9e0bf0dc Merge "Remove unused media position messages" 2022-06-21 17:37:06 +00:00
WMDE-Fisch 8535fa72ab Remove dead code in MWTransclusionDialog
Removing CSS will go into a follow up.

Bug: T310859
Change-Id: I05a0c12ab98ca428aca64181469d8c9cf6311f03
2022-06-21 14:22:47 +02:00
Thiemo Kreuz ec2a961d00 Remove two unused placeholder messages from gallery dialog
Both messages are unused since I1e93c3a. As I understand the patch
what it did was replacing two plain text input fields with WYSIWYG
editors. These don't use placeholders.

Change-Id: Ia4ac7d7c9ae86dedd02040a81300a9722e94d1b7
2022-06-21 14:20:33 +02:00
Thiemo Kreuz a01163d097 Remove unused media position messages
All 4 messages are introduced via I15fbd1e in January 2014.

The "none" message is unused since Iddd78c9 from February 2014. It
was replaced with a checkbox with a different label.

The other 3 messages are unused since I7057997 from February 2015.
A more generic widget is used since then. It uses messages that are
named "visualeditor-align-widget-center" and so on.

Change-Id: I7ad4772cb4fdec7e478cee23dccd5ae600834caf
2022-06-21 14:11:53 +02:00
jenkins-bot d61bac4907 Merge "Remove unused "enabled in namespace" messages" 2022-06-20 16:22:35 +00:00
Thiemo Kreuz ca4755eeba Remove unused "choose media size" messages
The three messages have been added via Ib973ea2 (tracked via T49804)
and I6778705 in 2014. They have been used exclusively in the file
ve.ui.MWMediaEditDialog.js.

They have been removed from the file via I017a017 in 2014. The commit
message is a bit confusing. It sounds like the changes are copied
from the core submodule. But said submodule is only lib/ve. All other
changes in the patch are done to adapt to the changes made in the
submodule.

TL;DR: Unused since I017a017.

Change-Id: Ib475cce34f55a70d6fb7d3a36b197ced0b043337
2022-06-20 17:35:33 +02:00
Thiemo Kreuz 0238b12341 Remove unused "enabled in namespace" messages
One of the two messages was introduced via I4ef25c0 in 2012.
Back then it was meant to be used as part of the
"visualeditor-preference-enable" message.

Both are, as far as I can see, unused since I9d7786b (tracked via
T58205) from 2013.

Change-Id: Icdfeb431553883f2b105ddd1c3b36873ba7c0b67
2022-06-20 17:04:02 +02:00
WMDE-Fisch 6396b030d5 Remove dead code in MWTemplatePlaceholderPage
Bug: T310859
Change-Id: I04de9c4bd3828e8769136d5776037e927ba7b4ab
2022-06-20 10:30:31 +02:00
WMDE-Fisch bf2f40e8d4 Remove dead code in MWTransclusionContentPage
The outline item is only used by the new sidebar for the move and
remove flags it seems.

Bug: T310859
Change-Id: Ia74e5b0e3dbf81e745137b181ed34a4d48dac42c
2022-06-17 16:46:30 +02:00
jenkins-bot e2a3629aa8 Merge "Remove redundant error message used sometimes when switching" 2022-06-17 13:24:10 +00:00
WMDE-Fisch 3273b7e5bd Remove dead code in MWParameterPage
Parameters do not have an "OutlineItem" anymore so the code for
that was completely removed.

Bug: T310859
Change-Id: Ie57f462b8fda4505b99ee5bc9d788908d18d9c64
2022-06-17 12:25:40 +02:00
Thiemo Kreuz 218ac78960 Remove obsolete "search for a parameter" page and widgets
… as well as messages, CSS, and icons that are now unused.

Bug: T310859
Change-Id: I1a2797728788cf1a86299414c1430ded0b362d4e
2022-06-17 10:23:00 +02:00
Bartosz Dziewoński 5622576ef9 Fix broken error message 'visualeditor-saveerror'
The message 'visualeditor-error-invalidresponse' doesn't exist,
it has been removed in 5f1c68945d.
MediaWiki API methods can return an error message for this case.

The message 'visualeditor-saveerror' is not used anywhere else.

Change-Id: I3f5617b94135fa602b714aafc0eb6b16f2cd77df
2022-06-16 00:35:13 +00:00
Bartosz Dziewoński 559d85f0f4 Remove redundant error message used sometimes when switching
The API error messages already explain everything well enough,
we pass them directly into a very similar popup in #loadFail.
This message is older than the pretty API error responses,
and didn't work with them well.

Bug: T306763
Change-Id: Ie0d8dc24c967cce02579d6c0539a55ba14372f84
2022-06-16 01:28:19 +02:00
WMDE-Fisch 82718bf70a Remove feedback message link
The testing phase for the implemented features is finished. So the
feedback link for the project can be removed.

Also added missing documentation for a message key used.

Bug: T307188
Change-Id: I2e2e4ff58d2bacda5ae841bcf6f418e786a3967e
2022-06-15 12:37:14 +00:00
Adam Wight 1b4c81c27d Remove $wgVisualEditorTransclusionDialogInlineDescriptions feature flag
The feature is always enabled now.

Bug: T307188
Change-Id: Id8b39d44901dee9118837fc4670d7faa4ef19b43
2022-06-15 12:09:47 +02:00
Svantje Lilienthal 58fd0531d9 Remove updated feature message about search
Bug: T296471
Change-Id: Ie6eea76dacdc614ecb910c48e7e1f519b8c69322
2022-06-10 13:13:51 +00:00
Amir E. Aharoni 646a812ef4 Split advanced language variants messages
These messages are quite advanced, and they are strongly needed
only in a handful of languages. To make VE localization easier
for volunteer translators, they should be in a separate file,
clearly labeled and with a different priority.

I'll make a separate patch for corresponding translatewiki
configuration.

Change-Id: I64a70b9b4756efea7dfa7cf3cb4dbe9251b73211
2022-05-29 22:16:26 +03:00
Translation updater bot 0bee2c6ce9 Localisation updates from https://translatewiki.net.
Change-Id: I4ff19a0e7896443cff27f009009accab6ca25592
2022-05-26 08:52:21 +02:00
Translation updater bot 24a00796fb Localisation updates from https://translatewiki.net.
Change-Id: I3445bd329c8262e14d0a6e1de94d2bb02fd952a1
2022-05-23 08:17:53 +02:00
Ed Sanders e9b29e7714 Messages: Remove 'visualeditor-donebutton-tooltip'
This was removed from the code a while ago when we switched
to a single toolbar on mobile.

Change-Id: Ic2a807bd8e17a692ad3a6974bbb3028fa1d2d434
2022-05-18 01:06:45 +01:00
WMDE-Fisch 1f4eec1a10 Nudge translators to make unused toggle button label short
Even though we wrap and break word, it would be better fitting with
a short message here.

Bug: T300008
Change-Id: I6ce8dc349bafec75001e3693faaac10d59637c66
2022-04-29 13:47:51 +02:00
jenkins-bot 0e77a51898 Merge "Stop hide unused label from overflowing" 2022-04-29 08:45:20 +00:00
WMDE-Fisch 4377893297 Stop hide unused label from overflowing
Will implicitly set a max width for the button due to the margin.
Long words will break in the middle of the word.

Also includes a shorter label.

Bug: T300008
Change-Id: I37505af8383d8c0c2bd4af3987ec5e2a3049688a
2022-04-29 10:26:20 +02:00
WMDE-Fisch d996288169 Move message about missing parameters to sidebar
Will be removed when parameters are added. Needs different margins
depending on beeing shown in the single transclusion mode without
header or on multiple transclusions.

Bug: T300710
Change-Id: Ieb95d7276aa4d4b0fcbb74f87ab734e4a393dc21
2022-04-29 10:03:23 +02:00
Ed Sanders 699899c8c4 i18n: Remove unused "VisualEditor" tab messages
Hasn't been used in years, and we no longer use the CamelCase product name.

Change-Id: I8bda918a9db3ac7bf683dc6115af7a89d04ab9b7
2022-04-13 15:43:43 +01:00
Translation updater bot 5648463ceb Localisation updates from https://translatewiki.net.
Change-Id: I98ff381676e55788a223ff6792d2649c5f1fe45c
2022-04-04 09:35:24 +02:00
Ed Sanders 2fa21ebcdb Use "Author" in media dialog
"Author" is used on Commons and in various places in
MultimediaViewer. Artist is not used in these places.

Bug: T267501
Change-Id: Iccd2d926537a7d4147e6cc8b5c2c9c1ecf4d6b27
2022-03-19 22:22:00 +00:00
jenkins-bot 401da7ee13 Merge "Remove MWDismissibleMessageWidget and use MessageWidget's showClose option instead" 2022-03-17 11:43:33 +00:00
Thiemo Kreuz 0b47a8c85b Improve messages about duplicate template parameters
There are some combinations that can result in a message that is
more confusing than helpful. For example, when a parameter is
already in a template, but via an alias, that alias is potentially
shown in the sidebar (only when the parameter doesn't have a
label). When the user enters the primary name of this parameter,
the message talks about a "duplicate", but the user can't
understand what this duplicate is.

Just make all messages repeat the parameter's label as shown in
the sidebar. This is often redundant, but sometimes crucial
information.

This patch also improves the qqq.json documentation. All messages
get 2 parameters, even if some of them use only 1.

Bug: T285869
Bug: T291059
Change-Id: I826e341cebd8f89dba63d64de67baba1ec8f2001
2022-02-21 17:35:47 +01:00
WMDE-Fisch 9e5db239af Add hints for translators when the term 'field' is used
Bug: T300641
Change-Id: I05aef0cbbefb6a8d6899b5bff36566028e822259
2022-02-08 16:15:39 +00:00