Commit graph

17144 commits

Author SHA1 Message Date
jenkins-bot 2b8f2c276d Merge "Fix reporting of loading errors from ArticleTarget#loadSuccess" 2020-02-12 23:33:06 +00:00
jenkins-bot 99b0a33e99 Merge "ArticleTargetSaver: Fix error messages" 2020-02-12 23:33:03 +00:00
Esanders c9b2e8b4d2 Only preserve data-parsoid/RESTBase ID on transclusion nodes
The previous attempt to fix this didn't preserve any attributes
but removing data-parsoid can result in a loss of wikitext formatting.

This reverts commit bdfd4b6d8f.

Bug: T207325
Change-Id: I2a38e651d17262889eddb149c72c9e08b4e56ed0
2020-02-12 22:51:43 +00:00
Bartosz Dziewoński c95be08cc4 Localize remaining hardcoded English error messages
Bug: T227325
Change-Id: Ibee27bd8457f83910da03ecb8801e5f26bdb3b2a
2020-02-12 22:18:40 +01:00
Bartosz Dziewoński f491196559 Fix reporting of loading errors from ArticleTarget#loadSuccess
It was broken on desktop and on mobile, but for different reasons:

Desktop: In change 5f1c68945d,
I removed some code from DesktopArticleTarget that was checking for
`typeof errorDetails === 'string'`. I thought it was unused, but it
was actually needed for this code.

Mobile: overlay.reportError() doesn't work here: that method displays
the error inside the save panel, which is not visible at this point.

This is now solved by treating those errors as if they were API errors,
which is something we were already doing in ArticleTargetSaver.

Change-Id: I5207836f56d65171b1240cef02fc17b9956036ef
2020-02-12 22:18:40 +01:00
Bartosz Dziewoński 6d993fee49 ArticleTargetSaver: Fix error messages
Follow-up to 5f1c68945d, which renamed
these messages while moving them into MediaWiki core.

Also, parse HTML in them. This is consistent with real API error
messages, and with the behavior of mw.Api#getErrorMessage. (And also
fixes potential HTML escaping issues.)

Change-Id: I307ca9873e245169a0d4b43499317acbac69fb9b
2020-02-12 22:18:40 +01:00
jenkins-bot 1a426d8614 Merge "Remove use of Title::quickUserCan" 2020-02-12 18:22:34 +00:00
Translation updater bot b57fd476a1 Localisation updates from https://translatewiki.net.
Change-Id: If46e56053c90621789e0d45a65084b8e998c2f3e
2020-02-12 09:01:08 +01:00
DannyS712 cb1b9b5f20 Remove use of Title::quickUserCan
Bug: T244927
Change-Id: I6d7fb8825d512d1bf9c0005289b28704412975c3
2020-02-12 06:49:52 +00:00
jenkins-bot 5f2349fdd7 Merge "Update VE core submodule to master (792df1cd0)" 2020-02-11 22:48:01 +00:00
jenkins-bot 94abf22847 Merge "Add .mw-parser-output to historical visual diffs" 2020-02-11 22:25:59 +00:00
jenkins-bot bd416c3828 Merge "Fix EditAttemptStep events logged with revision_id=0" 2020-02-11 20:51:23 +00:00
Bartosz Dziewoński 115c0b03fa Add .mw-parser-output to historical visual diffs
It was already added for visual diffs inside the editor. This fixes
some minor styling issues, e.g. the arrow after external links is now
shown.

Bug: T244673
Change-Id: I3ea72930ee7822a7579ebe787654d716f5947224
2020-02-11 21:12:19 +01:00
James D. Forrester aaa411fe28 Update VE core submodule to master (792df1cd0)
New changes:
792df1cd0 Localisation updates from https://translatewiki.net.

Change-Id: I9af8ce94bfc44c72db5d62bdd8f0e7af691738c6
2020-02-11 11:00:55 -08:00
Bartosz Dziewoński 2f5856bd2e Fix EditAttemptStep events logged with revision_id=0
When opening the old wikitext editor, 'wgRevisionId' is always set to
0, and remains that way even if we switch to visual editor.

Elsewhere in the code, we handle this case by reading the revision ID
from the old wikitext edit form, so do that here as well. (This still
works after switching to visual editor.)

Bug: T230133
Change-Id: I9d3a23beb6b1393633b94ac3c9c6c667d7560308
2020-02-11 19:37:22 +01:00
Translation updater bot 7a5ddbd5ea Localisation updates from https://translatewiki.net.
Change-Id: I21e7ce1cd8fb0e47b5b179fee280f4eb9caad79f
2020-02-11 08:19:53 +01:00
Translation updater bot d07ea1a9ff Localisation updates from https://translatewiki.net.
Change-Id: I5198ad8e141134188962e3c46c90647149fb4d90
2020-02-10 08:36:24 +01:00
jenkins-bot 5b2ba08c44 Merge "Use WMUI styled WikiEditor switcher when in Vector" 2020-02-08 02:37:12 +00:00
Ed Sanders eebe103fe4 Use WMUI styled WikiEditor switcher when in Vector
Bug: T223155
Change-Id: I6cf305e77cfeda96e7736dc26f1d7feff6fb3911
2020-02-07 18:20:39 -08:00
Bartosz Dziewoński e30e27e2b4 Update VE core submodule to master (4ff5f2555)
New changes:
99d766aee ve.ce.BranchNode: Force re-applying of selection if tag name changes
d7b6b1650 Unwrap unsupported section tags when pasting

Bug: T243852
Bug: T244109
Change-Id: Id33b4dc4e0dfafcc2414e8b083bc6869964de38f
2020-02-08 03:05:21 +01:00
jenkins-bot be6777590c Merge "Fix handling of pasted internal red links" 2020-02-07 21:04:53 +00:00
jenkins-bot e3f2bae73c Merge "VisualEditorHooks: don't duplicate tag definitions" 2020-02-07 17:15:20 +00:00
Bartosz Dziewoński a816baedd9 Fix handling of pasted internal red links
Bug: T239550
Change-Id: Iacfba4b46bea8294f12a0c010344fda317f75df6
2020-02-07 17:41:19 +01:00
Translation updater bot 1cb6407364 Localisation updates from https://translatewiki.net.
Change-Id: I2bc3b51422caac84be780c597590ccda9c4772e2
2020-02-07 09:58:18 +01:00
David Lynch 95f034ffc4 VisualEditorHooks: don't duplicate tag definitions
Also update the doc comment for our tags hook, as we removed one hook.

Change-Id: I431a707e97de9eb24416ef7972b5c59fd66ac35a
2020-02-07 01:22:23 -06:00
David Lynch 0d6f984cc5 Change tags method so anon edits will go through
It turns out anonymous users can't apply change tags, so change
I2c1d0f8d69bc03e5c1877c790247e165f160e966 broke editing for them.

Bug: T242184
Change-Id: I7c27e4d9995428e213a980819810f235fdfe9435
2020-02-06 15:31:45 -06:00
David Lynch 078fbcf737 Update VE core submodule to master (e1760b7f7)
New changes:
fb4f0a83b Completion framework

Local changes to wire in the completion framework

Bug: T232601
Depends-On: If6aee9df67e7a1234d47c0ba0c2f05ef47e5bd51
Change-Id: I075cac9aa195574c3d416a40bbdc5ec2d64424e2
2020-02-06 12:05:48 -08:00
Bartosz Dziewoński 9a3fc22080 Update VE core submodule to master (624ec74b7)
New changes:
07c028575 Require two clicks on link for label editing after closing context item
ff0e814ad update-ooui: Fix link to release notes
0d9bdde76 Update OOUI to v0.36.4
c09049edc Change toolbar border hack to add borders instead of remove them
b888802f5 Rebaser: Bump dependency versions
624ec74b7 Localisation updates from https://translatewiki.net.

Bug: T232003
Bug: T232172
Change-Id: I7a74108c08fced3df33617993e98e39649bb4b41
2020-02-06 18:37:28 +01:00
Translation updater bot bbf304c8f1 Localisation updates from https://translatewiki.net.
Change-Id: Icbae912ed98594af2756757ee1b76e3ace7b98ae
2020-02-06 08:20:16 +01:00
jenkins-bot d5ea567039 Merge "Match WikiEditor switching widget to Apex toolbar theme" 2020-02-05 22:40:59 +00:00
Timo Tijhof 761c26e0a0 ve.init.mw.trackSubscriber: Remove 2015 compat for this.timeStamp
I8e82acc12 is from 2015, a long time has passed since then.

Bug: T229577
Change-Id: I656a9994451299c482e6752d6a03663f3270b8e1
2020-02-05 20:09:52 +00:00
Bartosz Dziewoński 6ee5db11dc Correct API documentation for 'tags'
The message wasn't updated when we changed our minds during the
development of d85d30f9b3. Now the
normal tagging is done in client-side code, so it's effectively
always "suppressed" when calling the API.

Change-Id: Ie75ce31e7c723ff2677e8caa205666f5394405fa
2020-02-05 14:20:31 +01:00
Translation updater bot 2cca81a662 Localisation updates from https://translatewiki.net.
Change-Id: I3e5487a089b0a92ba9d0521f6d1d464bea7041d6
2020-02-05 08:19:56 +01:00
jenkins-bot 22c6449d5f Merge "Don't offer switching to VE if it's disabled in preferences" 2020-02-05 01:48:34 +00:00
jenkins-bot 54c8ca6c39 Merge "Fix tab initialization if NWE is enabled but VE is disabled" 2020-02-05 01:48:31 +00:00
Ed Sanders 787d16f512 Match WikiEditor switching widget to Apex toolbar theme
Bug: T223155
Change-Id: I5c14f28ba3c341c74875bac090c6106655c6b4c7
2020-02-04 17:25:59 -08:00
jenkins-bot 582b99781c Merge "Change gallery structure to match Parsoid" 2020-02-05 00:52:51 +00:00
jenkins-bot 0896917030 Merge "ve.ce.MWGalleryNode: Fix how 'mode', 'class', 'style' changes are applied" 2020-02-04 20:03:29 +00:00
Bartosz Dziewoński 353549003a Change gallery structure to match Parsoid
Bug: T214649
Change-Id: Ia5eb2057a8073488de2228315f08a20656ee946b
2020-02-04 20:02:18 +00:00
Bartosz Dziewoński 98ed2311b6 ve.ce.MWGalleryNode: Fix how 'mode', 'class', 'style' changes are applied
* Changing the 'mode' did not clear the old class, only add a new one.
* Clearing the 'class' or 'style' did not really clear it if the field
  was left empty.

Both of these could result in the action not taking effect visually.

* Setting a class unintentionally also removed internal VE classes.
  This doesn't seem to have any negative effects at a glance, but it's
  probably a bad idea.

Change-Id: I304c222a2c8bc9d35b1cfaee401ab1f815251fde
2020-02-04 19:49:01 +00:00
jenkins-bot 124ae7a444 Merge "Tag VE edits from the client-side" 2020-02-04 16:43:59 +00:00
Translation updater bot ab357925de Localisation updates from https://translatewiki.net.
Change-Id: Icb65fd5af73dd906f60325851293327c50b0f9f8
2020-02-04 08:34:24 +01:00
jenkins-bot 48da3746f8 Merge "Disallow switching in NWE welcome dialog if VE should be unavailable" 2020-02-03 23:59:10 +00:00
jenkins-bot f7a61e3f42 Merge "Allow switching in welcome dialog on mobile" 2020-02-03 23:57:18 +00:00
James D. Forrester ff95a56c0c Update VE core submodule to master (d930b6581)
New changes:
d930b6581 build: Update all karma-related tools to latest

Bug: T243791
Change-Id: I2616c28c6327921ddd21f0f39b635e0f622a6ecd
2020-02-03 13:09:48 -08:00
Bartosz Dziewoński 06ab627b29 Update VE core submodule to master (daa98ac4e)
New changes:
ab2f2ca1a ve.ce.BranchNode: Detach all children first when calling #detach
dae5a8c7e Localisation updates from https://translatewiki.net.
98e69f146 Remove hack to avoid iOS Safari menu bar area tap stealing

Bug: T206278
Bug: T227628
Change-Id: Id9442f433277bb32b7a581286ab3308bb0b16aae
2020-02-03 19:50:56 +01:00
jenkins-bot cb303c2b65 Merge "Remove hack to avoid iOS Safari menu bar area tap stealing" 2020-02-03 18:46:13 +00:00
jenkins-bot 6cd05e686d Merge "Don't display duplicate protection notices when user can't edit" 2020-02-03 17:33:39 +00:00
Translation updater bot b79f68e762 Localisation updates from https://translatewiki.net.
Change-Id: Idae99750161b4d18014b7af8e538be39f982d0ce
2020-02-03 08:28:47 +01:00
James D. Forrester a318f448e6 Update VE core submodule to master (62458b89d)
New changes:
c5582eab7 Localisation updates from https://translatewiki.net.
33f0680f2 Always use excludeInsertion when translating table selections
6d9d86720 eslint: Use /mediawiki ruleset
48cf4045e ve.dm.SourceConverter: Add a trailing newline to each full paragraph

Bug: T243606
Bug: T243860
Change-Id: Ib2a2025dea1c393e436c0bad1ad42b6aa8a3717e
2020-01-31 17:56:05 -08:00