The timing variable is a private closure variable containing an object
that tracks the timestamps of different events in the current cycle. The
duration variable is the result of using that information to compute the
difference between the current timestamp and the relevant anchor
timestamp. For the '_timing' property in the EventLogging data, duration
is the correct value, not timing.
(This is confusing and we should probably rename the timing variable.)
Change-Id: Iff78eb0ab83c84b73ad5c8f3eb85b1c7f120ebef
Follows-Up: Ifc2135d99f4bec917dac60992098958b72c37fc6
Moved to their respective extensions
Change-Id: If463068a862cfde15ab4d250a1424c88a5229176
Depends-On: Ib1354f0404209a15194895026ff9d179d16b1900
Depends-On: I1807a5d3d99ecab2bf4545a1bab3aa3f2ae64da8
New changes:
ac8b90baa Use ve.dm.SurfaceFragment#hasMatchingAncestor where possible
3008ac425 ve.ui.FormatTool: Remove unused property
bae540ab3 eslint: Drop 'dot-notation' rule
0df7b6921 build: Upgrade stylelint-config-wikimedia to 0.5.0 and make pass
b1e836eac Localisation updates from https://translatewiki.net.
48b1be92d ve.dm.Change: Fix guessing selection for internal-list-only transactions
5722bab84 Enable jquery/no-(show/hide/toggle) rules
ed14182e0 Guard against Target#teardown being called twice
Bug: T208914
Bug: T210552
Change-Id: I0ba709bec3399e3d595ea830fe44e6ede1c6c2e6
This sets the label to be the same as the default value inherited from
ve.ui.MWTemplateDialog. Looks like it's no longer needed since change
Ia8fb88d3501ffa2c26add4419da5463a926f45d1 (2014).
Change-Id: I1dd40d2428c0221dfdc79e5f34e411b127624eb6
This early return in loadSuccess() has been incorrectly removed in
b2718b186a.
As a very unexpected result of loading the editor twice in case
loading metadata is retried, the "Publish" button was staying
disabled. See the task for investigation.
Bug: T209542
Change-Id: If528afe1ca052062005937f03fe822c5c8d0958b
* Also make sure block notices have type 'block'.
* Remove old flag for tracking since we'll be using one
from core
Change-Id: I4b66e73c8a4c4dd7bffd7c0239b1d5ec06eed12f
Depends-On: I6bd1c95548616677e1f72ba6bcfc6f2b551c1ca6
These aren't supported by VE-MW, so must just be
garbage from a browser plugin, possibly Citavi.
Bug: T200971
Change-Id: I9f34e9890e7f59d76cd464778481c415cc3c5dbd
* Pass the page title, so that links to section point to the current
page rather than "API"
* Make all links open in a new window, instead of producing a warning
about losing your changes
Bug: T208978
Change-Id: Ia1924e1af644ee41ebcaa1da40ca004cb72dcdaf
New changes:
73a231157 Only handle document selectionchange events when focussed
083272487 Localisation updates from https://translatewiki.net.
b5f36f1ea Localisation updates from https://translatewiki.net.
6a2233f68 Workaround native selection bug for number inputs in Firefox
Bug: T209646
Change-Id: I78fc21e88ead9ff6e181e1a88f3f0ddbdcd8e4d8
* Use ve.getProp
* Use .abusefilter key instead of string search (the key
didn't exist when we first implemented AF support)
* Move AF handler next to captcha handler, and comment
both as should-be-moved-to-plugin.
Change-Id: I171d63844b84b5a12396b6d6746f92110fc06c6c